Broarm\EventTickets\TicketControllerExtension

Complexity

Total Complexity

7

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	TicketForm()	0	10	3
A	WaitingListRegistrationForm()	0	8	2
A	checkIn()	0	4	1
A	getWaitingListSuccess()	0	4	1

<?php
/**
 * TicketControllerExtension.php
 *
 * @author Bram de Leeuw
 * Date: 09/03/17
 */

namespace Broarm\EventTickets;

use CalendarEvent_Controller;
use Extension;

/**
 * Class TicketControllerExtension
 *
 * @package Broarm\EventTickets
 *
 * @property TicketControllerExtension|TicketExtension|CalendarEvent_Controller $owner
 */
class TicketControllerExtension extends Extension
{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'TicketForm',
        'WaitingListRegistrationForm',
        'checkin'
    );

    /**
     * Get the ticket form with available tickets
     *
     * @return TicketForm

Should the return type not be TicketForm|null?

     */
    public function TicketForm()
    {
        if ($this->owner->Tickets()->count() && $this->owner->getAvailability() > 0) {

The method getAvailability does only exist in Broarm\EventTickets\TicketExtension, but not in Broarm\EventTickets\TicketControllerExtension and CalendarEvent_Controller.

            $ticketForm = new TicketForm($this->owner, 'TicketForm', $this->owner->Tickets(), $this->owner->dataRecord);
            $ticketForm->setNextStep(CheckoutSteps::start());
            return $ticketForm;
        } else {
            return null;
        }
    }

    /**
     * show the waiting list form when the event is sold out
     *
     * @return WaitingListRegistrationForm

Should the return type not be WaitingListRegistrationForm|null?

     */
    public function WaitingListRegistrationForm()
    {
        if ($this->owner->Tickets()->count()) {
            return new WaitingListRegistrationForm($this->owner, 'WaitingListRegistrationForm');
        } else {
            return null;
        }
    }

    /**
     * Go to the check in controller
     *
     * @return CheckInController
     */
    public function checkIn()
    {
        return new CheckInController($this->owner->dataRecord);
    }

    /**
     * Checks the waiting list var
     *
     * @return mixed
     */
    public function getWaitingListSuccess()
    {
        return $this->owner->getRequest()->getVar('waitinglist');
    }
}