This class seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
17
{
18
private static $allowed_actions = array(
19
'ReservationForm'
20
);
21
22
protected $step = 'register';
23
24
/**
25
* Get the reservation form
26
*
27
* @return ReservationForm
28
*/
29
public function ReservationForm()
30
{
31
$reservationForm = new ReservationForm($this, 'ReservationForm', ReservationSession::get());
It seems like \Broarm\EventTickets\ReservationSession::get() targeting Broarm\EventTickets\ReservationSession::get() can also be of type object<DataObject>; however, Broarm\EventTickets\ReservationForm::__construct() does only seem to accept null|object<Broarm\EventTickets\Reservation>, maybe add an additional type check?
This check looks at variables that are passed out again to other methods.
If the outgoing method call has stricter type requirements than the method itself, an issue is raised.
TheBnl /
event-tickets
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.