Broarm\EventTickets\ReservationController

Complexity

Total Complexity

1

Size/Duplication

Total Lines	20
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	ReservationForm()	6	6	1

<?php
/**
 * ReservationController.php
 *
 * @author Bram de Leeuw
 * Date: 14/03/17
 */

namespace Broarm\EventTickets;

/**
 * Class ReservationController
 *
 * @package Broarm\EventTickets
 */
class ReservationController extends CheckoutStepController

This class seems to be duplicated in your project.

{
    private static $allowed_actions = array(
        'ReservationForm'
    );

    protected $step = 'register';

    /**
     * Get the reservation form
     *
     * @return ReservationForm
     */
    public function ReservationForm()
    {
        $reservationForm = new ReservationForm($this, 'ReservationForm', ReservationSession::get());

It seems like \Broarm\EventTickets\ReservationSession::get() targeting Broarm\EventTickets\ReservationSession::get() can also be of type object<DataObject>; however, Broarm\EventTickets\ReservationForm::__construct() does only seem to accept null|object<Broarm\EventTickets\Reservation>, maybe add an additional type check?

        $reservationForm->setNextStep(CheckoutSteps::nextStep($this->step));
        return $reservationForm;
    }
}