View GitHub Repository feedback

Schedule Inspection
Subscribe
Passed
Pull Request — master (#19)
by Florian
05:47
created
Status
Category
Toggle Patches
public/check.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -35,8 +35,8 @@
 
 block discarded – undo
35 35
36 36 
 $majorProblems = $symfonyRequirements->getFailedRequirements();
37 37 
 $minorProblems = $symfonyRequirements->getFailedRecommendations();
38 
-$hasMajorProblems = (bool)count($majorProblems);
39 
-$hasMinorProblems = (bool)count($minorProblems);
38 
+$hasMajorProblems = (bool) count($majorProblems);
39 
+$hasMinorProblems = (bool) count($minorProblems);
40 40
41 41 
 ?>
42 42 
 <!DOCTYPE html>
Please login to merge, or discard this patch.
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -511,7 +511,10 @@  discard block
 
 block discarded – undo
511 511 
                 <?php if ($hasMinorProblems): ?>
512 512 
                     <h2>Recommendations</h2>
513 513 
                     <p>
514 
-                        <?php if ($hasMajorProblems): ?>Additionally, to<?php else: ?>To<?php endif; ?> enhance your
514 
+                        <?php if ($hasMajorProblems): ?>Additionally, to<?php else {
515 
+    : ?>To<?php endif;
516 
+}
517 
+?> enhance your
515 518 
                         Symfony experience,
516 519 
                         it’s recommended that you fix the following:
517 520 
                     </p>
 
@@ -529,9 +532,12 @@  discard block
 
 block discarded – undo
529 532 
                         <?php if ($symfonyRequirements->getPhpIniPath()): ?>
530 533 
                             Changes to the <strong>php.ini</strong> file must be done in "
531 534 
                             <strong><?php echo $symfonyRequirements->getPhpIniPath(); ?></strong>".
532 
-                        <?php else: ?>
535 
+                        <?php else {
536 
+    : ?>
533 537 
                             To change settings, create a "<strong>php.ini</strong>".
534 
-                        <?php endif; ?>
538 
+                        <?php endif;
539 
+}
540 
+?>
535 541 
                     </p>
536 542 
                 <?php endif; ?>
537 543
Please login to merge, or discard this patch.
src/Controller/Base/BaseFormController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62 
         $startEntity = clone $defaultEntity;
63 63
64 64 
         //create persist callable
65 
-        $myOnSuccessCallable = function ($form) use ($defaultEntity, $beforeCreateCallable, $successfulText, $formType, $startEntity, $buttonLabel) {
65 
+        $myOnSuccessCallable = function($form) use ($defaultEntity, $beforeCreateCallable, $successfulText, $formType, $startEntity, $buttonLabel) {
66 66 
             $manager = $this->getDoctrine()->getManager();
67 67
68 68 
             if (!\is_callable($beforeCreateCallable) || false !== $beforeCreateCallable($manager)) {
 
@@ -104,7 +104,7 @@  discard block
 
 block discarded – undo
104 104 
         $successfulText = $translator->trans('form.successful.updated', [], 'framework');
105 105
106 106 
         //create persist callable
107 
-        $myOnSuccessCallable = function ($form) use ($entity, $beforeUpdateCallable, $successfulText) {
107 
+        $myOnSuccessCallable = function($form) use ($entity, $beforeUpdateCallable, $successfulText) {
108 108 
             $manager = $this->getDoctrine()->getManager();
109 109
110 110 
             if (!\is_callable($beforeUpdateCallable) || false !== $beforeUpdateCallable($manager)) {
 
@@ -145,7 +145,7 @@  discard block
 
 block discarded – undo
145 145 
             $translator->trans('form.submit_buttons.delete', [], 'framework'),
146 146 
             $translator->trans('form.successful.deleted', [], 'framework'),
147 147 
             $beforeDeleteCallable ??
148 
-            function () {
148 
+            function() {
149 149 
                 return true;
150 150 
             }
151 151 
         );
 
@@ -165,7 +165,7 @@  discard block
 
 block discarded – undo
165 165 
      */
166 166 
     private function handleDeleteFormInternal(Request $request, BaseEntity $entity, $formType, $buttonLabel, $successText, $beforeDeleteCallable)
167 167 
     {
168 
-        $myOnSuccessCallable = function ($form) use ($entity, $successText, $beforeDeleteCallable) {
168 
+        $myOnSuccessCallable = function($form) use ($entity, $successText, $beforeDeleteCallable) {
169 169 
             $manager = $this->getDoctrine()->getManager();
170 170
171 171 
             if (false !== $beforeDeleteCallable($entity, $manager)) {
Please login to merge, or discard this patch.
src/Controller/Administration/Semester/EventController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -58,7 +58,7 @@  discard block
 
 block discarded – undo
58 58 
         $myForm = $this->handleCreateForm(
59 59 
             $request,
60 60 
             $event,
61 
-            function () use ($event) {
61 
+            function() use ($event) {
62 62 
                 return $this->prePersistActions($event);
63 63 
             }
64 64 
         );
 
@@ -87,7 +87,7 @@  discard block
 
 block discarded – undo
87 87 
         $myForm = $this->handleUpdateForm(
88 88 
             $request,
89 89 
             $event,
90 
-            function () use ($event) {
90 
+            function() use ($event) {
91 91 
                 return $this->prePersistActions($event);
92 92 
             }
93 93 
         );
Please login to merge, or discard this patch.
src/Controller/ApiController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -186,7 +186,7 @@
 
 block discarded – undo
186 186
187 187 
         //write fields
188 188 
         $identifier = $payload->identifier;
189 
-        $timeNeededInSeconds = (int)$payload->timeNeededInSeconds;
189 
+        $timeNeededInSeconds = (int) $payload->timeNeededInSeconds;
190 190
191 191 
         //get participant
192 192 
         $participant = $this->getDoctrine()->getRepository(Participant::class)->findOneBy(['identifier' => $identifier, 'event' => $event->getId()]);
Please login to merge, or discard this patch.
deploy.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -37,13 +37,13 @@  discard block
 
 block discarded – undo
37 37 
 );
38 38
39 39 
 desc('Installing vendors');
40 
-task('deploy:vendors', function () {
40 
+task('deploy:vendors', function() {
41 41 
     run('cd {{release_path}} && {{bin/composer}} {{composer_options}}', ['timeout' => 400]);
42 42 
 });
43 43
44 44 
 //build yarn stuff & upload
45 45 
 desc('Bundling locally css/js and then uploading it');
46 
-task('frontend:build', function () {
46 
+task('frontend:build', function() {
47 47 
     runLocally('yarn install');
48 48 
     runLocally('yarn run encore production');
49 49 
     runLocally('rsync -azP public/dist {{user}}@{{hostname}}:{{release_path}}/public');
 
@@ -51,7 +51,7 @@  discard block
 
 block discarded – undo
51 51
52 52 
 // kill php processes to ensure symlinks are refreshed
53 53 
 desc('Refreshing symlink by terminating any running php processes');
54 
-task('deploy:refresh_symlink', function () {
54 
+task('deploy:refresh_symlink', function() {
55 55 
     run('killall -9 php-cgi'); //kill all php processes so symlink is refreshed
56 56 
 })->desc('Refreshing symlink');
57 57
Please login to merge, or discard this patch.
public/index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -29,7 +29,7 @@
 
 block discarded – undo
29 29 
     Request::setTrustedHosts([$trustedHosts]);
30 30 
 }
31 31
32 
-$kernel = new Kernel($_SERVER['APP_ENV'], (bool)$_SERVER['APP_DEBUG']);
32 
+$kernel = new Kernel($_SERVER['APP_ENV'], (bool) $_SERVER['APP_DEBUG']);
33 33 
 $request = Request::createFromGlobals();
34 34 
 $response = $kernel->handle($request);
35 35 
 $response->send();
Please login to merge, or discard this patch.
config/bootstrap.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -20,4 +20,4 @@
 
 block discarded – undo
20 20
21 21 
 $_SERVER['APP_ENV'] = $_ENV['APP_ENV'] = $_SERVER['APP_ENV'] ?: $_ENV['APP_ENV'] ?: 'dev';
22 22 
 $_SERVER['APP_DEBUG'] = $_SERVER['APP_DEBUG'] ?? $_ENV['APP_DEBUG'] ?? 'prod' !== $_SERVER['APP_ENV'];
23 
-$_SERVER['APP_DEBUG'] = $_ENV['APP_DEBUG'] = (int)$_SERVER['APP_DEBUG'] || filter_var($_SERVER['APP_DEBUG'], FILTER_VALIDATE_BOOLEAN) ? '1' : '0';
23 
+$_SERVER['APP_DEBUG'] = $_ENV['APP_DEBUG'] = (int) $_SERVER['APP_DEBUG'] || filter_var($_SERVER['APP_DEBUG'], FILTER_VALIDATE_BOOLEAN) ? '1' : '0';
Please login to merge, or discard this patch.