RegionBranchStoreUrlJson::findAll() - Code Metrics - Inspection of "fcacfd386764a7d7d67312741ba73b69e555a33d" - TalismanFR/rosselhozbank-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (fcacfd)

by Anatoliy

created 2020-01-28 12:17 UTC

RegionBranchStoreUrlJson::findAll() B

↳ Parent: RegionBranchStoreUrlJson

Complexity

Conditions	6
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	8.8337
c	0
b	0
f	0
cc	6
nc	6
nop	0

<?php


namespace talismanfr\rosselhozbank\stores;


use talismanfr\rosselhozbank\dto\RegionBranch;
use talismanfr\rosselhozbank\shared\UrlValue;
use talismanfr\rosselhozbank\stores\contracts\RegionBranchStore;

class RegionBranchStoreUrlJson implements RegionBranchStore
{


    private $url;

    /** @var RegionBranch[]|null */
    private $all=null;

    /**
     * RegionBranchStoreUrlJson constructor.
     * @param $url
     */
    public function __construct(?UrlValue $url)
    {
        $this->url = $url;
        if(empty($this->url)){
            $this->url=new UrlValue('https://www.rshb.ru/promo/smb/rko-partner/js/region.json');
        }
    }


    /**
     * @inheritDoc
     * @return RegionBranch[]
     */
    public function findAll(): ?array
    {
        if($this->all){
            return $this->all;
        }


        $resource=file_get_contents($this->url->__toString());
        if(empty($resource)){
            return null;
        }

        try{
            $resource=json_decode($resource,true);
            if(!$resource){
                return null;
            }
        }catch (\Exception $e){
            return null;
        }
        foreach ($resource as $item){
            $this->all[]=new RegionBranch(
                (int)$item['id'],
                $item['origName'],
                $item['newName']
            );
        }
        return $this->all;
    }

    /**
     * @inheritDoc
     */
    public function findByRegion(string $region): ?RegionBranch
    {
        foreach ($this->findAll() as $regionBranch){
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if($regionBranch->getRegionName()==$region){
                return $regionBranch;
            }
        }

        return null;
    }

    public function findById(int $id): ?RegionBranch
    {
        foreach ($this->findAll() as $regionBranch){
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if($regionBranch->getId()==$id){
                return $regionBranch;
            }
        }

        return null;
    }
}

1			<?php
2
3
4			namespace talismanfr\rosselhozbank\stores;
5
6
7			use talismanfr\rosselhozbank\dto\RegionBranch;
8			use talismanfr\rosselhozbank\shared\UrlValue;
9			use talismanfr\rosselhozbank\stores\contracts\RegionBranchStore;
10
11			class RegionBranchStoreUrlJson implements RegionBranchStore
12			{
13
14
15			private $url;
16
17			/** @var RegionBranch[]\|null */
18			private $all=null;
19
20			/**
21			* RegionBranchStoreUrlJson constructor.
22			* @param $url
23			*/
24			public function __construct(?UrlValue $url)
25			{
26			$this->url = $url;
27			if(empty($this->url)){
28			$this->url=new UrlValue('https://www.rshb.ru/promo/smb/rko-partner/js/region.json');
29			}
30			}
31
32
33			/**
34			* @inheritDoc
35			* @return RegionBranch[]
36			*/
37			public function findAll(): ?array
38			{
39			if($this->all){
40			return $this->all;
41			}
42
43
44			$resource=file_get_contents($this->url->__toString());
45			if(empty($resource)){
46			return null;
47			}
48
49			try{
50			$resource=json_decode($resource,true);
51			if(!$resource){
52			return null;
53			}
54			}catch (\Exception $e){
55			return null;
56			}
57			foreach ($resource as $item){
58			$this->all[]=new RegionBranch(
59			(int)$item['id'],
60			$item['origName'],
61			$item['newName']
62			);
63			}
64			return $this->all;
65			}
66
67			/**
68			* @inheritDoc
69			*/
70			public function findByRegion(string $region): ?RegionBranch
71			{
72			foreach ($this->findAll() as $regionBranch){
			0 ignored issues – show Bug introduced 2020-01-28 12:20 UTC by Report Bug Copy Issue Report The expression `$this->findAll()` of type `array<integer,object<tal...dto\RegionBranch>>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
73			if($regionBranch->getRegionName()==$region){
74			return $regionBranch;
75			}
76			}
77
78			return null;
79			}
80
81			public function findById(int $id): ?RegionBranch
82			{
83			foreach ($this->findAll() as $regionBranch){
			0 ignored issues – show Bug introduced 2020-01-28 12:20 UTC by Report Bug Copy Issue Report The expression `$this->findAll()` of type `array<integer,object<tal...dto\RegionBranch>>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
84			if($regionBranch->getId()==$id){
85			return $regionBranch;
86			}
87			}
88
89			return null;
90			}
91			}

TalismanFR / rosselhozbank-api

Branch — master (fcacfd)

RegionBranchStoreUrlJson::findAll() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like