talismanfr\rosselhozbank\stores\RegionBranchStoreUrlJson

Complexity

Total Complexity

14

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
B	findAll()	0	29	6
A	findByRegion()	0	10	3
A	findById()	0	10	3

<?php


namespace talismanfr\rosselhozbank\stores;


use talismanfr\rosselhozbank\dto\RegionBranch;
use talismanfr\rosselhozbank\shared\UrlValue;
use talismanfr\rosselhozbank\stores\contracts\RegionBranchStore;

class RegionBranchStoreUrlJson implements RegionBranchStore
{


    private $url;

    /** @var RegionBranch[]|null */
    private $all=null;

    /**
     * RegionBranchStoreUrlJson constructor.
     * @param $url
     */
    public function __construct(?UrlValue $url)
    {
        $this->url = $url;
        if(empty($this->url)){
            $this->url=new UrlValue('https://www.rshb.ru/promo/smb/rko-partner/js/region.json');
        }
    }


    /**
     * @inheritDoc
     * @return RegionBranch[]
     */
    public function findAll(): ?array
    {
        if($this->all){
            return $this->all;
        }


        $resource=file_get_contents($this->url->__toString());
        if(empty($resource)){
            return null;
        }

        try{
            $resource=json_decode($resource,true);
            if(!$resource){
                return null;
            }
        }catch (\Exception $e){
            return null;
        }
        foreach ($resource as $item){
            $this->all[]=new RegionBranch(
                (int)$item['id'],
                $item['origName'],
                $item['newName']
            );
        }
        return $this->all;
    }

    /**
     * @inheritDoc
     */
    public function findByRegion(string $region): ?RegionBranch
    {
        foreach ($this->findAll() as $regionBranch){

The expression $this->findAll() of type array<integer,object<talismanfr\rosselhozbank\dto\RegionBranch>>|null is not guaranteed to be traversable. How about adding an additional type check?

            if($regionBranch->getRegionName()==$region){
                return $regionBranch;
            }
        }

        return null;
    }

    public function findById(int $id): ?RegionBranch
    {
        foreach ($this->findAll() as $regionBranch){

The expression $this->findAll() of type array<integer,object<talismanfr\rosselhozbank\dto\RegionBranch>>|null is not guaranteed to be traversable. How about adding an additional type check?

            if($regionBranch->getId()==$id){
                return $regionBranch;
            }
        }

        return null;
    }
}