Inspection of "[BUGFIX] Remove wrong data-formengine-input-name a..." - TYPO3/TYPO3.CMS - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fdcb41...982160 )

unknown

created 2021-01-04 14:58 UTC

Status

Spacing +130 added lines, -130 removed lines patch added patch discarded remove patch

@@ -58,7 +58,7 @@  discard block
 block discarded – undo
         'listModule' => [
             'renderType' => 'listModule',
             'disabled' => true,
-            'after' => [ 'addRecord' ],
+            'after' => ['addRecord'],
         ],
     ];
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
      */
     protected function renderFieldControl(): array
     {
-        $alternativeResult =  [
+        $alternativeResult = [
             'additionalJavaScriptPost' => [],
             'additionalHiddenFields' => [],
             'additionalInlineLanguageLabelFiles' => [],
@@ -185,10 +185,10 @@  discard block
 block discarded – undo
 
         // Html stuff for filter and select filter on top of right side of multi select boxes
         $filterTextfield[] = '<span class="input-group input-group-sm">';
-        $filterTextfield[] =    '<span class="input-group-addon">';
-        $filterTextfield[] =        '<span class="fa fa-filter"></span>';
-        $filterTextfield[] =    '</span>';
-        $filterTextfield[] =    '<input class="t3js-formengine-multiselect-filter-textfield form-control" value="">';
+        $filterTextfield[] = '<span class="input-group-addon">';
+        $filterTextfield[] = '<span class="fa fa-filter"></span>';
+        $filterTextfield[] = '</span>';
+        $filterTextfield[] = '<input class="t3js-formengine-multiselect-filter-textfield form-control" value="">';
         $filterTextfield[] = '</span>';
 
         $filterDropDownOptions = [];
@@ -206,14 +206,14 @@  discard block
 block discarded – undo
         $filterHtml[] = '<div class="form-multigroup-item-wizard">';
         if (!empty($filterDropDownOptions)) {
             $filterHtml[] = '<div class="t3js-formengine-multiselect-filter-container form-multigroup-wrap">';
-            $filterHtml[] =     '<div class="form-multigroup-item form-multigroup-element">';
-            $filterHtml[] =         '<select class="form-select form-select-sm t3js-formengine-multiselect-filter-dropdown">';
-            $filterHtml[] =             implode(LF, $filterDropDownOptions);
-            $filterHtml[] =         '</select>';
-            $filterHtml[] =     '</div>';
-            $filterHtml[] =     '<div class="form-multigroup-item form-multigroup-element">';
-            $filterHtml[] =         implode(LF, $filterTextfield);
-            $filterHtml[] =     '</div>';
+            $filterHtml[] = '<div class="form-multigroup-item form-multigroup-element">';
+            $filterHtml[] = '<select class="form-select form-select-sm t3js-formengine-multiselect-filter-dropdown">';
+            $filterHtml[] = implode(LF, $filterDropDownOptions);
+            $filterHtml[] = '</select>';
+            $filterHtml[] = '</div>';
+            $filterHtml[] = '<div class="form-multigroup-item form-multigroup-element">';
+            $filterHtml[] = implode(LF, $filterTextfield);
+            $filterHtml[] = '</div>';
             $filterHtml[] = '</div>';
         } else {
             $filterHtml[] = implode(LF, $filterTextfield);
@@ -244,112 +244,112 @@  discard block
 block discarded – undo
 
         $html = [];
         $html[] = '<div class="formengine-field-item t3js-formengine-field-item">';
-        $html[] =   $fieldInformationHtml;
-        $html[] =   '<div class="form-wizards-wrap">';
-        $html[] =       '<div class="form-wizards-element">';
-        $html[] =           '<input type="hidden" data-formengine-input-name="' . htmlspecialchars($elementName) . '" value="' . (int)$itemCanBeSelectedMoreThanOnce . '" />';
-        $html[] =           '<div class="form-multigroup-wrap t3js-formengine-field-group">';
-        $html[] =               '<div class="form-multigroup-item form-multigroup-element">';
-        $html[] =                   '<label>';
-        $html[] =                       htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.selected'));
-        $html[] =                   '</label>';
-        $html[] =                   '<div class="form-wizards-wrap form-wizards-aside">';
-        $html[] =                       '<div class="form-wizards-element">';
-        $html[] =                           '<select';
-        $html[] =                               ' id="' . $selectedOptionsFieldId . '"';
-        $html[] =                               ' size="' . $size . '"';
-        $html[] =                               ' class="form-select"';
-        $html[] =                               $multipleAttribute;
-        $html[] =                               ' data-formengine-input-name="' . htmlspecialchars($elementName) . '"';
-        $html[] =                           '>';
-        $html[] =                               implode(LF, $selectedItemsHtml);
-        $html[] =                           '</select>';
-        $html[] =                       '</div>';
-        $html[] =                       '<div class="form-wizards-items-aside">';
-        $html[] =                           '<div class="btn-group-vertical">';
+        $html[] = $fieldInformationHtml;
+        $html[] = '<div class="form-wizards-wrap">';
+        $html[] = '<div class="form-wizards-element">';
+        $html[] = '<input type="hidden" data-formengine-input-name="' . htmlspecialchars($elementName) . '" value="' . (int)$itemCanBeSelectedMoreThanOnce . '" />';
+        $html[] = '<div class="form-multigroup-wrap t3js-formengine-field-group">';
+        $html[] = '<div class="form-multigroup-item form-multigroup-element">';
+        $html[] = '<label>';
+        $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.selected'));
+        $html[] = '</label>';
+        $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
+        $html[] = '<div class="form-wizards-element">';
+        $html[] = '<select';
+        $html[] = ' id="' . $selectedOptionsFieldId . '"';
+        $html[] = ' size="' . $size . '"';
+        $html[] = ' class="form-select"';
+        $html[] = $multipleAttribute;
+        $html[] = ' data-formengine-input-name="' . htmlspecialchars($elementName) . '"';
+        $html[] = '>';
+        $html[] = implode(LF, $selectedItemsHtml);
+        $html[] = '</select>';
+        $html[] = '</div>';
+        $html[] = '<div class="form-wizards-items-aside">';
+        $html[] = '<div class="btn-group-vertical">';
         if ($maxItems > 1 && $size >= 5) {
-            $html[] =                           '<a href="#"';
-            $html[] =                               ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-top"';
-            $html[] =                               ' data-fieldname="' . htmlspecialchars($elementName) . '"';
-            $html[] =                               ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_to_top')) . '"';
-            $html[] =                           '>';
-            $html[] =                               $this->iconFactory->getIcon('actions-move-to-top', Icon::SIZE_SMALL)->render();
-            $html[] =                           '</a>';
+            $html[] = '<a href="#"';
+            $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-top"';
+            $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
+            $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_to_top')) . '"';
+            $html[] = '>';
+            $html[] = $this->iconFactory->getIcon('actions-move-to-top', Icon::SIZE_SMALL)->render();
+            $html[] = '</a>';
         }
         if ($maxItems > 1) {
-            $html[] =                           '<a href="#"';
-            $html[] =                               ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-up"';
-            $html[] =                               ' data-fieldname="' . htmlspecialchars($elementName) . '"';
-            $html[] =                               ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_up')) . '"';
-            $html[] =                           '>';
-            $html[] =                               $this->iconFactory->getIcon('actions-move-up', Icon::SIZE_SMALL)->render();
-            $html[] =                           '</a>';
-            $html[] =                           '<a href="#"';
-            $html[] =                               ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-down"';
-            $html[] =                               ' data-fieldname="' . htmlspecialchars($elementName) . '"';
-            $html[] =                               ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_down')) . '"';
-            $html[] =                           '>';
-            $html[] =                               $this->iconFactory->getIcon('actions-move-down', Icon::SIZE_SMALL)->render();
-            $html[] =                           '</a>';
+            $html[] = '<a href="#"';
+            $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-up"';
+            $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
+            $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_up')) . '"';
+            $html[] = '>';
+            $html[] = $this->iconFactory->getIcon('actions-move-up', Icon::SIZE_SMALL)->render();
+            $html[] = '</a>';
+            $html[] = '<a href="#"';
+            $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-down"';
+            $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
+            $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_down')) . '"';
+            $html[] = '>';
+            $html[] = $this->iconFactory->getIcon('actions-move-down', Icon::SIZE_SMALL)->render();
+            $html[] = '</a>';
         }
         if ($maxItems > 1 && $size >= 5) {
-            $html[] =                           '<a href="#"';
-            $html[] =                               ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-bottom"';
-            $html[] =                               ' data-fieldname="' . htmlspecialchars($elementName) . '"';
-            $html[] =                               ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_to_bottom')) . '"';
-            $html[] =                           '>';
-            $html[] =                               $this->iconFactory->getIcon('actions-move-to-bottom', Icon::SIZE_SMALL)->render();
-            $html[] =                           '</a>';
+            $html[] = '<a href="#"';
+            $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-bottom"';
+            $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
+            $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_to_bottom')) . '"';
+            $html[] = '>';
+            $html[] = $this->iconFactory->getIcon('actions-move-to-bottom', Icon::SIZE_SMALL)->render();
+            $html[] = '</a>';
         }
-        $html[] =                                $alternativeFieldControlHtml;
-        $html[] =                               '<a href="#"';
-        $html[] =                                   ' class="btn btn-default t3js-btn-option t3js-btn-removeoption"';
-        $html[] =                                   ' data-fieldname="' . htmlspecialchars($elementName) . '"';
-        $html[] =                                   ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.remove_selected')) . '"';
-        $html[] =                               '>';
-        $html[] =                                   $this->iconFactory->getIcon('actions-selection-delete', Icon::SIZE_SMALL)->render();
-        $html[] =                               '</a>';
-        $html[] =                           '</div>';
-        $html[] =                       '</div>';
-        $html[] =                   '</div>';
-        $html[] =               '</div>';
-        $html[] =               '<div class="form-multigroup-item form-multigroup-element">';
-        $html[] =                   '<label>';
-        $html[] =                       htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.items'));
-        $html[] =                   '</label>';
-        $html[] =                   '<div class="form-wizards-wrap form-wizards-aside">';
-        $html[] =                       '<div class="form-wizards-element">';
-        $html[] =                           implode(LF, $filterHtml);
-        $html[] =                           '<select';
-        $html[] =                               ' data-relatedfieldname="' . htmlspecialchars($elementName) . '"';
-        $html[] =                               ' data-exclusivevalues="' . htmlspecialchars($config['exclusiveKeys']) . '"';
-        $html[] =                               ' id="' . $availableOptionsFieldId . '"';
-        $html[] =                               ' class="form-select t3js-formengine-select-itemstoselect"';
-        $html[] =                               ' size="' . $size . '"';
-        $html[] =                               ' onchange="' . htmlspecialchars(implode('', $parameterArray['fieldChangeFunc'])) . '"';
-        $html[] =                               ' data-formengine-validation-rules="' . htmlspecialchars($this->getValidationDataAsJsonString($config)) . '"';
-        $html[] =                           '>';
-        $html[] =                               implode(LF, $selectableItemsHtml);
-        $html[] =                           '</select>';
-        $html[] =                       '</div>';
+        $html[] = $alternativeFieldControlHtml;
+        $html[] = '<a href="#"';
+        $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-removeoption"';
+        $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
+        $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.remove_selected')) . '"';
+        $html[] = '>';
+        $html[] = $this->iconFactory->getIcon('actions-selection-delete', Icon::SIZE_SMALL)->render();
+        $html[] = '</a>';
+        $html[] = '</div>';
+        $html[] = '</div>';
+        $html[] = '</div>';
+        $html[] = '</div>';
+        $html[] = '<div class="form-multigroup-item form-multigroup-element">';
+        $html[] = '<label>';
+        $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.items'));
+        $html[] = '</label>';
+        $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
+        $html[] = '<div class="form-wizards-element">';
+        $html[] = implode(LF, $filterHtml);
+        $html[] = '<select';
+        $html[] = ' data-relatedfieldname="' . htmlspecialchars($elementName) . '"';
+        $html[] = ' data-exclusivevalues="' . htmlspecialchars($config['exclusiveKeys']) . '"';
+        $html[] = ' id="' . $availableOptionsFieldId . '"';
+        $html[] = ' class="form-select t3js-formengine-select-itemstoselect"';
+        $html[] = ' size="' . $size . '"';
+        $html[] = ' onchange="' . htmlspecialchars(implode('', $parameterArray['fieldChangeFunc'])) . '"';
+        $html[] = ' data-formengine-validation-rules="' . htmlspecialchars($this->getValidationDataAsJsonString($config)) . '"';
+        $html[] = '>';
+        $html[] = implode(LF, $selectableItemsHtml);
+        $html[] = '</select>';
+        $html[] = '</div>';
         if (!empty($fieldControlHtml)) {
-            $html[] =                       '<div class="form-wizards-items-aside">';
-            $html[] =                           '<div class="btn-group-vertical">';
-            $html[] =                               $fieldControlHtml;
-            $html[] =                           '</div>';
-            $html[] =                       '</div>';
+            $html[] = '<div class="form-wizards-items-aside">';
+            $html[] = '<div class="btn-group-vertical">';
+            $html[] = $fieldControlHtml;
+            $html[] = '</div>';
+            $html[] = '</div>';
         }
-        $html[] =                   '</div>';
-        $html[] =               '</div>';
-        $html[] =           '</div>';
-        $html[] =           '<input type="hidden" name="' . htmlspecialchars($elementName) . '" value="' . htmlspecialchars(implode(',', $listOfSelectedValues)) . '" />';
-        $html[] =       '</div>';
+        $html[] = '</div>';
+        $html[] = '</div>';
+        $html[] = '</div>';
+        $html[] = '<input type="hidden" name="' . htmlspecialchars($elementName) . '" value="' . htmlspecialchars(implode(',', $listOfSelectedValues)) . '" />';
+        $html[] = '</div>';
         if (!empty($fieldWizardHtml)) {
             $html[] = '<div class="form-wizards-items-bottom">';
             $html[] = $fieldWizardHtml;
             $html[] = '</div>';
         }
-        $html[] =   '</div>';
+        $html[] = '</div>';
         $html[] = '</div>';
 
         $resultArray['requireJsModules'][] = ['TYPO3/CMS/Backend/FormEngine/Element/SelectMultipleSideBySideElement' => '
@@ -416,29 +416,29 @@  discard block
 block discarded – undo
 
         $html = [];
         $html[] = '<div class="formengine-field-item t3js-formengine-field-item">';
-        $html[] =   $fieldInformationHtml;
-        $html[] =   '<div class="form-wizards-wrap">';
-        $html[] =       '<div class="form-wizards-element">';
-        $html[] =           '<label>';
-        $html[] =               htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.selected'));
-        $html[] =           '</label>';
-        $html[] =           '<div class="form-wizards-wrap form-wizards-aside">';
-        $html[] =               '<div class="form-wizards-element">';
-        $html[] =                   '<select';
-        $html[] =                       ' id="' . StringUtility::getUniqueId('tceforms-multiselect-') . '"';
-        $html[] =                       ' size="' . $size . '"';
-        $html[] =                       ' class="form-select"';
-        $html[] =                       $multiple;
-        $html[] =                       ' data-formengine-input-name="' . htmlspecialchars($fieldName) . '"';
-        $html[] =                       ' disabled="disabled">';
-        $html[] =                   '/>';
-        $html[] =                       implode(LF, $optionsHtml);
-        $html[] =                   '</select>';
-        $html[] =               '</div>';
-        $html[] =           '</div>';
-        $html[] =           '<input type="hidden" name="' . htmlspecialchars($fieldName) . '" value="' . htmlspecialchars(implode(',', $listOfSelectedValues)) . '" />';
-        $html[] =       '</div>';
-        $html[] =   '</div>';
+        $html[] = $fieldInformationHtml;
+        $html[] = '<div class="form-wizards-wrap">';
+        $html[] = '<div class="form-wizards-element">';
+        $html[] = '<label>';
+        $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.selected'));
+        $html[] = '</label>';
+        $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
+        $html[] = '<div class="form-wizards-element">';
+        $html[] = '<select';
+        $html[] = ' id="' . StringUtility::getUniqueId('tceforms-multiselect-') . '"';
+        $html[] = ' size="' . $size . '"';
+        $html[] = ' class="form-select"';
+        $html[] = $multiple;
+        $html[] = ' data-formengine-input-name="' . htmlspecialchars($fieldName) . '"';
+        $html[] = ' disabled="disabled">';
+        $html[] = '/>';
+        $html[] = implode(LF, $optionsHtml);
+        $html[] = '</select>';
+        $html[] = '</div>';
+        $html[] = '</div>';
+        $html[] = '<input type="hidden" name="' . htmlspecialchars($fieldName) . '" value="' . htmlspecialchars(implode(',', $listOfSelectedValues)) . '" />';
+        $html[] = '</div>';
+        $html[] = '</div>';
         $html[] = '</div>';
 
         $resultArray['html'] = implode(LF, $html);

Please login to merge, or discard this patch.

		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	'listModule' => [
59	59	'renderType' => 'listModule',
60	60	'disabled' => true,
61		- 'after' => [ 'addRecord' ],
	61	+ 'after' => ['addRecord'],
62	62	],
63	63	];
64	64
		@@ -92,7 +92,7 @@ discard block
		block discarded – undo
92	92	*/
93	93	protected function renderFieldControl(): array
94	94	{
95		- $alternativeResult = [
	95	+ $alternativeResult = [
96	96	'additionalJavaScriptPost' => [],
97	97	'additionalHiddenFields' => [],
98	98	'additionalInlineLanguageLabelFiles' => [],
		@@ -185,10 +185,10 @@ discard block
		block discarded – undo
185	185
186	186	// Html stuff for filter and select filter on top of right side of multi select boxes
187	187	$filterTextfield[] = '<span class="input-group input-group-sm">';
188		- $filterTextfield[] = '<span class="input-group-addon">';
189		- $filterTextfield[] = '<span class="fa fa-filter"></span>';
190		- $filterTextfield[] = '</span>';
191		- $filterTextfield[] = '<input class="t3js-formengine-multiselect-filter-textfield form-control" value="">';
	188	+ $filterTextfield[] = '<span class="input-group-addon">';
	189	+ $filterTextfield[] = '<span class="fa fa-filter"></span>';
	190	+ $filterTextfield[] = '</span>';
	191	+ $filterTextfield[] = '<input class="t3js-formengine-multiselect-filter-textfield form-control" value="">';
192	192	$filterTextfield[] = '</span>';
193	193
194	194	$filterDropDownOptions = [];
		@@ -206,14 +206,14 @@ discard block
		block discarded – undo
206	206	$filterHtml[] = '<div class="form-multigroup-item-wizard">';
207	207	if (!empty($filterDropDownOptions)) {
208	208	$filterHtml[] = '<div class="t3js-formengine-multiselect-filter-container form-multigroup-wrap">';
209		- $filterHtml[] = '<div class="form-multigroup-item form-multigroup-element">';
210		- $filterHtml[] = '<select class="form-select form-select-sm t3js-formengine-multiselect-filter-dropdown">';
211		- $filterHtml[] = implode(LF, $filterDropDownOptions);
212		- $filterHtml[] = '</select>';
213		- $filterHtml[] = '</div>';
214		- $filterHtml[] = '<div class="form-multigroup-item form-multigroup-element">';
215		- $filterHtml[] = implode(LF, $filterTextfield);
216		- $filterHtml[] = '</div>';
	209	+ $filterHtml[] = '<div class="form-multigroup-item form-multigroup-element">';
	210	+ $filterHtml[] = '<select class="form-select form-select-sm t3js-formengine-multiselect-filter-dropdown">';
	211	+ $filterHtml[] = implode(LF, $filterDropDownOptions);
	212	+ $filterHtml[] = '</select>';
	213	+ $filterHtml[] = '</div>';
	214	+ $filterHtml[] = '<div class="form-multigroup-item form-multigroup-element">';
	215	+ $filterHtml[] = implode(LF, $filterTextfield);
	216	+ $filterHtml[] = '</div>';
217	217	$filterHtml[] = '</div>';
218	218	} else {
219	219	$filterHtml[] = implode(LF, $filterTextfield);
		@@ -244,112 +244,112 @@ discard block
		block discarded – undo
244	244
245	245	$html = [];
246	246	$html[] = '<div class="formengine-field-item t3js-formengine-field-item">';
247		- $html[] = $fieldInformationHtml;
248		- $html[] = '<div class="form-wizards-wrap">';
249		- $html[] = '<div class="form-wizards-element">';
250		- $html[] = '<input type="hidden" data-formengine-input-name="' . htmlspecialchars($elementName) . '" value="' . (int)$itemCanBeSelectedMoreThanOnce . '" />';
251		- $html[] = '<div class="form-multigroup-wrap t3js-formengine-field-group">';
252		- $html[] = '<div class="form-multigroup-item form-multigroup-element">';
253		- $html[] = '<label>';
254		- $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.selected'));
255		- $html[] = '</label>';
256		- $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
257		- $html[] = '<div class="form-wizards-element">';
258		- $html[] = '<select';
259		- $html[] = ' id="' . $selectedOptionsFieldId . '"';
260		- $html[] = ' size="' . $size . '"';
261		- $html[] = ' class="form-select"';
262		- $html[] = $multipleAttribute;
263		- $html[] = ' data-formengine-input-name="' . htmlspecialchars($elementName) . '"';
264		- $html[] = '>';
265		- $html[] = implode(LF, $selectedItemsHtml);
266		- $html[] = '</select>';
267		- $html[] = '</div>';
268		- $html[] = '<div class="form-wizards-items-aside">';
269		- $html[] = '<div class="btn-group-vertical">';
	247	+ $html[] = $fieldInformationHtml;
	248	+ $html[] = '<div class="form-wizards-wrap">';
	249	+ $html[] = '<div class="form-wizards-element">';
	250	+ $html[] = '<input type="hidden" data-formengine-input-name="' . htmlspecialchars($elementName) . '" value="' . (int)$itemCanBeSelectedMoreThanOnce . '" />';
	251	+ $html[] = '<div class="form-multigroup-wrap t3js-formengine-field-group">';
	252	+ $html[] = '<div class="form-multigroup-item form-multigroup-element">';
	253	+ $html[] = '<label>';
	254	+ $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.selected'));
	255	+ $html[] = '</label>';
	256	+ $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
	257	+ $html[] = '<div class="form-wizards-element">';
	258	+ $html[] = '<select';
	259	+ $html[] = ' id="' . $selectedOptionsFieldId . '"';
	260	+ $html[] = ' size="' . $size . '"';
	261	+ $html[] = ' class="form-select"';
	262	+ $html[] = $multipleAttribute;
	263	+ $html[] = ' data-formengine-input-name="' . htmlspecialchars($elementName) . '"';
	264	+ $html[] = '>';
	265	+ $html[] = implode(LF, $selectedItemsHtml);
	266	+ $html[] = '</select>';
	267	+ $html[] = '</div>';
	268	+ $html[] = '<div class="form-wizards-items-aside">';
	269	+ $html[] = '<div class="btn-group-vertical">';
270	270	if ($maxItems > 1 && $size >= 5) {
271		- $html[] = '<a href="#"';
272		- $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-top"';
273		- $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
274		- $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_to_top')) . '"';
275		- $html[] = '>';
276		- $html[] = $this->iconFactory->getIcon('actions-move-to-top', Icon::SIZE_SMALL)->render();
277		- $html[] = '</a>';
	271	+ $html[] = '<a href="#"';
	272	+ $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-top"';
	273	+ $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
	274	+ $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_to_top')) . '"';
	275	+ $html[] = '>';
	276	+ $html[] = $this->iconFactory->getIcon('actions-move-to-top', Icon::SIZE_SMALL)->render();
	277	+ $html[] = '</a>';
278	278	}
279	279	if ($maxItems > 1) {
280		- $html[] = '<a href="#"';
281		- $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-up"';
282		- $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
283		- $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_up')) . '"';
284		- $html[] = '>';
285		- $html[] = $this->iconFactory->getIcon('actions-move-up', Icon::SIZE_SMALL)->render();
286		- $html[] = '</a>';
287		- $html[] = '<a href="#"';
288		- $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-down"';
289		- $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
290		- $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_down')) . '"';
291		- $html[] = '>';
292		- $html[] = $this->iconFactory->getIcon('actions-move-down', Icon::SIZE_SMALL)->render();
293		- $html[] = '</a>';
	280	+ $html[] = '<a href="#"';
	281	+ $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-up"';
	282	+ $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
	283	+ $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_up')) . '"';
	284	+ $html[] = '>';
	285	+ $html[] = $this->iconFactory->getIcon('actions-move-up', Icon::SIZE_SMALL)->render();
	286	+ $html[] = '</a>';
	287	+ $html[] = '<a href="#"';
	288	+ $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-down"';
	289	+ $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
	290	+ $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_down')) . '"';
	291	+ $html[] = '>';
	292	+ $html[] = $this->iconFactory->getIcon('actions-move-down', Icon::SIZE_SMALL)->render();
	293	+ $html[] = '</a>';
294	294	}
295	295	if ($maxItems > 1 && $size >= 5) {
296		- $html[] = '<a href="#"';
297		- $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-bottom"';
298		- $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
299		- $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_to_bottom')) . '"';
300		- $html[] = '>';
301		- $html[] = $this->iconFactory->getIcon('actions-move-to-bottom', Icon::SIZE_SMALL)->render();
302		- $html[] = '</a>';
	296	+ $html[] = '<a href="#"';
	297	+ $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-moveoption-bottom"';
	298	+ $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
	299	+ $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.move_to_bottom')) . '"';
	300	+ $html[] = '>';
	301	+ $html[] = $this->iconFactory->getIcon('actions-move-to-bottom', Icon::SIZE_SMALL)->render();
	302	+ $html[] = '</a>';
303	303	}
304		- $html[] = $alternativeFieldControlHtml;
305		- $html[] = '<a href="#"';
306		- $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-removeoption"';
307		- $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
308		- $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.remove_selected')) . '"';
309		- $html[] = '>';
310		- $html[] = $this->iconFactory->getIcon('actions-selection-delete', Icon::SIZE_SMALL)->render();
311		- $html[] = '</a>';
312		- $html[] = '</div>';
313		- $html[] = '</div>';
314		- $html[] = '</div>';
315		- $html[] = '</div>';
316		- $html[] = '<div class="form-multigroup-item form-multigroup-element">';
317		- $html[] = '<label>';
318		- $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.items'));
319		- $html[] = '</label>';
320		- $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
321		- $html[] = '<div class="form-wizards-element">';
322		- $html[] = implode(LF, $filterHtml);
323		- $html[] = '<select';
324		- $html[] = ' data-relatedfieldname="' . htmlspecialchars($elementName) . '"';
325		- $html[] = ' data-exclusivevalues="' . htmlspecialchars($config['exclusiveKeys']) . '"';
326		- $html[] = ' id="' . $availableOptionsFieldId . '"';
327		- $html[] = ' class="form-select t3js-formengine-select-itemstoselect"';
328		- $html[] = ' size="' . $size . '"';
329		- $html[] = ' onchange="' . htmlspecialchars(implode('', $parameterArray['fieldChangeFunc'])) . '"';
330		- $html[] = ' data-formengine-validation-rules="' . htmlspecialchars($this->getValidationDataAsJsonString($config)) . '"';
331		- $html[] = '>';
332		- $html[] = implode(LF, $selectableItemsHtml);
333		- $html[] = '</select>';
334		- $html[] = '</div>';
	304	+ $html[] = $alternativeFieldControlHtml;
	305	+ $html[] = '<a href="#"';
	306	+ $html[] = ' class="btn btn-default t3js-btn-option t3js-btn-removeoption"';
	307	+ $html[] = ' data-fieldname="' . htmlspecialchars($elementName) . '"';
	308	+ $html[] = ' title="' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.remove_selected')) . '"';
	309	+ $html[] = '>';
	310	+ $html[] = $this->iconFactory->getIcon('actions-selection-delete', Icon::SIZE_SMALL)->render();
	311	+ $html[] = '</a>';
	312	+ $html[] = '</div>';
	313	+ $html[] = '</div>';
	314	+ $html[] = '</div>';
	315	+ $html[] = '</div>';
	316	+ $html[] = '<div class="form-multigroup-item form-multigroup-element">';
	317	+ $html[] = '<label>';
	318	+ $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.items'));
	319	+ $html[] = '</label>';
	320	+ $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
	321	+ $html[] = '<div class="form-wizards-element">';
	322	+ $html[] = implode(LF, $filterHtml);
	323	+ $html[] = '<select';
	324	+ $html[] = ' data-relatedfieldname="' . htmlspecialchars($elementName) . '"';
	325	+ $html[] = ' data-exclusivevalues="' . htmlspecialchars($config['exclusiveKeys']) . '"';
	326	+ $html[] = ' id="' . $availableOptionsFieldId . '"';
	327	+ $html[] = ' class="form-select t3js-formengine-select-itemstoselect"';
	328	+ $html[] = ' size="' . $size . '"';
	329	+ $html[] = ' onchange="' . htmlspecialchars(implode('', $parameterArray['fieldChangeFunc'])) . '"';
	330	+ $html[] = ' data-formengine-validation-rules="' . htmlspecialchars($this->getValidationDataAsJsonString($config)) . '"';
	331	+ $html[] = '>';
	332	+ $html[] = implode(LF, $selectableItemsHtml);
	333	+ $html[] = '</select>';
	334	+ $html[] = '</div>';
335	335	if (!empty($fieldControlHtml)) {
336		- $html[] = '<div class="form-wizards-items-aside">';
337		- $html[] = '<div class="btn-group-vertical">';
338		- $html[] = $fieldControlHtml;
339		- $html[] = '</div>';
340		- $html[] = '</div>';
	336	+ $html[] = '<div class="form-wizards-items-aside">';
	337	+ $html[] = '<div class="btn-group-vertical">';
	338	+ $html[] = $fieldControlHtml;
	339	+ $html[] = '</div>';
	340	+ $html[] = '</div>';
341	341	}
342		- $html[] = '</div>';
343		- $html[] = '</div>';
344		- $html[] = '</div>';
345		- $html[] = '<input type="hidden" name="' . htmlspecialchars($elementName) . '" value="' . htmlspecialchars(implode(',', $listOfSelectedValues)) . '" />';
346		- $html[] = '</div>';
	342	+ $html[] = '</div>';
	343	+ $html[] = '</div>';
	344	+ $html[] = '</div>';
	345	+ $html[] = '<input type="hidden" name="' . htmlspecialchars($elementName) . '" value="' . htmlspecialchars(implode(',', $listOfSelectedValues)) . '" />';
	346	+ $html[] = '</div>';
347	347	if (!empty($fieldWizardHtml)) {
348	348	$html[] = '<div class="form-wizards-items-bottom">';
349	349	$html[] = $fieldWizardHtml;
350	350	$html[] = '</div>';
351	351	}
352		- $html[] = '</div>';
	352	+ $html[] = '</div>';
353	353	$html[] = '</div>';
354	354
355	355	$resultArray['requireJsModules'][] = ['TYPO3/CMS/Backend/FormEngine/Element/SelectMultipleSideBySideElement' => '
		@@ -416,29 +416,29 @@ discard block
		block discarded – undo
416	416
417	417	$html = [];
418	418	$html[] = '<div class="formengine-field-item t3js-formengine-field-item">';
419		- $html[] = $fieldInformationHtml;
420		- $html[] = '<div class="form-wizards-wrap">';
421		- $html[] = '<div class="form-wizards-element">';
422		- $html[] = '<label>';
423		- $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.selected'));
424		- $html[] = '</label>';
425		- $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
426		- $html[] = '<div class="form-wizards-element">';
427		- $html[] = '<select';
428		- $html[] = ' id="' . StringUtility::getUniqueId('tceforms-multiselect-') . '"';
429		- $html[] = ' size="' . $size . '"';
430		- $html[] = ' class="form-select"';
431		- $html[] = $multiple;
432		- $html[] = ' data-formengine-input-name="' . htmlspecialchars($fieldName) . '"';
433		- $html[] = ' disabled="disabled">';
434		- $html[] = '/>';
435		- $html[] = implode(LF, $optionsHtml);
436		- $html[] = '</select>';
437		- $html[] = '</div>';
438		- $html[] = '</div>';
439		- $html[] = '<input type="hidden" name="' . htmlspecialchars($fieldName) . '" value="' . htmlspecialchars(implode(',', $listOfSelectedValues)) . '" />';
440		- $html[] = '</div>';
441		- $html[] = '</div>';
	419	+ $html[] = $fieldInformationHtml;
	420	+ $html[] = '<div class="form-wizards-wrap">';
	421	+ $html[] = '<div class="form-wizards-element">';
	422	+ $html[] = '<label>';
	423	+ $html[] = htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.selected'));
	424	+ $html[] = '</label>';
	425	+ $html[] = '<div class="form-wizards-wrap form-wizards-aside">';
	426	+ $html[] = '<div class="form-wizards-element">';
	427	+ $html[] = '<select';
	428	+ $html[] = ' id="' . StringUtility::getUniqueId('tceforms-multiselect-') . '"';
	429	+ $html[] = ' size="' . $size . '"';
	430	+ $html[] = ' class="form-select"';
	431	+ $html[] = $multiple;
	432	+ $html[] = ' data-formengine-input-name="' . htmlspecialchars($fieldName) . '"';
	433	+ $html[] = ' disabled="disabled">';
	434	+ $html[] = '/>';
	435	+ $html[] = implode(LF, $optionsHtml);
	436	+ $html[] = '</select>';
	437	+ $html[] = '</div>';
	438	+ $html[] = '</div>';
	439	+ $html[] = '<input type="hidden" name="' . htmlspecialchars($fieldName) . '" value="' . htmlspecialchars(implode(',', $listOfSelectedValues)) . '" />';
	440	+ $html[] = '</div>';
	441	+ $html[] = '</div>';
442	442	$html[] = '</div>';
443	443
444	444	$resultArray['html'] = implode(LF, $html);

TYPO3 / TYPO3.CMS

Push — master ( fdcb41...982160 )

Status

Category

Spacing +130 added lines, -130 removed lines patch added patch discarded remove patch