Failed Conditions
Pull Request — master (#1308)
by Timo
31:21 queued 23:33
created
Domain/Search/ResultSet/Facets/OptionBased/Options/OptionsFacetParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      * @param SearchResultSet $resultSet
31 31
      * @param string $facetName
32 32
      * @param array $facetConfiguration
33
-     * @return OptionsFacet|null
33
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
34 34
      */
35 35
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
36 36
     {
Please login to merge, or discard this patch.
Search/ResultSet/Facets/OptionBased/QueryGroup/QueryGroupFacetParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
      * @param SearchResultSet $resultSet
33 33
      * @param string $facetName
34 34
      * @param array $facetConfiguration
35
-     * @return QueryGroupFacet|null
35
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
36 36
      */
37 37
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
38 38
     {
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Facet/RemoveAllFacetsViewHelper.php 1 patch
Unused Use Statements   -9 removed lines patch added patch discarded remove patch
@@ -14,16 +14,7 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
19
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionsFacet\Option;
20
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionsFacet\OptionsFacet;
21
-use ApacheSolrForTypo3\Solr\Domain\Search\Uri\SearchUriBuilder;
22
-use ApacheSolrForTypo3\Solr\Mvc\Controller\SolrControllerContext;
23
-use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractTagBasedViewHelper;
24 17
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
25
-use TYPO3\CMS\Core\Utility\GeneralUtility;
26
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
27 18
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
28 19
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
29 20
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Paginate/ResultPageViewHelper.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -14,10 +14,7 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/Widget/ResultPaginateViewHelper.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,6 @@
 block discarded – undo
24 24
  *  This copyright notice MUST APPEAR in all copies of the script!
25 25
  ***************************************************************/
26 26
 
27
-use ApacheSolrForTypo3\Solr\Search;
28 27
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
29 28
 use ApacheSolrForTypo3\Solr\Widget\AbstractWidgetViewHelper;
30 29
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/Facet/Area/GroupViewHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
     {
61 61
         /** @var  $facets FacetCollection */
62 62
         $facets = $arguments['facets'];
63
-        $requiredGroup = isset($arguments['groupName']) ? $arguments['groupName'] :  'main';
63
+        $requiredGroup = isset($arguments['groupName']) ? $arguments['groupName'] : 'main';
64 64
         $filtered = $facets->getByGroupName($requiredGroup);
65 65
 
66 66
         $templateVariableProvider = $renderingContext->getVariableProvider();
Please login to merge, or discard this patch.
Classes/ViewHelpers/Widget/Controller/FrequentlySearchedController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@
 block discarded – undo
87 87
 
88 88
             foreach ($frequentSearchTerms as $term => $hits) {
89 89
                 $size = round($minimumSize + (($hits - $minimumHits) * $step));
90
-                $frequentSearches[] = ['q' => htmlspecialchars_decode($term), 'hits' => $hits, 'style' => 'font-size: ' . $size . 'px', 'class' => 'tx-solr-frequent-term-' . $size, 'size' => $size,];
90
+                $frequentSearches[] = ['q' => htmlspecialchars_decode($term), 'hits' => $hits, 'style' => 'font-size: ' . $size . 'px', 'class' => 'tx-solr-frequent-term-' . $size, 'size' => $size, ];
91 91
             }
92 92
         }
93 93
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/Document/RelevanceViewHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
             /** @var $resultSet SearchResultSet */
68 68
         $resultSet = $arguments['resultSet'];
69 69
 
70
-        $maximumScore = $document->__solr_grouping_groupMaximumScore ? : $resultSet->getUsedSearch()->getMaximumResultScore();
70
+        $maximumScore = $document->__solr_grouping_groupMaximumScore ?: $resultSet->getUsedSearch()->getMaximumResultScore();
71 71
         $content = 0;
72 72
 
73 73
         if ($maximumScore <= 0) {
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Search/CurrentSearchViewHelper.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -14,10 +14,7 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
 
Please login to merge, or discard this patch.