Failed Conditions
Pull Request — master (#1308)
by Timo
31:21 queued 23:33
created
Classes/ViewHelpers/Document/IsBoostedFieldViewHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      * This method decides if the condition is true or false
50 50
      *
51 51
      * @param array $arguments ViewHelper arguments to evaluate the condition for this ViewHelper.
52
-     * @return bool
52
+     * @return double
53 53
      */
54 54
     protected static function evaluateCondition($arguments = null)
55 55
     {
Please login to merge, or discard this patch.
Classes/IndexQueue/Initializer/Page.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -270,7 +270,7 @@
 block discarded – undo
270 270
         $queueItemsOfExistingMountPoints = $GLOBALS['TYPO3_DB']->exec_SELECTgetRows(
271 271
             'COUNT(*) AS queueItemCount,item_uid',
272 272
             'tx_solr_indexqueue_item',
273
-            'item_type="pages" AND pages_mountidentifier = '. $identifier,
273
+            'item_type="pages" AND pages_mountidentifier = ' . $identifier,
274 274
             'item_uid',
275 275
             '',
276 276
             '',
Please login to merge, or discard this patch.
Classes/IndexQueue/Item.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -136,9 +136,9 @@
 block discarded – undo
136 136
         $this->rootPageUid = $itemMetaData['root'];
137 137
         $this->type = $itemMetaData['item_type'];
138 138
         $this->recordUid = $itemMetaData['item_uid'];
139
-        $this->mountPointIdentifier = (string) empty($itemMetaData['pages_mountidentifier']) ? '' : $itemMetaData['pages_mountidentifier'];
139
+        $this->mountPointIdentifier = (string)empty($itemMetaData['pages_mountidentifier']) ? '' : $itemMetaData['pages_mountidentifier'];
140 140
         $this->changed = $itemMetaData['changed'];
141
-        $this->errors = (string) empty($itemMetaData['errors']) ? '' : $itemMetaData['errors'];
141
+        $this->errors = (string)empty($itemMetaData['errors']) ? '' : $itemMetaData['errors'];
142 142
 
143 143
         $this->indexingConfigurationName = $itemMetaData['indexing_configuration'];
144 144
         $this->hasIndexingProperties = (boolean)$itemMetaData['has_indexing_properties'];
Please login to merge, or discard this patch.
Classes/Controller/Backend/Search/IndexAdministrationModuleController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
 
124 124
         if ($coresReloaded) {
125 125
             $this->addFlashMessage(
126
-                'Core configuration reloaded ('.implode(', ', $reloadedCores).').',
126
+                'Core configuration reloaded (' . implode(', ', $reloadedCores) . ').',
127 127
                 '',
128 128
                 FlashMessage::OK
129 129
             );
Please login to merge, or discard this patch.
Classes/System/Mvc/Backend/Service/ModuleDataStorageService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
      *
81 81
      * @param string|null $serializedModuleData
82 82
      */
83
-    private function unsetModuleDataIfCanNotBeSerialized(string &$serializedModuleData = null)
83
+    private function unsetModuleDataIfCanNotBeSerialized(string & $serializedModuleData = null)
84 84
     {
85 85
         if (!isset($serializedModuleData)) {
86 86
             $serializedModuleData = '';
Please login to merge, or discard this patch.
Domain/Search/ResultSet/Facets/OptionBased/Options/OptionsFacetParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      * @param SearchResultSet $resultSet
31 31
      * @param string $facetName
32 32
      * @param array $facetConfiguration
33
-     * @return OptionsFacet|null
33
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
34 34
      */
35 35
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
36 36
     {
Please login to merge, or discard this patch.
Search/ResultSet/Facets/OptionBased/QueryGroup/QueryGroupFacetParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
      * @param SearchResultSet $resultSet
33 33
      * @param string $facetName
34 34
      * @param array $facetConfiguration
35
-     * @return QueryGroupFacet|null
35
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
36 36
      */
37 37
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
38 38
     {
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Facet/RemoveAllFacetsViewHelper.php 1 patch
Unused Use Statements   -9 removed lines patch added patch discarded remove patch
@@ -14,16 +14,7 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
19
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionsFacet\Option;
20
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionsFacet\OptionsFacet;
21
-use ApacheSolrForTypo3\Solr\Domain\Search\Uri\SearchUriBuilder;
22
-use ApacheSolrForTypo3\Solr\Mvc\Controller\SolrControllerContext;
23
-use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractTagBasedViewHelper;
24 17
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
25
-use TYPO3\CMS\Core\Utility\GeneralUtility;
26
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
27 18
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
28 19
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
29 20
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Paginate/ResultPageViewHelper.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -14,10 +14,7 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
 
Please login to merge, or discard this patch.