TYPO3-Solr / ext-solr

Classes/Facet/DateRangeFacetRenderer.php

Doc Comments +1 added lines

@@ -106,6 +106,7 @@
 
     /**
      * tbd
+     * @param string $facetName
      */
     protected function buildAddFacetUrl($facetName)
     {

Classes/IndexQueue/PageIndexerResponse.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     /**
      * Turns a JSON encoded result string back into its PHP representation.
      *
-     * @param string $jsonEncodedResults JSON encoded result string
+     * @param string $jsonEncodedResponse JSON encoded result string
      * @return array|boolean An array of action => result pairs or FALSE if the response could not be decoded
      */
     public static function getResultsFromJson($jsonEncodedResponse)

Classes/IndexQueue/Queue.php

Doc Comments +1 added lines, -1 removed lines

@@ -856,7 +856,7 @@
      * Marks an item as failed and causes the indexer to skip the item in the
      * next run.
      *
-     * @param int|Item $item Either the item's Index Queue
+     * @param Item $item Either the item's Index Queue
      *      uid or the complete item
      * @param string $errorMessage Error message
      */

Classes/Plugin/PluginBase.php

Doc Comments +1 added lines, -1 removed lines

@@ -438,7 +438,7 @@
      * This method executes the requested commands and applies the changes to
      * the template.
      *
-     * @param $actionResult
+     * @param string $actionResult
      * @return string Rendered plugin content
      */
     abstract protected function render($actionResult);

Classes/Plugin/Results/NoResultsCommand.php

Doc Comments +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
     /**
      * Constructs label markers.
      *
-     * @return array Array of label markers.
+     * @return string Array of label markers.
      */
     protected function getLabelMarkers()
     {

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
         $markers = $this->getLabelMarkers();
 
         if ($this->parentPlugin->typoScriptConfiguration->getSearchSpellcheckingSearchUsingSpellCheckerSuggestion()) {
-            $suggestionResults =  $this->getSuggestionResults();
+            $suggestionResults = $this->getSuggestionResults();
             $markers['suggestion_results'] = $suggestionResults;
             $markers['has_suggestion_results'] = trim($suggestionResults) !== '';
         }

Classes/Query/FilterEncoder/DateRange.php

Doc Comments -1 removed lines

@@ -48,7 +48,6 @@
      * Parses the given date range from a GET parameter and returns a Solr
      * date range filter.
      *
-     * @param string $rangeFilter The range filter query string from the query URL
      * @param array $configuration Facet configuration
      * @return string Lucene query language filter to be used for querying Solr
      */

Classes/System/Configuration/TypoScriptConfiguration.php

Doc Comments +3 added lines, -3 removed lines

@@ -544,7 +544,7 @@ 
      *
      * @param string $configurationName
      * @param string $defaultIfEmpty
-     * @return mixed
+     * @return string
      */
     public function getIndexQueueInitializerClassByConfigurationName($configurationName, $defaultIfEmpty = 'ApacheSolrForTypo3\\Solr\\IndexQueue\\Initializer\\Record')
     {
@@ -1237,7 +1237,7 @@ 
      * plugin.tx_solr.search.query.allowEmptyQuery
      *
      * @param string $defaultIfEmpty
-     * @return string
+     * @return boolean
      */
     public function getSearchQueryAllowEmptyQuery($defaultIfEmpty = '')
     {
@@ -1299,7 +1299,7 @@ 
      *
      * plugin.tx_solr.search.query.returnFields
      *
-     * @param array $defaultIfEmpty
+     * @param string[] $defaultIfEmpty
      * @return array
      */
     public function getSearchQueryReturnFieldsAsArray($defaultIfEmpty = array())

Indentation -3 removed lines

@@ -767,7 +767,6 @@ 
      * Returns if a log message should be written when a page was indexed.
      *
      * plugin.tx_solr.logging.indexing.pageIndexed
-
      * @param bool $defaultIfEmpty
      * @return bool
      */
@@ -781,7 +780,6 @@ 
      * Returns if a log message should be written when the TYPO3 search markers are missing in the page.
      *
      * plugin.tx_solr.logging.indexing.missingTypo3SearchMarkers
-
      * @param bool $defaultIfEmpty
      * @return bool
      */
@@ -809,7 +807,6 @@ 
      * Indicates if the debug mode is enabled or not.
      *
      * plugin.tx_solr.enableDebugMode
-
      * @param bool $defaultIfEmpty
      * @return bool
      */

Spacing +1 added lines, -1 removed lines

@@ -1851,7 +1851,7 @@
     {
         $monitoredTables = array();
 
-        $indexingConfigurations =  $this->getEnabledIndexQueueConfigurationNames();
+        $indexingConfigurations = $this->getEnabledIndexQueueConfigurationNames();
         foreach ($indexingConfigurations as $indexingConfigurationName) {
             $monitoredTable = $this->getIndexQueueTableNameOrFallbackToConfigurationName($indexingConfigurationName);
             $monitoredTables[] = $monitoredTable;

Classes/Task/IndexQueueWorkerTask.php

Doc Comments +1 added lines, -1 removed lines

@@ -186,7 +186,7 @@
     }
 
     /**
-     * @return mixed
+     * @return integer
      */
     public function getDocumentsToIndexLimit()
     {

Spacing +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
             $message .= ' Failures: ' . $failedItemsCount;
         }
 
-        $message .=  ' / Using webroot: ' . htmlspecialchars($this->getWebRoot());
+        $message .= ' / Using webroot: ' . htmlspecialchars($this->getWebRoot());
 
         return $message;
     }

Classes/Template.php

Doc Comments +2 added lines, -1 removed lines

@@ -130,6 +130,7 @@ 
     /**
      * Finds the view helpers in the template and loads them.
      *
+     * @param string $content
      * @return void
      */
     protected function initializeViewHelpers($content)
@@ -1158,7 +1159,7 @@ 
     }
 
     /**
-     * @param $templateContent
+     * @param string $templateContent
      * @return mixed
      */
     public function setTemplateContent($templateContent)

Spacing +1 added lines, -1 removed lines

@@ -218,7 +218,7 @@
             $ucHelperKey = Util::underscoredToUpperCamelCase($helperKey);
             $vendorNameSpace = 'ApacheSolrForTypo3\\Solr\\';
             $possibleFilename = $ucHelperKey . '.php';
-            $possibleClassName =  $vendorNameSpace . str_replace('/', '\\',
+            $possibleClassName = $vendorNameSpace . str_replace('/', '\\',
                     $viewHelperRealPath) . '\\' . $ucHelperKey;
 
             $viewHelperIncludePath = ExtensionManagementUtility::extPath($extensionKey)