TYPO3-Solr / ext-solr

Classes/IndexQueue/Queue.php

Doc Comments +1 added lines, -1 removed lines

@@ -856,7 +856,7 @@
      * Marks an item as failed and causes the indexer to skip the item in the
      * next run.
      *
-     * @param int|Item $item Either the item's Index Queue
+     * @param Item $item Either the item's Index Queue
      *      uid or the complete item
      * @param string $errorMessage Error message
      */

Classes/Plugin/PluginBase.php

Doc Comments +1 added lines, -1 removed lines

@@ -438,7 +438,7 @@
      * This method executes the requested commands and applies the changes to
      * the template.
      *
-     * @param $actionResult
+     * @param string $actionResult
      * @return string Rendered plugin content
      */
     abstract protected function render($actionResult);

Classes/Plugin/Results/NoResultsCommand.php

Doc Comments +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
     /**
      * Constructs label markers.
      *
-     * @return array Array of label markers.
+     * @return string Array of label markers.
      */
     protected function getLabelMarkers()
     {

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
         $markers = $this->getLabelMarkers();
 
         if ($this->parentPlugin->typoScriptConfiguration->getSearchSpellcheckingSearchUsingSpellCheckerSuggestion()) {
-            $suggestionResults =  $this->getSuggestionResults();
+            $suggestionResults = $this->getSuggestionResults();
             $markers['suggestion_results'] = $suggestionResults;
             $markers['has_suggestion_results'] = trim($suggestionResults) !== '';
         }

Classes/System/Configuration/TypoScriptConfiguration.php

Doc Comments +3 added lines, -3 removed lines

@@ -544,7 +544,7 @@ 
      *
      * @param string $configurationName
      * @param string $defaultIfEmpty
-     * @return mixed
+     * @return string
      */
     public function getIndexQueueInitializerClassByConfigurationName($configurationName, $defaultIfEmpty = 'ApacheSolrForTypo3\\Solr\\IndexQueue\\Initializer\\Record')
     {
@@ -1237,7 +1237,7 @@ 
      * plugin.tx_solr.search.query.allowEmptyQuery
      *
      * @param string $defaultIfEmpty
-     * @return string
+     * @return boolean
      */
     public function getSearchQueryAllowEmptyQuery($defaultIfEmpty = '')
     {
@@ -1299,7 +1299,7 @@ 
      *
      * plugin.tx_solr.search.query.returnFields
      *
-     * @param array $defaultIfEmpty
+     * @param string[] $defaultIfEmpty
      * @return array
      */
     public function getSearchQueryReturnFieldsAsArray($defaultIfEmpty = array())

Indentation -3 removed lines

@@ -767,7 +767,6 @@ 
      * Returns if a log message should be written when a page was indexed.
      *
      * plugin.tx_solr.logging.indexing.pageIndexed
-
      * @param bool $defaultIfEmpty
      * @return bool
      */
@@ -781,7 +780,6 @@ 
      * Returns if a log message should be written when the TYPO3 search markers are missing in the page.
      *
      * plugin.tx_solr.logging.indexing.missingTypo3SearchMarkers
-
      * @param bool $defaultIfEmpty
      * @return bool
      */
@@ -809,7 +807,6 @@ 
      * Indicates if the debug mode is enabled or not.
      *
      * plugin.tx_solr.enableDebugMode
-
      * @param bool $defaultIfEmpty
      * @return bool
      */

Spacing +3 added lines, -3 removed lines

@@ -406,7 +406,7 @@ 
     {
         $monitoredTables = [];
 
-        $indexingConfigurations =  $this->getEnabledIndexQueueConfigurationNames();
+        $indexingConfigurations = $this->getEnabledIndexQueueConfigurationNames();
         foreach ($indexingConfigurations as $indexingConfigurationName) {
             $monitoredTable = $this->getIndexQueueTableNameOrFallbackToConfigurationName($indexingConfigurationName);
             $monitoredTables[] = $monitoredTable;
@@ -532,13 +532,13 @@ 
     public function getInitialPagesAdditionalWhereClause($defaultIfEmpty = ' AND 1=1')
     {
         $path = 'plugin.tx_solr.index.queue.pages' . '.initialPagesAdditionalWhereClause';
-        $initialPagesAdditionalWhereClause =  $this->getValueByPathOrDefaultValue($path, '');
+        $initialPagesAdditionalWhereClause = $this->getValueByPathOrDefaultValue($path, '');
 
         if (trim($initialPagesAdditionalWhereClause) === '') {
             return $defaultIfEmpty;
         }
 
-        return ' AND ' .  $initialPagesAdditionalWhereClause;
+        return ' AND ' . $initialPagesAdditionalWhereClause;
     }
 
     /**

Classes/Backend/SolrModule/AbstractModuleController.php

Spacing +2 added lines, -2 removed lines

@@ -190,12 +190,12 @@
     protected function getRequestArgumentOrDefaultValue($argumentKey, $default)
     {
         // no request -> return default
-        if (! isset($this->request)) {
+        if (!isset($this->request)) {
             return $default;
         }
 
         // argument not present -> return default value
-        if (! $this->request->hasArgument($argumentKey)) {
+        if (!$this->request->hasArgument($argumentKey)) {
             return $default;
         }
 

Classes/Access/Rootline.php

Spacing +1 added lines, -1 removed lines

@@ -221,7 +221,7 @@
     public static function cleanGroupArray(array $groups)
     {
         $groups = array_unique($groups); // removes duplicates
-        sort($groups, SORT_NUMERIC);     // sort
+        sort($groups, SORT_NUMERIC); // sort
 
         return $groups;
     }

Classes/Task/IndexQueueWorkerTask.php

Spacing +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
             $message .= ' Failures: ' . $failedItemsCount;
         }
 
-        $message .=  ' / Using webroot: ' . htmlspecialchars($this->getWebRoot());
+        $message .= ' / Using webroot: ' . htmlspecialchars($this->getWebRoot());
 
         return $message;
     }

Classes/Domain/Search/FrequentSearches/FrequentSearchesService.php

Spacing +4 added lines, -4 removed lines

@@ -69,7 +69,7 @@ 
      * @param TypoScriptFrontendController $tsfe
      * @param DatabaseConnection $database
      */
-    public function __construct(TypoScriptConfiguration $typoscriptConfiguration, AbstractFrontend $cache,  TypoScriptFrontendController $tsfe, DatabaseConnection $database)
+    public function __construct(TypoScriptConfiguration $typoscriptConfiguration, AbstractFrontend $cache, TypoScriptFrontendController $tsfe, DatabaseConnection $database)
     {
         $this->configuration = $typoscriptConfiguration;
         $this->cache = $cache;
@@ -132,7 +132,7 @@ 
             $checkLanguageWhere = '';
         }
 
-        $frequentSearchConfiguration['select.']['ADD_WHERE'] =  $checkRootPidWhere .
+        $frequentSearchConfiguration['select.']['ADD_WHERE'] = $checkRootPidWhere .
                                                                 $checkLanguageWhere . ' ' .
                                                                 $frequentSearchConfiguration['select.']['ADD_WHERE'];
 
@@ -167,10 +167,10 @@ 
         $identifier = 'frequentSearchesTags';
 
         if ($frequentSearchConfiguration['select.']['checkRootPageId']) {
-            $identifier .= '_RP' . (int) $this->tsfe->tmpl->rootLine[0]['uid'];
+            $identifier .= '_RP' . (int)$this->tsfe->tmpl->rootLine[0]['uid'];
         }
         if ($frequentSearchConfiguration['select.']['checkLanguage']) {
-            $identifier .= '_L' . (int) $this->tsfe->sys_language_uid;
+            $identifier .= '_L' . (int)$this->tsfe->sys_language_uid;
         }
 
         $identifier .= '_' . md5(serialize($frequentSearchConfiguration));

Classes/Domain/Search/LastSearches/LastSearchesService.php

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
      */
     public function addToLastSearches($keywords)
     {
-        $mode   = $this->configuration->getSearchLastSearchesMode();
+        $mode = $this->configuration->getSearchLastSearchesMode();
         switch ($mode) {
             case 'user':
                 $this->storeKeywordsToSession($keywords);
@@ -227,7 +227,7 @@ 
     protected function getNextSequenceId()
     {
         $nextSequenceId = 0;
-        $numberOfLastSearchesToLog = (int) $this->configuration->getSearchLastSearchesLimit();
+        $numberOfLastSearchesToLog = (int)$this->configuration->getSearchLastSearchesLimit();
 
         $row = $this->database->exec_SELECTgetRows(
             '(sequence_id + 1) % ' . $numberOfLastSearchesToLog . ' as next_sequence_id',

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
     /**
      * Gets the last searched keywords from the database
      *
-     * @param int|bool $limit
+     * @param integer $limit
      * @return array An array containing the last searches of the current user
      */
     protected function getLastSearchesFromDatabase($limit = false)