Completed
Pull Request — master (#875)
by
unknown
30:11 queued 10:15
created
Classes/System/Configuration/TypoScriptConfiguration.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -604,7 +604,7 @@  discard block
 block discarded – undo
604 604
      *
605 605
      * @param string $configurationName
606 606
      * @param string $defaultIfEmpty
607
-     * @return mixed
607
+     * @return string
608 608
      */
609 609
     public function getIndexQueueInitializerClassByConfigurationName($configurationName, $defaultIfEmpty = 'ApacheSolrForTypo3\\Solr\\IndexQueue\\Initializer\\Record')
610 610
     {
@@ -1309,7 +1309,7 @@  discard block
 block discarded – undo
1309 1309
      * plugin.tx_solr.search.query.allowEmptyQuery
1310 1310
      *
1311 1311
      * @param string $defaultIfEmpty
1312
-     * @return string
1312
+     * @return boolean
1313 1313
      */
1314 1314
     public function getSearchQueryAllowEmptyQuery($defaultIfEmpty = '')
1315 1315
     {
@@ -1371,7 +1371,7 @@  discard block
 block discarded – undo
1371 1371
      *
1372 1372
      * plugin.tx_solr.search.query.returnFields
1373 1373
      *
1374
-     * @param array $defaultIfEmpty
1374
+     * @param string[] $defaultIfEmpty
1375 1375
      * @return array
1376 1376
      */
1377 1377
     public function getSearchQueryReturnFieldsAsArray($defaultIfEmpty = array())
@@ -1956,7 +1956,7 @@  discard block
 block discarded – undo
1956 1956
      * plugin.tx_solr.index.enableCommits
1957 1957
      *
1958 1958
      * @param bool $defaultIfEmpty
1959
-     * @return bool
1959
+     * @return boolean|null
1960 1960
      */
1961 1961
     public function getEnableCommits($defaultIfEmpty = true)
1962 1962
     {
Please login to merge, or discard this patch.
Indentation   +2 added lines, -5 removed lines patch added patch discarded remove patch
@@ -827,7 +827,6 @@  discard block
 block discarded – undo
827 827
      * Returns if a log message should be written when a page was indexed.
828 828
      *
829 829
      * plugin.tx_solr.logging.indexing.pageIndexed
830
-
831 830
      * @param bool $defaultIfEmpty
832 831
      * @return bool
833 832
      */
@@ -841,7 +840,6 @@  discard block
 block discarded – undo
841 840
      * Returns if a log message should be written when the TYPO3 search markers are missing in the page.
842 841
      *
843 842
      * plugin.tx_solr.logging.indexing.missingTypo3SearchMarkers
844
-
845 843
      * @param bool $defaultIfEmpty
846 844
      * @return bool
847 845
      */
@@ -869,7 +867,6 @@  discard block
 block discarded – undo
869 867
      * Indicates if the debug mode is enabled or not.
870 868
      *
871 869
      * plugin.tx_solr.enableDebugMode
872
-
873 870
      * @param bool $defaultIfEmpty
874 871
      * @return bool
875 872
      */
@@ -1960,8 +1957,8 @@  discard block
 block discarded – undo
1960 1957
      */
1961 1958
     public function getEnableCommits($defaultIfEmpty = true)
1962 1959
     {
1963
-	$enableCommits = $this->getValueByPathOrDefaultValue('plugin.tx_solr.index.enableCommits', $defaultIfEmpty);
1964
-	$this->getBool($enableCommits);
1960
+    $enableCommits = $this->getValueByPathOrDefaultValue('plugin.tx_solr.index.enableCommits', $defaultIfEmpty);
1961
+    $this->getBool($enableCommits);
1965 1962
     }
1966 1963
 
1967 1964
 }
Please login to merge, or discard this patch.
Classes/GarbageCollector.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -207,7 +207,7 @@
 block discarded – undo
207 207
             $solrConnections = $connectionManager->getConnectionsBySite($site);
208 208
             foreach ($solrConnections as $solr) {
209 209
                 $solr->deleteByQuery('type:' . $table . ' AND uid:' . intval($uid));
210
-                if($solrConfiguration->getEnableCommits()) {
210
+                if ($solrConfiguration->getEnableCommits()) {
211 211
                     $solr->commit(false, false, false);
212 212
                 }
213 213
             }
Please login to merge, or discard this patch.
Classes/Task/ReIndexTask.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@
 block discarded – undo
98 98
                 . ' AND siteHash:' . $this->site->getSiteHash();
99 99
             $solrServer->deleteByQuery($deleteQuery);
100 100
 
101
-            if(!$solrConfiguration->getEnableCommits()) {
101
+            if (!$solrConfiguration->getEnableCommits()) {
102 102
                 # Do not commit
103 103
                 continue;
104 104
             }
Please login to merge, or discard this patch.