TYPO3-Solr / ext-solr

Classes/Domain/Search/LastSearches/LastSearchesService.php

Doc Comments +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
     /**
      * Gets the last searched keywords from the database
      *
-     * @param int|bool $limit
+     * @param integer $limit
      * @return array An array containing the last searches of the current user
      */
     protected function getLastSearchesFromDatabase($limit = false)

Classes/Plugin/Results/Results.php

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
 use ApacheSolrForTypo3\Solr\Domain\Search\SearchRequest;
 use ApacheSolrForTypo3\Solr\Plugin\CommandPluginBase;
 use ApacheSolrForTypo3\Solr\Plugin\PluginCommand;
-use ApacheSolrForTypo3\Solr\Query;
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
 use ApacheSolrForTypo3\Solr\Template;
 use TYPO3\CMS\Core\Utility\GeneralUtility;

Classes/Site.php

Doc Comments +1 added lines, -1 removed lines

@@ -274,7 +274,7 @@
      * Generates a list of page IDs in this site. Attention, this includes
      * all page types! Deleted pages are not included.
      *
-     * @param int|string $rootPageId Page ID from where to start collection sub pages
+     * @param integer $rootPageId Page ID from where to start collection sub pages
      * @param int $maxDepth Maximum depth to decend into the site tree
      * @return array Array of pages (IDs) in this site
      */

Classes/SolrService.php

Doc Comments +8 added lines, -8 removed lines

@@ -128,7 +128,7 @@ 
     /**
      * Returns the current time in milliseconds.
      *
-     * @return int
+     * @return double
      */
     protected function getMilliseconds()
     {
@@ -174,7 +174,7 @@ 
      *
      * Also does not report the time, see https://forge.typo3.org/issues/64551
      *
-     * @param float|int $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
      * @return bool TRUE if Solr can be reached, FALSE if not
      */
     public function ping($timeout = 2)
@@ -186,8 +186,8 @@ 
     /**
      * Call the /admin/ping servlet, can be used to get the runtime of a ping request.
      *
-     * @param float|int $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
-     * @return int runtime in milliseconds
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
+     * @return double runtime in milliseconds
      * @throws \ApacheSolrForTypo3\Solr\PingFailedException
      */
     public function getPingRoundTripRuntime($timeout = 2)
@@ -581,7 +581,7 @@ 
      * a complete and well formed "delete" xml document
      *
      * @param string $rawPost Expected to be utf-8 encoded xml document
-     * @param float|int $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
+     * @param integer $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
      * @return \Apache_Solr_Response
      */
     public function delete($rawPost, $timeout = 3600)
@@ -678,7 +678,7 @@ 
     /**
      * Add list of synonyms for base word to managed synonyms map
      *
-     * @param $baseWord
+     * @param string $baseWord
      * @param array $synonyms
      *
      * @return \Apache_Solr_Response
@@ -699,7 +699,7 @@ 
     /**
      * Remove a synonym from the synonyms map
      *
-     * @param $baseWord
+     * @param string $baseWord
      * @return \Apache_Solr_Response
      * @throws \Apache_Solr_InvalidArgumentException
      */
@@ -715,7 +715,7 @@ 
     /**
      * Central method for making a HTTP DELETE operation against the Solr server
      *
-     * @param $url
+     * @param string $url
      * @param bool|float $timeout Read timeout in seconds
      * @return \Apache_Solr_Response
      */

Classes/Util.php

Doc Comments +4 added lines, -4 removed lines

@@ -236,7 +236,7 @@ 
      * @param int $pageId Id of the (root) page to get the Solr configuration from.
      * @param string $path The TypoScript configuration path to retrieve.
      * @param bool $initializeTsfe Optionally initializes a full TSFE to get the configuration, defaults to FALSE
-     * @param int|bool $language System language uid or FALSE to disable language usage, optional, defaults to 0
+     * @param integer $language System language uid or FALSE to disable language usage, optional, defaults to 0
      * @return TypoScriptConfiguration The Solr configuration for the requested tree.
      */
     public static function getConfigurationFromPageId(
@@ -311,9 +311,9 @@ 
 
     /**
      * This function is used to retrieve the configuration from an existing TSFE instance
-     * @param $pageId
-     * @param $path
-     * @param $language
+     * @param integer $pageId
+     * @param string $path
+     * @param integer $language
      * @return mixed
      */
     private static function getConfigurationFromExistingTSFE($pageId, $path, $language)

Classes/Report/SolrStatus.php

Spacing +3 added lines, -3 removed lines

@@ -199,7 +199,7 @@ 
     {
         try {
             $pingQueryTime = $solr->getPingRoundTripRuntime();
-            $pingMessage = (int) $pingQueryTime . ' ms';
+            $pingMessage = (int)$pingQueryTime . ' ms';
         } catch (PingFailedException $e) {
             $this->responseStatus = Status::ERROR;
             $pingMessage = 'Ping error: ' . $e->getMessage();
@@ -217,7 +217,7 @@ 
         try {
             $solrConfigMessage = $solr->getSolrconfigName();
         } catch (\Exception $e) {
-            $this->responseStatus =  Status::ERROR;
+            $this->responseStatus = Status::ERROR;
             $solrConfigMessage = 'Error determining solr config: ' . $e->getMessage();
         }
 
@@ -234,7 +234,7 @@ 
         try {
             $solrSchemaMessage = $solr->getSchemaName();
         } catch (\Exception $e) {
-            $this->responseStatus  = Status::ERROR;
+            $this->responseStatus = Status::ERROR;
             $solrSchemaMessage = 'Error determining schema name: ' . $e->getMessage();
         }
 

Classes/Domain/Search/ResultSet/SearchResultSetService.php

Spacing +7 added lines, -9 removed lines

@@ -282,7 +282,7 @@ 
      * @param Query $query The query that has been searched for.
      * @param \Apache_Solr_Response $response The search's response.
      */
-    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response &$response)
+    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response & $response)
     {
         if ($this->shouldHideResultsFromInitialSearch($rawQuery)) {
             // explicitly set number of results to 0 as we just wanted
@@ -310,7 +310,7 @@ 
      *
      * @param \Apache_Solr_Response $response
      */
-    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response &$response)
+    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response & $response)
     {
         if (!is_array($response->response->docs)) {
             return;
@@ -362,7 +362,7 @@ 
      * @param \Apache_Solr_Response $response
      * @throws \InvalidArgumentException
      */
-    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response &$response)
+    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response & $response)
     {
         if (!is_array($response->response->docs)) {
             return;
@@ -387,7 +387,7 @@ 
         $searchResultClassName = $this->getResultClassName();
         $result = GeneralUtility::makeInstance($searchResultClassName, $originalDocument);
         if (!$result instanceof SearchResult) {
-            throw new \InvalidArgumentException('Could not create result object with class: ' . (string) $searchResultClassName, 1470037679);
+            throw new \InvalidArgumentException('Could not create result object with class: ' . (string)$searchResultClassName, 1470037679);
         }
 
         return $result;
@@ -399,8 +399,7 @@ 
     protected function getResultClassName()
     {
         return isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultClassName ']) ?
-            $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultClassName '] :
-            'ApacheSolrForTypo3\\Solr\\Domain\\Search\\ResultSet\\SearchResult';
+            $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultClassName '] : 'ApacheSolrForTypo3\\Solr\\Domain\\Search\\ResultSet\\SearchResult';
     }
 
     /**
@@ -409,8 +408,7 @@ 
     protected function getResultSetClassName()
     {
         return isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultSetClassName ']) ?
-            $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultSetClassName '] :
-            'ApacheSolrForTypo3\\Solr\\Domain\\Search\\ResultSet\\SearchResultSet';
+            $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultSetClassName '] : 'ApacheSolrForTypo3\\Solr\\Domain\\Search\\ResultSet\\SearchResultSet';
     }
 
     /**
@@ -556,7 +554,7 @@ 
         $response = $this->search->search($query, 0, 1);
         $this->processResponse($documentId, $query, $response);
 
-        $resultDocument = isset($response->response->docs[0]) ?  $response->response->docs[0] : null;
+        $resultDocument = isset($response->response->docs[0]) ? $response->response->docs[0] : null;
         return $resultDocument;
     }