Failed Conditions
Pull Request — master (#1638)
by Timo
04:43
created
Classes/Domain/Search/SearchRequestBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@
 block discarded – undo
175 175
      * This methods sets the page argument to an expected positive integer value in the arguments array.
176 176
      *
177 177
      * @param array $arguments
178
-     * @return array
178
+     * @return integer
179 179
      */
180 180
     protected function adjustPageArgumentToPositiveInteger(array $arguments)
181 181
     {
Please login to merge, or discard this patch.
Classes/Domain/Search/Suggest/SuggestService.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
      *
79 79
      * @param SearchRequest $searchRequest
80 80
      * @param string $additionalFilters
81
-     * @return array
81
+     * @return string
82 82
      */
83 83
     public function getSuggestions(SearchRequest $searchRequest, $additionalFilters) : array
84 84
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
      */
148 148
     protected function getSolrSuggestions(SuggestQuery $suggestQuery) : array
149 149
     {
150
-        $pageId =  $this->tsfe->getRequestedId();
150
+        $pageId = $this->tsfe->getRequestedId();
151 151
         $languageId = $this->tsfe->sys_language_uid;
152 152
         $solr = GeneralUtility::makeInstance(ConnectionManager::class)->getConnectionByPageId($pageId, $languageId);
153 153
         $search = GeneralUtility::makeInstance(Search::class, $solr);
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
      * @param string $additionalFilters
258 258
      * @return SuggestQuery
259 259
      */
260
-    protected function buildSuggestQuery(string $queryString , string $additionalFilters) : SuggestQuery
260
+    protected function buildSuggestQuery(string $queryString, string $additionalFilters) : SuggestQuery
261 261
     {
262 262
         $suggestQuery = GeneralUtility::makeInstance(SuggestQuery::class, $queryString);
263 263
 
Please login to merge, or discard this patch.
Classes/SolrService.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
 
253 253
         $status = $response->getHttpStatus();
254 254
         $isValidResponse = $status === 200;
255
-        if($isValidResponse) {
255
+        if ($isValidResponse) {
256 256
             return $response;
257 257
         }
258 258
 
@@ -271,13 +271,13 @@  discard block
 block discarded – undo
271 271
         $status = $response->getHttpStatus();
272 272
         $message = $response->getHttpStatusMessage();
273 273
 
274
-        if($status === 0) {
274
+        if ($status === 0) {
275 275
             $e = new SolrUnavailableException('Solr Server not available: ' . $message, 1505989391);
276 276
             $e->setSolrResponse($response);
277 277
             throw $e;
278 278
         }
279 279
 
280
-        if($status === 500) {
280
+        if ($status === 500) {
281 281
             $e = new SolrInternalServerErrorException('Internal Server error during search: ' . $message, 1505989897);
282 282
             $e->setSolrResponse($response);
283 283
             throw $e;
Please login to merge, or discard this patch.
Classes/Controller/SuggestController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
      */
78 78
     protected function handleSolrUnavailable()
79 79
     {
80
-        if($this->typoScriptConfiguration->getLoggingExceptions()) {
80
+        if ($this->typoScriptConfiguration->getLoggingExceptions()) {
81 81
                 /** @var SolrLogManager $logger */
82 82
             $logger = GeneralUtility::makeInstance(SolrLogManager::class, __CLASS__);
83 83
             $logger->log(SolrLogManager::ERROR, 'Solr server is not available');
Please login to merge, or discard this patch.