TGMPA / TGM-Plugin-Activation

classes/TGM_Plugin_Activation.php

Spacing +73 added lines, -73 removed lines

@@ -769,7 +769,7 @@ 
 			// All plugin information will be stored in an array for processing.
 			$slug = $this->sanitize_key( urldecode( $_GET['plugin'] ) );
 
-			if ( ! isset( $this->plugins[ $slug ] ) ) {
+			if ( ! isset( $this->plugins[$slug] ) ) {
 				return false;
 			}
 
@@ -814,7 +814,7 @@ 
 				$extra         = array();
 				$extra['slug'] = $slug; // Needed for potentially renaming of directory name.
 				$source        = $this->get_download_url( $slug );
-				$api           = ( 'repo' === $this->plugins[ $slug ]['source_type'] ) ? $this->get_plugins_api( $slug ) : null;
+				$api           = ( 'repo' === $this->plugins[$slug]['source_type'] ) ? $this->get_plugins_api( $slug ) : null;
 				$api           = ( false !== $api ) ? $api : null;
 
 				$url = add_query_arg(
@@ -831,8 +831,8 @@ 
 
 				$title     = ( 'update' === $install_type ) ? $this->strings['updating'] : $this->strings['installing'];
 				$skin_args = array(
-					'type'   => ( 'bundled' !== $this->plugins[ $slug ]['source_type'] ) ? 'web' : 'upload',
-					'title'  => sprintf( $title, $this->plugins[ $slug ]['name'] ),
+					'type'   => ( 'bundled' !== $this->plugins[$slug]['source_type'] ) ? 'web' : 'upload',
+					'title'  => sprintf( $title, $this->plugins[$slug]['name'] ),
 					'url'    => esc_url_raw( $url ),
 					'nonce'  => $install_type . '-plugin_' . $slug,
 					'plugin' => '',
@@ -842,7 +842,7 @@ 
 				unset( $title );
 
 				if ( 'update' === $install_type ) {
-					$skin_args['plugin'] = $this->plugins[ $slug ]['file_path'];
+					$skin_args['plugin'] = $this->plugins[$slug]['file_path'];
 					$skin                = new Plugin_Upgrader_Skin( $skin_args );
 				} else {
 					$skin = new Plugin_Installer_Skin( $skin_args );
@@ -857,12 +857,12 @@ 
 				if ( 'update' === $install_type ) {
 					// Inject our info into the update transient.
 					$to_inject                    = array(
-						$slug => $this->plugins[ $slug ],
+						$slug => $this->plugins[$slug],
 					);
-					$to_inject[ $slug ]['source'] = $source;
+					$to_inject[$slug]['source'] = $source;
 					$this->inject_update_info( $to_inject );
 
-					$upgrader->upgrade( $this->plugins[ $slug ]['file_path'] );
+					$upgrader->upgrade( $this->plugins[$slug]['file_path'] );
 				} else {
 					$upgrader->install( $source );
 				}
@@ -892,11 +892,11 @@ 
 				}
 
 				return true;
-			} elseif ( isset( $this->plugins[ $slug ]['file_path'], $_GET['tgmpa-activate'] ) && 'activate-plugin' === $_GET['tgmpa-activate'] ) {
+			} elseif ( isset( $this->plugins[$slug]['file_path'], $_GET['tgmpa-activate'] ) && 'activate-plugin' === $_GET['tgmpa-activate'] ) {
 				// Activate action link was clicked.
 				check_admin_referer( 'tgmpa-activate', 'tgmpa-nonce' );
 
-				if ( false === $this->activate_single_plugin( $this->plugins[ $slug ]['file_path'], $slug ) ) {
+				if ( false === $this->activate_single_plugin( $this->plugins[$slug]['file_path'], $slug ) ) {
 					return true; // Finish execution of the function early as we encountered an error.
 				}
 			}
@@ -921,17 +921,17 @@ 
 			foreach ( $plugins as $slug => $plugin ) {
 				$file_path = $plugin['file_path'];
 
-				if ( empty( $repo_updates->response[ $file_path ] ) ) {
-					$repo_updates->response[ $file_path ] = new stdClass();
+				if ( empty( $repo_updates->response[$file_path] ) ) {
+					$repo_updates->response[$file_path] = new stdClass();
 				}
 
 				// We only really need to set package, but let's do all we can in case WP changes something.
-				$repo_updates->response[ $file_path ]->slug        = $slug;
-				$repo_updates->response[ $file_path ]->plugin      = $file_path;
-				$repo_updates->response[ $file_path ]->new_version = $plugin['version'];
-				$repo_updates->response[ $file_path ]->package     = $plugin['source'];
-				if ( empty( $repo_updates->response[ $file_path ]->url ) && ! empty( $plugin['external_url'] ) ) {
-					$repo_updates->response[ $file_path ]->url = $plugin['external_url'];
+				$repo_updates->response[$file_path]->slug        = $slug;
+				$repo_updates->response[$file_path]->plugin      = $file_path;
+				$repo_updates->response[$file_path]->new_version = $plugin['version'];
+				$repo_updates->response[$file_path]->package     = $plugin['source'];
+				if ( empty( $repo_updates->response[$file_path]->url ) && ! empty( $plugin['external_url'] ) ) {
+					$repo_updates->response[$file_path]->url = $plugin['external_url'];
 				}
 			}
 
@@ -974,7 +974,7 @@ 
 			} else {
 				// Bulk installer contains less info, so fall back on the info registered here.
 				foreach ( $this->plugins as $slug => $plugin ) {
-					if ( ! empty( $upgrader->skin->plugin_names[ $upgrader->skin->i ] ) && $plugin['name'] === $upgrader->skin->plugin_names[ $upgrader->skin->i ] ) {
+					if ( ! empty( $upgrader->skin->plugin_names[$upgrader->skin->i] ) && $plugin['name'] === $upgrader->skin->plugin_names[$upgrader->skin->i] ) {
 						$desired_slug = $slug;
 						break;
 					}
@@ -1041,7 +1041,7 @@ 
 						// Make sure message doesn't display again if bulk activation is performed
 						// immediately after a single activation.
 						if ( ! isset( $_POST['action'] ) ) { // WPCS: CSRF OK.
-							echo '<div id="message" class="updated"><p>', esc_html( $this->strings['activated_successfully'] ), ' <strong>', esc_html( $this->plugins[ $slug ]['name'] ), '.</strong></p></div>';
+							echo '<div id="message" class="updated"><p>', esc_html( $this->strings['activated_successfully'] ), ' <strong>', esc_html( $this->plugins[$slug]['name'] ), '.</strong></p></div>';
 						}
 					} else {
 						// Simpler message layout for use on the plugin install page.
@@ -1054,7 +1054,7 @@ 
 				echo '<div id="message" class="error"><p>',
 					sprintf(
 						esc_html( $this->strings['plugin_already_active'] ),
-						'<strong>' . esc_html( $this->plugins[ $slug ]['name'] ) . '</strong>'
+						'<strong>' . esc_html( $this->plugins[$slug]['name'] ) . '</strong>'
 					),
 					'</p></div>';
 			} elseif ( $this->does_plugin_require_update( $slug ) ) {
@@ -1065,13 +1065,13 @@ 
 						echo '<div id="message" class="error"><p>',
 							sprintf(
 								esc_html( $this->strings['plugin_needs_higher_version'] ),
-								'<strong>' . esc_html( $this->plugins[ $slug ]['name'] ) . '</strong>'
+								'<strong>' . esc_html( $this->plugins[$slug]['name'] ) . '</strong>'
 							),
 							'</p></div>';
 					}
 				} else {
 					// Simpler message layout for use on the plugin install page.
-					echo '<p>', sprintf( esc_html( $this->strings['plugin_needs_higher_version'] ), esc_html( $this->plugins[ $slug ]['name'] ) ), '</p>';
+					echo '<p>', sprintf( esc_html( $this->strings['plugin_needs_higher_version'] ), esc_html( $this->plugins[$slug]['name'] ) ), '</p>';
 				}
 			}
 
@@ -1198,7 +1198,7 @@ 
 						$rendered .= sprintf(
 							$line_template,
 							sprintf(
-								translate_nooped_plural( $this->strings[ $type ], $count, 'tgmpa' ),
+								translate_nooped_plural( $this->strings[$type], $count, 'tgmpa' ),
 								$imploded,
 								$count
 							)
@@ -1315,7 +1315,7 @@ 
 
 			foreach ( (array) $wp_settings_errors as $key => $details ) {
 				if ( 'tgmpa' === $details['setting'] ) {
-					unset( $wp_settings_errors[ $key ] );
+					unset( $wp_settings_errors[$key] );
 					break;
 				}
 			}
@@ -1351,20 +1351,20 @@ 
 				return;
 			}
 
-			if ( empty( $plugin['slug'] ) || ! is_string( $plugin['slug'] ) || isset( $this->plugins[ $plugin['slug'] ] ) ) {
+			if ( empty( $plugin['slug'] ) || ! is_string( $plugin['slug'] ) || isset( $this->plugins[$plugin['slug']] ) ) {
 				return;
 			}
 
 			$defaults = array(
-				'name'               => '',      // String
-				'slug'               => '',      // String
-				'source'             => 'repo',  // String
-				'required'           => false,   // Boolean
-				'version'            => '',      // String
-				'force_activation'   => false,   // Boolean
-				'force_deactivation' => false,   // Boolean
-				'external_url'       => '',      // String
-				'is_callable'        => '',      // String|Array.
+				'name'               => '', // String
+				'slug'               => '', // String
+				'source'             => 'repo', // String
+				'required'           => false, // Boolean
+				'version'            => '', // String
+				'force_activation'   => false, // Boolean
+				'force_deactivation' => false, // Boolean
+				'external_url'       => '', // String
+				'is_callable'        => '', // String|Array.
 			);
 
 			// Prepare the received data.
@@ -1385,8 +1385,8 @@ 
 			$plugin['source_type'] = $this->get_plugin_source_type( $plugin['source'] );
 
 			// Set the class properties.
-			$this->plugins[ $plugin['slug'] ]    = $plugin;
-			$this->sort_order[ $plugin['slug'] ] = $plugin['name'];
+			$this->plugins[$plugin['slug']]    = $plugin;
+			$this->sort_order[$plugin['slug']] = $plugin['name'];
 
 			// Should we add the force activation hook ?
 			if ( true === $plugin['force_activation'] ) {
@@ -1470,11 +1470,11 @@ 
 			);
 
 			foreach ( $keys as $key ) {
-				if ( isset( $config[ $key ] ) ) {
-					if ( is_array( $config[ $key ] ) ) {
-						$this->$key = array_merge( $this->$key, $config[ $key ] );
+				if ( isset( $config[$key] ) ) {
+					if ( is_array( $config[$key] ) ) {
+						$this->$key = array_merge( $this->$key, $config[$key] );
 					} else {
-						$this->$key = $config[ $key ];
+						$this->$key = $config[$key];
 					}
 				}
 			}
@@ -1519,12 +1519,12 @@ 
 		 *                            Parameter added in v2.5.0.
 		 */
 		public function populate_file_path( $plugin_slug = '' ) {
-			if ( ! empty( $plugin_slug ) && is_string( $plugin_slug ) && isset( $this->plugins[ $plugin_slug ] ) ) {
-				$this->plugins[ $plugin_slug ]['file_path'] = $this->_get_plugin_basename_from_slug( $plugin_slug );
+			if ( ! empty( $plugin_slug ) && is_string( $plugin_slug ) && isset( $this->plugins[$plugin_slug] ) ) {
+				$this->plugins[$plugin_slug]['file_path'] = $this->_get_plugin_basename_from_slug( $plugin_slug );
 			} else {
 				// Add file_path key for all plugins.
 				foreach ( $this->plugins as $slug => $values ) {
-					$this->plugins[ $slug ]['file_path'] = $this->_get_plugin_basename_from_slug( $slug );
+					$this->plugins[$slug]['file_path'] = $this->_get_plugin_basename_from_slug( $slug );
 				}
 			}
 		}
@@ -1564,8 +1564,8 @@ 
 		 */
 		public function _get_plugin_data_from_name( $name, $data = 'slug' ) {
 			foreach ( $this->plugins as $values ) {
-				if ( $name === $values['name'] && isset( $values[ $data ] ) ) {
-					return $values[ $data ];
+				if ( $name === $values['name'] && isset( $values[$data] ) ) {
+					return $values[$data];
 				}
 			}
 
@@ -1583,13 +1583,13 @@ 
 		public function get_download_url( $slug ) {
 			$dl_source = '';
 
-			switch ( $this->plugins[ $slug ]['source_type'] ) {
+			switch ( $this->plugins[$slug]['source_type'] ) {
 				case 'repo':
 					return $this->get_wp_repo_download_url( $slug );
 				case 'external':
-					return $this->plugins[ $slug ]['source'];
+					return $this->plugins[$slug]['source'];
 				case 'bundled':
-					return $this->default_path . $this->plugins[ $slug ]['source'];
+					return $this->default_path . $this->plugins[$slug]['source'];
 			}
 
 			return $dl_source; // Should never happen.
@@ -1625,7 +1625,7 @@ 
 		protected function get_plugins_api( $slug ) {
 			static $api = array(); // Cache received responses.
 
-			if ( ! isset( $api[ $slug ] ) ) {
+			if ( ! isset( $api[$slug] ) ) {
 				if ( ! function_exists( 'plugins_api' ) ) {
 					require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
 				}
@@ -1640,16 +1640,16 @@ 
 					)
 				);
 
-				$api[ $slug ] = false;
+				$api[$slug] = false;
 
 				if ( is_wp_error( $response ) ) {
 					wp_die( esc_html( $this->strings['oops'] ) );
 				} else {
-					$api[ $slug ] = $response;
+					$api[$slug] = $response;
 				}
 			}
 
-			return $api[ $slug ];
+			return $api[$slug];
 		}
 
 		/**
@@ -1662,13 +1662,13 @@ 
 		 *                or the plugin name if not.
 		 */
 		public function get_info_link( $slug ) {
-			if ( ! empty( $this->plugins[ $slug ]['external_url'] ) && preg_match( self::IS_URL_REGEX, $this->plugins[ $slug ]['external_url'] ) ) {
+			if ( ! empty( $this->plugins[$slug]['external_url'] ) && preg_match( self::IS_URL_REGEX, $this->plugins[$slug]['external_url'] ) ) {
 				$link = sprintf(
 					'<a href="%1$s" target="_blank">%2$s</a>',
-					esc_url( $this->plugins[ $slug ]['external_url'] ),
-					esc_html( $this->plugins[ $slug ]['name'] )
+					esc_url( $this->plugins[$slug]['external_url'] ),
+					esc_html( $this->plugins[$slug]['name'] )
 				);
-			} elseif ( 'repo' === $this->plugins[ $slug ]['source_type'] ) {
+			} elseif ( 'repo' === $this->plugins[$slug]['source_type'] ) {
 				$url = add_query_arg(
 					array(
 						'tab'       => 'plugin-information',
@@ -1683,10 +1683,10 @@ 
 				$link = sprintf(
 					'<a href="%1$s" class="thickbox">%2$s</a>',
 					esc_url( $url ),
-					esc_html( $this->plugins[ $slug ]['name'] )
+					esc_html( $this->plugins[$slug]['name'] )
 				);
 			} else {
-				$link = esc_html( $this->plugins[ $slug ]['name'] ); // No hyperlink.
+				$link = esc_html( $this->plugins[$slug]['name'] ); // No hyperlink.
 			}
 
 			return $link;
@@ -1811,7 +1811,7 @@ 
 		public function is_plugin_installed( $slug ) {
 			$installed_plugins = $this->get_plugins(); // Retrieve a list of all installed plugins (WP cached).
 
-			return ( ! empty( $installed_plugins[ $this->plugins[ $slug ]['file_path'] ] ) );
+			return ( ! empty( $installed_plugins[$this->plugins[$slug]['file_path']] ) );
 		}
 
 		/**
@@ -1823,7 +1823,7 @@ 
 		 * @return bool True if active, false otherwise.
 		 */
 		public function is_plugin_active( $slug ) {
-			return ( ( ! empty( $this->plugins[ $slug ]['is_callable'] ) && is_callable( $this->plugins[ $slug ]['is_callable'] ) ) || is_plugin_active( $this->plugins[ $slug ]['file_path'] ) );
+			return ( ( ! empty( $this->plugins[$slug]['is_callable'] ) && is_callable( $this->plugins[$slug]['is_callable'] ) ) || is_plugin_active( $this->plugins[$slug]['file_path'] ) );
 		}
 
 		/**
@@ -1837,7 +1837,7 @@ 
 		 */
 		public function can_plugin_update( $slug ) {
 			// We currently can't get reliable info on non-WP-repo plugins - issue #380.
-			if ( 'repo' !== $this->plugins[ $slug ]['source_type'] ) {
+			if ( 'repo' !== $this->plugins[$slug]['source_type'] ) {
 				return true;
 			}
 
@@ -1893,8 +1893,8 @@ 
 		public function get_installed_version( $slug ) {
 			$installed_plugins = $this->get_plugins(); // Retrieve a list of all installed plugins (WP cached).
 
-			if ( ! empty( $installed_plugins[ $this->plugins[ $slug ]['file_path'] ]['Version'] ) ) {
-				return $installed_plugins[ $this->plugins[ $slug ]['file_path'] ]['Version'];
+			if ( ! empty( $installed_plugins[$this->plugins[$slug]['file_path']]['Version'] ) ) {
+				return $installed_plugins[$this->plugins[$slug]['file_path']]['Version'];
 			}
 
 			return '';
@@ -1910,7 +1910,7 @@ 
 		 */
 		public function does_plugin_require_update( $slug ) {
 			$installed_version = $this->get_installed_version( $slug );
-			$minimum_version   = $this->plugins[ $slug ]['version'];
+			$minimum_version   = $this->plugins[$slug]['version'];
 
 			return version_compare( $minimum_version, $installed_version, '>' );
 		}
@@ -1925,9 +1925,9 @@ 
 		 */
 		public function does_plugin_have_update( $slug ) {
 			// Presume bundled and external plugins will point to a package which meets the minimum required version.
-			if ( 'repo' !== $this->plugins[ $slug ]['source_type'] ) {
+			if ( 'repo' !== $this->plugins[$slug]['source_type'] ) {
 				if ( $this->does_plugin_require_update( $slug ) ) {
-					return $this->plugins[ $slug ]['version'];
+					return $this->plugins[$slug]['version'];
 				}
 
 				return false;
@@ -1935,8 +1935,8 @@ 
 
 			$repo_updates = get_site_transient( 'update_plugins' );
 
-			if ( isset( $repo_updates->response[ $this->plugins[ $slug ]['file_path'] ]->new_version ) ) {
-				return $repo_updates->response[ $this->plugins[ $slug ]['file_path'] ]->new_version;
+			if ( isset( $repo_updates->response[$this->plugins[$slug]['file_path']]->new_version ) ) {
+				return $repo_updates->response[$this->plugins[$slug]['file_path']]->new_version;
 			}
 
 			return false;
@@ -1952,14 +1952,14 @@ 
 		 */
 		public function get_upgrade_notice( $slug ) {
 			// We currently can't get reliable info on non-WP-repo plugins - issue #380.
-			if ( 'repo' !== $this->plugins[ $slug ]['source_type'] ) {
+			if ( 'repo' !== $this->plugins[$slug]['source_type'] ) {
 				return '';
 			}
 
 			$repo_updates = get_site_transient( 'update_plugins' );
 
-			if ( ! empty( $repo_updates->response[ $this->plugins[ $slug ]['file_path'] ]->upgrade_notice ) ) {
-				return $repo_updates->response[ $this->plugins[ $slug ]['file_path'] ]->upgrade_notice;
+			if ( ! empty( $repo_updates->response[$this->plugins[$slug]['file_path']]->upgrade_notice ) ) {
+				return $repo_updates->response[$this->plugins[$slug]['file_path']]->upgrade_notice;
 			}
 
 			return '';
@@ -2043,7 +2043,7 @@ 
 				 */
 				if ( true === $plugin['force_deactivation'] && is_plugin_active( $plugin['file_path'] ) ) {
 					deactivate_plugins( $plugin['file_path'] );
-					$deactivated[ $plugin['file_path'] ] = time();
+					$deactivated[$plugin['file_path']] = time();
 				}
 			}