Completed
Pull Request — develop (#805)
by
unknown
01:50
created
example.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -121,16 +121,16 @@
 block discarded – undo
121 121
 	 * Only uncomment the strings in the config array if you want to customize the strings.
122 122
 	 */
123 123
 	$config = array(
124
-		'id'           => 'tgmpa',                 // Unique ID for hashing notices for multiple instances of TGMPA.
125
-		'default_path' => '',                      // Default absolute path to bundled plugins.
124
+		'id'           => 'tgmpa', // Unique ID for hashing notices for multiple instances of TGMPA.
125
+		'default_path' => '', // Default absolute path to bundled plugins.
126 126
 		'menu'         => 'tgmpa-install-plugins', // Menu slug.
127
-		'parent_slug'  => 'themes.php',            // Parent menu slug.
128
-		'capability'   => 'edit_theme_options',    // Capability needed to view plugin install page, should be a capability associated with the parent menu used.
129
-		'has_notices'  => true,                    // Show admin notices or not.
130
-		'dismissable'  => true,                    // If false, a user cannot dismiss the nag message.
131
-		'dismiss_msg'  => '',                      // If 'dismissable' is false, this message will be output at top of nag.
132
-		'is_automatic' => false,                   // Automatically activate plugins after installation or not.
133
-		'message'      => '',                      // Message to output right before the plugins table.
127
+		'parent_slug'  => 'themes.php', // Parent menu slug.
128
+		'capability'   => 'edit_theme_options', // Capability needed to view plugin install page, should be a capability associated with the parent menu used.
129
+		'has_notices'  => true, // Show admin notices or not.
130
+		'dismissable'  => true, // If false, a user cannot dismiss the nag message.
131
+		'dismiss_msg'  => '', // If 'dismissable' is false, this message will be output at top of nag.
132
+		'is_automatic' => false, // Automatically activate plugins after installation or not.
133
+		'message'      => '', // Message to output right before the plugins table.
134 134
 
135 135
 		/*
136 136
 		'strings'      => array(
Please login to merge, or discard this patch.
class-tgm-plugin-activation.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2226,7 +2226,7 @@
 block discarded – undo
2226 2226
 		 *
2227 2227
 		 * @since 2.5.0
2228 2228
 		 *
2229
-		 * @return array CSS classnames.
2229
+		 * @return string[] CSS classnames.
2230 2230
 		 */
2231 2231
 		public function get_table_classes() {
2232 2232
 			return array( 'widefat', 'fixed' );
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1768,10 +1768,12 @@
 block discarded – undo
1768 1768
 			if ( 'update-core' === $screen->base ) {
1769 1769
 				// Core update screen.
1770 1770
 				return true;
1771
-			} elseif ( 'plugins' === $screen->base && ! empty( $_POST['action'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1771
+			} elseif ( 'plugins' === $screen->base && ! empty( $_POST['action'] ) ) {
1772
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1772 1773
 				// Plugins bulk update screen.
1773 1774
 				return true;
1774
-			} elseif ( 'update' === $screen->base && ! empty( $_POST['action'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
1775
+			} elseif ( 'update' === $screen->base && ! empty( $_POST['action'] ) ) {
1776
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
1775 1777
 				// Individual updates (ajax call).
1776 1778
 				return true;
1777 1779
 			}
Please login to merge, or discard this patch.
Spacing   +120 added lines, -120 removed lines patch added patch discarded remove patch
@@ -708,11 +708,11 @@  discard block
 block discarded – undo
708 708
 			$args = apply_filters(
709 709
 				'tgmpa_admin_menu_args',
710 710
 				array(
711
-					'parent_slug' => $this->parent_slug,                     // Parent Menu slug.
712
-					'page_title'  => $this->strings['page_title'],           // Page title.
713
-					'menu_title'  => $this->strings['menu_title'],           // Menu title.
714
-					'capability'  => $this->capability,                      // Capability.
715
-					'menu_slug'   => $this->menu,                            // Menu slug.
711
+					'parent_slug' => $this->parent_slug, // Parent Menu slug.
712
+					'page_title'  => $this->strings['page_title'], // Page title.
713
+					'menu_title'  => $this->strings['menu_title'], // Menu title.
714
+					'capability'  => $this->capability, // Capability.
715
+					'menu_slug'   => $this->menu, // Menu slug.
716 716
 					'function'    => array( $this, 'install_plugins_page' ), // Callback.
717 717
 				)
718 718
 			);
@@ -755,7 +755,7 @@  discard block
 block discarded – undo
755 755
 		 */
756 756
 		public function install_plugins_page() {
757 757
 			// Store new instance of plugin table in object.
758
-			$plugin_table = new TGMPA_List_Table($this);
758
+			$plugin_table = new TGMPA_List_Table( $this );
759 759
 
760 760
 			// Return early if processing a plugin installation action.
761 761
 			if ( ( ( 'tgmpa-bulk-install' === $plugin_table->current_action() || 'tgmpa-bulk-update' === $plugin_table->current_action() ) && $plugin_table->process_bulk_actions() ) || $this->do_plugin_install() ) {
@@ -814,7 +814,7 @@  discard block
 block discarded – undo
814 814
 			// All plugin information will be stored in an array for processing.
815 815
 			$slug = $this->sanitize_key( urldecode( $_GET['plugin'] ) );
816 816
 
817
-			if ( ! isset( $this->plugins[ $slug ] ) ) {
817
+			if ( ! isset( $this->plugins[$slug] ) ) {
818 818
 				return false;
819 819
 			}
820 820
 
@@ -859,7 +859,7 @@  discard block
 block discarded – undo
859 859
 				$extra         = array();
860 860
 				$extra['slug'] = $slug; // Needed for potentially renaming of directory name.
861 861
 				$source        = $this->get_download_url( $slug );
862
-				$api           = ( 'repo' === $this->plugins[ $slug ]['source_type'] ) ? $this->get_plugins_api( $slug ) : null;
862
+				$api           = ( 'repo' === $this->plugins[$slug]['source_type'] ) ? $this->get_plugins_api( $slug ) : null;
863 863
 				$api           = ( false !== $api ) ? $api : null;
864 864
 
865 865
 				$url = add_query_arg(
@@ -876,8 +876,8 @@  discard block
 block discarded – undo
876 876
 
877 877
 				$title     = ( 'update' === $install_type ) ? $this->strings['updating'] : $this->strings['installing'];
878 878
 				$skin_args = array(
879
-					'type'   => ( 'bundled' !== $this->plugins[ $slug ]['source_type'] ) ? 'web' : 'upload',
880
-					'title'  => sprintf( $title, $this->plugins[ $slug ]['name'] ),
879
+					'type'   => ( 'bundled' !== $this->plugins[$slug]['source_type'] ) ? 'web' : 'upload',
880
+					'title'  => sprintf( $title, $this->plugins[$slug]['name'] ),
881 881
 					'url'    => esc_url_raw( $url ),
882 882
 					'nonce'  => $install_type . '-plugin_' . $slug,
883 883
 					'plugin' => '',
@@ -887,7 +887,7 @@  discard block
 block discarded – undo
887 887
 				unset( $title );
888 888
 
889 889
 				if ( 'update' === $install_type ) {
890
-					$skin_args['plugin'] = $this->plugins[ $slug ]['file_path'];
890
+					$skin_args['plugin'] = $this->plugins[$slug]['file_path'];
891 891
 					$skin                = new Plugin_Upgrader_Skin( $skin_args );
892 892
 				} else {
893 893
 					$skin = new Plugin_Installer_Skin( $skin_args );
@@ -902,12 +902,12 @@  discard block
 block discarded – undo
902 902
 				if ( 'update' === $install_type ) {
903 903
 					// Inject our info into the update transient.
904 904
 					$to_inject                    = array(
905
-						$slug => $this->plugins[ $slug ],
905
+						$slug => $this->plugins[$slug],
906 906
 					);
907
-					$to_inject[ $slug ]['source'] = $source;
907
+					$to_inject[$slug]['source'] = $source;
908 908
 					$this->inject_update_info( $to_inject );
909 909
 
910
-					$upgrader->upgrade( $this->plugins[ $slug ]['file_path'] );
910
+					$upgrader->upgrade( $this->plugins[$slug]['file_path'] );
911 911
 				} else {
912 912
 					$upgrader->install( $source );
913 913
 				}
@@ -937,11 +937,11 @@  discard block
 block discarded – undo
937 937
 				}
938 938
 
939 939
 				return true;
940
-			} elseif ( isset( $this->plugins[ $slug ]['file_path'], $_GET['tgmpa-activate'] ) && 'activate-plugin' === $_GET['tgmpa-activate'] ) {
940
+			} elseif ( isset( $this->plugins[$slug]['file_path'], $_GET['tgmpa-activate'] ) && 'activate-plugin' === $_GET['tgmpa-activate'] ) {
941 941
 				// Activate action link was clicked.
942 942
 				check_admin_referer( 'tgmpa-activate', 'tgmpa-nonce' );
943 943
 
944
-				if ( false === $this->activate_single_plugin( $this->plugins[ $slug ]['file_path'], $slug ) ) {
944
+				if ( false === $this->activate_single_plugin( $this->plugins[$slug]['file_path'], $slug ) ) {
945 945
 					return true; // Finish execution of the function early as we encountered an error.
946 946
 				}
947 947
 			}
@@ -966,17 +966,17 @@  discard block
 block discarded – undo
966 966
 			foreach ( $plugins as $slug => $plugin ) {
967 967
 				$file_path = $plugin['file_path'];
968 968
 
969
-				if ( empty( $repo_updates->response[ $file_path ] ) ) {
970
-					$repo_updates->response[ $file_path ] = new stdClass();
969
+				if ( empty( $repo_updates->response[$file_path] ) ) {
970
+					$repo_updates->response[$file_path] = new stdClass();
971 971
 				}
972 972
 
973 973
 				// We only really need to set package, but let's do all we can in case WP changes something.
974
-				$repo_updates->response[ $file_path ]->slug        = $slug;
975
-				$repo_updates->response[ $file_path ]->plugin      = $file_path;
976
-				$repo_updates->response[ $file_path ]->new_version = $plugin['version'];
977
-				$repo_updates->response[ $file_path ]->package     = $plugin['source'];
978
-				if ( empty( $repo_updates->response[ $file_path ]->url ) && ! empty( $plugin['external_url'] ) ) {
979
-					$repo_updates->response[ $file_path ]->url = $plugin['external_url'];
974
+				$repo_updates->response[$file_path]->slug        = $slug;
975
+				$repo_updates->response[$file_path]->plugin      = $file_path;
976
+				$repo_updates->response[$file_path]->new_version = $plugin['version'];
977
+				$repo_updates->response[$file_path]->package     = $plugin['source'];
978
+				if ( empty( $repo_updates->response[$file_path]->url ) && ! empty( $plugin['external_url'] ) ) {
979
+					$repo_updates->response[$file_path]->url = $plugin['external_url'];
980 980
 				}
981 981
 			}
982 982
 
@@ -1019,7 +1019,7 @@  discard block
 block discarded – undo
1019 1019
 			} else {
1020 1020
 				// Bulk installer contains less info, so fall back on the info registered here.
1021 1021
 				foreach ( $this->plugins as $slug => $plugin ) {
1022
-					if ( ! empty( $upgrader->skin->plugin_names[ $upgrader->skin->i ] ) && $plugin['name'] === $upgrader->skin->plugin_names[ $upgrader->skin->i ] ) {
1022
+					if ( ! empty( $upgrader->skin->plugin_names[$upgrader->skin->i] ) && $plugin['name'] === $upgrader->skin->plugin_names[$upgrader->skin->i] ) {
1023 1023
 						$desired_slug = $slug;
1024 1024
 						break;
1025 1025
 					}
@@ -1087,7 +1087,7 @@  discard block
 block discarded – undo
1087 1087
 						// immediately after a single activation.
1088 1088
 						// phpcs:ignore WordPress.Security.NonceVerification.Missing -- Not using the superglobal.
1089 1089
 						if ( ! isset( $_POST['action'] ) ) {
1090
-							echo '<div id="message" class="updated"><p>', esc_html( $this->strings['activated_successfully'] ), ' <strong>', esc_html( $this->plugins[ $slug ]['name'] ), '.</strong></p></div>';
1090
+							echo '<div id="message" class="updated"><p>', esc_html( $this->strings['activated_successfully'] ), ' <strong>', esc_html( $this->plugins[$slug]['name'] ), '.</strong></p></div>';
1091 1091
 						}
1092 1092
 					} else {
1093 1093
 						// Simpler message layout for use on the plugin install page.
@@ -1100,7 +1100,7 @@  discard block
 block discarded – undo
1100 1100
 				echo '<div id="message" class="error"><p>',
1101 1101
 					sprintf(
1102 1102
 						esc_html( $this->strings['plugin_already_active'] ),
1103
-						'<strong>' . esc_html( $this->plugins[ $slug ]['name'] ) . '</strong>'
1103
+						'<strong>' . esc_html( $this->plugins[$slug]['name'] ) . '</strong>'
1104 1104
 					),
1105 1105
 					'</p></div>';
1106 1106
 			} elseif ( $this->does_plugin_require_update( $slug ) ) {
@@ -1112,13 +1112,13 @@  discard block
 block discarded – undo
1112 1112
 						echo '<div id="message" class="error"><p>',
1113 1113
 							sprintf(
1114 1114
 								esc_html( $this->strings['plugin_needs_higher_version'] ),
1115
-								'<strong>' . esc_html( $this->plugins[ $slug ]['name'] ) . '</strong>'
1115
+								'<strong>' . esc_html( $this->plugins[$slug]['name'] ) . '</strong>'
1116 1116
 							),
1117 1117
 							'</p></div>';
1118 1118
 					}
1119 1119
 				} else {
1120 1120
 					// Simpler message layout for use on the plugin install page.
1121
-					echo '<p>', sprintf( esc_html( $this->strings['plugin_needs_higher_version'] ), esc_html( $this->plugins[ $slug ]['name'] ) ), '</p>';
1121
+					echo '<p>', sprintf( esc_html( $this->strings['plugin_needs_higher_version'] ), esc_html( $this->plugins[$slug]['name'] ) ), '</p>';
1122 1122
 				}
1123 1123
 			}
1124 1124
 
@@ -1245,7 +1245,7 @@  discard block
 block discarded – undo
1245 1245
 						$rendered .= sprintf(
1246 1246
 							$line_template,
1247 1247
 							sprintf(
1248
-								translate_nooped_plural( $this->strings[ $type ], $count, 'tgmpa' ),
1248
+								translate_nooped_plural( $this->strings[$type], $count, 'tgmpa' ),
1249 1249
 								$imploded,
1250 1250
 								$count
1251 1251
 							)
@@ -1362,7 +1362,7 @@  discard block
 block discarded – undo
1362 1362
 
1363 1363
 			foreach ( (array) $wp_settings_errors as $key => $details ) {
1364 1364
 				if ( 'tgmpa' === $details['setting'] ) {
1365
-					unset( $wp_settings_errors[ $key ] );
1365
+					unset( $wp_settings_errors[$key] );
1366 1366
 					break;
1367 1367
 				}
1368 1368
 			}
@@ -1398,20 +1398,20 @@  discard block
 block discarded – undo
1398 1398
 				return;
1399 1399
 			}
1400 1400
 
1401
-			if ( empty( $plugin['slug'] ) || ! is_string( $plugin['slug'] ) || isset( $this->plugins[ $plugin['slug'] ] ) ) {
1401
+			if ( empty( $plugin['slug'] ) || ! is_string( $plugin['slug'] ) || isset( $this->plugins[$plugin['slug']] ) ) {
1402 1402
 				return;
1403 1403
 			}
1404 1404
 
1405 1405
 			$defaults = array(
1406
-				'name'               => '',      // String.
1407
-				'slug'               => '',      // String.
1408
-				'source'             => 'repo',  // String.
1409
-				'required'           => false,   // Boolean.
1410
-				'version'            => '',      // String.
1411
-				'force_activation'   => false,   // Boolean.
1412
-				'force_deactivation' => false,   // Boolean.
1413
-				'external_url'       => '',      // String.
1414
-				'is_callable'        => '',      // String or array.
1406
+				'name'               => '', // String.
1407
+				'slug'               => '', // String.
1408
+				'source'             => 'repo', // String.
1409
+				'required'           => false, // Boolean.
1410
+				'version'            => '', // String.
1411
+				'force_activation'   => false, // Boolean.
1412
+				'force_deactivation' => false, // Boolean.
1413
+				'external_url'       => '', // String.
1414
+				'is_callable'        => '', // String or array.
1415 1415
 			);
1416 1416
 
1417 1417
 			// Prepare the received data.
@@ -1432,8 +1432,8 @@  discard block
 block discarded – undo
1432 1432
 			$plugin['source_type'] = $this->get_plugin_source_type( $plugin['source'] );
1433 1433
 
1434 1434
 			// Set the class properties.
1435
-			$this->plugins[ $plugin['slug'] ]    = $plugin;
1436
-			$this->sort_order[ $plugin['slug'] ] = $plugin['name'];
1435
+			$this->plugins[$plugin['slug']]    = $plugin;
1436
+			$this->sort_order[$plugin['slug']] = $plugin['name'];
1437 1437
 
1438 1438
 			// Should we add the force activation hook ?
1439 1439
 			if ( true === $plugin['force_activation'] ) {
@@ -1517,11 +1517,11 @@  discard block
 block discarded – undo
1517 1517
 			);
1518 1518
 
1519 1519
 			foreach ( $keys as $key ) {
1520
-				if ( isset( $config[ $key ] ) ) {
1521
-					if ( is_array( $config[ $key ] ) ) {
1522
-						$this->$key = array_merge( $this->$key, $config[ $key ] );
1520
+				if ( isset( $config[$key] ) ) {
1521
+					if ( is_array( $config[$key] ) ) {
1522
+						$this->$key = array_merge( $this->$key, $config[$key] );
1523 1523
 					} else {
1524
-						$this->$key = $config[ $key ];
1524
+						$this->$key = $config[$key];
1525 1525
 					}
1526 1526
 				}
1527 1527
 			}
@@ -1566,12 +1566,12 @@  discard block
 block discarded – undo
1566 1566
 		 *                            Parameter added in v2.5.0.
1567 1567
 		 */
1568 1568
 		public function populate_file_path( $plugin_slug = '' ) {
1569
-			if ( ! empty( $plugin_slug ) && is_string( $plugin_slug ) && isset( $this->plugins[ $plugin_slug ] ) ) {
1570
-				$this->plugins[ $plugin_slug ]['file_path'] = $this->_get_plugin_basename_from_slug( $plugin_slug );
1569
+			if ( ! empty( $plugin_slug ) && is_string( $plugin_slug ) && isset( $this->plugins[$plugin_slug] ) ) {
1570
+				$this->plugins[$plugin_slug]['file_path'] = $this->_get_plugin_basename_from_slug( $plugin_slug );
1571 1571
 			} else {
1572 1572
 				// Add file_path key for all plugins.
1573 1573
 				foreach ( $this->plugins as $slug => $values ) {
1574
-					$this->plugins[ $slug ]['file_path'] = $this->_get_plugin_basename_from_slug( $slug );
1574
+					$this->plugins[$slug]['file_path'] = $this->_get_plugin_basename_from_slug( $slug );
1575 1575
 				}
1576 1576
 			}
1577 1577
 		}
@@ -1611,8 +1611,8 @@  discard block
 block discarded – undo
1611 1611
 		 */
1612 1612
 		public function _get_plugin_data_from_name( $name, $data = 'slug' ) {
1613 1613
 			foreach ( $this->plugins as $values ) {
1614
-				if ( $name === $values['name'] && isset( $values[ $data ] ) ) {
1615
-					return $values[ $data ];
1614
+				if ( $name === $values['name'] && isset( $values[$data] ) ) {
1615
+					return $values[$data];
1616 1616
 				}
1617 1617
 			}
1618 1618
 
@@ -1630,13 +1630,13 @@  discard block
 block discarded – undo
1630 1630
 		public function get_download_url( $slug ) {
1631 1631
 			$dl_source = '';
1632 1632
 
1633
-			switch ( $this->plugins[ $slug ]['source_type'] ) {
1633
+			switch ( $this->plugins[$slug]['source_type'] ) {
1634 1634
 				case 'repo':
1635 1635
 					return $this->get_wp_repo_download_url( $slug );
1636 1636
 				case 'external':
1637
-					return $this->plugins[ $slug ]['source'];
1637
+					return $this->plugins[$slug]['source'];
1638 1638
 				case 'bundled':
1639
-					return $this->default_path . $this->plugins[ $slug ]['source'];
1639
+					return $this->default_path . $this->plugins[$slug]['source'];
1640 1640
 			}
1641 1641
 
1642 1642
 			return $dl_source; // Should never happen.
@@ -1672,7 +1672,7 @@  discard block
 block discarded – undo
1672 1672
 		protected function get_plugins_api( $slug ) {
1673 1673
 			static $api = array(); // Cache received responses.
1674 1674
 
1675
-			if ( ! isset( $api[ $slug ] ) ) {
1675
+			if ( ! isset( $api[$slug] ) ) {
1676 1676
 				if ( ! function_exists( 'plugins_api' ) ) {
1677 1677
 					require_once ABSPATH . 'wp-admin/includes/plugin-install.php';
1678 1678
 				}
@@ -1687,16 +1687,16 @@  discard block
 block discarded – undo
1687 1687
 					)
1688 1688
 				);
1689 1689
 
1690
-				$api[ $slug ] = false;
1690
+				$api[$slug] = false;
1691 1691
 
1692 1692
 				if ( is_wp_error( $response ) ) {
1693 1693
 					wp_die( esc_html( $this->strings['oops'] ) );
1694 1694
 				} else {
1695
-					$api[ $slug ] = $response;
1695
+					$api[$slug] = $response;
1696 1696
 				}
1697 1697
 			}
1698 1698
 
1699
-			return $api[ $slug ];
1699
+			return $api[$slug];
1700 1700
 		}
1701 1701
 
1702 1702
 		/**
@@ -1709,13 +1709,13 @@  discard block
 block discarded – undo
1709 1709
 		 *                or the plugin name if not.
1710 1710
 		 */
1711 1711
 		public function get_info_link( $slug ) {
1712
-			if ( ! empty( $this->plugins[ $slug ]['external_url'] ) && preg_match( self::IS_URL_REGEX, $this->plugins[ $slug ]['external_url'] ) ) {
1712
+			if ( ! empty( $this->plugins[$slug]['external_url'] ) && preg_match( self::IS_URL_REGEX, $this->plugins[$slug]['external_url'] ) ) {
1713 1713
 				$link = sprintf(
1714 1714
 					'<a href="%1$s" target="_blank">%2$s</a>',
1715
-					esc_url( $this->plugins[ $slug ]['external_url'] ),
1716
-					esc_html( $this->plugins[ $slug ]['name'] )
1715
+					esc_url( $this->plugins[$slug]['external_url'] ),
1716
+					esc_html( $this->plugins[$slug]['name'] )
1717 1717
 				);
1718
-			} elseif ( 'repo' === $this->plugins[ $slug ]['source_type'] ) {
1718
+			} elseif ( 'repo' === $this->plugins[$slug]['source_type'] ) {
1719 1719
 				$url = add_query_arg(
1720 1720
 					array(
1721 1721
 						'tab'       => 'plugin-information',
@@ -1730,10 +1730,10 @@  discard block
 block discarded – undo
1730 1730
 				$link = sprintf(
1731 1731
 					'<a href="%1$s" class="thickbox">%2$s</a>',
1732 1732
 					esc_url( $url ),
1733
-					esc_html( $this->plugins[ $slug ]['name'] )
1733
+					esc_html( $this->plugins[$slug]['name'] )
1734 1734
 				);
1735 1735
 			} else {
1736
-				$link = esc_html( $this->plugins[ $slug ]['name'] ); // No hyperlink.
1736
+				$link = esc_html( $this->plugins[$slug]['name'] ); // No hyperlink.
1737 1737
 			}
1738 1738
 
1739 1739
 			return $link;
@@ -1858,7 +1858,7 @@  discard block
 block discarded – undo
1858 1858
 		public function is_plugin_installed( $slug ) {
1859 1859
 			$installed_plugins = $this->get_plugins(); // Retrieve a list of all installed plugins (WP cached).
1860 1860
 
1861
-			return ( ! empty( $installed_plugins[ $this->plugins[ $slug ]['file_path'] ] ) );
1861
+			return ( ! empty( $installed_plugins[$this->plugins[$slug]['file_path']] ) );
1862 1862
 		}
1863 1863
 
1864 1864
 		/**
@@ -1870,7 +1870,7 @@  discard block
 block discarded – undo
1870 1870
 		 * @return bool True if active, false otherwise.
1871 1871
 		 */
1872 1872
 		public function is_plugin_active( $slug ) {
1873
-			return ( ( ! empty( $this->plugins[ $slug ]['is_callable'] ) && is_callable( $this->plugins[ $slug ]['is_callable'] ) ) || is_plugin_active( $this->plugins[ $slug ]['file_path'] ) );
1873
+			return ( ( ! empty( $this->plugins[$slug]['is_callable'] ) && is_callable( $this->plugins[$slug]['is_callable'] ) ) || is_plugin_active( $this->plugins[$slug]['file_path'] ) );
1874 1874
 		}
1875 1875
 
1876 1876
 		/**
@@ -1884,7 +1884,7 @@  discard block
 block discarded – undo
1884 1884
 		 */
1885 1885
 		public function can_plugin_update( $slug ) {
1886 1886
 			// We currently can't get reliable info on non-WP-repo plugins - issue #380.
1887
-			if ( 'repo' !== $this->plugins[ $slug ]['source_type'] ) {
1887
+			if ( 'repo' !== $this->plugins[$slug]['source_type'] ) {
1888 1888
 				return true;
1889 1889
 			}
1890 1890
 
@@ -1940,8 +1940,8 @@  discard block
 block discarded – undo
1940 1940
 		public function get_installed_version( $slug ) {
1941 1941
 			$installed_plugins = $this->get_plugins(); // Retrieve a list of all installed plugins (WP cached).
1942 1942
 
1943
-			if ( ! empty( $installed_plugins[ $this->plugins[ $slug ]['file_path'] ]['Version'] ) ) {
1944
-				return $installed_plugins[ $this->plugins[ $slug ]['file_path'] ]['Version'];
1943
+			if ( ! empty( $installed_plugins[$this->plugins[$slug]['file_path']]['Version'] ) ) {
1944
+				return $installed_plugins[$this->plugins[$slug]['file_path']]['Version'];
1945 1945
 			}
1946 1946
 
1947 1947
 			return '';
@@ -1957,7 +1957,7 @@  discard block
 block discarded – undo
1957 1957
 		 */
1958 1958
 		public function does_plugin_require_update( $slug ) {
1959 1959
 			$installed_version = $this->get_installed_version( $slug );
1960
-			$minimum_version   = $this->plugins[ $slug ]['version'];
1960
+			$minimum_version   = $this->plugins[$slug]['version'];
1961 1961
 
1962 1962
 			return version_compare( $minimum_version, $installed_version, '>' );
1963 1963
 		}
@@ -1972,9 +1972,9 @@  discard block
 block discarded – undo
1972 1972
 		 */
1973 1973
 		public function does_plugin_have_update( $slug ) {
1974 1974
 			// Presume bundled and external plugins will point to a package which meets the minimum required version.
1975
-			if ( 'repo' !== $this->plugins[ $slug ]['source_type'] ) {
1975
+			if ( 'repo' !== $this->plugins[$slug]['source_type'] ) {
1976 1976
 				if ( $this->does_plugin_require_update( $slug ) ) {
1977
-					return $this->plugins[ $slug ]['version'];
1977
+					return $this->plugins[$slug]['version'];
1978 1978
 				}
1979 1979
 
1980 1980
 				return false;
@@ -1982,8 +1982,8 @@  discard block
 block discarded – undo
1982 1982
 
1983 1983
 			$repo_updates = get_site_transient( 'update_plugins' );
1984 1984
 
1985
-			if ( isset( $repo_updates->response[ $this->plugins[ $slug ]['file_path'] ]->new_version ) ) {
1986
-				return $repo_updates->response[ $this->plugins[ $slug ]['file_path'] ]->new_version;
1985
+			if ( isset( $repo_updates->response[$this->plugins[$slug]['file_path']]->new_version ) ) {
1986
+				return $repo_updates->response[$this->plugins[$slug]['file_path']]->new_version;
1987 1987
 			}
1988 1988
 
1989 1989
 			return false;
@@ -1999,14 +1999,14 @@  discard block
 block discarded – undo
1999 1999
 		 */
2000 2000
 		public function get_upgrade_notice( $slug ) {
2001 2001
 			// We currently can't get reliable info on non-WP-repo plugins - issue #380.
2002
-			if ( 'repo' !== $this->plugins[ $slug ]['source_type'] ) {
2002
+			if ( 'repo' !== $this->plugins[$slug]['source_type'] ) {
2003 2003
 				return '';
2004 2004
 			}
2005 2005
 
2006 2006
 			$repo_updates = get_site_transient( 'update_plugins' );
2007 2007
 
2008
-			if ( ! empty( $repo_updates->response[ $this->plugins[ $slug ]['file_path'] ]->upgrade_notice ) ) {
2009
-				return $repo_updates->response[ $this->plugins[ $slug ]['file_path'] ]->upgrade_notice;
2008
+			if ( ! empty( $repo_updates->response[$this->plugins[$slug]['file_path']]->upgrade_notice ) ) {
2009
+				return $repo_updates->response[$this->plugins[$slug]['file_path']]->upgrade_notice;
2010 2010
 			}
2011 2011
 
2012 2012
 			return '';
@@ -2090,7 +2090,7 @@  discard block
 block discarded – undo
2090 2090
 				 */
2091 2091
 				if ( true === $plugin['force_deactivation'] && is_plugin_active( $plugin['file_path'] ) ) {
2092 2092
 					deactivate_plugins( $plugin['file_path'] );
2093
-					$deactivated[ $plugin['file_path'] ] = time();
2093
+					$deactivated[$plugin['file_path']] = time();
2094 2094
 				}
2095 2095
 			}
2096 2096
 
@@ -2275,7 +2275,7 @@  discard block
 block discarded – undo
2275 2275
 		 *
2276 2276
 		 * @since 2.2.0
2277 2277
 		 */
2278
-		public function __construct($tgmpa) {
2278
+		public function __construct( $tgmpa ) {
2279 2279
 			$this->tgmpa = $tgmpa;
2280 2280
 
2281 2281
 			parent::__construct(
@@ -2329,30 +2329,30 @@  discard block
 block discarded – undo
2329 2329
 			$i          = 0;
2330 2330
 
2331 2331
 			// Redirect to the 'all' view if no plugins were found for the selected view context.
2332
-			if ( empty( $plugins[ $this->view_context ] ) ) {
2332
+			if ( empty( $plugins[$this->view_context] ) ) {
2333 2333
 				$this->view_context = 'all';
2334 2334
 			}
2335 2335
 
2336
-			foreach ( $plugins[ $this->view_context ] as $slug => $plugin ) {
2337
-				$table_data[ $i ]['sanitized_plugin']  = $plugin['name'];
2338
-				$table_data[ $i ]['slug']              = $slug;
2339
-				$table_data[ $i ]['plugin']            = '<strong>' . $this->tgmpa->get_info_link( $slug ) . '</strong>';
2340
-				$table_data[ $i ]['source']            = $this->get_plugin_source_type_text( $plugin['source_type'] );
2341
-				$table_data[ $i ]['type']              = $this->get_plugin_advise_type_text( $plugin['required'] );
2342
-				$table_data[ $i ]['status']            = $this->get_plugin_status_text( $slug );
2343
-				$table_data[ $i ]['installed_version'] = $this->tgmpa->get_installed_version( $slug );
2344
-				$table_data[ $i ]['minimum_version']   = $plugin['version'];
2345
-				$table_data[ $i ]['available_version'] = $this->tgmpa->does_plugin_have_update( $slug );
2336
+			foreach ( $plugins[$this->view_context] as $slug => $plugin ) {
2337
+				$table_data[$i]['sanitized_plugin']  = $plugin['name'];
2338
+				$table_data[$i]['slug']              = $slug;
2339
+				$table_data[$i]['plugin']            = '<strong>' . $this->tgmpa->get_info_link( $slug ) . '</strong>';
2340
+				$table_data[$i]['source']            = $this->get_plugin_source_type_text( $plugin['source_type'] );
2341
+				$table_data[$i]['type']              = $this->get_plugin_advise_type_text( $plugin['required'] );
2342
+				$table_data[$i]['status']            = $this->get_plugin_status_text( $slug );
2343
+				$table_data[$i]['installed_version'] = $this->tgmpa->get_installed_version( $slug );
2344
+				$table_data[$i]['minimum_version']   = $plugin['version'];
2345
+				$table_data[$i]['available_version'] = $this->tgmpa->does_plugin_have_update( $slug );
2346 2346
 
2347 2347
 				// Prep the upgrade notice info.
2348 2348
 				$upgrade_notice = $this->tgmpa->get_upgrade_notice( $slug );
2349 2349
 				if ( ! empty( $upgrade_notice ) ) {
2350
-					$table_data[ $i ]['upgrade_notice'] = $upgrade_notice;
2350
+					$table_data[$i]['upgrade_notice'] = $upgrade_notice;
2351 2351
 
2352 2352
 					add_action( "tgmpa_after_plugin_row_{$slug}", array( $this, 'wp_plugin_update_row' ), 10, 2 );
2353 2353
 				}
2354 2354
 
2355
-				$table_data[ $i ] = apply_filters( 'tgmpa_table_data_item', $table_data[ $i ], $plugin );
2355
+				$table_data[$i] = apply_filters( 'tgmpa_table_data_item', $table_data[$i], $plugin );
2356 2356
 
2357 2357
 				$i++;
2358 2358
 			}
@@ -2378,17 +2378,17 @@  discard block
 block discarded – undo
2378 2378
 					// No need to display plugins if they are installed, up-to-date and active.
2379 2379
 					continue;
2380 2380
 				} else {
2381
-					$plugins['all'][ $slug ] = $plugin;
2381
+					$plugins['all'][$slug] = $plugin;
2382 2382
 
2383 2383
 					if ( ! $this->tgmpa->is_plugin_installed( $slug ) ) {
2384
-						$plugins['install'][ $slug ] = $plugin;
2384
+						$plugins['install'][$slug] = $plugin;
2385 2385
 					} else {
2386 2386
 						if ( false !== $this->tgmpa->does_plugin_have_update( $slug ) ) {
2387
-							$plugins['update'][ $slug ] = $plugin;
2387
+							$plugins['update'][$slug] = $plugin;
2388 2388
 						}
2389 2389
 
2390 2390
 						if ( $this->tgmpa->can_plugin_activate( $slug ) ) {
2391
-							$plugins['activate'][ $slug ] = $plugin;
2391
+							$plugins['activate'][$slug] = $plugin;
2392 2392
 						}
2393 2393
 					}
2394 2394
 				}
@@ -2406,7 +2406,7 @@  discard block
 block discarded – undo
2406 2406
 		 */
2407 2407
 		protected function set_view_totals( $plugins ) {
2408 2408
 			foreach ( $plugins as $type => $list ) {
2409
-				$this->view_totals[ $type ] = count( $list );
2409
+				$this->view_totals[$type] = count( $list );
2410 2410
 			}
2411 2411
 		}
2412 2412
 
@@ -2508,8 +2508,8 @@  discard block
 block discarded – undo
2508 2508
 			$name = array();
2509 2509
 
2510 2510
 			foreach ( $items as $i => $plugin ) {
2511
-				$type[ $i ] = $plugin['type']; // Required / recommended.
2512
-				$name[ $i ] = $plugin['sanitized_plugin'];
2511
+				$type[$i] = $plugin['type']; // Required / recommended.
2512
+				$name[$i] = $plugin['sanitized_plugin'];
2513 2513
 			}
2514 2514
 
2515 2515
 			array_multisort( $type, SORT_DESC, $name, SORT_ASC, $items );
@@ -2556,7 +2556,7 @@  discard block
 block discarded – undo
2556 2556
 
2557 2557
 				if ( ! empty( $text ) ) {
2558 2558
 
2559
-					$status_links[ $type ] = sprintf(
2559
+					$status_links[$type] = sprintf(
2560 2560
 						'<a href="%s"%s>%s</a>',
2561 2561
 						esc_url( $this->tgmpa->get_tgmpa_status_url( $type ) ),
2562 2562
 						( $type === $this->view_context ) ? ' class="current"' : '',
@@ -2579,7 +2579,7 @@  discard block
 block discarded – undo
2579 2579
 		 * @return string
2580 2580
 		 */
2581 2581
 		public function column_default( $item, $column_name ) {
2582
-			return $item[ $column_name ];
2582
+			return $item[$column_name];
2583 2583
 		}
2584 2584
 
2585 2585
 		/**
@@ -2779,7 +2779,7 @@  discard block
 block discarded – undo
2779 2779
 					'tgmpa-nonce'
2780 2780
 				);
2781 2781
 
2782
-				$action_links[ $action ] = sprintf(
2782
+				$action_links[$action] = sprintf(
2783 2783
 					'<a href="%1$s">' . esc_html( $text ) . '</a>', // $text contains the second placeholder.
2784 2784
 					esc_url( $nonce_url ),
2785 2785
 					'<span class="screen-reader-text">' . esc_html( $item['sanitized_plugin'] ) . '</span>'
@@ -2930,19 +2930,19 @@  discard block
 block discarded – undo
2930 2930
 				// Validate the received input.
2931 2931
 				foreach ( $plugins_to_install as $key => $slug ) {
2932 2932
 					// Check if the plugin was registered with TGMPA and remove if not.
2933
-					if ( ! isset( $this->tgmpa->plugins[ $slug ] ) ) {
2934
-						unset( $plugins_to_install[ $key ] );
2933
+					if ( ! isset( $this->tgmpa->plugins[$slug] ) ) {
2934
+						unset( $plugins_to_install[$key] );
2935 2935
 						continue;
2936 2936
 					}
2937 2937
 
2938 2938
 					// For install: make sure this is a plugin we *can* install and not one already installed.
2939 2939
 					if ( 'install' === $install_type && true === $this->tgmpa->is_plugin_installed( $slug ) ) {
2940
-						unset( $plugins_to_install[ $key ] );
2940
+						unset( $plugins_to_install[$key] );
2941 2941
 					}
2942 2942
 
2943 2943
 					// For updates: make sure this is a plugin we *can* update (update available and WP version ok).
2944 2944
 					if ( 'update' === $install_type && false === $this->tgmpa->is_plugin_updatetable( $slug ) ) {
2945
-						unset( $plugins_to_install[ $key ] );
2945
+						unset( $plugins_to_install[$key] );
2946 2946
 					}
2947 2947
 				}
2948 2948
 
@@ -2994,7 +2994,7 @@  discard block
 block discarded – undo
2994 2994
 
2995 2995
 				// Prepare the data for validated plugins for the install/upgrade.
2996 2996
 				foreach ( $plugins_to_install as $slug ) {
2997
-					$name   = $this->tgmpa->plugins[ $slug ]['name'];
2997
+					$name   = $this->tgmpa->plugins[$slug]['name'];
2998 2998
 					$source = $this->tgmpa->get_download_url( $slug );
2999 2999
 
3000 3000
 					if ( ! empty( $name ) && ! empty( $source ) ) {
@@ -3007,9 +3007,9 @@  discard block
 block discarded – undo
3007 3007
 								break;
3008 3008
 
3009 3009
 							case 'update':
3010
-								$file_paths[]                 = $this->tgmpa->plugins[ $slug ]['file_path'];
3011
-								$to_inject[ $slug ]           = $this->tgmpa->plugins[ $slug ];
3012
-								$to_inject[ $slug ]['source'] = $source;
3010
+								$file_paths[]                 = $this->tgmpa->plugins[$slug]['file_path'];
3011
+								$to_inject[$slug]           = $this->tgmpa->plugins[$slug];
3012
+								$to_inject[$slug]['source'] = $source;
3013 3013
 								break;
3014 3014
 						}
3015 3015
 					}
@@ -3077,8 +3077,8 @@  discard block
 block discarded – undo
3077 3077
 				// Grab the file paths for the selected & inactive plugins from the registration array.
3078 3078
 				foreach ( $plugins as $slug ) {
3079 3079
 					if ( $this->tgmpa->can_plugin_activate( $slug ) ) {
3080
-						$plugins_to_activate[] = $this->tgmpa->plugins[ $slug ]['file_path'];
3081
-						$plugin_names[]        = $this->tgmpa->plugins[ $slug ]['name'];
3080
+						$plugins_to_activate[] = $this->tgmpa->plugins[$slug]['file_path'];
3081
+						$plugin_names[]        = $this->tgmpa->plugins[$slug]['name'];
3082 3082
 					}
3083 3083
 				}
3084 3084
 				unset( $slug );
@@ -3111,8 +3111,8 @@  discard block
 block discarded – undo
3111 3111
 					// Update recently activated plugins option.
3112 3112
 					$recent = (array) get_option( 'recently_activated' );
3113 3113
 					foreach ( $plugins_to_activate as $plugin => $time ) {
3114
-						if ( isset( $recent[ $plugin ] ) ) {
3115
-							unset( $recent[ $plugin ] );
3114
+						if ( isset( $recent[$plugin] ) ) {
3115
+							unset( $recent[$plugin] );
3116 3116
 						}
3117 3117
 					}
3118 3118
 					update_option( 'recently_activated', $recent );
@@ -3416,7 +3416,7 @@  discard block
 block discarded – undo
3416 3416
 						)
3417 3417
 				);
3418 3418
 
3419
-				$results[ $plugin ] = $this->result;
3419
+				$results[$plugin] = $this->result;
3420 3420
 
3421 3421
 				// Prevent credentials auth screen from displaying multiple times.
3422 3422
 				if ( false === $result ) {
@@ -3604,7 +3604,7 @@  discard block
 block discarded – undo
3604 3604
 					'names'        => array(),
3605 3605
 					'install_type' => 'install',
3606 3606
 			);
3607
-			$args     = wp_parse_args( $args, $defaults );
3607
+			$args = wp_parse_args( $args, $defaults );
3608 3608
 
3609 3609
 			// Set plugin names to $this->plugin_names property.
3610 3610
 			$this->plugin_names = $args['names'];
@@ -3661,7 +3661,7 @@  discard block
 block discarded – undo
3661 3661
 		 */
3662 3662
 		public function before( $title = '' ) {
3663 3663
 			if ( empty( $title ) ) {
3664
-				$title = esc_html( $this->plugin_names[ $this->i ] );
3664
+				$title = esc_html( $this->plugin_names[$this->i] );
3665 3665
 			}
3666 3666
 			parent::before( $title );
3667 3667
 		}
@@ -3678,7 +3678,7 @@  discard block
 block discarded – undo
3678 3678
 		 */
3679 3679
 		public function after( $title = '' ) {
3680 3680
 			if ( empty( $title ) ) {
3681
-				$title = esc_html( $this->plugin_names[ $this->i ] );
3681
+				$title = esc_html( $this->plugin_names[$this->i] );
3682 3682
 			}
3683 3683
 			parent::after( $title );
3684 3684
 
@@ -3848,7 +3848,7 @@  discard block
 block discarded – undo
3848 3848
 		 */
3849 3849
 		protected static function emulate_filter_bool( $value ) {
3850 3850
 			// phpcs:disable WordPress.Arrays.ArrayDeclarationSpacing.ArrayItemNoNewLine
3851
-			static $true  = array(
3851
+			static $true = array(
3852 3852
 				'1',
3853 3853
 				'true', 'True', 'TRUE',
3854 3854
 				'y', 'Y',
Please login to merge, or discard this patch.