AbstractSimpleBundle::getContainerExtension() - Code Metrics - Inspection of "Cleanup, php7, improve test coverage" - Symplify/PHP7_Sculpin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Tomáš

created 2016-09-21 14:26 UTC

AbstractSimpleBundle::getContainerExtension() A

↳ Parent: AbstractSimpleBundle

Complexity

Conditions	4
Paths	8

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	14
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	9
nc	8
nop	0
crap	20

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\SimpleBundle;

use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;
use Symplify\SimpleBundle\DependencyInjection\Extension\ServicesAndConfigurationAwareExtension;

abstract class AbstractSimpleBundle extends Bundle
{
    public function getContainerExtension() : ExtensionInterface
    {
        $extension = new ServicesAndConfigurationAwareExtension();
        if ($this->getServicesFile()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $extension->setServicesFilePath($this->getServicesFile());
        }
        if ($this->getConfiguration()) {
            $extension->setConfiguration($this->getConfiguration());
        }
        if ($this->getParametersAliases()) {
            $extension->setParametersAliases($this->getParametersAliases());
        }

        return $extension;
    }

    /**
     * @return string|null
     */
    protected function getServicesFile()
    {
    }

    /**
     * @return ConfigurationInterface|null
     */
    protected function getConfiguration()
    {
    }

    /***

     * @return string[]|null
     */
    protected function getParametersAliases()
    {
    }
}


1			<?php
2
3			/*
4			* This file is part of Symplify
5			* Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
6			*/
7
8			namespace Symplify\SimpleBundle;
9
10			use Symfony\Component\Config\Definition\ConfigurationInterface;
11			use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
12			use Symfony\Component\HttpKernel\Bundle\Bundle;
13			use Symplify\SimpleBundle\DependencyInjection\Extension\ServicesAndConfigurationAwareExtension;
14
15			abstract class AbstractSimpleBundle extends Bundle
16			{
17			public function getContainerExtension() : ExtensionInterface
18			{
19			$extension = new ServicesAndConfigurationAwareExtension();
20			if ($this->getServicesFile()) {
			0 ignored issues – show Bug Best Practice introduced 2016-09-21 14:16 UTC by Report Bug Copy Issue Report The expression `$this->getServicesFile()` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
21			$extension->setServicesFilePath($this->getServicesFile());
22			}
23			if ($this->getConfiguration()) {
24			$extension->setConfiguration($this->getConfiguration());
25			}
26			if ($this->getParametersAliases()) {
27			$extension->setParametersAliases($this->getParametersAliases());
28			}
29
30			return $extension;
31			}
32
33			/**
34			* @return string\|null
35			*/
36			protected function getServicesFile()
37			{
38			}
39
40			/**
41			* @return ConfigurationInterface\|null
42			*/
43			protected function getConfiguration()
44			{
45			}
46
47			/***
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-09-21 14:16 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48			* @return string[]\|null
49			*/
50			protected function getParametersAliases()
51			{
52			}
53			}
54

Symplify / PHP7_Sculpin

Pull Request — master (#6)

AbstractSimpleBundle::getContainerExtension() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like