Symplify\SimpleBundle\AbstractSimpleBundle

Complexity

Total Complexity

7

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getContainerExtension()	0	15	4
A	getServicesFile()	0	3	1
A	getConfiguration()	0	3	1
A	getParametersAliases()	0	3	1

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\SimpleBundle;

use Symfony\Component\Config\Definition\ConfigurationInterface;
use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
use Symfony\Component\HttpKernel\Bundle\Bundle;
use Symplify\SimpleBundle\DependencyInjection\Extension\ServicesAndConfigurationAwareExtension;

abstract class AbstractSimpleBundle extends Bundle
{
    public function getContainerExtension() : ExtensionInterface
    {
        $extension = new ServicesAndConfigurationAwareExtension();
        if ($this->getServicesFile()) {

The expression $this->getServicesFile() of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $extension->setServicesFilePath($this->getServicesFile());
        }
        if ($this->getConfiguration()) {
            $extension->setConfiguration($this->getConfiguration());
        }
        if ($this->getParametersAliases()) {
            $extension->setParametersAliases($this->getParametersAliases());
        }

        return $extension;
    }

    /**
     * @return string|null
     */
    protected function getServicesFile()
    {
    }

    /**
     * @return ConfigurationInterface|null
     */
    protected function getConfiguration()
    {
    }

    /***

56% of this comment could be valid code. Did you maybe forget this after debugging?

     * @return string[]|null
     */
    protected function getParametersAliases()
    {
    }
}