Ruleset::setSniffProperty() - Code Metrics - Inspection of "Merge pull request #5 from Symplify/coverage" - Symplify/PHP7_CodeSniffer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f7eb77...bdcf7d )

by Tomáš

created 2016-08-04 22:06 UTC

Ruleset::setSniffProperty() B

↳ Parent: Ruleset

Complexity

Conditions	5
Paths	7

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	20
ccs	0
cts	12
cp	0
rs	8.8571
c	1
b	0
f	0
cc	5
eloc	11
nc	7
nop	3
crap	30

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\PHP7_CodeSniffer\Ruleset;

use PHP_CodeSniffer\Sniffs\Sniff;

final class Ruleset
{
    /**
     * @var RulesetBuilder
     */
    private $rulesetBuilder;

    public function __construct(RulesetBuilder $rulesetBuilder)
    {
        $this->rulesetBuilder = $rulesetBuilder;
    }

    /**
     * @param array|Sniff[] $sniffs
     */
    public function decorateSniffsWithCustomRules(array $sniffs, array $ruleset)

    {
        dump($ruleset);
        die;

        // todo: put to SniffDispatcher on sniff loading?
        //        $ruleset = $this->rulesetBuilder->getRuleset();


        foreach ($sniffs as $sniffCode => $sniffObject) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            if (!isset($ruleset[$sniffCode]['properties'])) {
                continue;
            }

            foreach ($ruleset[$sniffCode]['properties'] as $name => $value) {
                $this->setSniffProperty($sniffCode, $name, $value);
            }
        }
    }

    /**
     * @param string $sniffCode
     * @param string $name
     * @param string|array $value
     */
    private function setSniffProperty(string $sniffCode, string $name, $value)
    {
        if (isset($sniffs[$sniffCode]) === false) {

            return;
        }

        $name = trim($name);
        if (is_string($value)) {
            $value = trim($value);
        }

        // Special case for booleans.
        if ($value === 'true') {
            $value = true;
        } elseif ($value === 'false') {
            $value = false;
        }

        $sniffs[$sniffCode]->$name = $value;

    }
}


1		<?php
2
3		/*
4		* This file is part of Symplify
5		* Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
6		*/
7
8		namespace Symplify\PHP7_CodeSniffer\Ruleset;
9
10		use PHP_CodeSniffer\Sniffs\Sniff;
11
12		final class Ruleset
13		{
14		/**
15		* @var RulesetBuilder
16		*/
17		private $rulesetBuilder;
18
19	1	public function __construct(RulesetBuilder $rulesetBuilder)
20		{
21	1	$this->rulesetBuilder = $rulesetBuilder;
22	1	}
23
24		/**
25		* @param array\|Sniff[] $sniffs
26		*/
27		public function decorateSniffsWithCustomRules(array $sniffs, array $ruleset)
		0 ignored issues – show Unused Code introduced 2016-08-04 22:09 UTC by Report Bug Copy Issue Report The parameter `$sniffs` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
28		{
29		dump($ruleset);
30		die;
		0 ignored issues – show Coding Style Compatibility introduced 2016-08-04 22:09 UTC by Report Bug Copy Issue Report The method `decorateSniffsWithCustomRules()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
31		// todo: put to SniffDispatcher on sniff loading?
32		// $ruleset = $this->rulesetBuilder->getRuleset();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-04 22:09 UTC by Report Bug Copy Issue Report `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33
34		foreach ($sniffs as $sniffCode => $sniffObject) {
		0 ignored issues – show Unused Code introduced 2016-08-04 22:09 UTC by Report Bug Copy Issue Report `// todo: put to SniffDis...$name, $value); } }` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
35		if (!isset($ruleset[$sniffCode]['properties'])) {
36		continue;
37		}
38
39		foreach ($ruleset[$sniffCode]['properties'] as $name => $value) {
40		$this->setSniffProperty($sniffCode, $name, $value);
41		}
42		}
43		}
44
45		/**
46		* @param string $sniffCode
47		* @param string $name
48		* @param string\|array $value
49		*/
50		private function setSniffProperty(string $sniffCode, string $name, $value)
51		{
52		if (isset($sniffs[$sniffCode]) === false) {
		0 ignored issues – show Bug introduced 2016-08-03 12:14 UTC by Report Bug Copy Issue Report The variable `$sniffs` seems to never exist, and therefore `isset` should always return `false`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
53		return;
54		}
55
56		$name = trim($name);
57		if (is_string($value)) {
58		$value = trim($value);
59		}
60
61		// Special case for booleans.
62		if ($value === 'true') {
63		$value = true;
64		} elseif ($value === 'false') {
65		$value = false;
66		}
67
68		$sniffs[$sniffCode]->$name = $value;
		0 ignored issues – show Bug introduced 2016-08-03 12:14 UTC by Report Bug Copy Issue Report The variable `$sniffs` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
69		}
70		}
71

Symplify / PHP7_CodeSniffer

Push — master ( f7eb77...bdcf7d )

Ruleset::setSniffProperty() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like