Symplify\PHP7_CodeSniffer\Ruleset\Ruleset

Complexity

Total Complexity

10

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

16.66%

Importance

Changes	2
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	decorateSniffsWithCustomRules()	0	17	4
B	setSniffProperty()	0	20	5

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\PHP7_CodeSniffer\Ruleset;

use PHP_CodeSniffer\Sniffs\Sniff;

final class Ruleset
{
    /**
     * @var RulesetBuilder
     */
    private $rulesetBuilder;

    public function __construct(RulesetBuilder $rulesetBuilder)
    {
        $this->rulesetBuilder = $rulesetBuilder;
    }

    /**
     * @param array|Sniff[] $sniffs
     */
    public function decorateSniffsWithCustomRules(array $sniffs, array $ruleset)

The parameter $sniffs is not used and could be removed.

    {
        dump($ruleset);
        die;

The method decorateSniffsWithCustomRules() contains an exit expression.

        // todo: put to SniffDispatcher on sniff loading?
        //        $ruleset = $this->rulesetBuilder->getRuleset();

54% of this comment could be valid code. Did you maybe forget this after debugging?

        foreach ($sniffs as $sniffCode => $sniffObject) {

// todo: put to SniffDispatcher on sniff loading? // $ruleset = $this->rulesetBuilder->getRuleset(); foreach ($sniffs as $sniffCode => $sniffObject) { if (!isset($ruleset[$sniffCode]['properties'])) { continue; } foreach ($ruleset[$sniffCode]['properties'] as $name => $value) { $this->setSniffProperty($sniffCode, $name, $value); } } does not seem to be reachable.

            if (!isset($ruleset[$sniffCode]['properties'])) {
                continue;
            }

            foreach ($ruleset[$sniffCode]['properties'] as $name => $value) {
                $this->setSniffProperty($sniffCode, $name, $value);
            }
        }
    }

    /**
     * @param string $sniffCode
     * @param string $name
     * @param string|array $value
     */
    private function setSniffProperty(string $sniffCode, string $name, $value)
    {
        if (isset($sniffs[$sniffCode]) === false) {

The variable $sniffs seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

            return;
        }

        $name = trim($name);
        if (is_string($value)) {
            $value = trim($value);
        }

        // Special case for booleans.
        if ($value === 'true') {
            $value = true;
        } elseif ($value === 'false') {
            $value = false;
        }

        $sniffs[$sniffCode]->$name = $value;

The variable $sniffs does not exist. Did you forget to declare it?

    }
}