SingleSniffFactory::setCustomSniffPropertyValues() - Code Metrics - Inspection of "Merge pull request #11 from Symplify/ruleset" - Symplify/PHP7_CodeSniffer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 393329...74ff7b )

by Tomáš

created 2016-08-19 09:32 UTC

SingleSniffFactory::setCustomSniffPropertyValues() A

↳ Parent: SingleSniffFactory

Complexity

Conditions	3
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.3332

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	4
cts	6
cp	0.6667
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	2
nop	1
crap	3.3332

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\PHP7_CodeSniffer\Sniff\Factory;

use PHP_CodeSniffer\Sniffs\Sniff;
use Symplify\PHP7_CodeSniffer\Sniff\Xml\DataCollector\SniffPropertyValueDataCollector;
use Symplify\PHP7_CodeSniffer\Sniff\Xml\DataCollector\ExcludedSniffDataCollector;

final class SingleSniffFactory
{
    /**
     * @var ExcludedSniffDataCollector
     */
    private $excludedSniffDataCollector;

    /**
     * @var SniffPropertyValueDataCollector
     */
    private $sniffPropertyValueDataCollector;

    public function __construct(
        ExcludedSniffDataCollector $excludedSniffDataCollector,
        SniffPropertyValueDataCollector $customSniffPropertyDataCollector
    ) {
        $this->excludedSniffDataCollector = $excludedSniffDataCollector;
        $this->sniffPropertyValueDataCollector = $customSniffPropertyDataCollector;
    }

    /**
     * @return Sniff|null
     */
    public function create(string $sniffClassName)
    {
        if ($this->excludedSniffDataCollector->isSniffClassExcluded($sniffClassName)) {
            return null;
        }

        $sniff = new $sniffClassName;
        return $this->setCustomSniffPropertyValues($sniff);
    }

    private function setCustomSniffPropertyValues(Sniff $sniff) : Sniff
    {
        $sniffPropertyValues = $this->sniffPropertyValueDataCollector->getForSniff($sniff);
        if ($sniffPropertyValues) {

            foreach ($sniffPropertyValues as $property => $value) {
                $sniff->$property = $value;
            }
        }

        return $sniff;
    }
}


1		<?php
2
3		/*
4		* This file is part of Symplify
5		* Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
6		*/
7
8		namespace Symplify\PHP7_CodeSniffer\Sniff\Factory;
9
10		use PHP_CodeSniffer\Sniffs\Sniff;
11		use Symplify\PHP7_CodeSniffer\Sniff\Xml\DataCollector\SniffPropertyValueDataCollector;
12		use Symplify\PHP7_CodeSniffer\Sniff\Xml\DataCollector\ExcludedSniffDataCollector;
13
14		final class SingleSniffFactory
15		{
16		/**
17		* @var ExcludedSniffDataCollector
18		*/
19		private $excludedSniffDataCollector;
20
21		/**
22		* @var SniffPropertyValueDataCollector
23		*/
24		private $sniffPropertyValueDataCollector;
25
26	14	public function __construct(
27		ExcludedSniffDataCollector $excludedSniffDataCollector,
28		SniffPropertyValueDataCollector $customSniffPropertyDataCollector
29		) {
30	14	$this->excludedSniffDataCollector = $excludedSniffDataCollector;
31	14	$this->sniffPropertyValueDataCollector = $customSniffPropertyDataCollector;
32	14	}
33
34		/**
35		* @return Sniff\|null
36		*/
37	9	public function create(string $sniffClassName)
38		{
39	9	if ($this->excludedSniffDataCollector->isSniffClassExcluded($sniffClassName)) {
40	1	return null;
41		}
42
43	8	$sniff = new $sniffClassName;
44	8	return $this->setCustomSniffPropertyValues($sniff);
45		}
46
47	8	private function setCustomSniffPropertyValues(Sniff $sniff) : Sniff
48		{
49	8	$sniffPropertyValues = $this->sniffPropertyValueDataCollector->getForSniff($sniff);
50	8	if ($sniffPropertyValues) {
		0 ignored issues – show Bug Best Practice introduced 2016-08-19 09:42 UTC by Report Bug Copy Issue Report The expression `$sniffPropertyValues` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
51		foreach ($sniffPropertyValues as $property => $value) {
52		$sniff->$property = $value;
53		}
54		}
55
56	8	return $sniff;
57		}
58		}
59

Symplify / PHP7_CodeSniffer

Push — master ( 393329...74ff7b )

SingleSniffFactory::setCustomSniffPropertyValues() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like