Symplify\PHP7_CodeSniffer\Sniff\Factory\SingleSniffFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

86.67%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	create()	0	9	2
A	setCustomSniffPropertyValues()	0	11	3

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\PHP7_CodeSniffer\Sniff\Factory;

use PHP_CodeSniffer\Sniffs\Sniff;
use Symplify\PHP7_CodeSniffer\Sniff\Xml\DataCollector\SniffPropertyValueDataCollector;
use Symplify\PHP7_CodeSniffer\Sniff\Xml\DataCollector\ExcludedSniffDataCollector;

final class SingleSniffFactory
{
    /**
     * @var ExcludedSniffDataCollector
     */
    private $excludedSniffDataCollector;

    /**
     * @var SniffPropertyValueDataCollector
     */
    private $sniffPropertyValueDataCollector;

    public function __construct(
        ExcludedSniffDataCollector $excludedSniffDataCollector,
        SniffPropertyValueDataCollector $customSniffPropertyDataCollector
    ) {
        $this->excludedSniffDataCollector = $excludedSniffDataCollector;
        $this->sniffPropertyValueDataCollector = $customSniffPropertyDataCollector;
    }

    /**
     * @return Sniff|null
     */
    public function create(string $sniffClassName)
    {
        if ($this->excludedSniffDataCollector->isSniffClassExcluded($sniffClassName)) {
            return null;
        }

        $sniff = new $sniffClassName;
        return $this->setCustomSniffPropertyValues($sniff);
    }

    private function setCustomSniffPropertyValues(Sniff $sniff) : Sniff
    {
        $sniffPropertyValues = $this->sniffPropertyValueDataCollector->getForSniff($sniff);
        if ($sniffPropertyValues) {

The expression $sniffPropertyValues of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($sniffPropertyValues as $property => $value) {
                $sniff->$property = $value;
            }
        }

        return $sniff;
    }
}