Lead::checkAlreadyExists() - Code Metrics - Inspection of "Refactoring" - Surge-Financial/laravel-salesforce - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( abf85d...bf3287 )

by Ashleigh

created 2017-07-31 15:51 UTC

Lead::checkAlreadyExists() B

↳ Parent: Lead

Complexity

Conditions	6
Paths	5

Size

Total Lines	23
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	8.5906
c	0
b	0
f	0
cc	6
eloc	12
nc	5
nop	2

<?php

namespace Surge\LaravelSalesforce\Objects;

class Lead extends AbstractObject
{
    /**
     * Insert new lead.
     *
     * @param $params
     */
    public function create(array$params)
    {
        $params['RecordTypeId'] = config('laravel-salesforce.record_type.lead');

        return parent::create($params);
    }

    /**
     * Check if lead already exists on SF.
     *
     * @param string $phone
     * @param string $email
     *
     * @return bool|array
     */
    public function checkAlreadyExists($phone = null, $email = null)
    {
        //return false if not enough data provided
        if (!$email && !$phone) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return false;
        }

        if ($email) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $query = 'SELECT Id, OwnerId  FROM '.$this->getType().' WHERE Email = \''.addslashes(trim($email)).'\'';
        } else {
            $query = 'SELECT Id, OwnerId  FROM '.$this->getType().' WHERE Phone = \''.addslashes(trim($phone)).'\'';
        }

        $query .= ' AND RecordTypeId = \''.config('laravel-salesforce.record_type.lead').'\'';

        $response = $this->query($query);

        if ($response && $response->totalSize > 0) {
            return array_shift($response->records);
        }

        return false;
    }
}


1			<?php
2
3			namespace Surge\LaravelSalesforce\Objects;
4
5			class Lead extends AbstractObject
6			{
7			/**
8			* Insert new lead.
9			*
10			* @param $params
11			*/
12			public function create(array$params)
13			{
14			$params['RecordTypeId'] = config('laravel-salesforce.record_type.lead');
15
16			return parent::create($params);
17			}
18
19			/**
20			* Check if lead already exists on SF.
21			*
22			* @param string $phone
23			* @param string $email
24			*
25			* @return bool\|array
26			*/
27			public function checkAlreadyExists($phone = null, $email = null)
28			{
29			//return false if not enough data provided
30			if (!$email && !$phone) {
			0 ignored issues – show Bug Best Practice introduced 2017-07-11 08:29 UTC by Report Bug Copy Issue Report The expression `$email` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Bug Best Practice introduced 2017-07-11 08:29 UTC by Report Bug Copy Issue Report The expression `$phone` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
31			return false;
32			}
33
34			if ($email) {
			0 ignored issues – show Bug Best Practice introduced 2017-07-11 08:29 UTC by Report Bug Copy Issue Report The expression `$email` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
35			$query = 'SELECT Id, OwnerId FROM '.$this->getType().' WHERE Email = \''.addslashes(trim($email)).'\'';
36			} else {
37			$query = 'SELECT Id, OwnerId FROM '.$this->getType().' WHERE Phone = \''.addslashes(trim($phone)).'\'';
38			}
39
40			$query .= ' AND RecordTypeId = \''.config('laravel-salesforce.record_type.lead').'\'';
41
42			$response = $this->query($query);
43
44			if ($response && $response->totalSize > 0) {
45			return array_shift($response->records);
46			}
47
48			return false;
49			}
50			}
51

Surge-Financial / laravel-salesforce

Push — master ( abf85d...bf3287 )

Lead::checkAlreadyExists() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like