Surge\LaravelSalesforce\Objects\Lead

Complexity

Total Complexity

7

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	6	1
B	checkAlreadyExists()	0	23	6

<?php

namespace Surge\LaravelSalesforce\Objects;

class Lead extends AbstractObject
{
    /**
     * Insert new lead.
     *
     * @param $params
     */
    public function create(array$params)
    {
        $params['RecordTypeId'] = config('laravel-salesforce.record_type.lead');

        return parent::create($params);
    }

    /**
     * Check if lead already exists on SF.
     *
     * @param string $phone
     * @param string $email
     *
     * @return bool|array
     */
    public function checkAlreadyExists($phone = null, $email = null)
    {
        //return false if not enough data provided
        if (!$email && !$phone) {

The expression $email of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

The expression $phone of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            return false;
        }

        if ($email) {

The expression $email of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $query = 'SELECT Id, OwnerId  FROM '.$this->getType().' WHERE Email = \''.addslashes(trim($email)).'\'';
        } else {
            $query = 'SELECT Id, OwnerId  FROM '.$this->getType().' WHERE Phone = \''.addslashes(trim($phone)).'\'';
        }

        $query .= ' AND RecordTypeId = \''.config('laravel-salesforce.record_type.lead').'\'';

        $response = $this->query($query);

        if ($response && $response->totalSize > 0) {
            return array_shift($response->records);
        }

        return false;
    }
}