Strategy11 / formidable-forms

classes/models/FrmValidate.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
 		$form = $this->get_form();
 		$key  = $this->get_option_key();
-		return ! empty( $form->options[ $key ] ) && 'off' !== $form->options[ $key ];
+		return ! empty( $form->options[$key] ) && 'off' !== $form->options[$key];
 	}
 
 	/**

classes/models/FrmStopforumspam.php

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
 
 	private function is_spam() {
 		$ip_address   = FrmAppHelper::get_ip_address();
-		$ips_to_allow = array( '', '127.0.0.1'  );
+		$ips_to_allow = array( '', '127.0.0.1' );
 		$request_data = array();
 
 		if ( ! in_array( $ip_address, $ips_to_allow, true ) ) {
@@ -73,7 +73,7 @@ 
 	}
 
 	private function add_email_to_request( &$request_data ) {
-		$email = $this->values['item_meta'][ $this->posted_fields['email'] ];
+		$email = $this->values['item_meta'][$this->posted_fields['email']];
 		if ( is_email( $email ) ) {
 			$request_data['email'] = $email;
 		}

classes/models/FrmHoneypot.php

Spacing +1 added lines, -1 removed lines

@@ -208,7 +208,7 @@
 			return '';
 		}
 
-		return isset( $item_meta[ $field_id ] ) ? $item_meta[ $field_id ] : '';
+		return isset( $item_meta[$field_id] ) ? $item_meta[$field_id] : '';
 	}
 
 	/**

classes/models/FrmSettings.php

Spacing +4 added lines, -4 removed lines

@@ -227,8 +227,8 @@ 
 		}
 
 		foreach ( $settings as $setting => $default ) {
-			if ( isset( $params[ 'frm_' . $setting ] ) ) {
-				$this->{$setting} = $params[ 'frm_' . $setting ];
+			if ( isset( $params['frm_' . $setting] ) ) {
+				$this->{$setting} = $params['frm_' . $setting];
 			} elseif ( ! isset( $this->{$setting} ) ) {
 				$this->{$setting} = $default;
 			}
@@ -418,7 +418,7 @@ 
 			'honeypot',
 		);
 		foreach ( $checkboxes as $set ) {
-			$this->$set = isset( $params[ 'frm_' . $set ] ) ? absint( $params[ 'frm_' . $set ] ) : 0;
+			$this->$set = isset( $params['frm_' . $set] ) ? absint( $params['frm_' . $set] ) : 0;
 		}
 	}
 
@@ -431,7 +431,7 @@ 
 		$frm_roles = FrmAppHelper::frm_capabilities();
 		$roles     = get_editable_roles();
 		foreach ( $frm_roles as $frm_role => $frm_role_description ) {
-			$this->$frm_role = (array) ( isset( $params[ $frm_role ] ) ? $params[ $frm_role ] : 'administrator' );
+			$this->$frm_role = (array) ( isset( $params[$frm_role] ) ? $params[$frm_role] : 'administrator' );
 
 			// Make sure administrators always have permissions
 			if ( ! in_array( 'administrator', $this->$frm_role, true ) ) {

classes/models/FrmEntryValidate.php

Spacing +30 added lines, -30 removed lines

@@ -27,7 +27,7 @@ 
 			return $errors;
 		}
 
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
 			$frm_settings   = FrmAppHelper::get_settings();
 			$errors['form'] = $frm_settings->admin_permission;
 		}
@@ -130,7 +130,7 @@ 
 		$args = wp_parse_args( $args, $defaults );
 
 		if ( empty( $args['parent_field_id'] ) ) {
-			$value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : '';
+			$value = isset( $values['item_meta'][$args['id']] ) ? $values['item_meta'][$args['id']] : '';
 		} else {
 			// value is from a nested form
 			$value = $values;
@@ -151,7 +151,7 @@ 
 		}
 
 		if ( $posted_field->required == '1' && FrmAppHelper::is_empty_value( $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
 		} elseif ( ! isset( $_POST['item_name'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			self::maybe_add_item_name( $value, $posted_field );
 		}
@@ -234,7 +234,7 @@ 
 			$pattern = self::phone_format( $field );
 
 			if ( ! preg_match( $pattern, $value ) ) {
-				$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
+				$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
 			}
 		}
 	}
@@ -358,7 +358,7 @@ 
 	 */
 	private static function form_is_in_progress( $values ) {
 		return FrmAppHelper::pro_is_installed() &&
-			( isset( $values[ 'frm_page_order_' . $values['form_id'] ] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
+			( isset( $values['frm_page_order_' . $values['form_id']] ) || FrmAppHelper::get_post_param( 'frm_next_page' ) ) &&
 			FrmField::get_all_types_in_form( $values['form_id'], 'break' );
 	}
 
@@ -389,7 +389,7 @@ 
 	}
 
 	private static function is_blacklist_spam( $values ) {
-		$check = new FrmBlacklistSpamCheck( $values['form_id'] );;
+		$check = new FrmBlacklistSpamCheck( $values['form_id'] ); ;
 		$check->set_values( $values );
 		return ! $check->validate();
 	}
@@ -617,9 +617,9 @@ 
 			foreach ( $datas['missing_keys'] as $key_index => $key ) {
 				$found = self::is_akismet_guest_info_value( $key, $value, $field_id, $datas['name_field_ids'], $values );
 				if ( $found ) {
-					$datas[ $key ]             = $value;
+					$datas[$key]             = $value;
 					$datas['frm_duplicated'][] = $field_id;
-					unset( $datas['missing_keys'][ $key_index ] );
+					unset( $datas['missing_keys'][$key_index] );
 				}
 			}
 		}//end foreach
@@ -662,11 +662,11 @@ 
 					if ( 'Name' !== $field->name ) {
 						continue;
 					}
-					if ( isset( $fields[ $index + 1 ] ) && 'Last' === $fields[ $index + 1 ]->name ) {
-						if ( empty( $values[ absint( $fields[ $index + 1 ]->id ) ] ) ) {
+					if ( isset( $fields[$index + 1] ) && 'Last' === $fields[$index + 1]->name ) {
+						if ( empty( $values[absint( $fields[$index + 1]->id )] ) ) {
 							continue;
 						}
-						$value .= ' ' . $values[ $fields[ $index + 1 ]->id ];
+						$value .= ' ' . $values[$fields[$index + 1]->id];
 						return true;
 					}
 				}
@@ -685,13 +685,13 @@ 
 	 */
 	private static function get_name_text_fields( $form_id ) {
 		$name_text_fields_is_initialized = is_array( self::$name_text_fields );
-		if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[ $form_id ] ) ) {
-			return self::$name_text_fields[ $form_id ];
+		if ( $name_text_fields_is_initialized && isset( self::$name_text_fields[$form_id] ) ) {
+			return self::$name_text_fields[$form_id];
 		}
 		if ( ! $name_text_fields_is_initialized ) {
 			self::$name_text_fields = array();
 		}
-		self::$name_text_fields[ $form_id ] = FrmDb::get_results(
+		self::$name_text_fields[$form_id] = FrmDb::get_results(
 			'frm_fields',
 			array(
 				'form_id' => $form_id,
@@ -702,7 +702,7 @@ 
 			array( 'order_by' => 'field_order ASC' )
 		);
 
-		return self::$name_text_fields[ $form_id ];
+		return self::$name_text_fields[$form_id];
 	}
 
 	private static function add_server_values_to_akismet( &$datas ) {
@@ -711,7 +711,7 @@ 
 
 			// Send any potentially useful $_SERVER vars, but avoid sending junk we don't need.
 			if ( $include_value ) {
-				$datas[ $key ] = $value;
+				$datas[$key] = $value;
 			}
 			unset( $key, $value );
 		}
@@ -728,10 +728,10 @@ 
 	private static function add_comment_content_to_akismet( &$datas, $values ) {
 		if ( isset( $datas['frm_duplicated'] ) ) {
 			foreach ( $datas['frm_duplicated'] as $index ) {
-				if ( isset( $values['item_meta'][ $index ] ) ) {
-					unset( $values['item_meta'][ $index ] );
+				if ( isset( $values['item_meta'][$index] ) ) {
+					unset( $values['item_meta'][$index] );
 				} else {
-					unset( $values[ $index ] );
+					unset( $values[$index] );
 				}
 			}
 			unset( $datas['frm_duplicated'] );
@@ -750,14 +750,14 @@ 
 	private static function skip_adding_values_to_akismet( &$values ) {
 		$skipped_fields = self::get_akismet_skipped_field_ids( $values );
 		foreach ( $skipped_fields as $skipped_field ) {
-			if ( ! isset( $values['item_meta'][ $skipped_field->id ] ) ) {
+			if ( ! isset( $values['item_meta'][$skipped_field->id] ) ) {
 				continue;
 			}
 
 			if ( self::should_really_skip_field( $skipped_field, $values ) ) {
-				unset( $values['item_meta'][ $skipped_field->id ] );
-				if ( isset( $values['item_meta']['other'][ $skipped_field->id ] ) ) {
-					unset( $values['item_meta']['other'][ $skipped_field->id ] );
+				unset( $values['item_meta'][$skipped_field->id] );
+				if ( isset( $values['item_meta']['other'][$skipped_field->id] ) ) {
+					unset( $values['item_meta']['other'][$skipped_field->id] );
 				}
 			}
 		}
@@ -793,14 +793,14 @@ 
 		}
 
 		// If a choice field has Other option, but Other is not selected.
-		if ( empty( $values['item_meta']['other'][ $field_data->id ] ) ) {
+		if ( empty( $values['item_meta']['other'][$field_data->id] ) ) {
 			return true;
 		}
 
 		// Check if submitted value is same as one of field option.
 		foreach ( $field_data->options as $option ) {
 			$option_value = ! is_array( $option ) ? $option : ( isset( $option['value'] ) ? $option['value'] : '' );
-			if ( $values['item_meta']['other'][ $field_data->id ] === $option_value ) {
+			if ( $values['item_meta']['other'][$field_data->id] === $option_value ) {
 				return true;
 			}
 		}
@@ -871,7 +871,7 @@ 
 
 			// Convert name array to string.
 			if ( isset( $value['first'] ) && isset( $value['last'] ) ) {
-				$values['item_meta'][ $field_id ] = trim( implode( ' ', $value ) );
+				$values['item_meta'][$field_id] = trim( implode( ' ', $value ) );
 				$values['name_field_ids'][]       = $field_id;
 				continue;
 			}
@@ -892,8 +892,8 @@ 
 						continue;
 					}
 
-					if ( ! isset( $values['item_meta'][ $subsubindex ] ) ) {
-						$values['item_meta'][ $subsubindex ] = array();
+					if ( ! isset( $values['item_meta'][$subsubindex] ) ) {
+						$values['item_meta'][$subsubindex] = array();
 					}
 
 					// Convert name array to string.
@@ -903,11 +903,11 @@ 
 						$values['name_field_ids'][] = $subsubindex;
 					}
 
-					$values['item_meta'][ $subsubindex ][] = $subsubvalue;
+					$values['item_meta'][$subsubindex][] = $subsubvalue;
 				}
 			}//end foreach
 
-			unset( $values['item_meta'][ $field_id ] );
+			unset( $values['item_meta'][$field_id] );
 		}//end foreach
 
 		return $form_ids;