Strategy11 / formidable-forms

classes/controllers/FrmFieldsController.php

Spacing +26 added lines, -26 removed lines

@@ -25,7 +25,7 @@ 
 
 		$_GET['page'] = 'formidable';
 
-		$values     = array(
+		$values = array(
 			'id'         => FrmAppHelper::get_post_param( 'form_id', '', 'absint' ),
 			'doing_ajax' => true,
 		);
@@ -48,7 +48,7 @@ 
 
 			ob_start();
 			self::load_single_field( $field, $values );
-			$field_html[ absint( $field->id ) ] = ob_get_contents();
+			$field_html[absint( $field->id )] = ob_get_contents();
 			ob_end_clean();
 		}
 
@@ -263,7 +263,7 @@ 
 			foreach ( $opts as $opt_key => $opt ) {
 				if ( strpos( $opt, '|' ) !== false ) {
 					$vals             = explode( '|', $opt );
-					$opts[ $opt_key ] = array(
+					$opts[$opt_key] = array(
 						'label' => trim( $vals[0] ),
 						'value' => trim( $vals[1] ),
 					);
@@ -278,7 +278,7 @@ 
 			$other_array = array();
 			foreach ( $field['options'] as $opt_key => $opt ) {
 				if ( FrmFieldsHelper::is_other_opt( $opt_key ) ) {
-					$other_array[ $opt_key ] = $opt;
+					$other_array[$opt_key] = $opt;
 				}
 				unset( $opt_key, $opt );
 			}
@@ -321,18 +321,18 @@ 
 		$frm_settings         = FrmAppHelper::get_settings();
 		$field_types          = FrmFieldTypeOptionData::get_field_types( $field['type'] );
 
-		if ( ! isset( $all_field_types[ $field['type'] ] ) ) {
+		if ( ! isset( $all_field_types[$field['type']] ) ) {
 			// Add fallback for an add-on field type that has been deactivated.
-			$all_field_types[ $field['type'] ] = array(
+			$all_field_types[$field['type']] = array(
 				'name' => ucfirst( $field['type'] ),
 				'icon' => 'frm_icon_font frm_pencil_icon',
 			);
-		} elseif ( ! is_array( $all_field_types[ $field['type'] ] ) ) {
+		} elseif ( ! is_array( $all_field_types[$field['type']] ) ) {
 			// Fallback for fields added in a more basic way.
-			FrmFormsHelper::prepare_field_type( $all_field_types[ $field['type'] ] );
+			FrmFormsHelper::prepare_field_type( $all_field_types[$field['type']] );
 		}
 
-		$type_name = $all_field_types[ $field['type'] ]['name'];
+		$type_name = $all_field_types[$field['type']]['name'];
 		if ( $field['type'] === 'divider' && FrmField::is_option_true( $field, 'repeat' ) ) {
 			$type_name = $all_field_types['divider|repeat']['name'];
 		}
@@ -406,13 +406,13 @@ 
 		$active   = 'default_value';
 
 		foreach ( $settings as $type ) {
-			if ( ! empty( $field[ $type ] ) ) {
+			if ( ! empty( $field[$type] ) ) {
 				$active = $type;
 			}
 		}
 
-		$types[ $active ]['class']  .= ' current';
-		$types[ $active ]['current'] = true;
+		$types[$active]['class']  .= ' current';
+		$types[$active]['current'] = true;
 
 		return $types;
 	}
@@ -430,8 +430,8 @@ 
 			'website' => 'url',
 			'image'   => 'url',
 		);
-		if ( isset( $type_switch[ $type ] ) ) {
-			$type = $type_switch[ $type ];
+		if ( isset( $type_switch[$type] ) ) {
+			$type = $type_switch[$type];
 		}
 
 		$pro_fields = FrmField::pro_field_selection();
@@ -584,11 +584,11 @@ 
 		// include "col" for valid html
 		$unit = trim( preg_replace( '/[0-9]+/', '', $field['size'] ) );
 
-		if ( ! isset( $calc[ $unit ] ) ) {
+		if ( ! isset( $calc[$unit] ) ) {
 			return;
 		}
 
-		$size = (float) str_replace( $unit, '', $field['size'] ) / $calc[ $unit ];
+		$size = (float) str_replace( $unit, '', $field['size'] ) / $calc[$unit];
 
 		$add_html['cols'] = 'cols="' . absint( $size ) . '"';
 	}
@@ -826,11 +826,11 @@ 
 	private static function get_form_for_js_validation( $field ) {
 		global $frm_vars;
 		if ( ! empty( $frm_vars['js_validate_forms'] ) ) {
-			if ( isset( $frm_vars['js_validate_forms'][ $field['form_id'] ] ) ) {
-				return $frm_vars['js_validate_forms'][ $field['form_id'] ];
+			if ( isset( $frm_vars['js_validate_forms'][$field['form_id']] ) ) {
+				return $frm_vars['js_validate_forms'][$field['form_id']];
 			}
-			if ( ! empty( $field['parent_form_id'] ) && isset( $frm_vars['js_validate_forms'][ $field['parent_form_id'] ] ) ) {
-				return $frm_vars['js_validate_forms'][ $field['parent_form_id'] ];
+			if ( ! empty( $field['parent_form_id'] ) && isset( $frm_vars['js_validate_forms'][$field['parent_form_id']] ) ) {
+				return $frm_vars['js_validate_forms'][$field['parent_form_id']];
 			}
 		}
 		return false;
@@ -917,13 +917,13 @@ 
 		foreach ( $field['shortcodes'] as $k => $v ) {
 			if ( isset( $field['subfield_name'] ) && 0 === strpos( $k, 'aria-invalid' ) ) {
 				$subfield_name = $field['subfield_name'];
-				if ( ! isset( $field['shortcodes'][ 'aria-invalid-' . $subfield_name ] ) ) {
+				if ( ! isset( $field['shortcodes']['aria-invalid-' . $subfield_name] ) ) {
 					continue;
 				}
 				// Change the key to the correct aria-invalid value so that $add_html is set correctly for the current subfield of a combo field.
 				$k = 'aria-invalid';
-				$v = $field['shortcodes'][ 'aria-invalid-' . $subfield_name ];
-				unset( $field['shortcodes'][ 'aria-invalid-' . $subfield_name ] );
+				$v = $field['shortcodes']['aria-invalid-' . $subfield_name];
+				unset( $field['shortcodes']['aria-invalid-' . $subfield_name] );
 			}
 			if ( 'opt' === $k || ! self::should_allow_input_attribute( $k ) ) {
 				continue;
@@ -931,10 +931,10 @@ 
 
 			if ( is_numeric( $k ) && strpos( $v, '=' ) ) {
 				$add_html[] = $v;
-			} elseif ( ! empty( $k ) && isset( $add_html[ $k ] ) ) {
-				$add_html[ $k ] = str_replace( $k . '="', $k . '="' . $v, $add_html[ $k ] );
+			} elseif ( ! empty( $k ) && isset( $add_html[$k] ) ) {
+				$add_html[$k] = str_replace( $k . '="', $k . '="' . $v, $add_html[$k] );
 			} else {
-				$add_html[ $k ] = $k . '="' . esc_attr( $v ) . '"';
+				$add_html[$k] = $k . '="' . esc_attr( $v ) . '"';
 			}
 
 			unset( $k, $v );

classes/models/fields/FrmFieldType.php

Spacing +20 added lines, -20 removed lines

@@ -156,8 +156,8 @@ 
 		$field_val = '';
 		if ( is_object( $this->field ) ) {
 			$field_val = $this->field->{$column};
-		} elseif ( is_array( $this->field ) && isset( $this->field[ $column ] ) ) {
-			$field_val = $this->field[ $column ];
+		} elseif ( is_array( $this->field ) && isset( $this->field[$column] ) ) {
+			$field_val = $this->field[$column];
 		}
 
 		return $field_val;
@@ -171,7 +171,7 @@ 
 		if ( is_object( $this->field ) ) {
 			$this->field->{$column} = $value;
 		} elseif ( is_array( $this->field ) ) {
-			$this->field[ $column ] = $value;
+			$this->field[$column] = $value;
 		}
 	}
 
@@ -613,7 +613,7 @@ 
 			printf(
 				/* translators: %s: Field type */
 				esc_html__( '%s Options', 'formidable' ),
-				esc_html( $all_field_types[ $args['display']['type'] ]['name'] )
+				esc_html( $all_field_types[$args['display']['type']]['name'] )
 			);
 			FrmAppHelper::icon_by_class( 'frmfont frm_arrowdown6_icon', array( 'aria-hidden' => 'true' ) );
 			?>
@@ -713,7 +713,7 @@ 
 	 * New field
 	 */
 	public function get_new_field_defaults() {
-		$field        = array(
+		$field = array(
 			'name'          => $this->get_new_field_name(),
 			'description'   => '',
 			'type'          => $this->type,
@@ -744,8 +744,8 @@ 
 
 		$fields = array_merge( $fields, $pro_fields );
 
-		if ( isset( $fields[ $this->type ] ) ) {
-			$name = is_array( $fields[ $this->type ] ) ? $fields[ $this->type ]['name'] : $fields[ $this->type ];
+		if ( isset( $fields[$this->type] ) ) {
+			$name = is_array( $fields[$this->type] ) ? $fields[$this->type]['name'] : $fields[$this->type];
 		}
 
 		return $name;
@@ -762,7 +762,7 @@ 
 	 * @return array
 	 */
 	public function get_default_field_options() {
-		$opts        = array(
+		$opts = array(
 			'size'               => '',
 			'max'                => '',
 			'label'              => '',
@@ -1006,7 +1006,7 @@ 
 	 * @return void
 	 */
 	public function set_aria_invalid_error( &$shortcode_atts, $args ) {
-		$shortcode_atts['aria-invalid'] = isset( $args['errors'][ 'field' . $this->field_id ] ) ? 'true' : 'false';
+		$shortcode_atts['aria-invalid'] = isset( $args['errors']['field' . $this->field_id] ) ? 'true' : 'false';
 	}
 
 	/**
@@ -1192,8 +1192,8 @@ 
 		$selected = $values['field_value'];
 
 		if ( isset( $values['combo_name'] ) ) {
-			$options  = $options[ $values['combo_name'] ];
-			$selected = is_array( $selected ) && isset( $selected[ $values['combo_name'] ] ) ? $selected[ $values['combo_name'] ] : '';
+			$options  = $options[$values['combo_name']];
+			$selected = is_array( $selected ) && isset( $selected[$values['combo_name']] ) ? $selected[$values['combo_name']] : '';
 		}
 
 		$input = $this->select_tag( $values );
@@ -1248,7 +1248,7 @@ 
 	}
 
 	protected function fill_display_field_values( $args = array() ) {
-		$defaults        = array(
+		$defaults = array(
 			'field_name'    => 'item_meta[' . $this->get_field_column( 'id' ) . ']',
 			'field_id'      => $this->get_field_column( 'id' ),
 			'field_plus_id' => '',
@@ -1305,7 +1305,7 @@ 
 			}
 		}
 
-		if ( isset( $args['errors'][ 'field' . $args['field_id'] ] ) && ! $custom_error_fields ) {
+		if ( isset( $args['errors']['field' . $args['field_id']] ) && ! $custom_error_fields ) {
 			if ( $error_comes_first ) {
 				array_unshift( $describedby, 'frm_error_' . $args['html_id'] );
 			} else {
@@ -1384,11 +1384,11 @@ 
 
 		$field_id = $this->get_field_column( 'id' );
 		if ( ! array_key_exists( $field_id, $frm_validated_unique_values ) ) {
-			$frm_validated_unique_values[ $field_id ] = array();
+			$frm_validated_unique_values[$field_id] = array();
 			return false;
 		}
 
-		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[ $field_id ], true );
+		$already_validated_this_value = in_array( $value, $frm_validated_unique_values[$field_id], true );
 		return $already_validated_this_value;
 	}
 
@@ -1413,7 +1413,7 @@ 
 	private function value_validated_as_unique( $value ) {
 		global $frm_validated_unique_values;
 		$field_id                                   = $this->get_field_column( 'id' );
-		$frm_validated_unique_values[ $field_id ][] = $value;
+		$frm_validated_unique_values[$field_id][] = $value;
 	}
 
 	/**
@@ -1454,8 +1454,8 @@ 
 		$value = $this->prepare_display_value( $value, $atts );
 
 		if ( is_array( $value ) ) {
-			if ( ! empty( $atts['show'] ) && isset( $value[ $atts['show'] ] ) ) {
-				$value = $value[ $atts['show'] ];
+			if ( ! empty( $atts['show'] ) && isset( $value[$atts['show']] ) ) {
+				$value = $value[$atts['show']];
 			} elseif ( empty( $atts['return_array'] ) ) {
 				$sep   = isset( $atts['sep'] ) ? $atts['sep'] : ', ';
 				$value = FrmAppHelper::safe_implode( $sep, $value );
@@ -1585,8 +1585,8 @@ 
 		$saved_entries = $atts['ids'];
 		$new_value     = array();
 		foreach ( (array) $value as $old_child_id ) {
-			if ( isset( $saved_entries[ $old_child_id ] ) ) {
-				$new_value[] = $saved_entries[ $old_child_id ];
+			if ( isset( $saved_entries[$old_child_id] ) ) {
+				$new_value[] = $saved_entries[$old_child_id];
 			}
 		}
 

classes/models/FrmFieldFormHtml.php

Spacing +12 added lines, -12 removed lines

@@ -44,8 +44,8 @@ 
 	 * @param array  $atts
 	 */
 	private function _set( $param, $atts ) {
-		if ( isset( $atts[ $param ] ) ) {
-			$this->{$param} = $atts[ $param ];
+		if ( isset( $atts[$param] ) ) {
+			$this->{$param} = $atts[$param];
 		}
 	}
 
@@ -89,8 +89,8 @@ 
 
 		$exclude = array( 'field_obj', 'html' );
 		foreach ( $exclude as $ex ) {
-			if ( isset( $atts[ $ex ] ) ) {
-				unset( $this->pass_args[ $ex ] );
+			if ( isset( $atts[$ex] ) ) {
+				unset( $this->pass_args[$ex] );
 			}
 		}
 	}
@@ -102,8 +102,8 @@ 
 	 * @param array $set
 	 */
 	private function set_from_field( $atts, $set ) {
-		if ( isset( $atts[ $set['param'] ] ) ) {
-			$this->{$set['param']} = $atts[ $set['param'] ];
+		if ( isset( $atts[$set['param']] ) ) {
+			$this->{$set['param']} = $atts[$set['param']];
 		} else {
 			$this->{$set['param']} = $this->field_obj->get_field_column( $set['default'] );
 		}
@@ -230,7 +230,7 @@ 
 	 */
 	private function replace_error_shortcode() {
 		$this->maybe_add_error_id();
-		$error = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? $this->pass_args['errors'][ 'field' . $this->field_id ] : false;
+		$error = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? $this->pass_args['errors']['field' . $this->field_id] : false;
 
 		if ( ! empty( $error ) && false === strpos( $this->html, 'role="alert"' ) && FrmAppHelper::should_include_alert_role_on_field_errors() ) {
 			$error_body = self::get_error_body( $this->html );
@@ -271,7 +271,7 @@ 
 	 * @since 3.06.02
 	 */
 	private function maybe_add_error_id() {
-		if ( ! isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ) {
+		if ( ! isset( $this->pass_args['errors']['field' . $this->field_id] ) ) {
 			return;
 		}
 
@@ -351,7 +351,7 @@ 
 		preg_match_all( "/\[(input|deletelink)\b(.*?)(?:(\/))?\]/s", $this->html, $shortcodes, PREG_PATTERN_ORDER );
 
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
-			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
+			$shortcode_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
 			$tag            = FrmShortcodeHelper::get_shortcode_tag( $shortcodes, $short_key );
 
 			$replace_with = '';
@@ -362,7 +362,7 @@ 
 				$replace_with = $this->replace_input_shortcode( $shortcode_atts );
 			}
 
-			$this->html = str_replace( $shortcodes[0][ $short_key ], $replace_with, $this->html );
+			$this->html = str_replace( $shortcodes[0][$short_key], $replace_with, $this->html );
 		}
 	}
 
@@ -384,7 +384,7 @@ 
 	 */
 	private function prepare_input_shortcode_atts( $shortcode_atts ) {
 		if ( isset( $shortcode_atts['opt'] ) ) {
-			--$shortcode_atts['opt'];
+			-- $shortcode_atts['opt'];
 		}
 
 		$field_class = isset( $shortcode_atts['class'] ) ? $shortcode_atts['class'] : '';
@@ -447,7 +447,7 @@ 
 	 */
 	private function get_field_div_classes() {
 		// Add error class
-		$classes = isset( $this->pass_args['errors'][ 'field' . $this->field_id ] ) ? ' frm_blank_field' : '';
+		$classes = isset( $this->pass_args['errors']['field' . $this->field_id] ) ? ' frm_blank_field' : '';
 
 		// Add label position class
 		$settings = $this->field_obj->display_field_settings();

classes/models/fields/FrmFieldCombo.php

Spacing +13 added lines, -13 removed lines

@@ -61,12 +61,12 @@ 
 			if ( is_array( $sub_field ) ) {
 				$sub_field                 = wp_parse_args( $sub_field, $defaults );
 				$sub_field['name']         = $name;
-				$this->sub_fields[ $name ] = $sub_field;
+				$this->sub_fields[$name] = $sub_field;
 				continue;
 			}
 
 			if ( is_string( $sub_field ) ) {
-				$this->sub_fields[ $name ] = wp_parse_args(
+				$this->sub_fields[$name] = wp_parse_args(
 					array(
 						'name'  => $name,
 						'label' => $sub_field,
@@ -89,7 +89,7 @@ 
 	 */
 	public function set_aria_invalid_error( &$shortcode_atts, $args ) {
 		foreach ( $this->get_sub_fields() as $sub_field ) {
-			$shortcode_atts[ 'aria-invalid-' . $sub_field['name'] ] = isset( $args['errors'][ 'field' . $this->field_id . '-' . $sub_field['name'] ] ) ? 'true' : 'false';
+			$shortcode_atts['aria-invalid-' . $sub_field['name']] = isset( $args['errors']['field' . $this->field_id . '-' . $sub_field['name']] ) ? 'true' : 'false';
 		}
 	}
 
@@ -135,9 +135,9 @@ 
 				}
 
 				if ( is_string( $option ) ) {
-					$extra_options[ $key . '_' . $option ] = '';
+					$extra_options[$key . '_' . $option] = '';
 				} elseif ( ! empty( $option['name'] ) ) {
-					$extra_options[ $key . '_' . $option['name'] ] = '';
+					$extra_options[$key . '_' . $option['name']] = '';
 				}
 			}
 		}
@@ -163,7 +163,7 @@ 
 		foreach ( $this->sub_fields as $name => $sub_field ) {
 			$sub_field['name'] = $name;
 			$wrapper_classes   = 'frm_grid_container frm_sub_field_options frm_sub_field_options-' . $sub_field['name'];
-			if ( ! isset( $processed_sub_fields[ $name ] ) ) {
+			if ( ! isset( $processed_sub_fields[$name] ) ) {
 				// Options for this subfield should be hidden.
 				$wrapper_classes .= ' frm_hidden';
 			}
@@ -193,7 +193,7 @@ 
 			$default_value = array();
 
 			foreach ( $this->sub_fields as $name => $sub_field ) {
-				$default_value[ $name ] = '';
+				$default_value[$name] = '';
 			}
 
 			return $default_value;
@@ -375,8 +375,8 @@ 
 		// Placeholder.
 		if ( in_array( 'placeholder', $sub_field['options'], true ) ) {
 			$placeholders = FrmField::get_option( $field, 'placeholder' );
-			if ( ! empty( $placeholders[ $sub_field['name'] ] ) ) {
-				$field['placeholder'] = $placeholders[ $sub_field['name'] ];
+			if ( ! empty( $placeholders[$sub_field['name']] ) ) {
+				$field['placeholder'] = $placeholders[$sub_field['name']];
 			}
 		}
 
@@ -437,9 +437,9 @@ 
 
 		// Validate not empty.
 		foreach ( $sub_fields as $name => $sub_field ) {
-			if ( empty( $sub_field['optional'] ) && empty( $args['value'][ $name ] ) ) {
-				$errors[ 'field' . $args['id'] . '-' . $name ] = '';
-				$errors[ 'field' . $args['id'] ]               = $blank_msg;
+			if ( empty( $sub_field['optional'] ) && empty( $args['value'][$name] ) ) {
+				$errors['field' . $args['id'] . '-' . $name] = '';
+				$errors['field' . $args['id']]               = $blank_msg;
 			}
 		}
 
@@ -458,7 +458,7 @@ 
 		$field_key  = isset( $this->field->field_key ) ? $this->field->field_key : $this->field['field_key'];
 		$sub_fields = $this->get_processed_sub_fields();
 		foreach ( $sub_fields as $name => $sub_field ) {
-			$headings[ $field_id . '_' . $name ] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
+			$headings[$field_id . '_' . $name] = $field_name . ' (' . $field_key . ') - ' . $sub_field['label'];
 		}
 
 		return $headings;