View GitHub Repository formidable-forms

Schedule Inspection
Subscribe
Completed
Push — master ( c5dfeb...3076e8 )
by Jamie
11:27 queued 05:33
created
Status
Category
Toggle Patches
classes/views/shared/mb_adv_info.php 1 patch
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch 
@@ -42,8 +42,8 @@  discard block
 
 block discarded – undo
42 42
43 43 
 				if ( $f->type == 'data' ) {
44 44 
 					//get all fields from linked form
45 
-                    if ( isset($f->field_options['form_select']) && is_numeric($f->field_options['form_select']) ) {
46 
-                        $linked_form = FrmDb::get_var( $wpdb->prefix .'frm_fields', array( 'id' => $f->field_options['form_select'] ), 'form_id' );
45 
+                    if ( isset( $f->field_options['form_select'] ) && is_numeric( $f->field_options['form_select'] ) ) {
46 
+                        $linked_form = FrmDb::get_var( $wpdb->prefix . 'frm_fields', array( 'id' => $f->field_options['form_select'] ), 'form_id' );
47 47 
                         if ( ! in_array( $linked_form, $linked_forms ) ) {
48 48 
                             $linked_forms[] = $linked_form;
49 49 
 							$linked_fields = FrmField::getAll( array( 'fi.type not' => FrmField::no_save_fields(), 'fi.form_id' => $linked_form ) );
 
@@ -53,14 +53,14 @@  discard block
 
 block discarded – undo
53 53 
                                     FrmAppHelper::insert_opt_html( array( 'id' => $f->id . ' show=' . $linked_field->id, 'key' => $f->field_key . ' show=' . $linked_field->field_key, 'name' => $linked_field->name, 'type' => $linked_field->type ) );
54 54
55 55 
                                     $ldfe = $linked_field->id;
56 
-                                    unset($linked_field);
56 
+                                    unset( $linked_field );
57 57 
                                 }
58 58 
                             }
59 59 
                         }
60 60 
                     }
61 61 
                     $dfe = $f->id;
62 62 
         	    }
63 
-                unset($f);
63 
+                unset( $f );
64 64 
                 }
65 65 
             } ?>
66 66 
         </ul>
 
@@ -84,7 +84,7 @@  discard block
 
 block discarded – undo
84 84 
         </li>
85 85 
         <?php
86 86 
             $col = ( $col == 'one' ) ? 'two' : 'one';
87 
-            unset($skey, $sname);
87 
+            unset( $skey, $sname );
88 88 
         }
89 89 
         ?>
90 90 
         </ul>
 
@@ -106,8 +106,8 @@  discard block
 
 block discarded – undo
106 106 
             ?>
107 107 
                 <li>
108 108 
                     <a href="javascript:void(0)" class="frmids alignright frm_insert_code" data-code="if <?php echo esc_attr( $f->id ) ?>]<?php esc_attr_e( 'Conditional text here', 'formidable' ) ?>[/if <?php echo esc_attr( $f->id ) ?>">[if <?php echo (int) $f->id ?>]</a>
109 
-                	<a href="javascript:void(0)" class="frmkeys alignright frm_insert_code" data-code="if <?php echo esc_attr( $f->field_key ) ?>]something[/if <?php echo esc_attr( $f->field_key ) ?>">[if <?php echo FrmAppHelper::truncate($f->field_key, 10) ?>]</a>
110 
-                	<a href="javascript:void(0)" class="frm_insert_code" data-code="<?php echo esc_attr($f->id) ?>"><?php echo FrmAppHelper::truncate($f->name, 60) ?></a>
109 
+                	<a href="javascript:void(0)" class="frmkeys alignright frm_insert_code" data-code="if <?php echo esc_attr( $f->field_key ) ?>]something[/if <?php echo esc_attr( $f->field_key ) ?>">[if <?php echo FrmAppHelper::truncate( $f->field_key, 10 ) ?>]</a>
110 
+                	<a href="javascript:void(0)" class="frm_insert_code" data-code="<?php echo esc_attr( $f->id ) ?>"><?php echo FrmAppHelper::truncate( $f->name, 60 ) ?></a>
111 111 
                 </li>
112 112 
                 <?php
113 113 
 
@@ -116,7 +116,7 @@  discard block
 
 block discarded – undo
116 116 
                     } else if ( $f->type == 'file' ) {
117 117 
                         $file = $f;
118 118 
                     }
119 
-        		    unset($f);
119 
+        		    unset( $f );
120 120 
 		        }
121 121 
 		    } ?>
122 122 
         </ul>
 
@@ -128,11 +128,11 @@  discard block
 
 block discarded – undo
128 128 
 		foreach ( $cond_shortcodes as $skey => $sname ) {
129 129 
 	    ?>
130 130 
 	    <li class="frm_col_<?php echo esc_attr( $col ) ?>">
131 
-	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="if x <?php echo esc_attr($skey) ?>][/if x"><?php echo esc_html( $sname ) ?></a>
131 
+	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="if x <?php echo esc_attr( $skey ) ?>][/if x"><?php echo esc_html( $sname ) ?></a>
132 132 
 	    </li>
133 133 
 	    <?php
134 134 
 	        $col = ( $col == 'one' ) ? 'two' : 'one';
135 
-	        unset($skey, $sname);
135 
+	        unset( $skey, $sname );
136 136 
 	    }
137 137 
         ?>
138 138 
         </ul>
 
@@ -146,22 +146,22 @@  discard block
 
 block discarded – undo
146 146 
 		foreach ( $adv_shortcodes as $skey => $sname ) {
147 147 
 	    ?>
148 148 
 	    <li class="frm_col_<?php echo esc_attr( $col ) ?>">
149 
-	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code <?php echo is_array( $sname ) ? 'frm_help' : ''; ?>" data-code="x <?php echo esc_attr( $skey ) ?>" <?php echo is_array( $sname ) ? 'title="'. esc_attr( $sname['title'] ) .'"' : ''; ?>><?php echo is_array( $sname ) ? $sname['label'] : $sname; ?></a>
149 
+	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code <?php echo is_array( $sname ) ? 'frm_help' : ''; ?>" data-code="x <?php echo esc_attr( $skey ) ?>" <?php echo is_array( $sname ) ? 'title="' . esc_attr( $sname['title'] ) . '"' : ''; ?>><?php echo is_array( $sname ) ? $sname['label'] : $sname; ?></a>
150 150 
 	    </li>
151 151 
 	    <?php
152 
-	        $col = ($col == 'one') ? 'two' : 'one';
153 
-	        unset($skey, $sname);
152 
+	        $col = ( $col == 'one' ) ? 'two' : 'one';
153 
+	        unset( $skey, $sname );
154 154 
 	    }
155 155 
         ?>
156 
-        <?php if ( isset($file) ) { ?>
156 
+        <?php if ( isset( $file ) ) { ?>
157 157 
         <li class="frm_col_<?php echo esc_attr( $col ) ?>">
158 
-	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr($file->id) ?> show_image=1"><?php _e( 'Show image', 'formidable' ) ?></a>
158 
+	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr( $file->id ) ?> show_image=1"><?php _e( 'Show image', 'formidable' ) ?></a>
159 159 
 	    </li>
160 
-	    <li class="frm_col_<?php echo $col = (($col == 'one') ? 'two' : 'one') ?>">
161 
-	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr($file->id) ?> show=id"><?php _e( 'Image ID', 'formidable' ) ?></a>
160 
+	    <li class="frm_col_<?php echo $col = ( ( $col == 'one' ) ? 'two' : 'one' ) ?>">
161 
+	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr( $file->id ) ?> show=id"><?php _e( 'Image ID', 'formidable' ) ?></a>
162 162 
 	    </li>
163 
-	    <li class="frm_col_<?php echo $col = (($col == 'one') ? 'two' : 'one') ?>">
164 
-	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr($file->id) ?> show_filename=1"><?php _e( 'Image Name', 'formidable' ) ?></a>
163 
+	    <li class="frm_col_<?php echo $col = ( ( $col == 'one' ) ? 'two' : 'one' ) ?>">
164 
+	        <a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr( $file->id ) ?> show_filename=1"><?php _e( 'Image Name', 'formidable' ) ?></a>
165 165 
 	    </li>
166 166 
 	    <?php } ?>
167 167 
         </ul>
 
@@ -169,7 +169,7 @@  discard block
 
 block discarded – undo
169 169 
         <div class="clear"></div>
170 170 
         <?php
171 171
172 
-        if ( isset($uid) && ! empty($user_fields) ) {
172 
+        if ( isset( $uid ) && ! empty( $user_fields ) ) {
173 173 
             $col = 'one'; ?>
174 174 
         <p class="howto"><?php _e( 'Insert user information', 'formidable' ) ?></p>
175 175 
         <ul class="frm_code_list">
 
@@ -178,14 +178,14 @@  discard block
 
 block discarded – undo
178 178 
 				<a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr( $uid->id . ' show="' . $uk . '"' ) ?>"><?php echo esc_html( $uf ) ?></a>
179 179 
     	    </li>
180 180 
         <?php
181 
-            $col = ($col == 'one') ? 'two' : 'one';
182 
-            unset($uf, $uk);
181 
+            $col = ( $col == 'one' ) ? 'two' : 'one';
182 
+            unset( $uf, $uk );
183 183 
         }
184 
-        unset($uid); ?>
184 
+        unset( $uid ); ?>
185 185 
         </ul>
186 186 
         <?php }
187 187
188 
-        if ( isset($repeat_field) ) { ?>
188 
+        if ( isset( $repeat_field ) ) { ?>
189 189 
         <div class="clear"></div>
190 190 
         <p class="howto"><?php _e( 'Repeating field options', 'formidable' ) ?></p>
191 191 
             <ul class="frm_code_list">
 
@@ -196,7 +196,7 @@  discard block
 
 block discarded – undo
196 196 
         <?php
197 197 
         }
198 198
199 
-        if ( isset($dfe) ) { ?>
199 
+        if ( isset( $dfe ) ) { ?>
200 200
201 201 
         <div class="clear"></div>
202 202 
         <p class="howto"><?php _e( 'Dynamic field options', 'formidable' ) ?></p>
 
@@ -204,7 +204,7 @@  discard block
 
 block discarded – undo
204 204 
         	    <li class="frm_col_one">
205 205 
 					<a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr( $dfe . ' show="created-at"' ) ?>"><?php _e( 'Creation Date', 'formidable' ) ?></a>
206 206 
         	    </li>
207 
-        	    <?php if ( isset($ldfe) ) { ?>
207 
+        	    <?php if ( isset( $ldfe ) ) { ?>
208 208 
         	    <li class="frm_col_two">
209 209 
 					<a href="javascript:void(0)" class="frmbutton button frm_insert_code" data-code="<?php echo esc_attr( $dfe . ' show="' . $ldfe . '"' ) ?>"><?php _e( 'Field From Entry', 'formidable' ) ?></a>
210 210 
         	    </li>
 
@@ -216,7 +216,7 @@  discard block
 
 block discarded – undo
216 216
217 217 
     <?php
218 218 
     if ( $settings_tab ) {
219 
-        include(FrmAppHelper::plugin_path() .'/classes/views/frm-forms/mb_html_tab.php');
219 
+        include( FrmAppHelper::plugin_path() . '/classes/views/frm-forms/mb_html_tab.php' );
220 220 
     }
221 221 
     ?>
222 222 
 </div>
Please login to merge, or discard this patch.