Completed
Push — master ( a254d2...75d516 )
by Stephanie
02:52 queued 13s
created
classes/models/FrmForm.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
 		foreach ( $values as $value_key => $value ) {
142 142
 			if ( $value_key && in_array( $value_key, $form_fields ) ) {
143
-				$new_values[ $value_key ] = $value;
143
+				$new_values[$value_key] = $value;
144 144
 			}
145 145
 		}
146 146
 
@@ -210,15 +210,15 @@  discard block
 block discarded – undo
210 210
 		$existing_keys = array_keys( $values['item_meta'] );
211 211
 		foreach ( $all_fields as $fid ) {
212 212
 			if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
213
-				$values['item_meta'][ $fid->id ] = '';
213
+				$values['item_meta'][$fid->id] = '';
214 214
 			}
215
-			$field_array[ $fid->id ] = $fid;
215
+			$field_array[$fid->id] = $fid;
216 216
 		}
217 217
 		unset( $all_fields );
218 218
 
219 219
 		foreach ( $values['item_meta'] as $field_id => $default_value ) {
220
-			if ( isset( $field_array[ $field_id ] ) ) {
221
-				$field = $field_array[ $field_id ];
220
+			if ( isset( $field_array[$field_id] ) ) {
221
+				$field = $field_array[$field_id];
222 222
 			} else {
223 223
 				$field = FrmField::getOne( $field_id );
224 224
 			}
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 				continue;
228 228
 			}
229 229
 
230
-			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] ) );
230
+			$is_settings_page = ( isset( $values['options'] ) || isset( $values['field_options']['custom_html_' . $field_id] ) );
231 231
 			if ( $is_settings_page ) {
232 232
 				self::get_settings_page_html( $values, $field );
233 233
 
@@ -242,15 +242,15 @@  discard block
 block discarded – undo
242 242
 			$update_options = apply_filters( 'frm_field_options_to_update', $update_options );
243 243
 
244 244
 			foreach ( $update_options as $opt => $default ) {
245
-				$field->field_options[ $opt ] = isset( $values['field_options'][ $opt . '_' . $field_id ] ) ? $values['field_options'][ $opt . '_' . $field_id ] : $default;
246
-				self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
245
+				$field->field_options[$opt] = isset( $values['field_options'][$opt . '_' . $field_id] ) ? $values['field_options'][$opt . '_' . $field_id] : $default;
246
+				self::sanitize_field_opt( $opt, $field->field_options[$opt] );
247 247
 			}
248 248
 
249 249
 			$field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
250 250
 
251 251
 			$new_field = array(
252 252
 				'field_options' => $field->field_options,
253
-				'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
253
+				'default_value' => isset( $values['default_value_' . $field_id] ) ? FrmAppHelper::maybe_json_encode( $values['default_value_' . $field_id] ) : '',
254 254
 			);
255 255
 
256 256
 			self::prepare_field_update_values( $field, $values, $new_field );
@@ -283,11 +283,11 @@  discard block
 block discarded – undo
283 283
 	 * Updating the settings page
284 284
 	 */
285 285
 	private static function get_settings_page_html( $values, &$field ) {
286
-		if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
286
+		if ( isset( $values['field_options']['custom_html_' . $field->id] ) ) {
287 287
 			$prev_opts     = array();
288 288
 			$fallback_html = isset( $field->field_options['custom_html'] ) ? $field->field_options['custom_html'] : FrmFieldsHelper::get_default_html( $field->type );
289 289
 
290
-			$field->field_options['custom_html'] = isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ? $values['field_options'][ 'custom_html_' . $field->id ] : $fallback_html;
290
+			$field->field_options['custom_html'] = isset( $values['field_options']['custom_html_' . $field->id] ) ? $values['field_options']['custom_html_' . $field->id] : $fallback_html;
291 291
 		} elseif ( $field->type == 'hidden' || $field->type == 'user_id' ) {
292 292
 			$prev_opts = $field->field_options;
293 293
 		}
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
 		foreach ( $field_cols as $col => $default ) {
314 314
 			$default = ( $default === '' ) ? $field->{$col} : $default;
315 315
 
316
-			$new_field[ $col ] = isset( $values['field_options'][ $col . '_' . $field->id ] ) ? $values['field_options'][ $col . '_' . $field->id ] : $default;
316
+			$new_field[$col] = isset( $values['field_options'][$col . '_' . $field->id] ) ? $values['field_options'][$col . '_' . $field->id] : $default;
317 317
 		}
318 318
 
319 319
 		// Don't save the template option.
@@ -727,8 +727,8 @@  discard block
 block discarded – undo
727 727
 			self::maybe_get_form( $form );
728 728
 		}
729 729
 
730
-		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
731
-			return $frm_vars['form_params'][ $form->id ];
730
+		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][$form->id] ) ) {
731
+			return $frm_vars['form_params'][$form->id];
732 732
 		}
733 733
 
734 734
 		$action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // WPCS: CSRF ok.
@@ -757,15 +757,15 @@  discard block
 block discarded – undo
757 757
 			//if there are two forms on the same page, make sure not to submit both
758 758
 			foreach ( $default_values as $var => $default ) {
759 759
 				if ( $var == 'action' ) {
760
-					$values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
760
+					$values[$var] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
761 761
 				} else {
762
-					$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
762
+					$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
763 763
 				}
764 764
 				unset( $var, $default );
765 765
 			}
766 766
 		} else {
767 767
 			foreach ( $default_values as $var => $default ) {
768
-				$values[ $var ] = $default;
768
+				$values[$var] = $default;
769 769
 				unset( $var, $default );
770 770
 			}
771 771
 		}
@@ -791,7 +791,7 @@  discard block
 block discarded – undo
791 791
 			'sdir'     => '',
792 792
 		);
793 793
 		foreach ( $defaults as $var => $default ) {
794
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
794
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
795 795
 		}
796 796
 
797 797
 		return $values;
@@ -819,7 +819,7 @@  discard block
 block discarded – undo
819 819
 			'keep_post' => '',
820 820
 		);
821 821
 		foreach ( $defaults as $var => $default ) {
822
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
822
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
823 823
 		}
824 824
 
825 825
 		return $values;
@@ -905,7 +905,7 @@  discard block
 block discarded – undo
905 905
 		$form = $atts['form'];
906 906
 		$default = isset( $atts['default'] ) ? $atts['default'] : '';
907 907
 
908
-		return isset( $form->options[ $atts['option'] ] ) ? $form->options[ $atts['option'] ] : $default;
908
+		return isset( $form->options[$atts['option']] ) ? $form->options[$atts['option']] : $default;
909 909
 	}
910 910
 
911 911
 	/**
Please login to merge, or discard this patch.