Completed
Pull Request — master (#184)
by Stephanie
02:20
created
classes/views/inbox/list.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 			</h3>
30 30
 			<span class="frm_inbox_date">
31 31
 				<?php
32
-				if ( ! isset( $message['read'] ) || ! isset( $message['read'][ $user->ID ] ) ) {
32
+				if ( ! isset( $message['read'] ) || ! isset( $message['read'][$user->ID] ) ) {
33 33
 					$inbox->mark_read( $key );
34 34
 					?>
35 35
 					<span class="frm_inbox_unread"></span>
Please login to merge, or discard this patch.
classes/models/FrmInbox.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -132,6 +132,9 @@  discard block
 block discarded – undo
132 132
 		}
133 133
 	}
134 134
 
135
+	/**
136
+	 * @param boolean $messages
137
+	 */
135 138
 	private function filter_messages( &$messages ) {
136 139
 		$user_id = get_current_user_id();
137 140
 		foreach ( $messages as $k => $message ) {
@@ -256,6 +259,7 @@  discard block
 block discarded – undo
256 259
 
257 260
 	/**
258 261
 	 * @since 4.05.02
262
+	 * @param string $key
259 263
 	 */
260 264
 	public function remove( $key ) {
261 265
 		if ( isset( $this->messages[ $key ] ) ) {
Please login to merge, or discard this patch.
Spacing   +27 added lines, -27 removed lines patch added patch discarded remove patch
@@ -75,18 +75,18 @@  discard block
 block discarded – undo
75 75
 	 * @param array $message
76 76
 	 */
77 77
 	public function add_message( $message ) {
78
-		if ( isset( $this->messages[ $message['key'] ] ) && ! isset( $message['force'] ) ) {
78
+		if ( isset( $this->messages[$message['key']] ) && ! isset( $message['force'] ) ) {
79 79
 			// Don't replace messages unless required.
80 80
 			return;
81 81
 		}
82 82
 
83
-		if ( isset( $this->messages[ $message['key'] ] ) ) {
83
+		if ( isset( $this->messages[$message['key']] ) ) {
84 84
 			// Move up and mark as new.
85
-			unset( $this->messages[ $message['key'] ] );
85
+			unset( $this->messages[$message['key']] );
86 86
 		}
87 87
 
88 88
 		$message = $this->fill_message( $message );
89
-		$this->messages[ $message['key'] ] = array(
89
+		$this->messages[$message['key']] = array(
90 90
 			'created' => $message['time'],
91 91
 			'message' => $message['message'],
92 92
 			'subject' => $message['subject'],
@@ -118,11 +118,11 @@  discard block
 block discarded – undo
118 118
 	private function clean_messages() {
119 119
 		$removed  = false;
120 120
 		foreach ( $this->messages as $t => $message ) {
121
-			$read    = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][ get_current_user_id() ] ) && $message['read'][ get_current_user_id() ] < strtotime( '-1 month' );
122
-			$dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][ get_current_user_id() ] ) && $message['dismissed'][ get_current_user_id() ] < strtotime( '-1 week' );
121
+			$read    = isset( $message['read'] ) && ! empty( $message['read'] ) && isset( $message['read'][get_current_user_id()] ) && $message['read'][get_current_user_id()] < strtotime( '-1 month' );
122
+			$dismissed = isset( $message['dismissed'] ) && ! empty( $message['dismissed'] ) && isset( $message['dismissed'][get_current_user_id()] ) && $message['dismissed'][get_current_user_id()] < strtotime( '-1 week' );
123 123
 			$expired = $this->is_expired( $message );
124 124
 			if ( $read || $expired || $dismissed ) {
125
-				unset( $this->messages[ $t ] );
125
+				unset( $this->messages[$t] );
126 126
 				$removed = true;
127 127
 			}
128 128
 		}
@@ -135,11 +135,11 @@  discard block
 block discarded – undo
135 135
 	private function filter_messages( &$messages ) {
136 136
 		$user_id = get_current_user_id();
137 137
 		foreach ( $messages as $k => $message ) {
138
-			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][ $user_id ] );
138
+			$dismissed = isset( $message['dismissed'] ) && isset( $message['dismissed'][$user_id] );
139 139
 			if ( $this->is_expired( $message ) || $dismissed ) {
140
-				unset( $messages[ $k ] );
140
+				unset( $messages[$k] );
141 141
 			} elseif ( ! $this->is_for_user( $message ) ) {
142
-				unset( $messages[ $k ] );
142
+				unset( $messages[$k] );
143 143
 			}
144 144
 		}
145 145
 	}
@@ -171,14 +171,14 @@  discard block
 block discarded – undo
171 171
 	 * @param string $key
172 172
 	 */
173 173
 	public function mark_read( $key ) {
174
-		if ( ! isset( $this->messages[ $key ] ) ) {
174
+		if ( ! isset( $this->messages[$key] ) ) {
175 175
 			return;
176 176
 		}
177 177
 
178
-		if ( ! isset( $this->messages[ $key ]['read'] ) ) {
179
-			$this->messages[ $key ]['read'] = array();
178
+		if ( ! isset( $this->messages[$key]['read'] ) ) {
179
+			$this->messages[$key]['read'] = array();
180 180
 		}
181
-		$this->messages[ $key ]['read'][ get_current_user_id() ] = time();
181
+		$this->messages[$key]['read'][get_current_user_id()] = time();
182 182
 
183 183
 		$this->update_list();
184 184
 	}
@@ -189,9 +189,9 @@  discard block
 block discarded – undo
189 189
 	 * @since 4.05.02
190 190
 	 */
191 191
 	public function mark_unread( $key ) {
192
-		$is_read = isset( $this->messages[ $key ] ) && isset( $this->messages[ $key ]['read'] ) && isset( $this->messages[ $key ]['read'][ get_current_user_id() ] );
192
+		$is_read = isset( $this->messages[$key] ) && isset( $this->messages[$key]['read'] ) && isset( $this->messages[$key]['read'][get_current_user_id()] );
193 193
 		if ( $is_read ) {
194
-			unset( $this->messages[ $key ]['read'][ get_current_user_id() ] );
194
+			unset( $this->messages[$key]['read'][get_current_user_id()] );
195 195
 			$this->update_list();
196 196
 		}
197 197
 	}
@@ -205,14 +205,14 @@  discard block
 block discarded – undo
205 205
 			return;
206 206
 		}
207 207
 
208
-		if ( ! isset( $this->messages[ $key ] ) ) {
208
+		if ( ! isset( $this->messages[$key] ) ) {
209 209
 			return;
210 210
 		}
211 211
 
212
-		if ( ! isset( $this->messages[ $key ]['dismissed'] ) ) {
213
-			$this->messages[ $key ]['dismissed'] = array();
212
+		if ( ! isset( $this->messages[$key]['dismissed'] ) ) {
213
+			$this->messages[$key]['dismissed'] = array();
214 214
 		}
215
-		$this->messages[ $key ]['dismissed'][ get_current_user_id() ] = time();
215
+		$this->messages[$key]['dismissed'][get_current_user_id()] = time();
216 216
 
217 217
 		$this->update_list();
218 218
 	}
@@ -224,11 +224,11 @@  discard block
 block discarded – undo
224 224
 		$user_id = get_current_user_id();
225 225
 		foreach ( $this->messages as $key => $message ) {
226 226
 			if ( ! isset( $message['dismissed'] ) ) {
227
-				$this->messages[ $key ]['dismissed'] = array();
227
+				$this->messages[$key]['dismissed'] = array();
228 228
 			}
229 229
 
230
-			if ( ! isset( $message['dismissed'][ $user_id ] ) ) {
231
-				$this->messages[ $key ]['dismissed'][ $user_id ] = time();
230
+			if ( ! isset( $message['dismissed'][$user_id] ) ) {
231
+				$this->messages[$key]['dismissed'][$user_id] = time();
232 232
 			}
233 233
 		}
234 234
 		$this->update_list();
@@ -238,8 +238,8 @@  discard block
 block discarded – undo
238 238
 		$messages = $this->get_messages( 'filter' );
239 239
 		$user_id  = get_current_user_id();
240 240
 		foreach ( $messages as $t => $message ) {
241
-			if ( isset( $message['read'] ) && isset( $message['read'][ $user_id ] ) ) {
242
-				unset( $messages[ $t ] );
241
+			if ( isset( $message['read'] ) && isset( $message['read'][$user_id] ) ) {
242
+				unset( $messages[$t] );
243 243
 			}
244 244
 		}
245 245
 		return $messages;
@@ -258,8 +258,8 @@  discard block
 block discarded – undo
258 258
 	 * @since 4.05.02
259 259
 	 */
260 260
 	public function remove( $key ) {
261
-		if ( isset( $this->messages[ $key ] ) ) {
262
-			unset( $this->messages[ $key ] );
261
+		if ( isset( $this->messages[$key] ) ) {
262
+			unset( $this->messages[$key] );
263 263
 			$this->update_list();
264 264
 		}
265 265
 	}
Please login to merge, or discard this patch.