Strategy11 / formidable-forms

classes/controllers/FrmFormsController.php

Spacing +26 added lines, -26 removed lines

@@ -546,11 +546,11 @@ 
 			),
 		);
 
-		if ( ! isset( $available_status[ $status ] ) ) {
+		if ( ! isset( $available_status[$status] ) ) {
 			return;
 		}
 
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
 
 		$params = FrmForm::list_page_params();
 
@@ -558,7 +558,7 @@ 
 		check_admin_referer( $status . '_form_' . $params['id'] );
 
 		$count = 0;
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
 			$count ++;
 		}
 
@@ -575,7 +575,7 @@ 
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 		$available_status['trash']['message']   = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
 
-		$message = $available_status[ $status ]['message'];
+		$message = $available_status[$status]['message'];
 
 		self::display_forms_list( $params, $message );
 	}
@@ -596,7 +596,7 @@ 
 				'type'  => 'request',
 			)
 		);
-		$message      = sprintf(
+		$message = sprintf(
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
 			$count,
@@ -1145,7 +1145,7 @@ 
 
 		foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
 			if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
-				unset( $sections[ $feature ] );
+				unset( $sections[$feature] );
 			}
 		}
 
@@ -1178,7 +1178,7 @@ 
 				$section['id'] = $section['anchor'];
 			}
 
-			$sections[ $key ] = $section;
+			$sections[$key] = $section;
 		}
 
 		return $sections;
@@ -1296,7 +1296,7 @@ 
 		if ( ! empty( $user_fields ) ) {
 			$user_helpers = array();
 			foreach ( $user_fields as $uk => $uf ) {
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
 				unset( $uk, $uf );
 			}
 
@@ -1435,7 +1435,7 @@ 
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
 			$frm_vars['js_validate_forms'] = array();
 		}
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
+		$frm_vars['js_validate_forms'][$form->id] = $form;
 	}
 
 	public static function get_email_html() {
@@ -1594,7 +1594,7 @@ 
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
 			} else {
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
-				$action = $vars[ $action ];
+				$action = $vars[$action];
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1753,7 +1753,7 @@ 
 		$actions = array();
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
 			if ( is_object( $form ) ) {
-				$actions[ $form->id ] = $form->name;
+				$actions[$form->id] = $form->name;
 			}
 			unset( $form );
 		}
@@ -1997,8 +1997,8 @@ 
 	private static function get_saved_errors( $form, $params ) {
 		global $frm_vars;
 
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
 		} else {
 			$errors = array();
 		}
@@ -2020,7 +2020,7 @@ 
 	public static function just_created_entry( $form_id ) {
 		global $frm_vars;
 
-		return ( isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
+		return ( isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
 	}
 
 	/**
@@ -2040,7 +2040,7 @@ 
 	private static function get_confirmation_method( $atts ) {
 		$action = FrmOnSubmitHelper::current_event( $atts );
 		$opt    = 'update' === $action ? 'edit_action' : 'success_action';
-		$method = ( isset( $atts['form']->options[ $opt ] ) && ! empty( $atts['form']->options[ $opt ] ) ) ? $atts['form']->options[ $opt ] : 'message';
+		$method = ( isset( $atts['form']->options[$opt] ) && ! empty( $atts['form']->options[$opt] ) ) ? $atts['form']->options[$opt] : 'message';
 
 		if ( ! empty( $atts['entry_id'] ) ) {
 			$met_actions = self::get_met_on_submit_actions( $atts, $action );
@@ -2061,7 +2061,7 @@ 
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
 		if ( ! isset( $params['id'] ) ) {
 			global $frm_vars;
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
 		}
 
 		$conf_method = self::get_confirmation_method(
@@ -2143,7 +2143,7 @@ 
 		$args['success_opt'] = $opt;
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
 
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
 			self::load_page_after_submit( $args );
 		} elseif ( $args['conf_method'] === 'redirect' ) {
 			self::redirect_after_submit( $args );
@@ -2167,7 +2167,7 @@ 
 		}
 
 		// If a redirect action has already opened the URL in a new tab, we show the default message in the currect tab.
-		if ( ! empty( self::$redirected_in_new_tab[ $args['form']->id ] ) ) {
+		if ( ! empty( self::$redirected_in_new_tab[$args['form']->id] ) ) {
 			return array( FrmOnSubmitHelper::get_fallback_action_after_open_in_new_tab( $event ) );
 		}
 
@@ -2354,7 +2354,7 @@ 
 
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
 
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
 
 		/**
 		 * Filters the run success action args.
@@ -2374,8 +2374,8 @@ 
 	private static function load_page_after_submit( $args ) {
 		global $post;
 		$opt = $args['success_opt'];
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
 			$old_post = $post;
 			$post     = $page;
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2405,7 +2405,7 @@ 
 		add_filter( 'frm_use_wpautop', '__return_false' );
 
 		$opt         = $args['success_opt'];
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
 		$success_url = do_shortcode( $success_url );
 
@@ -2425,7 +2425,7 @@ 
 		if ( ! headers_sent() && empty( $args['force_delay_redirect'] ) ) { // Not AJAX submit, no headers sent, and there is just one Redirect action runs.
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
-				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
+				self::$redirected_in_new_tab[$args['form']->id] = 1;
 				return;
 			}
 
@@ -2685,7 +2685,7 @@ 
 			'description' => false,
 			'reset'       => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -2723,7 +2723,7 @@ 
 		$opt          = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
 
 		if ( $entry_id && is_numeric( $entry_id ) ) {
-			$message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
+			$message = isset( $form->options[$opt . '_msg'] ) ? $form->options[$opt . '_msg'] : $frm_settings->success_msg;
 			$class   = 'frm_message';
 		} else {
 			$message = $frm_settings->failed_msg;
@@ -2947,7 +2947,7 @@ 
 
 		check_ajax_referer( 'frm_ajax', 'nonce' );
 
-		$html             = FrmAppHelper::clip(
+		$html = FrmAppHelper::clip(
 			function() {
 				FrmAppHelper::maybe_autocomplete_pages_options(
 					array(

classes/controllers/FrmAppController.php

Spacing +1 added lines, -1 removed lines

@@ -388,7 +388,7 @@
 	 * @return void
 	 */
 	public static function api_email_form( $form_key, $title, $description ) {
-		$user        = wp_get_current_user();
+		$user = wp_get_current_user();
 		$args = array(
 			'api_url'     => 'https://sandbox.formidableforms.com/api/wp-json/frm/v2/forms/' . $form_key . '?return=html&exclude_script=jquery&exclude_style=formidable-css',
 			'title'       => $title,

classes/helpers/FrmTipsHelper.php

Spacing +4 added lines, -4 removed lines

@@ -45,7 +45,7 @@ 
 			'page'  => '',
 			'class' => 'frm-mt-0',
 		);
-		$tip      = array_merge( $defaults, $tip );
+		$tip = array_merge( $defaults, $tip );
 
 		if ( isset( $tip['link'] ) && ! isset( $tip['link']['medium'] ) ) {
 			$tip['link']['medium'] = 'tip';
@@ -372,7 +372,7 @@ 
 	 * @return array
 	 */
 	public static function get_banner_tip() {
-		$tips       = array(
+		$tips = array(
 			array(
 				'link' => array(
 					'medium'  => 'banner',
@@ -399,7 +399,7 @@ 
 			),
 		);
 		$random     = rand( 0, count( $tips ) - 1 );
-		$tip        = $tips[ $random ];
+		$tip        = $tips[$random];
 		$tip['num'] = $random;
 
 		return $tip;
@@ -408,7 +408,7 @@ 
 	public static function get_random_tip( $tips ) {
 		$random = rand( 0, count( $tips ) - 1 );
 
-		return $tips[ $random ];
+		return $tips[$random];
 	}
 
 	/**

classes/helpers/FrmFormsHelper.php

Spacing +23 added lines, -23 removed lines

@@ -28,7 +28,7 @@ 
 			'class'        => '',
 			'inc_children' => 'exclude',
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		if ( ! $args['field_id'] ) {
 			$args['field_id'] = $field_name;
@@ -70,7 +70,7 @@ 
 	 */
 	public static function add_html_attr( $class, $param, &$add_html ) {
 		if ( ! empty( $class ) ) {
-			$add_html[ $param ] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
+			$add_html[$param] = sanitize_title( $param ) . '="' . esc_attr( trim( sanitize_text_field( $class ) ) ) . '"';
 		}
 	}
 
@@ -293,8 +293,8 @@ 
 			'description' => '',
 		);
 		foreach ( $defaults as $var => $default ) {
-			if ( ! isset( $values[ $var ] ) ) {
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			if ( ! isset( $values[$var] ) ) {
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 			}
 		}
 
@@ -309,8 +309,8 @@ 
 			'parent_form_id' => 0,
 		);
 		foreach ( $defaults as $var => $default ) {
-			if ( ! isset( $values[ $var ] ) ) {
-				$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			if ( ! isset( $values[$var] ) ) {
+				$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 			}
 		}
 		unset( $defaults );
@@ -347,16 +347,16 @@ 
 		$defaults = self::get_default_opts();
 		foreach ( $defaults as $var => $default ) {
 			if ( is_array( $default ) ) {
-				if ( ! isset( $values[ $var ] ) ) {
-					$values[ $var ] = ( $record && isset( $record->options[ $var ] ) ) ? $record->options[ $var ] : array();
+				if ( ! isset( $values[$var] ) ) {
+					$values[$var] = ( $record && isset( $record->options[$var] ) ) ? $record->options[$var] : array();
 				}
 
 				foreach ( $default as $k => $v ) {
-					$values[ $var ][ $k ] = ( $post_values && isset( $post_values[ $var ][ $k ] ) ) ? $post_values[ $var ][ $k ] : ( ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) ) ? $record->options[ $var ][ $k ] : $v );
+					$values[$var][$k] = ( $post_values && isset( $post_values[$var][$k] ) ) ? $post_values[$var][$k] : ( ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) ) ? $record->options[$var][$k] : $v );
 
 					if ( is_array( $v ) ) {
 						foreach ( $v as $k1 => $v1 ) {
-							$values[ $var ][ $k ][ $k1 ] = ( $post_values && isset( $post_values[ $var ][ $k ][ $k1 ] ) ) ? $post_values[ $var ][ $k ][ $k1 ] : ( ( $record && isset( $record->options[ $var ] ) && isset( $record->options[ $var ][ $k ] ) && isset( $record->options[ $var ][ $k ][ $k1 ] ) ) ? $record->options[ $var ][ $k ][ $k1 ] : $v1 );
+							$values[$var][$k][$k1] = ( $post_values && isset( $post_values[$var][$k][$k1] ) ) ? $post_values[$var][$k][$k1] : ( ( $record && isset( $record->options[$var] ) && isset( $record->options[$var][$k] ) && isset( $record->options[$var][$k][$k1] ) ) ? $record->options[$var][$k][$k1] : $v1 );
 							unset( $k1, $v1 );
 						}
 					}
@@ -364,7 +364,7 @@ 
 					unset( $k, $v );
 				}
 			} else {
-				$values[ $var ] = ( $post_values && isset( $post_values['options'][ $var ] ) ) ? $post_values['options'][ $var ] : ( ( $record && isset( $record->options[ $var ] ) ) ? $record->options[ $var ] : $default );
+				$values[$var] = ( $post_values && isset( $post_values['options'][$var] ) ) ? $post_values['options'][$var] : ( ( $record && isset( $record->options[$var] ) ) ? $record->options[$var] : $default );
 			}
 
 			unset( $var, $default );
@@ -410,7 +410,7 @@ 
 	public static function fill_form_options( &$options, $values ) {
 		$defaults = self::get_default_opts();
 		foreach ( $defaults as $var => $default ) {
-			$options[ $var ] = isset( $values['options'][ $var ] ) ? $values['options'][ $var ] : $default;
+			$options[$var] = isset( $values['options'][$var] ) ? $values['options'][$var] : $default;
 			unset( $var, $default );
 		}
 	}
@@ -585,7 +585,7 @@ 
 	public static function insert_opt_html( $args ) {
 		$class  = isset( $args['class'] ) ? $args['class'] : '';
 		$fields = FrmField::all_field_selection();
-		$field  = isset( $fields[ $args['type'] ] ) ? $fields[ $args['type'] ] : array();
+		$field  = isset( $fields[$args['type']] ) ? $fields[$args['type']] : array();
 
 		self::prepare_field_type( $field );
 
@@ -741,7 +741,7 @@ 
 			FrmField::update( $field->id, array( 'field_order' => $field->field_order + 2 ) );
 		}
 
-		$add_order    += 2;
+		$add_order += 2;
 		$open         = false;
 		$reset_fields = true;
 	}
@@ -1148,10 +1148,10 @@ 
 				$link .= ' onclick="return confirm(\'' . esc_attr( $link_details['confirm'] ) . '\')"';
 			}
 
-			$label = ( isset( $link_details[ $length ] ) ? $link_details[ $length ] : $link_details['label'] );
-			if ( $length == 'icon' && isset( $link_details[ $length ] ) ) {
+			$label = ( isset( $link_details[$length] ) ? $link_details[$length] : $link_details['label'] );
+			if ( $length == 'icon' && isset( $link_details[$length] ) ) {
 				$label = '<span class="' . $label . '" title="' . esc_attr( $link_details['label'] ) . '" aria-hidden="true"></span>';
-				$link  .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
+				$link .= ' aria-label="' . esc_attr( $link_details['label'] ) . '"';
 			}
 
 			$link .= '>' . $label . '</a>';
@@ -1296,7 +1296,7 @@ 
 			$status = 'publish';
 		}
 
-		$name = $nice_names[ $status ];
+		$name = $nice_names[$status];
 
 		return $name;
 	}
@@ -1360,7 +1360,7 @@ 
 		$icon = $icons[''];
 		if ( count( $categories ) === 1 ) {
 			$category = reset( $categories );
-			$icon     = isset( $icons[ $category ] ) ? $icons[ $category ] : $icon;
+			$icon     = isset( $icons[$category] ) ? $icons[$category] : $icon;
 		} elseif ( ! empty( $categories ) ) {
 			$icons = array_intersect_key( $icons, array_flip( $categories ) );
 			$icon = reset( $icons );
@@ -1498,7 +1498,7 @@ 
 
 		foreach ( $item['categories'] as $k => $category ) {
 			if ( in_array( $category, $plans, true ) ) {
-				unset( $item['categories'][ $k ] );
+				unset( $item['categories'][$k] );
 
 				if ( in_array( $category, array( 'Creator', 'Personal' ), true ) ) {
 					// Show the current package name.
@@ -1700,9 +1700,9 @@ 
 		}
 
 		foreach ( $shortcodes[0] as $key => $shortcode ) {
-			$options = trim( $shortcodes[3][ $key ] );
+			$options = trim( $shortcodes[3][$key] );
 
-			if ( in_array( $shortcodes[1][ $key ], array( 'if ' ), true ) ) {
+			if ( in_array( $shortcodes[1][$key], array( 'if ' ), true ) ) {
 				// Skip if shortcodes.
 				continue;
 			}
@@ -1712,7 +1712,7 @@ 
 				continue;
 			}
 
-			$new_shortcode = '[' . $shortcodes[2][ $key ];
+			$new_shortcode = '[' . $shortcodes[2][$key];
 			if ( $options ) {
 				$new_shortcode .= ' ' . $options;
 			}

classes/controllers/FrmFormTemplatesController.php

Spacing +12 added lines, -12 removed lines

@@ -329,11 +329,11 @@ 
 
 		// Perform add or remove operation.
 		if ( 'add' === $operation ) {
-			self::$favorite_templates[ $key ][] = $template_id;
+			self::$favorite_templates[$key][] = $template_id;
 		} elseif ( 'remove' === $operation ) {
-			$position = array_search( $template_id, self::$favorite_templates[ $key ], true );
+			$position = array_search( $template_id, self::$favorite_templates[$key], true );
 			if ( $position !== false ) {
-				unset( self::$favorite_templates[ $key ][ $position ] );
+				unset( self::$favorite_templates[$key][$position] );
 			}
 		}
 
@@ -462,7 +462,7 @@ 
 		foreach ( self::$templates as $key => &$template ) {
 			// Skip the template if the categories are not set.
 			if ( ! isset( $template['categories'] ) ) {
-				unset( self::$templates[ $key ] );
+				unset( self::$templates[$key] );
 				continue;
 			}
 
@@ -476,14 +476,14 @@ 
 				// Add the slug to the new array.
 				$template['category_slugs'][] = $category_slug;
 
-				if ( ! isset( self::$categories[ $category_slug ] ) ) {
-					self::$categories[ $category_slug ] = array(
+				if ( ! isset( self::$categories[$category_slug] ) ) {
+					self::$categories[$category_slug] = array(
 						'name'  => $category,
 						'count' => 0,
 					);
 				}
 
-				self::$categories[ $category_slug ]['count']++;
+				self::$categories[$category_slug]['count'] ++;
 			}
 
 			// Mark the template as favorite if it's in the favorite templates list.
@@ -496,7 +496,7 @@ 
 		$redundant_cats = array_merge( array( 'PayPal', 'Stripe', 'Twilio' ), FrmFormsHelper::ignore_template_categories() );
 		foreach ( $redundant_cats as $redundant_cat ) {
 			$category_slug = sanitize_title( $redundant_cat );
-			unset( self::$categories[ $category_slug ] );
+			unset( self::$categories[$category_slug] );
 		}
 
 		// Sort the categories by keys alphabetically.
@@ -520,7 +520,7 @@ 
 				'count' => 0, // Assigned via JavaScript.
 			);
 		}
-		$special_categories['all-templates']  = array(
+		$special_categories['all-templates'] = array(
 			'name'  => __( 'All Templates', 'formidable' ),
 			'count' => count( self::$templates ),
 		);
@@ -547,9 +547,9 @@ 
 	 */
 	private static function assign_featured_templates() {
 		foreach ( self::FEATURED_TEMPLATES_KEYS as $key ) {
-			if ( isset( self::$templates[ $key ] ) ) {
-				self::$templates[ $key ]['is_featured'] = true;
-				self::$featured_templates[]             = self::$templates[ $key ];
+			if ( isset( self::$templates[$key] ) ) {
+				self::$templates[$key]['is_featured'] = true;
+				self::$featured_templates[]             = self::$templates[$key];
 			}
 		}
 	}