Strategy11 / formidable-forms

classes/models/fields/FrmFieldUrl.php

Spacing +3 added lines, -3 removed lines

@@ -58,7 +58,7 @@ 
 			'sep'  => ', ',
 			'html' => false,
 		);
-		$atts     = wp_parse_args( $atts, $defaults );
+		$atts = wp_parse_args( $atts, $defaults );
 
 		if ( $atts['html'] ) {
 			$atts['sep'] = ' ';
@@ -81,9 +81,9 @@ 
 
 		// validate the url format
 		if ( $value && ! preg_match( '/^http(s)?:\/\/(?:localhost|(?:[\da-z\.-]+\.[\da-z\.-]+))/i', $value ) ) {
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
 		} elseif ( $this->field->required == '1' && ! $value ) { // phpcs:ignore Universal.Operators.StrictComparisons
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'blank' );
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $this->field, 'blank' );
 		}
 
 		return $errors;

Braces +2 added lines, -1 removed lines

@@ -82,7 +82,8 @@
 		// validate the url format
 		if ( $value && ! preg_match( '/^http(s)?:\/\/(?:localhost|(?:[\da-z\.-]+\.[\da-z\.-]+))/i', $value ) ) {
 			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'invalid' );
-		} elseif ( $this->field->required == '1' && ! $value ) { // phpcs:ignore Universal.Operators.StrictComparisons
+		} elseif ( $this->field->required == '1' && ! $value ) {
+// phpcs:ignore Universal.Operators.StrictComparisons
 			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $this->field, 'blank' );
 		}
 

classes/controllers/FrmEntriesController.php

Braces +2 added lines, -1 removed lines

@@ -750,7 +750,8 @@
 	public static function process_entry( $errors = '', $ajax = false ) {
 		$form_id = FrmAppHelper::get_post_param( 'form_id', '', 'absint' );
 
-		if ( FrmAppHelper::is_admin() || empty( $_POST ) || ! $form_id || ! isset( $_POST['item_key'] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmAppHelper::is_admin() || empty( $_POST ) || ! $form_id || ! isset( $_POST['item_key'] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			return;
 		}
 

phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantEmptyOnAssignedVariableSniff.php

Spacing +36 added lines, -36 removed lines

@@ -63,21 +63,21 @@ 
 		// Find the opening parenthesis after empty.
 		$openParen = $phpcsFile->findNext( T_WHITESPACE, $stackPtr + 1, null, true );
 
-		if ( false === $openParen || $tokens[ $openParen ]['code'] !== T_OPEN_PARENTHESIS ) {
+		if ( false === $openParen || $tokens[$openParen]['code'] !== T_OPEN_PARENTHESIS ) {
 			return;
 		}
 
 		// Find the variable inside empty().
 		$variablePtr = $phpcsFile->findNext( T_WHITESPACE, $openParen + 1, null, true );
 
-		if ( false === $variablePtr || $tokens[ $variablePtr ]['code'] !== T_VARIABLE ) {
+		if ( false === $variablePtr || $tokens[$variablePtr]['code'] !== T_VARIABLE ) {
 			return;
 		}
 
-		$variableName = $tokens[ $variablePtr ]['content'];
+		$variableName = $tokens[$variablePtr]['content'];
 
 		// Check if there's anything else inside the empty() call (like array access).
-		$closeParen = $tokens[ $openParen ]['parenthesis_closer'];
+		$closeParen = $tokens[$openParen]['parenthesis_closer'];
 		$nextToken  = $phpcsFile->findNext( T_WHITESPACE, $variablePtr + 1, $closeParen, true );
 
 		if ( false !== $nextToken ) {
@@ -100,7 +100,7 @@ 
 
 		// Check if there's a boolean NOT before empty.
 		$prevToken = $phpcsFile->findPrevious( T_WHITESPACE, $stackPtr - 1, null, true );
-		$isNegated = ( false !== $prevToken && $tokens[ $prevToken ]['code'] === T_BOOLEAN_NOT );
+		$isNegated = ( false !== $prevToken && $tokens[$prevToken]['code'] === T_BOOLEAN_NOT );
 
 		// Determine the suggested replacement.
 		if ( $isNegated ) {
@@ -126,8 +126,8 @@ 
 				$phpcsFile->fixer->replaceToken( $prevToken, '' );
 
 				// Remove any whitespace between "!" and "empty".
-				for ( $i = $prevToken + 1; $i < $stackPtr; $i++ ) {
-					if ( $tokens[ $i ]['code'] === T_WHITESPACE ) {
+				for ( $i = $prevToken + 1; $i < $stackPtr; $i ++ ) {
+					if ( $tokens[$i]['code'] === T_WHITESPACE ) {
 						$phpcsFile->fixer->replaceToken( $i, '' );
 					}
 				}
@@ -137,8 +137,8 @@ 
 			$phpcsFile->fixer->replaceToken( $stackPtr, '' );
 
 			// Remove whitespace after empty.
-			for ( $i = $stackPtr + 1; $i < $openParen; $i++ ) {
-				if ( $tokens[ $i ]['code'] === T_WHITESPACE ) {
+			for ( $i = $stackPtr + 1; $i < $openParen; $i ++ ) {
+				if ( $tokens[$i]['code'] === T_WHITESPACE ) {
 					$phpcsFile->fixer->replaceToken( $i, '' );
 				}
 			}
@@ -149,9 +149,9 @@ 
 			// Remove whitespace after opening paren.
 			$nextAfterOpen = $openParen + 1;
 
-			while ( $nextAfterOpen < $variablePtr && $tokens[ $nextAfterOpen ]['code'] === T_WHITESPACE ) {
+			while ( $nextAfterOpen < $variablePtr && $tokens[$nextAfterOpen]['code'] === T_WHITESPACE ) {
 				$phpcsFile->fixer->replaceToken( $nextAfterOpen, '' );
-				++$nextAfterOpen;
+				++ $nextAfterOpen;
 			}
 
 			// Keep the variable, but add "! " prefix if not negated.
@@ -162,9 +162,9 @@ 
 			// Remove whitespace before closing paren.
 			$prevBeforeClose = $closeParen - 1;
 
-			while ( $prevBeforeClose > $variablePtr && $tokens[ $prevBeforeClose ]['code'] === T_WHITESPACE ) {
+			while ( $prevBeforeClose > $variablePtr && $tokens[$prevBeforeClose]['code'] === T_WHITESPACE ) {
 				$phpcsFile->fixer->replaceToken( $prevBeforeClose, '' );
-				--$prevBeforeClose;
+				-- $prevBeforeClose;
 			}
 
 			// Replace closing paren.
@@ -211,8 +211,8 @@ 
 		$tokens = $phpcsFile->getTokens();
 
 		// Find the opening parenthesis that contains this empty() call.
-		for ( $i = $stackPtr - 1; $i >= 0; $i-- ) {
-			$code = $tokens[ $i ]['code'];
+		for ( $i = $stackPtr - 1; $i >= 0; $i -- ) {
+			$code = $tokens[$i]['code'];
 
 			// Skip whitespace and the "!" operator.
 			if ( $code === T_WHITESPACE || $code === T_BOOLEAN_NOT ) {
@@ -224,7 +224,7 @@ 
 				$beforeParen = $phpcsFile->findPrevious( T_WHITESPACE, $i - 1, null, true );
 
 				if ( false !== $beforeParen ) {
-					$beforeCode = $tokens[ $beforeParen ]['code'];
+					$beforeCode = $tokens[$beforeParen]['code'];
 
 					if ( $beforeCode === T_IF || $beforeCode === T_ELSEIF ) {
 						return $beforeParen;
@@ -257,16 +257,16 @@ 
 		// Find the end of the empty() call.
 		$openParen = $phpcsFile->findNext( T_WHITESPACE, $stackPtr + 1, null, true );
 
-		if ( false === $openParen || $tokens[ $openParen ]['code'] !== T_OPEN_PARENTHESIS ) {
+		if ( false === $openParen || $tokens[$openParen]['code'] !== T_OPEN_PARENTHESIS ) {
 			return false;
 		}
 
-		$closeParen = $tokens[ $openParen ]['parenthesis_closer'];
+		$closeParen = $tokens[$openParen]['parenthesis_closer'];
 
 		// Look for && or || after the empty() call.
 		$nextToken = $phpcsFile->findNext( T_WHITESPACE, $closeParen + 1, null, true );
 
-		if ( false !== $nextToken && in_array( $tokens[ $nextToken ]['code'], array( T_BOOLEAN_AND, T_BOOLEAN_OR ), true ) ) {
+		if ( false !== $nextToken && in_array( $tokens[$nextToken]['code'], array( T_BOOLEAN_AND, T_BOOLEAN_OR ), true ) ) {
 			// Find the statement start (return, etc.).
 			return $this->findStatementStart( $phpcsFile, $stackPtr );
 		}
@@ -275,11 +275,11 @@ 
 		$searchFrom = $stackPtr;
 		$prevToken  = $phpcsFile->findPrevious( T_WHITESPACE, $searchFrom - 1, null, true );
 
-		if ( false !== $prevToken && $tokens[ $prevToken ]['code'] === T_BOOLEAN_NOT ) {
+		if ( false !== $prevToken && $tokens[$prevToken]['code'] === T_BOOLEAN_NOT ) {
 			$prevToken = $phpcsFile->findPrevious( T_WHITESPACE, $prevToken - 1, null, true );
 		}
 
-		if ( false !== $prevToken && in_array( $tokens[ $prevToken ]['code'], array( T_BOOLEAN_AND, T_BOOLEAN_OR ), true ) ) {
+		if ( false !== $prevToken && in_array( $tokens[$prevToken]['code'], array( T_BOOLEAN_AND, T_BOOLEAN_OR ), true ) ) {
 			return $this->findStatementStart( $phpcsFile, $stackPtr );
 		}
 
@@ -297,8 +297,8 @@ 
 	private function findStatementStart( File $phpcsFile, $stackPtr ) {
 		$tokens = $phpcsFile->getTokens();
 
-		for ( $i = $stackPtr - 1; $i >= 0; $i-- ) {
-			$code = $tokens[ $i ]['code'];
+		for ( $i = $stackPtr - 1; $i >= 0; $i -- ) {
+			$code = $tokens[$i]['code'];
 
 			// Found a statement start.
 			if ( in_array( $code, array( T_RETURN, T_ECHO, T_IF, T_ELSEIF ), true ) ) {
@@ -330,10 +330,10 @@ 
 	private function findContainingFunction( File $phpcsFile, $stackPtr ) {
 		$tokens = $phpcsFile->getTokens();
 
-		for ( $i = $stackPtr - 1; $i >= 0; $i-- ) {
-			if ( $tokens[ $i ]['code'] === T_FUNCTION || $tokens[ $i ]['code'] === T_CLOSURE ) {
-				if ( isset( $tokens[ $i ]['scope_opener'], $tokens[ $i ]['scope_closer'] ) ) {
-					if ( $stackPtr > $tokens[ $i ]['scope_opener'] && $stackPtr < $tokens[ $i ]['scope_closer'] ) {
+		for ( $i = $stackPtr - 1; $i >= 0; $i -- ) {
+			if ( $tokens[$i]['code'] === T_FUNCTION || $tokens[$i]['code'] === T_CLOSURE ) {
+				if ( isset( $tokens[$i]['scope_opener'], $tokens[$i]['scope_closer'] ) ) {
+					if ( $stackPtr > $tokens[$i]['scope_opener'] && $stackPtr < $tokens[$i]['scope_closer'] ) {
 						return $i;
 					}
 				}
@@ -358,31 +358,31 @@ 
 	 */
 	private function wasVariableUnconditionallyAssigned( File $phpcsFile, $functionToken, $statementToken, $variableName ) {
 		$tokens      = $phpcsFile->getTokens();
-		$scopeOpener = $tokens[ $functionToken ]['scope_opener'];
+		$scopeOpener = $tokens[$functionToken]['scope_opener'];
 
 		// The statement's level is what we compare against.
-		$statementLevel = $tokens[ $statementToken ]['level'];
+		$statementLevel = $tokens[$statementToken]['level'];
 
 		// Search from the function start to the statement.
-		for ( $i = $scopeOpener + 1; $i < $statementToken; $i++ ) {
-			if ( $tokens[ $i ]['code'] !== T_VARIABLE ) {
+		for ( $i = $scopeOpener + 1; $i < $statementToken; $i ++ ) {
+			if ( $tokens[$i]['code'] !== T_VARIABLE ) {
 				continue;
 			}
 
-			if ( $tokens[ $i ]['content'] !== $variableName ) {
+			if ( $tokens[$i]['content'] !== $variableName ) {
 				continue;
 			}
 
 			// Check if this variable is being assigned (has = after it).
 			$nextToken = $phpcsFile->findNext( T_WHITESPACE, $i + 1, null, true );
 
-			if ( false === $nextToken || $tokens[ $nextToken ]['code'] !== T_EQUAL ) {
+			if ( false === $nextToken || $tokens[$nextToken]['code'] !== T_EQUAL ) {
 				continue;
 			}
 
 			// Check if the assignment is at the same scope level as the statement.
 			// This ensures the variable was assigned unconditionally before the statement.
-			$assignmentLevel = $tokens[ $i ]['level'];
+			$assignmentLevel = $tokens[$i]['level'];
 
 			if ( $assignmentLevel === $statementLevel ) {
 				return true;
@@ -403,8 +403,8 @@ 
 	private function findContainingIf( File $phpcsFile, $stackPtr ) {
 		$tokens = $phpcsFile->getTokens();
 
-		for ( $i = $stackPtr - 1; $i >= 0; $i-- ) {
-			$code = $tokens[ $i ]['code'];
+		for ( $i = $stackPtr - 1; $i >= 0; $i -- ) {
+			$code = $tokens[$i]['code'];
 
 			if ( $code === T_IF || $code === T_ELSEIF ) {
 				return $i;