Strategy11 / formidable-forms

classes/models/fields/FrmFieldUserID.php

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
 	protected function get_field_value( $args ) {
 		$user_ID      = get_current_user_id();
 		$user_ID      = $user_ID ? $user_ID : '';
-		$posted_value = FrmAppHelper::is_admin() && $_POST && isset( $_POST['item_meta'][ $this->field['id'] ] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		$posted_value = FrmAppHelper::is_admin() && $_POST && isset( $_POST['item_meta'][$this->field['id']] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 		$action       = $args['action'] ?? $args['form_action'] ?? '';
 		$updating     = $action === 'update';
 		return is_numeric( $this->field['value'] ) || $posted_value || $updating ? $this->field['value'] : $user_ID;

classes/models/fields/FrmFieldCaptcha.php

Spacing +6 added lines, -6 removed lines

@@ -296,8 +296,8 @@ 
 
 		if ( is_wp_error( $resp ) ) {
 			$error_string                     = $resp->get_error_message();
-			$errors[ 'field' . $args['id'] ]  = __( 'There was a problem verifying your captcha', 'formidable' );
-			$errors[ 'field' . $args['id'] ] .= ' ' . $error_string;
+			$errors['field' . $args['id']]  = __( 'There was a problem verifying your captcha', 'formidable' );
+			$errors['field' . $args['id']] .= ' ' . $error_string;
 			return $errors;
 		}
 
@@ -325,7 +325,7 @@ 
 			if ( $invalid_message === __( 'The reCAPTCHA was not entered correctly', 'formidable' ) ) {
 				$invalid_message = '';
 			}
-			$errors[ 'field' . $args['id'] ] = $invalid_message === '' ? $frm_settings->re_msg : $invalid_message;
+			$errors['field' . $args['id']] = $invalid_message === '' ? $frm_settings->re_msg : $invalid_message;
 		}
 
 		return $errors;
@@ -345,8 +345,8 @@ 
 
 		$form_id = is_object( $this->field ) ? $this->field->form_id : $this->field['form_id'];
 
-		if ( ! isset( $frm_vars['captcha_scores'][ $form_id ] ) ) {
-			$frm_vars['captcha_scores'][ $form_id ] = $score;
+		if ( ! isset( $frm_vars['captcha_scores'][$form_id] ) ) {
+			$frm_vars['captcha_scores'][$form_id] = $score;
 		}
 	}
 
@@ -377,7 +377,7 @@ 
 	protected static function post_data_includes_token() {
 		$settings = FrmCaptchaFactory::get_settings_object();
 		// phpcs:ignore WordPress.Security.NonceVerification.Missing
-		return ! empty( $_POST[ $settings->token_field ] );
+		return ! empty( $_POST[$settings->token_field] );
 	}
 
 	/**

classes/models/FrmForm.php

Spacing +31 added lines, -31 removed lines

@@ -232,7 +232,7 @@ 
 			}
 
 			if ( $new_val !== $value ) {
-				$new_values[ $key ] = $new_val;
+				$new_values[$key] = $new_val;
 			}
 		}//end foreach
 
@@ -268,7 +268,7 @@ 
 
 		foreach ( $values as $value_key => $value ) {
 			if ( $value_key && in_array( $value_key, $form_fields, true ) ) {
-				$new_values[ $value_key ] = $value;
+				$new_values[$value_key] = $value;
 			}
 		}
 
@@ -359,20 +359,20 @@ 
 		foreach ( $all_fields as $fid ) {
 			// phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict
 			if ( ! in_array( $fid->id, $existing_keys ) && ( isset( $values['frm_fields_submitted'] ) && in_array( $fid->id, $values['frm_fields_submitted'] ) ) || isset( $values['options'] ) ) {
-				$values['item_meta'][ $fid->id ] = '';
+				$values['item_meta'][$fid->id] = '';
 			}
-			$field_array[ $fid->id ] = $fid;
+			$field_array[$fid->id] = $fid;
 		}
 		unset( $all_fields );
 
 		foreach ( $values['item_meta'] as $field_id => $default_value ) {
-			$field = $field_array[ $field_id ] ?? FrmField::getOne( $field_id );
+			$field = $field_array[$field_id] ?? FrmField::getOne( $field_id );
 
 			if ( ! $field ) {
 				continue;
 			}
 
-			$is_settings_page = isset( $values['options'] ) || isset( $values['field_options'][ 'custom_html_' . $field_id ] );
+			$is_settings_page = isset( $values['options'] ) || isset( $values['field_options']['custom_html_' . $field_id] );
 
 			if ( $is_settings_page ) {
 				self::get_settings_page_html( $values, $field );
@@ -393,22 +393,22 @@ 
 			}
 
 			foreach ( $update_options as $opt => $default ) {
-				$field->field_options[ $opt ] = $values['field_options'][ $opt . '_' . $field_id ] ?? $default;
-				self::sanitize_field_opt( $opt, $field->field_options[ $opt ] );
+				$field->field_options[$opt] = $values['field_options'][$opt . '_' . $field_id] ?? $default;
+				self::sanitize_field_opt( $opt, $field->field_options[$opt] );
 			}
 
 			$field->field_options = apply_filters( 'frm_update_field_options', $field->field_options, $field, $values );
 
 			$new_field = array(
 				'field_options' => $field->field_options,
-				'default_value' => isset( $values[ 'default_value_' . $field_id ] ) ? FrmAppHelper::maybe_json_encode( $values[ 'default_value_' . $field_id ] ) : '',
+				'default_value' => isset( $values['default_value_' . $field_id] ) ? FrmAppHelper::maybe_json_encode( $values['default_value_' . $field_id] ) : '',
 			);
 
-			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options'][ 'options_' . $field_id ] ) && is_array( $values['field_options'][ 'options_' . $field_id ] ) ) {
-				foreach ( $values['field_options'][ 'options_' . $field_id ] as $option_key => $option ) {
+			if ( ! FrmAppHelper::allow_unfiltered_html() && isset( $values['field_options']['options_' . $field_id] ) && is_array( $values['field_options']['options_' . $field_id] ) ) {
+				foreach ( $values['field_options']['options_' . $field_id] as $option_key => $option ) {
 					if ( is_array( $option ) ) {
 						foreach ( $option as $key => $item ) {
-							$values['field_options'][ 'options_' . $field_id ][ $option_key ][ $key ] = FrmAppHelper::kses( $item, 'all' );
+							$values['field_options']['options_' . $field_id][$option_key][$key] = FrmAppHelper::kses( $item, 'all' );
 						}
 					}
 				}
@@ -439,8 +439,8 @@ 
 	 */
 	private static function maybe_update_max_option( $field, $values, &$new_field ) {
 		if ( $field->type === 'textarea' &&
-			! empty( $values['field_options'][ 'type_' . $field->id ] ) &&
-			in_array( $values['field_options'][ 'type_' . $field->id ], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
+			! empty( $values['field_options']['type_' . $field->id] ) &&
+			in_array( $values['field_options']['type_' . $field->id], array( 'text', 'email', 'url', 'password', 'phone' ), true ) ) {
 
 			$new_field['field_options']['max'] = '';
 
@@ -448,7 +448,7 @@ 
 			 * Update posted field setting so that new 'max' option is displayed after form is saved and page reloads.
 			 * FrmFieldsHelper::fill_default_field_opts populates field options by calling self::get_posted_field_setting.
 			 */
-			$_POST['field_options'][ 'max_' . $field->id ] = '';
+			$_POST['field_options']['max_' . $field->id] = '';
 		}
 	}
 
@@ -526,11 +526,11 @@ 
 	 * @return void
 	 */
 	private static function get_settings_page_html( $values, &$field ) {
-		if ( isset( $values['field_options'][ 'custom_html_' . $field->id ] ) ) {
+		if ( isset( $values['field_options']['custom_html_' . $field->id] ) ) {
 			$prev_opts     = array();
 			$fallback_html = $field->field_options['custom_html'] ?? FrmFieldsHelper::get_default_html( $field->type );
 
-			$field->field_options['custom_html'] = $values['field_options'][ 'custom_html_' . $field->id ] ?? $fallback_html;
+			$field->field_options['custom_html'] = $values['field_options']['custom_html_' . $field->id] ?? $fallback_html;
 		} elseif ( $field->type === 'hidden' || $field->type === 'user_id' ) {
 			$prev_opts = $field->field_options;
 		}
@@ -565,7 +565,7 @@ 
 
 		foreach ( $field_cols as $col => $default ) {
 			$default           = $default === '' ? $field->{$col} : $default;
-			$new_field[ $col ] = $values['field_options'][ $col . '_' . $field->id ] ?? $default;
+			$new_field[$col] = $values['field_options'][$col . '_' . $field->id] ?? $default;
 		}
 
 		if ( $field->type === 'submit' && isset( $new_field['field_order'] ) && (int) $new_field['field_order'] === FrmSubmitHelper::DEFAULT_ORDER ) {
@@ -774,7 +774,7 @@ 
 				self::destroy( $form->id );
 
 				if ( empty( $form->parent_form_id ) ) {
-					++$count;
+					++ $count;
 				}
 			}
 
@@ -998,16 +998,16 @@ 
 		foreach ( $results as $row ) {
 			if ( 'trash' !== $row->status ) {
 				if ( $row->is_template ) {
-					++$counts['template'];
+					++ $counts['template'];
 				} else {
-					++$counts['published'];
+					++ $counts['published'];
 				}
 			} else {
-				++$counts['trash'];
+				++ $counts['trash'];
 			}
 
 			if ( 'draft' === $row->status ) {
-				++$counts['draft'];
+				++ $counts['draft'];
 			}
 
 			unset( $row );
@@ -1056,8 +1056,8 @@ 
 			self::maybe_get_form( $form );
 		}
 
-		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][ $form->id ] ) ) {
-			return $frm_vars['form_params'][ $form->id ];
+		if ( isset( $frm_vars['form_params'] ) && is_array( $frm_vars['form_params'] ) && isset( $frm_vars['form_params'][$form->id] ) ) {
+			return $frm_vars['form_params'][$form->id];
 		}
 
 		$action_var = isset( $_REQUEST['frm_action'] ) ? 'frm_action' : 'action'; // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -1088,15 +1088,15 @@ 
 			// If there are two forms on the same page, make sure not to submit both.
 			foreach ( $default_values as $var => $default ) {
 				if ( $var === 'action' ) {
-					$values[ $var ] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
+					$values[$var] = FrmAppHelper::get_param( $action_var, $default, 'get', 'sanitize_title' );
 				} else {
-					$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+					$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 				}
 				unset( $var, $default );
 			}
 		} else {
 			foreach ( $default_values as $var => $default ) {
-				$values[ $var ] = $default;
+				$values[$var] = $default;
 				unset( $var, $default );
 			}
 		}
@@ -1126,7 +1126,7 @@ 
 		);
 
 		foreach ( $defaults as $var => $default ) {
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 		}
 
 		return $values;
@@ -1161,7 +1161,7 @@ 
 		);
 
 		foreach ( $defaults as $var => $default ) {
-			$values[ $var ] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
+			$values[$var] = FrmAppHelper::get_param( $var, $default, 'get', 'sanitize_text_field' );
 		}
 
 		return $values;
@@ -1304,7 +1304,7 @@ 
 		$form    = $atts['form'];
 		$default = $atts['default'] ?? '';
 
-		return $form->options[ $atts['option'] ] ?? $default;
+		return $form->options[$atts['option']] ?? $default;
 	}
 
 	/**

phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantParenthesesSniff.php

Spacing +12 added lines, -12 removed lines

@@ -45,11 +45,11 @@ 
 		$tokens = $phpcsFile->getTokens();
 
 		// Must have a closing parenthesis.
-		if ( ! isset( $tokens[ $stackPtr ]['parenthesis_closer'] ) ) {
+		if ( ! isset( $tokens[$stackPtr]['parenthesis_closer'] ) ) {
 			return;
 		}
 
-		$closeParen = $tokens[ $stackPtr ]['parenthesis_closer'];
+		$closeParen = $tokens[$stackPtr]['parenthesis_closer'];
 
 		// Check what's before the opening parenthesis.
 		$prevToken = $phpcsFile->findPrevious( T_WHITESPACE, $stackPtr - 1, null, true );
@@ -69,7 +69,7 @@ 
 			T_RETURN,
 		);
 
-		if ( ! in_array( $tokens[ $prevToken ]['code'], $validPrecedingTokens, true ) ) {
+		if ( ! in_array( $tokens[$prevToken]['code'], $validPrecedingTokens, true ) ) {
 			return;
 		}
 
@@ -81,7 +81,7 @@ 
 		}
 
 		// The expression should end with a semicolon or comma (for array elements).
-		if ( $tokens[ $afterClose ]['code'] !== T_SEMICOLON && $tokens[ $afterClose ]['code'] !== T_COMMA && $tokens[ $afterClose ]['code'] !== T_CLOSE_PARENTHESIS ) {
+		if ( $tokens[$afterClose]['code'] !== T_SEMICOLON && $tokens[$afterClose]['code'] !== T_COMMA && $tokens[$afterClose]['code'] !== T_CLOSE_PARENTHESIS ) {
 			return;
 		}
 
@@ -105,17 +105,17 @@ 
 			// Remove whitespace after opening parenthesis.
 			$next = $stackPtr + 1;
 
-			while ( $next < $closeParen && $tokens[ $next ]['code'] === T_WHITESPACE ) {
+			while ( $next < $closeParen && $tokens[$next]['code'] === T_WHITESPACE ) {
 				$phpcsFile->fixer->replaceToken( $next, '' );
-				++$next;
+				++ $next;
 			}
 
 			// Remove whitespace before closing parenthesis.
 			$prev = $closeParen - 1;
 
-			while ( $prev > $stackPtr && $tokens[ $prev ]['code'] === T_WHITESPACE ) {
+			while ( $prev > $stackPtr && $tokens[$prev]['code'] === T_WHITESPACE ) {
 				$phpcsFile->fixer->replaceToken( $prev, '' );
-				--$prev;
+				-- $prev;
 			}
 
 			// Remove closing parenthesis.
@@ -150,17 +150,17 @@ 
 		$hasArithmeticOp  = false;
 		$nestedParenDepth = 0;
 
-		for ( $i = $openParen + 1; $i < $closeParen; $i++ ) {
-			$code = $tokens[ $i ]['code'];
+		for ( $i = $openParen + 1; $i < $closeParen; $i ++ ) {
+			$code = $tokens[$i]['code'];
 
 			// Track nested parentheses - we only care about the top level.
 			if ( $code === T_OPEN_PARENTHESIS ) {
-				++$nestedParenDepth;
+				++ $nestedParenDepth;
 				continue;
 			}
 
 			if ( $code === T_CLOSE_PARENTHESIS ) {
-				--$nestedParenDepth;
+				-- $nestedParenDepth;
 				continue;
 			}