Strategy11 / formidable-forms

classes/models/FrmSolution.php

Braces +2 added lines, -1 removed lines

@@ -125,7 +125,8 @@
 		}
 
 		// Only do this for single site installs.
-		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) { // WPCS: CSRF ok.
+		if ( isset( $_GET['activate-multi'] ) || is_network_admin() ) {
+// WPCS: CSRF ok.
 			return;
 		}
 

Doc Comments +3 added lines

@@ -546,6 +546,9 @@
 		$this->show_import_options( $this->view_options(), 'view' );
 	}
 
+	/**
+	 * @param string $importing
+	 */
 	protected function show_import_options( $options, $importing, $xml = '' ) {
 		if ( empty( $options ) ) {
 			return;

Spacing +10 added lines, -10 removed lines

@@ -167,7 +167,7 @@ 
 	 */
 	public static function add_settings( $sections ) {
 		wp_enqueue_style( 'formidable-pro-fields' );
-		$sections[ $this->plugin_slug ] = array(
+		$sections[$this->plugin_slug] = array(
 			'class'    => $this,
 			'function' => 'settings_page',
 			'name'     => $this->plugin_name(),
@@ -324,9 +324,9 @@ 
 			// Set the current step.
 			if ( ! isset( $step['current'] ) ) {
 				if ( $step['complete'] ) {
-					$steps[ $k ]['current'] = false;
+					$steps[$k]['current'] = false;
 				} else {
-					$steps[ $k ]['current'] = ! $has_current;
+					$steps[$k]['current'] = ! $has_current;
 					$has_current = true;
 				}
 			} elseif ( $step['current'] ) {
@@ -336,10 +336,10 @@ 
 			// Set disabled buttons.
 			$class = isset( $step['button_class'] ) ? $step['button_class'] : '';
 			$class .= ' button-primary frm-button-primary';
-			if ( ! $steps[ $k ]['current'] ) {
+			if ( ! $steps[$k]['current'] ) {
 				$class .= ' frm_grey disabled';
 			}
-			$steps[ $k ]['button_class'] = $class;
+			$steps[$k]['button_class'] = $class;
 		}
 
 		return $steps;
@@ -361,7 +361,7 @@ 
 			if ( $plugin['status'] === 'active' ) {
 				continue;
 			}
-			$links[ $plugin_key ] = $plugin;
+			$links[$plugin_key] = $plugin;
 			if ( isset( $plugin['url'] ) ) {
 				$rel[] = $plugin['url'];
 			} else {
@@ -476,7 +476,7 @@ 
 		$addons = $api->get_api_info();
 
 		$id = $this->download_id();
-		$has_file = isset( $addons[ $id ] ) && isset( $addons[ $id ]['beta'] );
+		$has_file = isset( $addons[$id] ) && isset( $addons[$id]['beta'] );
 
 		if ( ! $step['current'] ) {
 			?>
@@ -491,10 +491,10 @@ 
 
 		if ( ! $has_file ) {
 			echo '<p class="frm_error_style">' . esc_html__( 'We didn\'t find anything to import. Please contact our team.', 'formidable' ) . '</p>';
-		} elseif ( ! isset( $addons[ $id ]['beta']['package'] ) ) {
+		} elseif ( ! isset( $addons[$id]['beta']['package'] ) ) {
 			echo '<p class="frm_error_style">' . esc_html__( 'Looks like you may not have a current subscription for this solution. Please check your account.', 'formidable' ) . '</p>';
 		} else {
-			$xml = $addons[ $id ]['beta']['package'];
+			$xml = $addons[$id]['beta']['package'];
 			if ( is_array( $xml ) ) {
 				$xml = reset( $xml );
 			}
@@ -632,7 +632,7 @@ 
 		foreach ( $forms as $form ) {
 			$was_imported = isset( $form['form'] ) ? FrmForm::get_id_by_key( $form['form'] ) : false;
 			if ( $was_imported ) {
-				$imported[ $form['form'] ] = $was_imported;
+				$imported[$form['form']] = $was_imported;
 			}
 		}
 		

classes/controllers/FrmXMLController.php

Spacing +12 added lines, -12 removed lines

@@ -121,7 +121,7 @@ 
 			return;
 		}
 
-		$selected_xml  = isset( $form['xml'] ) && isset( $form['xml'][ $selected_form ] ) ? $form['xml'][ $selected_form ] : '';
+		$selected_xml = isset( $form['xml'] ) && isset( $form['xml'][$selected_form] ) ? $form['xml'][$selected_form] : '';
 		if ( empty( $selected_xml ) || strpos( $selected_xml, 'http' ) !== 0 ) {
 			return;
 		}
@@ -133,8 +133,8 @@ 
 	 * @since 4.06.02
 	 */
 	private static function get_selected_in_form( $form, $value = 'form' ) {
-		if ( ! empty( $form ) && isset( $form[ $value ] ) && ! empty( $form[ $value ] ) ) {
-			return $form[ $value ];
+		if ( ! empty( $form ) && isset( $form[$value] ) && ! empty( $form[$value] ) ) {
+			return $form[$value];
 		}
 
 		return '';
@@ -163,14 +163,14 @@ 
 			}
 
 			if ( $for === 'view' ) {
-				$item_key  = is_array( $view_keys ) ? $view_keys[ $form_key ] : $view_keys;
+				$item_key  = is_array( $view_keys ) ? $view_keys[$form_key] : $view_keys;
 				$shortcode = '[display-frm-data id=%1$s filter=limited]';
 			} elseif ( $for === 'form' ) {
 				$item_key = $form_key;
 				$shortcode = '[formidable id=%1$s]';
 			} else {
 				$item_key  = self::get_selected_in_form( $form, 'form' );
-				$shortcode = '[' . esc_html( $for ) .' id=%1$s]';
+				$shortcode = '[' . esc_html( $for ) . ' id=%1$s]';
 			}
 
 			if ( empty( $item_key ) ) {
@@ -178,7 +178,7 @@ 
 				continue;
 			}
 
-			$page_ids[ $for ] = wp_insert_post(
+			$page_ids[$for] = wp_insert_post(
 				array(
 					'post_title'   => $name,
 					'post_type'    => 'page',
@@ -319,7 +319,7 @@ 
 		// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.MissingUnslash
 		$file_type = sanitize_option( 'upload_path', $_FILES['frm_import_file']['name'] );
 		$file_type = strtolower( pathinfo( $file_type, PATHINFO_EXTENSION ) );
-		if ( 'xml' !== $file_type && isset( $export_format[ $file_type ] ) ) {
+		if ( 'xml' !== $file_type && isset( $export_format[$file_type] ) ) {
 			// allow other file types to be imported
 			do_action( 'frm_before_import_' . $file_type );
 
@@ -402,7 +402,7 @@ 
 		foreach ( $type as $tb_type ) {
 			$where = array();
 			$join  = '';
-			$table = $tables[ $tb_type ];
+			$table = $tables[$tb_type];
 
 			$select     = $table . '.id';
 			$query_vars = array();
@@ -417,7 +417,7 @@ 
 							$table . '.parent_form_id' => $args['ids'],
 						);
 					} else {
-						$where[ $table . '.status !' ] = 'draft';
+						$where[$table . '.status !'] = 'draft';
 					}
 					break;
 				case 'actions':
@@ -430,7 +430,7 @@ 
 				case 'items':
 					// $join = "INNER JOIN {$wpdb->prefix}frm_item_metas im ON ($table.id = im.item_id)";
 					if ( $args['ids'] ) {
-						$where[ $table . '.form_id' ] = $args['ids'];
+						$where[$table . '.form_id'] = $args['ids'];
 					}
 					break;
 				case 'styles':
@@ -471,7 +471,7 @@ 
 					}
 			}
 
-			$records[ $tb_type ] = FrmDb::get_col( $table . $join, $where, $select );
+			$records[$tb_type] = FrmDb::get_col( $table . $join, $where, $select );
 			unset( $tb_type );
 		}
 
@@ -616,7 +616,7 @@ 
 		$no_export_fields = FrmField::no_save_fields();
 		foreach ( $csv_fields as $k => $f ) {
 			if ( in_array( $f->type, $no_export_fields ) ) {
-				unset( $csv_fields[ $k ] );
+				unset( $csv_fields[$k] );
 			}
 		}
 

classes/views/solutions/_import.php

Spacing +5 added lines, -5 removed lines

@@ -6,7 +6,7 @@ 
 				$info['url'] = $xml;
 			}
 
-			$disabled = isset( $imported[ $info['form'] ] ) ? ' disabled' : '';
+			$disabled = isset( $imported[$info['form']] ) ? ' disabled' : '';
 			$url   = isset( $info['url'] ) ? $info['url'] : '';
 			$value = $importing === 'form' ? $info['form'] : $info['key'];
 			if ( ! isset( $info['img'] ) ) {
@@ -16,14 +16,14 @@ 
 				continue;
 			}
 
-			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[ $info['form'] ] ) );
+			$hide_views = $importing === 'view' && ( ( $selected && $info['form'] !== $selected ) || isset( $imported[$info['form']] ) );
 			?>
 			<div class="frm_radio radio-inline radio frm_image_option<?php echo esc_attr( $importing === 'view' ? ' show_sub_opt show_' . $info['form'] : '' ); ?>" style="<?php echo esc_attr( $hide_views ? 'display:none' : '' ); ?>">
 				<?php if ( $importing === 'form' ) { ?>
 					<input type="hidden" name="xml[<?php echo esc_attr( $info['form'] ); ?>]" value="<?php echo esc_attr( $url ); ?>" <?php echo esc_attr( $disabled ); ?>/>
 				<?php } ?>
 				<label>
-					<input type="radio" name="<?php echo esc_attr( $importing .  ( $importing === 'view' ? '[' . $info['form'] . ']' : '' ) ); ?>" value="<?php echo esc_attr( $value ); ?>"
+					<input type="radio" name="<?php echo esc_attr( $importing . ( $importing === 'view' ? '[' . $info['form'] . ']' : '' ) ); ?>" value="<?php echo esc_attr( $value ); ?>"
 					<?php
 					echo esc_attr( $disabled );
 					if ( ! $selected && empty( $disabled ) ) {
@@ -36,7 +36,7 @@ 
 					<?php } ?>
 					/>
 					<div class="frm_image_option_container frm_label_with_image">
-						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) );  // WPCS: XSS ok. ?>
+						<?php echo FrmAppHelper::kses( $info['img'], array( 'svg', 'rect', 'path' ) ); // WPCS: XSS ok. ?>
 						<span class="frm_text_label_for_image">
 							<?php
 							if ( ! empty( $disabled ) ) {
@@ -49,7 +49,7 @@ 
 							}
 
 							if ( $importing === 'form' && $disabled ) {
-								echo FrmFormsHelper::edit_form_link( $imported[ $info['form'] ] );
+								echo FrmFormsHelper::edit_form_link( $imported[$info['form']] );
 							} else {
 								echo esc_html( $info['name'] );
 							}