Strategy11 / formidable-forms

classes/controllers/FrmDashboardController.php

Spacing +4 added lines, -4 removed lines

@@ -429,7 +429,7 @@ 
 		foreach ( $data as $key => $messages ) {
 			if ( in_array( $key, array( 'unread', 'dismissed' ), true ) ) {
 				foreach ( $messages as $key_msg => $message ) {
-					$data[ $key ][ $key_msg ]['cta'] = self::inbox_clean_messages_cta( $message['cta'] );
+					$data[$key][$key_msg]['cta'] = self::inbox_clean_messages_cta( $message['cta'] );
 				}
 			}
 		}
@@ -522,11 +522,11 @@ 
 	private static function get_dashboard_options( $option_name = null ) {
 		$options = get_option( self::OPTION_META_NAME, array() );
 
-		if ( null !== $option_name && ! isset( $options[ $option_name ] ) ) {
+		if ( null !== $option_name && ! isset( $options[$option_name] ) ) {
 			return array();
 		}
 
-		return null !== $option_name ? $options[ $option_name ] : $options;
+		return null !== $option_name ? $options[$option_name] : $options;
 	}
 
 	/**
@@ -539,7 +539,7 @@ 
 	 */
 	private static function update_dashboard_options( $data, $option_name ) {
 		$options                 = self::get_dashboard_options();
-		$options[ $option_name ] = $data;
+		$options[$option_name] = $data;
 		update_option( self::OPTION_META_NAME, $options, 'no' );
 	}
 

phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/SimplifyIfReturnSniff.php

Spacing +22 added lines, -22 removed lines

@@ -44,17 +44,17 @@ 
 		$tokens = $phpcsFile->getTokens();
 
 		// Make sure this if has a scope (curly braces).
-		if ( ! isset( $tokens[ $stackPtr ]['scope_opener'] ) || ! isset( $tokens[ $stackPtr ]['scope_closer'] ) ) {
+		if ( ! isset( $tokens[$stackPtr]['scope_opener'] ) || ! isset( $tokens[$stackPtr]['scope_closer'] ) ) {
 			return;
 		}
 
-		$scopeOpener = $tokens[ $stackPtr ]['scope_opener'];
-		$scopeCloser = $tokens[ $stackPtr ]['scope_closer'];
+		$scopeOpener = $tokens[$stackPtr]['scope_opener'];
+		$scopeCloser = $tokens[$stackPtr]['scope_closer'];
 
 		// Check if the if block contains only a single return statement.
 		$firstStatement = $phpcsFile->findNext( T_WHITESPACE, $scopeOpener + 1, $scopeCloser, true );
 
-		if ( false === $firstStatement || $tokens[ $firstStatement ]['code'] !== T_RETURN ) {
+		if ( false === $firstStatement || $tokens[$firstStatement]['code'] !== T_RETURN ) {
 			return;
 		}
 
@@ -80,12 +80,12 @@ 
 		}
 
 		// Check for else/elseif - skip these.
-		if ( in_array( $tokens[ $afterIf ]['code'], array( T_ELSE, T_ELSEIF ), true ) ) {
+		if ( in_array( $tokens[$afterIf]['code'], array( T_ELSE, T_ELSEIF ), true ) ) {
 			return;
 		}
 
 		// Must be followed by a return statement.
-		if ( $tokens[ $afterIf ]['code'] !== T_RETURN ) {
+		if ( $tokens[$afterIf]['code'] !== T_RETURN ) {
 			return;
 		}
 
@@ -112,7 +112,7 @@ 
 
 		// Get the condition and return values to check line length.
 		$conditionStart = $phpcsFile->findNext( T_OPEN_PARENTHESIS, $stackPtr + 1 );
-		$conditionEnd   = $tokens[ $conditionStart ]['parenthesis_closer'];
+		$conditionEnd   = $tokens[$conditionStart]['parenthesis_closer'];
 		$condition      = trim( $phpcsFile->getTokensAsString( $conditionStart + 1, $conditionEnd - $conditionStart - 1 ) );
 
 		$firstReturnValue  = trim( $phpcsFile->getTokensAsString( $firstStatement + 1, $returnEnd - $firstStatement - 1 ) );
@@ -122,7 +122,7 @@ 
 		$isNegated = false;
 		$firstNonWs = $phpcsFile->findNext( T_WHITESPACE, $conditionStart + 1, $conditionEnd, true );
 
-		if ( false !== $firstNonWs && $tokens[ $firstNonWs ]['code'] === T_BOOLEAN_NOT ) {
+		if ( false !== $firstNonWs && $tokens[$firstNonWs]['code'] === T_BOOLEAN_NOT ) {
 			$isNegated = true;
 			// Get condition without the leading !
 			$condition = trim( $phpcsFile->getTokensAsString( $firstNonWs + 1, $conditionEnd - $firstNonWs - 1 ) );
@@ -151,7 +151,7 @@ 
 			$phpcsFile->fixer->beginChangeset();
 
 			// Remove everything from the if to the second return's semicolon.
-			for ( $i = $stackPtr; $i <= $secondReturnEnd; $i++ ) {
+			for ( $i = $stackPtr; $i <= $secondReturnEnd; $i ++ ) {
 				$phpcsFile->fixer->replaceToken( $i, '' );
 			}
 
@@ -178,23 +178,23 @@ 
 		$tokenCount = 0;
 		$hasComplex = false;
 
-		for ( $i = $returnStart + 1; $i < $returnEnd; $i++ ) {
-			if ( $tokens[ $i ]['code'] === T_WHITESPACE ) {
+		for ( $i = $returnStart + 1; $i < $returnEnd; $i ++ ) {
+			if ( $tokens[$i]['code'] === T_WHITESPACE ) {
 				continue;
 			}
 
-			++$tokenCount;
+			++ $tokenCount;
 
 			// Check for complex constructs that shouldn't be in a ternary.
 			$complexTokens = array(
 				T_CLOSURE,
 				T_FUNCTION,
 				T_CLASS,
-				T_ARRAY,       // array() syntax - could be long.
+				T_ARRAY, // array() syntax - could be long.
 				T_OPEN_SHORT_ARRAY, // [] syntax - could be long.
 			);
 
-			if ( in_array( $tokens[ $i ]['code'], $complexTokens, true ) ) {
+			if ( in_array( $tokens[$i]['code'], $complexTokens, true ) ) {
 				$hasComplex = true;
 				break;
 			}
@@ -218,22 +218,22 @@ 
 		// Find the opening parenthesis of the if condition.
 		$openParen = $phpcsFile->findNext( T_OPEN_PARENTHESIS, $ifPtr + 1 );
 
-		if ( false === $openParen || ! isset( $tokens[ $openParen ]['parenthesis_closer'] ) ) {
+		if ( false === $openParen || ! isset( $tokens[$openParen]['parenthesis_closer'] ) ) {
 			return false;
 		}
 
-		$closeParen = $tokens[ $openParen ]['parenthesis_closer'];
+		$closeParen = $tokens[$openParen]['parenthesis_closer'];
 
 		// Count non-whitespace tokens in the condition.
 		$tokenCount = 0;
 		$hasComplex = false;
 
-		for ( $i = $openParen + 1; $i < $closeParen; $i++ ) {
-			if ( $tokens[ $i ]['code'] === T_WHITESPACE ) {
+		for ( $i = $openParen + 1; $i < $closeParen; $i ++ ) {
+			if ( $tokens[$i]['code'] === T_WHITESPACE ) {
 				continue;
 			}
 
-			++$tokenCount;
+			++ $tokenCount;
 
 			// Check for complex constructs.
 			$complexTokens = array(
@@ -241,12 +241,12 @@ 
 				T_FUNCTION,
 				T_CLASS,
 				T_BOOLEAN_AND, // && - multiple conditions.
-				T_BOOLEAN_OR,  // || - multiple conditions.
+				T_BOOLEAN_OR, // || - multiple conditions.
 				T_LOGICAL_AND, // and.
-				T_LOGICAL_OR,  // or.
+				T_LOGICAL_OR, // or.
 			);
 
-			if ( in_array( $tokens[ $i ]['code'], $complexTokens, true ) ) {
+			if ( in_array( $tokens[$i]['code'], $complexTokens, true ) ) {
 				$hasComplex = true;
 				break;
 			}