Strategy11 / formidable-forms

classes/controllers/FrmAddonsController.php

Spacing +26 added lines, -28 removed lines

@@ -116,7 +116,7 @@ 
 				'<span class="frm-upgrade-submenu">' . esc_html( $cta_text ) . '</span>',
 				'frm_view_forms',
 				'formidable-pro-upgrade',
-				function () {
+				function() {
 					// This function doesn't need to do anything.
 					// The redirect is handled earlier to avoid issues with the headers being sent.
 				}
@@ -147,7 +147,7 @@ 
 			unset( $addons['error'] );
 		}
 
-		$pro    = array(
+		$pro = array(
 			'pro' => array(
 				'title'      => 'Formidable Forms Pro',
 				'slug'       => 'formidable-pro',
@@ -189,9 +189,9 @@ 
 
 		// Extract the elements to move
 		foreach ( $plans as $plan ) {
-			if ( isset( self::$categories[ $plan ] ) ) {
-				$bottom_categories[ $plan ] = self::$categories[ $plan ];
-				unset( self::$categories[ $plan ] );
+			if ( isset( self::$categories[$plan] ) ) {
+				$bottom_categories[$plan] = self::$categories[$plan];
+				unset( self::$categories[$plan] );
 			}
 		}
 
@@ -245,14 +245,12 @@ 
 			// Add the slug to the new array.
 			$addon['category-slugs'][] = $category_slug;
 
-			if ( ! isset( self::$categories[ $category_slug ] ) ) {
-				self::$categories[ $category_slug ] = array(
+			if ( ! isset( self::$categories[$category_slug] ) ) {
+				self::$categories[$category_slug] = array(
 					'name'  => $category,
 					'count' => 0,
 				);
-			}
-
-			++self::$categories[ $category_slug ]['count'];
+			} ++self::$categories[$category_slug]['count'];
 		}
 	}
 
@@ -284,7 +282,7 @@ 
 		} else {
 			foreach ( $addons as $k => $addon ) {
 				if ( empty( $addon['excerpt'] ) && $k !== 'error' ) {
-					unset( $addons[ $k ] );
+					unset( $addons[$k] );
 				}
 			}
 		}
@@ -398,7 +396,7 @@ 
 
 		foreach ( $list as $k => $info ) {
 			$info['slug'] = $k;
-			$list[ $k ]   = array_merge( $defaults, $info );
+			$list[$k]   = array_merge( $defaults, $info );
 		}
 		return $list;
 	}
@@ -549,17 +547,17 @@ 
 				continue;
 			}
 
-			$wp_plugin    = $wp_plugins[ $folder ] ?? array();
+			$wp_plugin    = $wp_plugins[$folder] ?? array();
 			$wp_version   = $wp_plugin['Version'] ?? '1.0';
 			$plugin->slug = explode( '/', $folder )[0];
 
 			if ( version_compare( $wp_version, $plugin->new_version, '<' ) ) {
-				$transient->response[ $folder ] = $plugin;
+				$transient->response[$folder] = $plugin;
 			} else {
-				$transient->no_update[ $folder ] = $plugin;
+				$transient->no_update[$folder] = $plugin;
 			}
 
-			$transient->checked[ $folder ] = $wp_version;
+			$transient->checked[$folder] = $wp_version;
 
 		}//end foreach
 
@@ -592,7 +590,7 @@ 
 	 */
 	protected static function is_installed( $plugin ) {
 		$all_plugins = self::get_plugins();
-		return isset( $all_plugins[ $plugin ] );
+		return isset( $all_plugins[$plugin] );
 	}
 
 	/**
@@ -631,13 +629,13 @@ 
 			}
 
 			$download_id = $plugin['id'] ?? 0;
-			if ( ! empty( $download_id ) && ! isset( $version_info[ $download_id ]['package'] ) ) {
+			if ( ! empty( $download_id ) && ! isset( $version_info[$download_id]['package'] ) ) {
 				// if this addon is using its own license, get the update url
 				$addon_info = $api->get_api_info();
 
-				$version_info[ $download_id ] = $addon_info[ $download_id ];
+				$version_info[$download_id] = $addon_info[$download_id];
 				if ( isset( $addon_info['error'] ) ) {
-					$version_info[ $download_id ]['error'] = array(
+					$version_info[$download_id]['error'] = array(
 						'message' => $addon_info['error']['message'],
 						'code'    => $addon_info['error']['code'],
 					);
@@ -736,8 +734,8 @@ 
 					return $addon;
 				}
 			}
-		} elseif ( isset( $addons[ $download_id ] ) ) {
-			$plugin = $addons[ $download_id ];
+		} elseif ( isset( $addons[$download_id] ) ) {
+			$plugin = $addons[$download_id];
 		}
 
 		return $plugin;
@@ -803,7 +801,7 @@ 
 			self::set_addon_status( $addon );
 			self::set_categories( $addon );
 
-			$addons[ $id ] = $addon;
+			$addons[$id] = $addon;
 		}//end foreach
 	}
 
@@ -838,7 +836,7 @@ 
 		if ( strpos( $link, 'http' ) !== 0 ) {
 			$link = $site_url . $link;
 		}
-		$link       = FrmAppHelper::make_affiliate_url( $link );
+		$link = FrmAppHelper::make_affiliate_url( $link );
 
 		$utm  = array(
 			'campaign' => 'addons',
@@ -1061,7 +1059,7 @@ 
 	 */
 	public static function ajax_activate_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'activate' );
 			},
 			array( 'FrmAddonsController', 'get_addon_activation_response' )
@@ -1086,7 +1084,7 @@ 
 	 */
 	public static function ajax_deactivate_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'deactivate' );
 			}
 		);
@@ -1101,7 +1099,7 @@ 
 	 */
 	public static function ajax_uninstall_addon() {
 		self::process_addon_action(
-			function ( $plugin ) {
+			function( $plugin ) {
 				return self::handle_addon_action( $plugin, 'uninstall' );
 			}
 		);
@@ -1499,7 +1497,7 @@ 
 		$addons = $api->get_api_info();
 
 		if ( is_array( $addons ) && array_key_exists( $addon_id, $addons ) ) {
-			$dates    = $addons[ $addon_id ];
+			$dates    = $addons[$addon_id];
 			$requires = FrmFormsHelper::get_plan_required( $dates );
 		}
 

classes/controllers/FrmAppController.php

Spacing +10 added lines, -10 removed lines

@@ -1334,11 +1334,11 @@ 
 			wp_set_script_translations( 's11-floating-links-config', 's11-' );
 		}
 
-		$upgrade_utm         = array(
+		$upgrade_utm = array(
 			'campaign' => 'floating-links',
 			'content'  => 'floating-links-upgrade',
 		);
-		$docs_utm            = array(
+		$docs_utm = array(
 			'campaign' => 'floating-links',
 			'content'  => 'floating-links-docs',
 		);
@@ -1412,15 +1412,15 @@ 
 		global $wp_filter;
 
 		foreach ( $actions as $action ) {
-			if ( empty( $wp_filter[ $action ]->callbacks ) ) {
+			if ( empty( $wp_filter[$action]->callbacks ) ) {
 				continue;
 			}
-			foreach ( $wp_filter[ $action ]->callbacks as $priority => $callbacks ) {
+			foreach ( $wp_filter[$action]->callbacks as $priority => $callbacks ) {
 				foreach ( $callbacks as $callback_name => $callback ) {
 					if ( self::is_our_callback_string( $callback_name ) || self::is_our_callback_array( $callback ) ) {
 						continue;
 					}
-					unset( $wp_filter[ $action ]->callbacks[ $priority ][ $callback_name ] );
+					unset( $wp_filter[$action]->callbacks[$priority][$callback_name] );
 				}
 			}
 		}
@@ -1458,8 +1458,8 @@ 
 		$current_sort  = $previous_meta;
 		$form_id       = $is_entry_list ? FrmAppHelper::simple_get( 'form', 'absint' ) : 0;
 
-		if ( is_array( $current_sort ) && $form_id && is_int( $form_id ) && isset( $current_sort[ $form_id ] ) ) {
-			$current_sort = $current_sort[ $form_id ];
+		if ( is_array( $current_sort ) && $form_id && is_int( $form_id ) && isset( $current_sort[$form_id] ) ) {
+			$current_sort = $current_sort[$form_id];
 		}
 
 		if ( $new_sort !== $current_sort ) {
@@ -1468,7 +1468,7 @@ 
 			if ( $is_entry_list && $form_id && is_int( $form_id ) ) {
 				// Index meta by form ID.
 				$temp_meta             = is_array( $previous_meta ) ? $previous_meta : array();
-				$temp_meta[ $form_id ] = $new_meta;
+				$temp_meta[$form_id] = $new_meta;
 				$new_meta              = $temp_meta;
 				unset( $temp_meta );
 			}
@@ -1496,8 +1496,8 @@ 
 		$preferred_list_sort = get_user_meta( $user_id, $meta_key, true );
 		$form_id             = FrmAppHelper::simple_get( 'form', 'absint' );
 
-		if ( is_array( $preferred_list_sort ) && $form_id && is_int( $form_id ) && isset( $preferred_list_sort[ $form_id ] ) ) {
-			$preferred_list_sort = $preferred_list_sort[ $form_id ];
+		if ( is_array( $preferred_list_sort ) && $form_id && is_int( $form_id ) && isset( $preferred_list_sort[$form_id] ) ) {
+			$preferred_list_sort = $preferred_list_sort[$form_id];
 		}
 
 		if ( is_array( $preferred_list_sort ) && ! empty( $preferred_list_sort['orderby'] ) ) {

classes/views/addons/min-version-notice.php

Braces +5 added lines, -2 removed lines

@@ -14,7 +14,10 @@
 		);
 		?>
 		Please <a href="<?php echo esc_url( FrmAppHelper::admin_upgrade_link( $utm, 'account/downloads/' ) ); ?>">renew now</a> to get the latest version.
-	<?php else : ?>
-		Please <a href="<?php echo esc_url( admin_url( 'plugins.php?s=formidable%20forms%20pro' ) ); ?>">update now</a>.
+	<?php else {
+	: ?>
+		Please <a href="<?php echo esc_url( admin_url( 'plugins.php?s=formidable%20forms%20pro' ) );
+}
+?>">update now</a>.
 	<?php endif; ?>
 </div>