Strategy11 / formidable-forms

classes/controllers/FrmFormsController.php

Spacing +33 added lines, -33 removed lines

@@ -647,7 +647,7 @@ 
 			 * @param string|null $src
 			 * @return string
 			 */
-			function ( $src ) {
+			function( $src ) {
 				if ( is_null( $src ) ) {
 					$src = '';
 				}
@@ -712,11 +712,11 @@ 
 			),
 		);
 
-		if ( ! isset( $available_status[ $status ] ) ) {
+		if ( ! isset( $available_status[$status] ) ) {
 			return;
 		}
 
-		FrmAppHelper::permission_check( $available_status[ $status ]['permission'] );
+		FrmAppHelper::permission_check( $available_status[$status]['permission'] );
 
 		$params = FrmForm::list_page_params();
 
@@ -724,8 +724,8 @@ 
 		check_admin_referer( $status . '_form_' . $params['id'] );
 
 		$count = 0;
-		if ( FrmForm::set_status( $params['id'], $available_status[ $status ]['new_status'] ) ) {
-			++$count;
+		if ( FrmForm::set_status( $params['id'], $available_status[$status]['new_status'] ) ) {
+			++ $count;
 		}
 
 		$form_type = FrmAppHelper::get_simple_request(
@@ -741,7 +741,7 @@ 
 		/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 		$available_status['trash']['message'] = sprintf( _n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ), $count, '<a href="' . esc_url( wp_nonce_url( '?page=formidable&frm_action=untrash&form_type=' . $form_type . '&id=' . $params['id'], 'untrash_form_' . $params['id'] ) ) . '">', '</a>' );
 
-		$message = $available_status[ $status ]['message'];
+		$message = $available_status[$status]['message'];
 
 		self::display_forms_list( $params, $message );
 	}
@@ -756,7 +756,7 @@ 
 		$count = 0;
 		foreach ( $ids as $id ) {
 			if ( FrmForm::trash( $id ) ) {
-				++$count;
+				++ $count;
 			}
 		}
 
@@ -766,7 +766,7 @@ 
 				'type'  => 'request',
 			)
 		);
-		$message      = sprintf(
+		$message = sprintf(
 			/* translators: %1$s: Number of forms, %2$s: Start link HTML, %3$s: End link HTML */
 			_n( '%1$s form moved to the Trash. %2$sUndo%3$s', '%1$s forms moved to the Trash. %2$sUndo%3$s', $count, 'formidable' ),
 			$count,
@@ -787,7 +787,7 @@ 
 
 		$count = 0;
 		if ( FrmForm::destroy( $params['id'] ) ) {
-			++$count;
+			++ $count;
 		}
 
 		/* translators: %1$s: Number of forms */
@@ -807,7 +807,7 @@ 
 		foreach ( $ids as $id ) {
 			$d = FrmForm::destroy( $id );
 			if ( $d ) {
-				++$count;
+				++ $count;
 			}
 		}
 
@@ -1301,7 +1301,7 @@ 
 
 		add_action(
 			'wp_enqueue_editor',
-			function () {
+			function() {
 				wp_print_media_templates();
 			}
 		);
@@ -1406,7 +1406,7 @@ 
 
 		foreach ( array( 'landing', 'chat', 'abandonment' ) as $feature ) {
 			if ( ! FrmAppHelper::show_new_feature( $feature ) ) {
-				unset( $sections[ $feature ] );
+				unset( $sections[$feature] );
 			}
 		}
 
@@ -1434,7 +1434,7 @@ 
 				$section['id'] = $section['anchor'];
 			}
 
-			$sections[ $key ] = $section;
+			$sections[$key] = $section;
 		}//end foreach
 
 		return $sections;
@@ -1557,7 +1557,7 @@ 
 		if ( $user_fields ) {
 			$user_helpers = array();
 			foreach ( $user_fields as $uk => $uf ) {
-				$user_helpers[ '|user_id| show="' . $uk . '"' ] = $uf;
+				$user_helpers['|user_id| show="' . $uk . '"'] = $uf;
 				unset( $uk, $uf );
 			}
 
@@ -1696,7 +1696,7 @@ 
 		if ( ! isset( $frm_vars['js_validate_forms'] ) ) {
 			$frm_vars['js_validate_forms'] = array();
 		}
-		$frm_vars['js_validate_forms'][ $form->id ] = $form;
+		$frm_vars['js_validate_forms'][$form->id] = $form;
 	}
 
 	public static function get_email_html() {
@@ -1867,7 +1867,7 @@ 
 				add_filter( 'frm_validate_form', 'FrmFormsController::json_error' );
 			} else {
 				$vars   = FrmAppHelper::json_to_array( $json_vars );
-				$action = $vars[ $action ];
+				$action = $vars[$action];
 				unset( $_REQUEST['frm_compact_fields'], $_POST['frm_compact_fields'] ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_REQUEST = array_merge( $_REQUEST, $vars ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_POST    = array_merge( $_POST, $_REQUEST ); // phpcs:ignore WordPress.Security.NonceVerification.Missing
@@ -2040,7 +2040,7 @@ 
 		$actions = array();
 		foreach ( $frm_vars['forms_loaded'] as $form ) {
 			if ( is_object( $form ) ) {
-				$actions[ $form->id ] = $form->name;
+				$actions[$form->id] = $form->name;
 			}
 			unset( $form );
 		}
@@ -2285,8 +2285,8 @@ 
 	private static function get_saved_errors( $form, $params ) {
 		global $frm_vars;
 
-		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][ $form->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			$errors = $frm_vars['created_entries'][ $form->id ]['errors'];
+		if ( $params['posted_form_id'] == $form->id && $_POST && isset( $frm_vars['created_entries'][$form->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$errors = $frm_vars['created_entries'][$form->id]['errors'];
 		} else {
 			$errors = array();
 		}
@@ -2308,7 +2308,7 @@ 
 	public static function just_created_entry( $form_id ) {
 		global $frm_vars;
 
-		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][ $form_id ] ) && isset( $frm_vars['created_entries'][ $form_id ]['entry_id'] ) ? $frm_vars['created_entries'][ $form_id ]['entry_id'] : 0;
+		return isset( $frm_vars['created_entries'] ) && isset( $frm_vars['created_entries'][$form_id] ) && isset( $frm_vars['created_entries'][$form_id]['entry_id'] ) ? $frm_vars['created_entries'][$form_id]['entry_id'] : 0;
 	}
 
 	/**
@@ -2328,7 +2328,7 @@ 
 	private static function get_confirmation_method( $atts ) {
 		$action = FrmOnSubmitHelper::current_event( $atts );
 		$opt    = 'update' === $action ? 'edit_action' : 'success_action';
-		$method = ! empty( $atts['form']->options[ $opt ] ) ? $atts['form']->options[ $opt ] : 'message';
+		$method = ! empty( $atts['form']->options[$opt] ) ? $atts['form']->options[$opt] : 'message';
 
 		if ( ! empty( $atts['entry_id'] ) ) {
 			$met_actions = self::get_met_on_submit_actions( $atts, $action );
@@ -2349,7 +2349,7 @@ 
 	public static function maybe_trigger_redirect( $form, $params, $args ) {
 		if ( ! isset( $params['id'] ) ) {
 			global $frm_vars;
-			$params['id'] = $frm_vars['created_entries'][ $form->id ]['entry_id'];
+			$params['id'] = $frm_vars['created_entries'][$form->id]['entry_id'];
 		}
 
 		$conf_method = self::get_confirmation_method(
@@ -2431,7 +2431,7 @@ 
 		$args['success_opt'] = $opt;
 		$args['ajax']        = ! empty( $frm_vars['ajax'] );
 
-		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[ $opt . '_page_id' ] ) ) {
+		if ( $args['conf_method'] === 'page' && is_numeric( $args['form']->options[$opt . '_page_id'] ) ) {
 			self::load_page_after_submit( $args );
 		} elseif ( $args['conf_method'] === 'redirect' ) {
 			self::redirect_after_submit( $args );
@@ -2455,7 +2455,7 @@ 
 		}
 
 		// If a redirect action has already opened the URL in a new tab, we show the default message in the current tab.
-		if ( ! empty( self::$redirected_in_new_tab[ $args['form']->id ] ) ) {
+		if ( ! empty( self::$redirected_in_new_tab[$args['form']->id] ) ) {
 			return array( FrmOnSubmitHelper::get_fallback_action_after_open_in_new_tab( $event ) );
 		}
 
@@ -2643,7 +2643,7 @@ 
 
 		$opt = 'update' === $args['action'] ? 'edit_' : 'success_';
 
-		$new_args['conf_method'] = $new_args['form']->options[ $opt . 'action' ];
+		$new_args['conf_method'] = $new_args['form']->options[$opt . 'action'];
 
 		/**
 		 * Filters the run success action args.
@@ -2663,8 +2663,8 @@ 
 	private static function load_page_after_submit( $args ) {
 		global $post;
 		$opt = $args['success_opt'];
-		if ( ! $post || $args['form']->options[ $opt . '_page_id' ] != $post->ID ) {
-			$page     = get_post( $args['form']->options[ $opt . '_page_id' ] );
+		if ( ! $post || $args['form']->options[$opt . '_page_id'] != $post->ID ) {
+			$page     = get_post( $args['form']->options[$opt . '_page_id'] );
 			$old_post = $post;
 			$post     = $page;
 			$content  = apply_filters( 'frm_content', $page->post_content, $args['form'], $args['entry_id'] );
@@ -2694,7 +2694,7 @@ 
 		add_filter( 'frm_use_wpautop', '__return_false' );
 
 		$opt         = $args['success_opt'];
-		$success_url = trim( $args['form']->options[ $opt . '_url' ] );
+		$success_url = trim( $args['form']->options[$opt . '_url'] );
 		$success_url = apply_filters( 'frm_content', $success_url, $args['form'], $args['entry_id'] );
 		$success_url = do_shortcode( $success_url );
 
@@ -2716,7 +2716,7 @@ 
 			// Not AJAX submit, no headers sent, and there is just one Redirect action runs.
 			if ( ! empty( $args['form']->options['open_in_new_tab'] ) ) {
 				self::print_open_in_new_tab_js_with_fallback_handler( $success_url, $args );
-				self::$redirected_in_new_tab[ $args['form']->id ] = 1;
+				self::$redirected_in_new_tab[$args['form']->id] = 1;
 				return;
 			}
 
@@ -2976,7 +2976,7 @@ 
 			'description' => false,
 			'reset'       => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 	}
 
 	/**
@@ -3014,7 +3014,7 @@ 
 		$opt          = isset( $args['success_opt'] ) ? $args['success_opt'] : 'success';
 
 		if ( $entry_id && is_numeric( $entry_id ) ) {
-			$message = isset( $form->options[ $opt . '_msg' ] ) ? $form->options[ $opt . '_msg' ] : $frm_settings->success_msg;
+			$message = isset( $form->options[$opt . '_msg'] ) ? $form->options[$opt . '_msg'] : $frm_settings->success_msg;
 			$class   = 'frm_message';
 		} else {
 			$message = $frm_settings->failed_msg;
@@ -3237,8 +3237,8 @@ 
 
 		check_ajax_referer( 'frm_ajax', 'nonce' );
 
-		$html             = FrmAppHelper::clip(
-			function () {
+		$html = FrmAppHelper::clip(
+			function() {
 				FrmAppHelper::maybe_autocomplete_pages_options(
 					array(
 						'field_name'  => 'frm_page_dropdown',

classes/models/FrmFormMigrator.php

Spacing +9 added lines, -9 removed lines

@@ -234,7 +234,7 @@ 
 
 			// This may occasionally skip one level/order e.g. after adding a
 			// list field, as field_order would already be prepared to be used.
-			++$field_order;
+			++ $field_order;
 
 			if ( ! empty( $new_field['fields'] ) && is_array( $new_field['fields'] ) ) {
 				// we have (inner) fields to merge
@@ -272,7 +272,7 @@ 
 
 		$order = 0;
 		foreach ( $fields as $field ) {
-			++$order;
+			++ $order;
 			$type     = $this->get_field_type( $field );
 			$new_type = $this->convert_field_type( $type, $field );
 			if ( ! in_array( $new_type, $with_end ) && $new_type !== 'break' ) {
@@ -302,7 +302,7 @@ 
 		$sub['name'] = __( 'Section Buttons', 'formidable' );
 		$subs        = array( $sub );
 		$this->insert_fields_in_array( $subs, $order, 0, $fields );
-		++$order;
+		++ $order;
 	}
 
 	/**
@@ -399,7 +399,7 @@ 
 	protected function create_fields( $form_id, &$form ) {
 		foreach ( $form['fields'] as $key => $new_field ) {
 			$new_field['form_id']         = $form_id;
-			$form['fields'][ $key ]['id'] = FrmField::create( $new_field );
+			$form['fields'][$key]['id'] = FrmField::create( $new_field );
 		}
 	}
 
@@ -433,9 +433,9 @@ 
 			} elseif ( $key === 'the_post_title' ) {
 				$new_action->post_content['post_title'] = $value;
 			} elseif ( is_string( $value ) ) {
-				$new_action->post_content[ $key ] = $this->replace_smart_tags( $value, $form['fields'] );
+				$new_action->post_content[$key] = $this->replace_smart_tags( $value, $form['fields'] );
 			} else {
-				$new_action->post_content[ $key ] = $value;
+				$new_action->post_content[$key] = $value;
 			}
 		}
 
@@ -454,7 +454,7 @@ 
 
 		$imported = $this->get_tracked_import();
 
-		$imported[ $this->slug ][ $new_form_id ] = $source_id;
+		$imported[$this->slug][$new_form_id] = $source_id;
 
 		update_option( $this->tracking, $imported, false );
 	}
@@ -474,11 +474,11 @@ 
 	private function is_imported( $source_id ) {
 		$imported    = $this->get_tracked_import();
 		$new_form_id = 0;
-		if ( ! isset( $imported[ $this->slug ] ) || ! in_array( $source_id, $imported[ $this->slug ] ) ) {
+		if ( ! isset( $imported[$this->slug] ) || ! in_array( $source_id, $imported[$this->slug] ) ) {
 			return $new_form_id;
 		}
 
-		$new_form_id = array_search( $source_id, array_reverse( $imported[ $this->slug ], true ) );
+		$new_form_id = array_search( $source_id, array_reverse( $imported[$this->slug], true ) );
 		if ( ! empty( $new_form_id ) && empty( FrmForm::get_key_by_id( $new_form_id ) ) ) {
 			// Allow reimport if the form was deleted.
 			$new_form_id = 0;