Strategy11 / formidable-forms

classes/controllers/FrmFieldsController.php

Spacing +26 added lines, -26 removed lines

@@ -26,7 +26,7 @@ 
 
 		$_GET['page'] = 'formidable';
 
-		$values     = array(
+		$values = array(
 			'id'         => FrmAppHelper::get_post_param( 'form_id', '', 'absint' ),
 			'doing_ajax' => true,
 		);
@@ -50,7 +50,7 @@ 
 
 			ob_start();
 			self::load_single_field( $field, $values );
-			$field_html[ absint( $field->id ) ] = ob_get_clean();
+			$field_html[absint( $field->id )] = ob_get_clean();
 		}//end foreach
 
 		echo json_encode( $field_html );
@@ -283,7 +283,7 @@ 
 			foreach ( $opts as $opt_key => $opt ) {
 				if ( str_contains( $opt, '|' ) ) {
 					$vals             = explode( '|', $opt );
-					$opts[ $opt_key ] = array(
+					$opts[$opt_key] = array(
 						'label' => trim( $vals[0] ),
 						'value' => trim( $vals[1] ),
 					);
@@ -300,7 +300,7 @@ 
 
 			foreach ( $field['options'] as $opt_key => $opt ) {
 				if ( FrmFieldsHelper::is_other_opt( $opt_key ) ) {
-					$other_array[ $opt_key ] = $opt;
+					$other_array[$opt_key] = $opt;
 				}
 				unset( $opt_key, $opt );
 			}
@@ -345,18 +345,18 @@ 
 		$frm_settings         = FrmAppHelper::get_settings();
 		$field_types          = FrmFieldTypeOptionData::get_field_types( $field['type'] );
 
-		if ( ! isset( $all_field_types[ $field['type'] ] ) ) {
+		if ( ! isset( $all_field_types[$field['type']] ) ) {
 			// Add fallback for an add-on field type that has been deactivated.
-			$all_field_types[ $field['type'] ] = array(
+			$all_field_types[$field['type']] = array(
 				'name' => ucfirst( $field['type'] ),
 				'icon' => 'frmfont frm_pencil_icon',
 			);
-		} elseif ( ! is_array( $all_field_types[ $field['type'] ] ) ) {
+		} elseif ( ! is_array( $all_field_types[$field['type']] ) ) {
 			// Fallback for fields added in a more basic way.
-			FrmFormsHelper::prepare_field_type( $all_field_types[ $field['type'] ] );
+			FrmFormsHelper::prepare_field_type( $all_field_types[$field['type']] );
 		}
 
-		$type_name = $all_field_types[ $field['type'] ]['name'];
+		$type_name = $all_field_types[$field['type']]['name'];
 
 		if ( $field['type'] === 'divider' && FrmField::is_option_true( $field, 'repeat' ) ) {
 			$type_name = $all_field_types['divider|repeat']['name'];
@@ -435,14 +435,14 @@ 
 
 		if ( FrmAppHelper::pro_is_connected() ) {
 			foreach ( $settings as $type ) {
-				if ( ! empty( $field[ $type ] ) ) {
+				if ( ! empty( $field[$type] ) ) {
 					$active = $type;
 				}
 			}
 		}
 
-		$types[ $active ]['class']  .= ' current';
-		$types[ $active ]['current'] = true;
+		$types[$active]['class']  .= ' current';
+		$types[$active]['current'] = true;
 
 		return $types;
 	}
@@ -462,8 +462,8 @@ 
 			'image'   => 'url',
 		);
 
-		if ( isset( $type_switch[ $type ] ) ) {
-			$type = $type_switch[ $type ];
+		if ( isset( $type_switch[$type] ) ) {
+			$type = $type_switch[$type];
 		}
 
 		$pro_fields = FrmField::pro_field_selection();
@@ -628,11 +628,11 @@ 
 		// include "col" for valid html
 		$unit = trim( preg_replace( '/[0-9]+/', '', $field['size'] ) );
 
-		if ( ! isset( $calc[ $unit ] ) ) {
+		if ( ! isset( $calc[$unit] ) ) {
 			return;
 		}
 
-		$size             = (float) str_replace( $unit, '', $field['size'] ) / $calc[ $unit ];
+		$size             = (float) str_replace( $unit, '', $field['size'] ) / $calc[$unit];
 		$add_html['cols'] = 'cols="' . absint( $size ) . '"';
 	}
 
@@ -889,12 +889,12 @@ 
 		global $frm_vars;
 
 		if ( ! empty( $frm_vars['js_validate_forms'] ) ) {
-			if ( isset( $frm_vars['js_validate_forms'][ $field['form_id'] ] ) ) {
-				return $frm_vars['js_validate_forms'][ $field['form_id'] ];
+			if ( isset( $frm_vars['js_validate_forms'][$field['form_id']] ) ) {
+				return $frm_vars['js_validate_forms'][$field['form_id']];
 			}
 
-			if ( ! empty( $field['parent_form_id'] ) && isset( $frm_vars['js_validate_forms'][ $field['parent_form_id'] ] ) ) {
-				return $frm_vars['js_validate_forms'][ $field['parent_form_id'] ];
+			if ( ! empty( $field['parent_form_id'] ) && isset( $frm_vars['js_validate_forms'][$field['parent_form_id']] ) ) {
+				return $frm_vars['js_validate_forms'][$field['parent_form_id']];
 			}
 		}
 
@@ -984,13 +984,13 @@ 
 			if ( isset( $field['subfield_name'] ) && str_starts_with( $k, 'aria-invalid' ) ) {
 				$subfield_name = $field['subfield_name'];
 
-				if ( ! isset( $field['shortcodes'][ 'aria-invalid-' . $subfield_name ] ) ) {
+				if ( ! isset( $field['shortcodes']['aria-invalid-' . $subfield_name] ) ) {
 					continue;
 				}
 				// Change the key to the correct aria-invalid value so that $add_html is set correctly for the current subfield of a combo field.
 				$k = 'aria-invalid';
-				$v = $field['shortcodes'][ 'aria-invalid-' . $subfield_name ];
-				unset( $field['shortcodes'][ 'aria-invalid-' . $subfield_name ] );
+				$v = $field['shortcodes']['aria-invalid-' . $subfield_name];
+				unset( $field['shortcodes']['aria-invalid-' . $subfield_name] );
 			}
 
 			if ( 'opt' === $k || ! self::should_allow_input_attribute( $k ) ) {
@@ -999,10 +999,10 @@ 
 
 			if ( is_numeric( $k ) && str_contains( $v, '=' ) ) {
 				$add_html[] = $v;
-			} elseif ( ! empty( $k ) && isset( $add_html[ $k ] ) ) {
-				$add_html[ $k ] = str_replace( $k . '="', $k . '="' . $v, $add_html[ $k ] );
+			} elseif ( ! empty( $k ) && isset( $add_html[$k] ) ) {
+				$add_html[$k] = str_replace( $k . '="', $k . '="' . $v, $add_html[$k] );
 			} else {
-				$add_html[ $k ] = $k . '="' . esc_attr( $v ) . '"';
+				$add_html[$k] = $k . '="' . esc_attr( $v ) . '"';
 			}
 
 			unset( $k, $v );

phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/PreferObGetCleanSniff.php

Spacing +4 added lines, -4 removed lines

@@ -42,7 +42,7 @@ 
 		$tokens = $phpcsFile->getTokens();
 
 		// Check if this is ob_get_contents.
-		if ( strtolower( $tokens[ $stackPtr ]['content'] ) !== 'ob_get_contents' ) {
+		if ( strtolower( $tokens[$stackPtr]['content'] ) !== 'ob_get_contents' ) {
 			return;
 		}
 
@@ -61,11 +61,11 @@ 
 		}
 
 		// Check if the next statement is ob_end_clean().
-		if ( $tokens[ $nextToken ]['code'] !== T_STRING ) {
+		if ( $tokens[$nextToken]['code'] !== T_STRING ) {
 			return;
 		}
 
-		if ( strtolower( $tokens[ $nextToken ]['content'] ) !== 'ob_end_clean' ) {
+		if ( strtolower( $tokens[$nextToken]['content'] ) !== 'ob_end_clean' ) {
 			return;
 		}
 
@@ -90,7 +90,7 @@ 
 			$phpcsFile->fixer->replaceToken( $stackPtr, 'ob_get_clean' );
 
 			// Remove everything from after the first semicolon to the second semicolon (inclusive).
-			for ( $i = $semicolon + 1; $i <= $endCleanSemicolon; $i++ ) {
+			for ( $i = $semicolon + 1; $i <= $endCleanSemicolon; $i ++ ) {
 				$phpcsFile->fixer->replaceToken( $i, '' );
 			}