Strategy11 / formidable-forms

phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/SimplifyIssetFalsyCheckSniff.php

Spacing +20 added lines, -20 removed lines

@@ -46,7 +46,7 @@ 
 		// Check if isset is negated with "!".
 		$prevToken = $phpcsFile->findPrevious( T_WHITESPACE, $stackPtr - 1, null, true );
 
-		if ( false === $prevToken || $tokens[ $prevToken ]['code'] !== T_BOOLEAN_NOT ) {
+		if ( false === $prevToken || $tokens[$prevToken]['code'] !== T_BOOLEAN_NOT ) {
 			return;
 		}
 
@@ -55,15 +55,15 @@ 
 		// Find the opening parenthesis after isset.
 		$issetOpenParen = $phpcsFile->findNext( T_WHITESPACE, $stackPtr + 1, null, true );
 
-		if ( false === $issetOpenParen || $tokens[ $issetOpenParen ]['code'] !== T_OPEN_PARENTHESIS ) {
+		if ( false === $issetOpenParen || $tokens[$issetOpenParen]['code'] !== T_OPEN_PARENTHESIS ) {
 			return;
 		}
 
-		if ( ! isset( $tokens[ $issetOpenParen ]['parenthesis_closer'] ) ) {
+		if ( ! isset( $tokens[$issetOpenParen]['parenthesis_closer'] ) ) {
 			return;
 		}
 
-		$issetCloseParen = $tokens[ $issetOpenParen ]['parenthesis_closer'];
+		$issetCloseParen = $tokens[$issetOpenParen]['parenthesis_closer'];
 
 		// Get the variable/expression inside isset().
 		$issetContent = $this->getParenthesesContent( $phpcsFile, $issetOpenParen, $issetCloseParen );
@@ -75,14 +75,14 @@ 
 		// Find the || operator after isset().
 		$orOperator = $phpcsFile->findNext( T_WHITESPACE, $issetCloseParen + 1, null, true );
 
-		if ( false === $orOperator || $tokens[ $orOperator ]['code'] !== T_BOOLEAN_OR ) {
+		if ( false === $orOperator || $tokens[$orOperator]['code'] !== T_BOOLEAN_OR ) {
 			return;
 		}
 
 		// Find the "!" after ||.
 		$secondNot = $phpcsFile->findNext( T_WHITESPACE, $orOperator + 1, null, true );
 
-		if ( false === $secondNot || $tokens[ $secondNot ]['code'] !== T_BOOLEAN_NOT ) {
+		if ( false === $secondNot || $tokens[$secondNot]['code'] !== T_BOOLEAN_NOT ) {
 			return;
 		}
 
@@ -115,8 +115,8 @@ 
 			$phpcsFile->fixer->replaceToken( $notToken, '' );
 
 			// Remove whitespace between "!" and "isset".
-			for ( $i = $notToken + 1; $i < $stackPtr; $i++ ) {
-				if ( $tokens[ $i ]['code'] === T_WHITESPACE ) {
+			for ( $i = $notToken + 1; $i < $stackPtr; $i ++ ) {
+				if ( $tokens[$i]['code'] === T_WHITESPACE ) {
 					$phpcsFile->fixer->replaceToken( $i, '' );
 				}
 			}
@@ -127,7 +127,7 @@ 
 			// Remove everything from after isset's closing paren to end of second expression.
 			$endToken = $secondContent['end'];
 
-			for ( $i = $issetCloseParen + 1; $i <= $endToken; $i++ ) {
+			for ( $i = $issetCloseParen + 1; $i <= $endToken; $i ++ ) {
 				$phpcsFile->fixer->replaceToken( $i, '' );
 			}
 
@@ -150,8 +150,8 @@ 
 		$start   = null;
 		$end     = null;
 
-		for ( $i = $openParen + 1; $i < $closeParen; $i++ ) {
-			if ( $tokens[ $i ]['code'] === T_WHITESPACE ) {
+		for ( $i = $openParen + 1; $i < $closeParen; $i ++ ) {
+			if ( $tokens[$i]['code'] === T_WHITESPACE ) {
 				continue;
 			}
 
@@ -160,7 +160,7 @@ 
 			}
 
 			$end      = $i;
-			$content .= $tokens[ $i ]['content'];
+			$content .= $tokens[$i]['content'];
 		}
 
 		if ( empty( $content ) ) {
@@ -203,8 +203,8 @@ 
 
 		$bracketDepth = 0;
 
-		for ( $i = $startPtr; $i < count( $tokens ); $i++ ) {
-			$code = $tokens[ $i ]['code'];
+		for ( $i = $startPtr; $i < count( $tokens ); $i ++ ) {
+			$code = $tokens[$i]['code'];
 
 			// Skip whitespace.
 			if ( $code === T_WHITESPACE ) {
@@ -213,22 +213,22 @@ 
 
 			// Track bracket depth.
 			if ( $code === T_OPEN_SQUARE_BRACKET ) {
-				++$bracketDepth;
-				$content .= $tokens[ $i ]['content'];
+				++ $bracketDepth;
+				$content .= $tokens[$i]['content'];
 				$end      = $i;
 				continue;
 			}
 
 			if ( $code === T_CLOSE_SQUARE_BRACKET ) {
-				--$bracketDepth;
-				$content .= $tokens[ $i ]['content'];
+				-- $bracketDepth;
+				$content .= $tokens[$i]['content'];
 				$end      = $i;
 				continue;
 			}
 
 			// If we're inside brackets, accept more token types.
 			if ( $bracketDepth > 0 ) {
-				$content .= $tokens[ $i ]['content'];
+				$content .= $tokens[$i]['content'];
 				$end      = $i;
 				continue;
 			}
@@ -238,7 +238,7 @@ 
 				break;
 			}
 
-			$content .= $tokens[ $i ]['content'];
+			$content .= $tokens[$i]['content'];
 			$end      = $i;
 		}
 

phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/SimplifyIssetTruthyCheckSniff.php

Spacing +18 added lines, -18 removed lines

@@ -46,22 +46,22 @@ 
 		// Check that isset is NOT negated (we want `isset()` not `! isset()`).
 		$prevToken = $phpcsFile->findPrevious( T_WHITESPACE, $stackPtr - 1, null, true );
 
-		if ( false !== $prevToken && $tokens[ $prevToken ]['code'] === T_BOOLEAN_NOT ) {
+		if ( false !== $prevToken && $tokens[$prevToken]['code'] === T_BOOLEAN_NOT ) {
 			return;
 		}
 
 		// Find the opening parenthesis after isset.
 		$issetOpenParen = $phpcsFile->findNext( T_WHITESPACE, $stackPtr + 1, null, true );
 
-		if ( false === $issetOpenParen || $tokens[ $issetOpenParen ]['code'] !== T_OPEN_PARENTHESIS ) {
+		if ( false === $issetOpenParen || $tokens[$issetOpenParen]['code'] !== T_OPEN_PARENTHESIS ) {
 			return;
 		}
 
-		if ( ! isset( $tokens[ $issetOpenParen ]['parenthesis_closer'] ) ) {
+		if ( ! isset( $tokens[$issetOpenParen]['parenthesis_closer'] ) ) {
 			return;
 		}
 
-		$issetCloseParen = $tokens[ $issetOpenParen ]['parenthesis_closer'];
+		$issetCloseParen = $tokens[$issetOpenParen]['parenthesis_closer'];
 
 		// Get the variable/expression inside isset().
 		$issetContent = $this->getParenthesesContent( $phpcsFile, $issetOpenParen, $issetCloseParen );
@@ -73,7 +73,7 @@ 
 		// Find the && operator after isset().
 		$andOperator = $phpcsFile->findNext( T_WHITESPACE, $issetCloseParen + 1, null, true );
 
-		if ( false === $andOperator || $tokens[ $andOperator ]['code'] !== T_BOOLEAN_AND ) {
+		if ( false === $andOperator || $tokens[$andOperator]['code'] !== T_BOOLEAN_AND ) {
 			return;
 		}
 
@@ -108,7 +108,7 @@ 
 				T_SPACESHIP,
 			);
 
-			if ( in_array( $tokens[ $afterSecondVar ]['code'], $comparisonOperators, true ) ) {
+			if ( in_array( $tokens[$afterSecondVar]['code'], $comparisonOperators, true ) ) {
 				return;
 			}
 		}
@@ -130,7 +130,7 @@ 
 			// Remove everything from after isset's closing paren to end of second expression.
 			$endToken = $secondContent['end'];
 
-			for ( $i = $issetCloseParen + 1; $i <= $endToken; $i++ ) {
+			for ( $i = $issetCloseParen + 1; $i <= $endToken; $i ++ ) {
 				$phpcsFile->fixer->replaceToken( $i, '' );
 			}
 
@@ -153,8 +153,8 @@ 
 		$start   = null;
 		$end     = null;
 
-		for ( $i = $openParen + 1; $i < $closeParen; $i++ ) {
-			if ( $tokens[ $i ]['code'] === T_WHITESPACE ) {
+		for ( $i = $openParen + 1; $i < $closeParen; $i ++ ) {
+			if ( $tokens[$i]['code'] === T_WHITESPACE ) {
 				continue;
 			}
 
@@ -163,7 +163,7 @@ 
 			}
 
 			$end      = $i;
-			$content .= $tokens[ $i ]['content'];
+			$content .= $tokens[$i]['content'];
 		}
 
 		if ( empty( $content ) ) {
@@ -206,8 +206,8 @@ 
 
 		$bracketDepth = 0;
 
-		for ( $i = $startPtr; $i < count( $tokens ); $i++ ) {
-			$code = $tokens[ $i ]['code'];
+		for ( $i = $startPtr; $i < count( $tokens ); $i ++ ) {
+			$code = $tokens[$i]['code'];
 
 			// Skip whitespace.
 			if ( $code === T_WHITESPACE ) {
@@ -216,22 +216,22 @@ 
 
 			// Track bracket depth.
 			if ( $code === T_OPEN_SQUARE_BRACKET ) {
-				++$bracketDepth;
-				$content .= $tokens[ $i ]['content'];
+				++ $bracketDepth;
+				$content .= $tokens[$i]['content'];
 				$end      = $i;
 				continue;
 			}
 
 			if ( $code === T_CLOSE_SQUARE_BRACKET ) {
-				--$bracketDepth;
-				$content .= $tokens[ $i ]['content'];
+				-- $bracketDepth;
+				$content .= $tokens[$i]['content'];
 				$end      = $i;
 				continue;
 			}
 
 			// If we're inside brackets, accept more token types.
 			if ( $bracketDepth > 0 ) {
-				$content .= $tokens[ $i ]['content'];
+				$content .= $tokens[$i]['content'];
 				$end      = $i;
 				continue;
 			}
@@ -241,7 +241,7 @@ 
 				break;
 			}
 
-			$content .= $tokens[ $i ]['content'];
+			$content .= $tokens[$i]['content'];
 			$end      = $i;
 		}
 

classes/models/FrmField.php

Spacing +35 added lines, -35 removed lines

@@ -363,11 +363,11 @@ 
 			'coupon' => '2026-01-13',
 		);
 
-		if ( ! isset( $release_dates[ $type ] ) ) {
+		if ( ! isset( $release_dates[$type] ) ) {
 			return false;
 		}
 
-		$release_date = $release_dates[ $type ];
+		$release_date = $release_dates[$type];
 
 		$three_months_after_release = gmdate( 'Y-m-d', strtotime( $release_date . ' + 90 days' ) );
 		return gmdate( 'Y-m-d' ) < $three_months_after_release;
@@ -401,8 +401,8 @@ 
 		$values = FrmAppHelper::maybe_filter_array( $values, array( 'name', 'description' ) );
 
 		foreach ( array( 'name', 'description', 'type', 'default_value' ) as $col ) {
-			if ( isset( $values[ $col ] ) ) {
-				$new_values[ $col ] = $values[ $col ];
+			if ( isset( $values[$col] ) ) {
+				$new_values[$col] = $values[$col];
 			}
 		}
 
@@ -414,7 +414,7 @@ 
 		$new_values['created_at']    = current_time( 'mysql', 1 );
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['field_key'] ] = $new_values['field_key'];
+			$frm_duplicate_ids[$values['field_key']] = $new_values['field_key'];
 			$new_values                                = apply_filters( 'frm_duplicated_field', $new_values );
 		}
 
@@ -422,7 +422,7 @@ 
 
 		foreach ( $new_values as $k => $v ) {
 			if ( is_array( $v ) ) {
-				$new_values[ $k ] = $k === 'default_value' ? FrmAppHelper::maybe_json_encode( $v ) : serialize( $v );
+				$new_values[$k] = $k === 'default_value' ? FrmAppHelper::maybe_json_encode( $v ) : serialize( $v );
 			}
 			unset( $k, $v );
 		}
@@ -441,7 +441,7 @@ 
 		}
 
 		if ( isset( $values['id'] ) ) {
-			$frm_duplicate_ids[ $values['id'] ] = $new_id;
+			$frm_duplicate_ids[$values['id']] = $new_id;
 		}
 
 		return $new_id;
@@ -495,7 +495,7 @@ 
 			 *
 			 * @return string
 			 */
-			function ( $match ) {
+			function( $match ) {
 				$attr = shortcode_parse_atts( $match[3] );
 
 				if ( ! is_array( $attr ) ) {
@@ -523,7 +523,7 @@ 
 					}
 
 					if ( FrmAppHelper::input_key_is_safe( $key, 'update' ) ) {
-						$safe_atts[ $key ] = $value;
+						$safe_atts[$key] = $value;
 					}
 				}//end foreach
 
@@ -595,7 +595,7 @@ 
 	public static function duplicate( $old_form_id, $form_id, $copy_keys = false, $blog_id = false ) {
 		global $frm_duplicate_ids;
 
-		$where  = array(
+		$where = array(
 			array(
 				'or'                => 1,
 				'fi.form_id'        => $old_form_id,
@@ -644,8 +644,8 @@ 
 
 			$values                                 = apply_filters( 'frm_duplicated_field', $values );
 			$new_id                                 = self::create( $values );
-			$frm_duplicate_ids[ $field->id ]        = $new_id;
-			$frm_duplicate_ids[ $field->field_key ] = $new_id;
+			$frm_duplicate_ids[$field->id]        = $new_id;
+			$frm_duplicate_ids[$field->field_key] = $new_id;
 			unset( $field );
 		}//end foreach
 	}
@@ -695,11 +695,11 @@ 
 
 		// serialize array values
 		foreach ( array( 'field_options', 'options' ) as $opt ) {
-			if ( isset( $values[ $opt ] ) && is_array( $values[ $opt ] ) ) {
+			if ( isset( $values[$opt] ) && is_array( $values[$opt] ) ) {
 				if ( 'field_options' === $opt ) {
-					$values[ $opt ] = self::maybe_filter_options( $values[ $opt ] );
+					$values[$opt] = self::maybe_filter_options( $values[$opt] );
 				}
-				$values[ $opt ] = serialize( $values[ $opt ] );
+				$values[$opt] = serialize( $values[$opt] );
 			}
 		}
 
@@ -912,8 +912,8 @@ 
 					continue;
 				}
 
-				$fields[ $result->id ] = $result;
-				++$count;
+				$fields[$result->id] = $result;
+				++ $count;
 
 				// phpcs:ignore Universal.Operators.StrictComparisons
 				if ( $limit == 1 ) {
@@ -969,8 +969,8 @@ 
 			$count  = 0;
 
 			foreach ( $results as $result ) {
-				++$count;
-				$fields[ $result->id ] = $result;
+				++ $count;
+				$fields[$result->id] = $result;
 
 				if ( $limit && $count >= $limit ) {
 					break;
@@ -1103,7 +1103,7 @@ 
 		$query_type = $limit === ' LIMIT 1' || $limit == 1 ? 'row' : 'results'; // phpcs:ignore Universal.Operators.StrictComparisons
 
 		if ( is_array( $where ) ) {
-			$args    = array(
+			$args = array(
 				'order_by' => $order_by,
 				'limit'    => $limit,
 			);
@@ -1140,9 +1140,9 @@ 
 				FrmDb::set_cache( $result->field_key, $result, 'frm_field' );
 
 				self::prepare_options( $result );
-				$results[ $r_key ]->field_options = $result->field_options;
-				$results[ $r_key ]->options       = $result->options;
-				$results[ $r_key ]->default_value = $result->default_value;
+				$results[$r_key]->field_options = $result->field_options;
+				$results[$r_key]->options       = $result->options;
+				$results[$r_key]->default_value = $result->default_value;
 
 				unset( $r_key, $result );
 			}
@@ -1238,7 +1238,7 @@ 
 
 			if ( count( $next_fields ) >= self::$transient_size ) {
 				// if this transient is full, check for another
-				++$next;
+				++ $next;
 				self::get_next_transient( $fields, $base_name, $next );
 			}
 		}
@@ -1274,7 +1274,7 @@ 
 				return;
 			}
 
-			++$next;
+			++ $next;
 		}
 	}
 
@@ -1430,7 +1430,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_true_in_array( $field, $option ) {
-		return ! empty( $field[ $option ] );
+		return ! empty( $field[$option] );
 	}
 
 	/**
@@ -1440,7 +1440,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_true_in_object( $field, $option ) {
-		return ! empty( $field->field_options[ $option ] );
+		return ! empty( $field->field_options[$option] );
 	}
 
 	/**
@@ -1450,7 +1450,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_empty_in_array( $field, $option ) {
-		return empty( $field[ $option ] );
+		return empty( $field[$option] );
 	}
 
 	/**
@@ -1460,7 +1460,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_empty_in_object( $field, $option ) {
-		return empty( $field->field_options[ $option ] );
+		return empty( $field->field_options[$option] );
 	}
 
 	/**
@@ -1470,7 +1470,7 @@ 
 	 * @return bool
 	 */
 	public static function is_option_value_in_object( $field, $option ) {
-		return isset( $field->field_options[ $option ] ) && $field->field_options[ $option ] != ''; // phpcs:ignore Universal.Operators.StrictComparisons
+		return isset( $field->field_options[$option] ) && $field->field_options[$option] != ''; // phpcs:ignore Universal.Operators.StrictComparisons
 	}
 
 	/**
@@ -1492,10 +1492,10 @@ 
 	 * @return mixed
 	 */
 	public static function get_option_in_array( $field, $option ) {
-		if ( isset( $field[ $option ] ) ) {
-			$this_option = $field[ $option ];
-		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][ $option ] ) ) {
-			$this_option = $field['field_options'][ $option ];
+		if ( isset( $field[$option] ) ) {
+			$this_option = $field[$option];
+		} elseif ( isset( $field['field_options'] ) && is_array( $field['field_options'] ) && isset( $field['field_options'][$option] ) ) {
+			$this_option = $field['field_options'][$option];
 		} else {
 			$this_option = '';
 		}
@@ -1510,7 +1510,7 @@ 
 	 * @return mixed
 	 */
 	public static function get_option_in_object( $field, $option ) {
-		return $field->field_options[ $option ] ?? '';
+		return $field->field_options[$option] ?? '';
 	}
 
 	/**

classes/helpers/FrmAppHelper.php

Spacing +86 added lines, -86 removed lines

@@ -330,7 +330,7 @@ 
 			'fill'   => '#4d4d4d',
 			'orange' => '#f05a24',
 		);
-		$atts     = array_merge( $defaults, $atts );
+		$atts = array_merge( $defaults, $atts );
 
 		return '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 599.68 601.37" width="' . esc_attr( $atts['width'] ) . '" height="' . esc_attr( $atts['height'] ) . '">
 			<path fill="' . esc_attr( $atts['orange'] ) . '" d="M289.6 384h140v76h-140z"/>
@@ -629,7 +629,7 @@ 
 	 * @return string
 	 */
 	public static function get_server_value( $value ) {
-		return isset( $_SERVER[ $value ] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[ $value ] ) ) : '';
+		return isset( $_SERVER[$value] ) ? wp_strip_all_tags( wp_unslash( $_SERVER[$value] ) ) : '';
 	}
 
 	/**
@@ -663,7 +663,7 @@ 
 		$ip         = '';
 
 		foreach ( $ip_options as $key ) {
-			if ( ! isset( $_SERVER[ $key ] ) ) {
+			if ( ! isset( $_SERVER[$key] ) ) {
 				continue;
 			}
 
@@ -741,11 +741,11 @@ 
 		}
 
 		if ( $src === 'get' ) {
-			$value = isset( $_POST[ $param ] ) ? wp_unslash( $_POST[ $param ] ) : ( isset( $_GET[ $param ] ) ? wp_unslash( $_GET[ $param ] ) : $default ); // phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
+			$value = isset( $_POST[$param] ) ? wp_unslash( $_POST[$param] ) : ( isset( $_GET[$param] ) ? wp_unslash( $_GET[$param] ) : $default ); // phpcs:ignore WordPress.Security.NonceVerification.Missing, WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
 
-			if ( ! isset( $_POST[ $param ] ) && isset( $_GET[ $param ] ) && ! is_array( $value ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( ! isset( $_POST[$param] ) && isset( $_GET[$param] ) && ! is_array( $value ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = htmlspecialchars_decode( wp_unslash( $_GET[ $param ] ) );
+				$value = htmlspecialchars_decode( wp_unslash( $_GET[$param] ) );
 			}
 			self::sanitize_value( $sanitize, $value );
 		} else {
@@ -766,7 +766,7 @@ 
 				}
 
 				$p     = trim( $p, ']' );
-				$value = $value[ $p ] ?? $default;
+				$value = $value[$p] ?? $default;
 			}
 		}
 
@@ -832,28 +832,28 @@ 
 			'sanitize'   => 'sanitize_text_field',
 			'serialized' => false,
 		);
-		$args     = wp_parse_args( $args, $defaults );
+		$args = wp_parse_args( $args, $defaults );
 
 		$value = $args['default'];
 
 		if ( $args['type'] === 'get' ) {
-			if ( $_GET && isset( $_GET[ $args['param'] ] ) ) {
+			if ( $_GET && isset( $_GET[$args['param']] ) ) {
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
-				$value = wp_unslash( $_GET[ $args['param'] ] );
+				$value = wp_unslash( $_GET[$args['param']] );
 			}
 		} elseif ( $args['type'] === 'post' ) {
-			if ( isset( $_POST[ $args['param'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( isset( $_POST[$args['param']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
-				$value = wp_unslash( $_POST[ $args['param'] ] );
+				$value = wp_unslash( $_POST[$args['param']] );
 
 				if ( $args['serialized'] === true && is_serialized_string( $value ) && is_serialized( $value ) ) {
 					self::unserialize_or_decode( $value );
 				}
 			}
-		} elseif ( isset( $_REQUEST[ $args['param'] ] ) ) {
+		} elseif ( isset( $_REQUEST[$args['param']] ) ) {
 			// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				// phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized
-				$value = wp_unslash( $_REQUEST[ $args['param'] ] );
+				$value = wp_unslash( $_REQUEST[$args['param']] );
 		}
 
 		self::sanitize_value( $args['sanitize'], $value );
@@ -902,7 +902,7 @@ 
 			$temp_values = $value;
 
 			foreach ( $temp_values as $k => $v ) {
-				self::sanitize_value( $sanitize, $value[ $k ] );
+				self::sanitize_value( $sanitize, $value[$k] );
 			}
 
 			return;
@@ -921,8 +921,8 @@ 
 		$temp_values = $values;
 
 		foreach ( $temp_values as $k => $val ) {
-			if ( isset( $sanitize_method[ $k ] ) ) {
-				$values[ $k ] = call_user_func( $sanitize_method[ $k ], $val );
+			if ( isset( $sanitize_method[$k] ) ) {
+				$values[$k] = call_user_func( $sanitize_method[$k], $val );
 			}
 		}
 	}
@@ -986,7 +986,7 @@ 
 			$temp_values = $value;
 
 			foreach ( $temp_values as $k => $v ) {
-				self::decode_specialchars( $value[ $k ] );
+				self::decode_specialchars( $value[$k] );
 			}
 		} else {
 			self::decode_amp( $value );
@@ -1129,7 +1129,7 @@ 
 	 * @return array
 	 */
 	public static function add_allowed_submit_button_tags( $allowed_html ) {
-		$allowed_html['input']                    = array(
+		$allowed_html['input'] = array(
 			'type'           => true,
 			'value'          => true,
 			'formnovalidate' => true,
@@ -1157,7 +1157,7 @@ 
 			$allowed_html = $html;
 		} elseif ( $allowed ) {
 			foreach ( (array) $allowed as $a ) {
-				$allowed_html[ $a ] = $html[ $a ] ?? array();
+				$allowed_html[$a] = $html[$a] ?? array();
 			}
 		}
 
@@ -1349,8 +1349,8 @@ 
 
 		global $wp_query;
 
-		if ( isset( $wp_query->query_vars[ $param ] ) ) {
-			$value = $wp_query->query_vars[ $param ];
+		if ( isset( $wp_query->query_vars[$param] ) ) {
+			$value = $wp_query->query_vars[$param];
 		}
 
 		return $value;
@@ -1384,9 +1384,9 @@ 
 			'frm_keyalt_solid_icon' => 'frm_key_solid_icon',
 		);
 
-		if ( isset( $deprecated[ $icon ] ) ) {
-			$icon  = $deprecated[ $icon ];
-			$class = str_replace( $icon, $deprecated[ $icon ], $class );
+		if ( isset( $deprecated[$icon] ) ) {
+			$icon  = $deprecated[$icon];
+			$class = str_replace( $icon, $deprecated[$icon], $class );
 		}
 
 		if ( $icon === $class ) {
@@ -1520,7 +1520,7 @@ 
 	 * @return string|void
 	 */
 	public static function array_to_html_params( $atts, $echo = false ) {
-		$callback = function () use ( $atts ) {
+		$callback = function() use ( $atts ) {
 			if ( $atts ) {
 				foreach ( $atts as $key => $value ) {
 					echo ' ' . esc_attr( $key ) . '="' . esc_attr( $value ) . '"';
@@ -1709,7 +1709,7 @@ 
 			'value'       => false,
 			'class'       => '',
 		);
-		$atts     = array_merge( $defaults, $atts );
+		$atts = array_merge( $defaults, $atts );
 
 		if ( $atts['input_id'] === 'template' && empty( $atts['tosearch'] ) ) {
 			$atts['tosearch'] = 'frm-card';
@@ -1789,7 +1789,7 @@ 
 				'new_file_path' => self::plugin_path() . '/js',
 			)
 		);
-		$new_file  = new FrmCreateFile( $file_atts );
+		$new_file = new FrmCreateFile( $file_atts );
 
 		$files = array(
 			self::plugin_path() . '/js/formidable.min.js',
@@ -2009,8 +2009,8 @@ 
 	 */
 	private static function get_dropdown_value_and_label_from_option( $option, $key, $args ) {
 		if ( is_array( $option ) ) {
-			$value = $option[ $args['value_key'] ] ?? '';
-			$label = $option[ $args['label_key'] ] ?? '';
+			$value = $option[$args['value_key']] ?? '';
+			$label = $option[$args['label_key']] ?? '';
 		} else {
 			$value = $key;
 			$label = $option;
@@ -2418,9 +2418,9 @@ 
 			return $error;
 		}
 
-		$nonce_value = $_REQUEST && isset( $_REQUEST[ $nonce_name ] ) ? sanitize_text_field( wp_unslash( $_REQUEST[ $nonce_name ] ) ) : '';
+		$nonce_value = $_REQUEST && isset( $_REQUEST[$nonce_name] ) ? sanitize_text_field( wp_unslash( $_REQUEST[$nonce_name] ) ) : '';
 
-		if ( $_REQUEST && ( ! isset( $_REQUEST[ $nonce_name ] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
+		if ( $_REQUEST && ( ! isset( $_REQUEST[$nonce_name] ) || ! wp_verify_nonce( $nonce_value, $nonce ) ) ) {
 			$frm_settings = self::get_settings();
 			$error        = $frm_settings->admin_permission;
 		}
@@ -2473,7 +2473,7 @@ 
 			} else {
 				foreach ( $value as $k => $v ) {
 					if ( ! is_array( $v ) ) {
-						$value[ $k ] = call_user_func( $original_function, $v );
+						$value[$k] = call_user_func( $original_function, $v );
 					}
 				}
 			}
@@ -2527,7 +2527,7 @@ 
 			if ( is_array( $value ) ) {
 				$return = array_merge( $return, self::array_flatten( $value, $keys ) );
 			} elseif ( $keys === 'keep' ) {
-					$return[ $key ] = $value;
+					$return[$key] = $value;
 			} else {
 				$return[] = $value;
 			}
@@ -2620,11 +2620,11 @@ 
 
 		$ver = $default;
 
-		if ( ! isset( $wp_scripts->registered[ $handle ] ) ) {
+		if ( ! isset( $wp_scripts->registered[$handle] ) ) {
 			return $ver;
 		}
 
-		$query = $wp_scripts->registered[ $handle ];
+		$query = $wp_scripts->registered[$handle];
 
 		if ( is_object( $query ) && ! empty( $query->ver ) ) {
 			$ver = $query->ver;
@@ -2642,7 +2642,7 @@ 
 	 * @return string|null
 	 */
 	public static function js_redirect( $url, $echo = false ) {
-		$callback = function () use ( $url ) {
+		$callback = function() use ( $url ) {
 			echo '<script type="text/javascript">window.location="' . esc_url_raw( $url ) . '"</script>';
 		};
 		return self::clip( $callback, $echo );
@@ -2741,7 +2741,7 @@ 
 			$suffix = 2;
 			do {
 				$key_check = $key . $separator . $suffix;
-				++$suffix;
+				++ $suffix;
 			} while ( in_array( $key_check, $similar_keys, true ) );
 
 			$key = $key_check;
@@ -2860,7 +2860,7 @@ 
 
 		foreach ( array( 'name', 'description' ) as $var ) {
 			$default_val    = $record->{$var} ?? '';
-			$values[ $var ] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
+			$values[$var] = self::get_param( $var, $default_val, 'get', 'wp_kses_post' );
 			unset( $var, $default_val );
 		}
 
@@ -2933,10 +2933,10 @@ 
 			$meta_value = FrmEntryMeta::get_meta_value( $record, $field->id );
 		}//end if
 
-		$field_type = $post_values['field_options'][ 'type_' . $field->id ] ?? $field->type;
+		$field_type = $post_values['field_options']['type_' . $field->id] ?? $field->type;
 
-		if ( isset( $post_values['item_meta'][ $field->id ] ) ) {
-			$new_value = $post_values['item_meta'][ $field->id ];
+		if ( isset( $post_values['item_meta'][$field->id] ) ) {
+			$new_value = $post_values['item_meta'][$field->id];
 			self::unserialize_or_decode( $new_value );
 		} else {
 			$new_value = $meta_value;
@@ -2957,7 +2957,7 @@ 
 
 		$field_array = array_merge( (array) $field->field_options, $field_array );
 
-		$values['fields'][ $field->id ] = $field_array;
+		$values['fields'][$field->id] = $field_array;
 	}
 
 	/**
@@ -3007,11 +3007,11 @@ 
 		}
 
 		foreach ( $form->options as $opt => $value ) {
-			if ( isset( $post_values[ $opt ] ) ) {
-				$values[ $opt ] = $post_values[ $opt ];
-				self::unserialize_or_decode( $values[ $opt ] );
+			if ( isset( $post_values[$opt] ) ) {
+				$values[$opt] = $post_values[$opt];
+				self::unserialize_or_decode( $values[$opt] );
 			} else {
-				$values[ $opt ] = $value;
+				$values[$opt] = $value;
 			}
 		}
 
@@ -3031,8 +3031,8 @@ 
 
 		foreach ( $form_defaults as $opt => $default ) {
 			// phpcs:ignore Universal.Operators.StrictComparisons
-			if ( ! isset( $values[ $opt ] ) || $values[ $opt ] == '' ) {
-				$values[ $opt ] = $post_values['options'][ $opt ] ?? $default;
+			if ( ! isset( $values[$opt] ) || $values[$opt] == '' ) {
+				$values[$opt] = $post_values['options'][$opt] ?? $default;
 			}
 
 			unset( $opt, $default );
@@ -3043,8 +3043,8 @@ 
 		}
 
 		foreach ( array( 'before', 'after', 'submit' ) as $h ) {
-			if ( ! isset( $values[ $h . '_html' ] ) ) {
-				$values[ $h . '_html' ] = $post_values['options'][ $h . '_html' ] ?? FrmFormsHelper::get_default_html( $h );
+			if ( ! isset( $values[$h . '_html'] ) ) {
+				$values[$h . '_html'] = $post_values['options'][$h . '_html'] ?? FrmFormsHelper::get_default_html( $h );
 			}
 			unset( $h );
 		}
@@ -3261,12 +3261,12 @@ 
 			// Show time in specified unit.
 			$levels = self::get_unit( $levels );
 
-			if ( isset( $time_strings[ $levels ] ) ) {
+			if ( isset( $time_strings[$levels] ) ) {
 				$diff         = array(
 					$levels => self::time_format( $levels, $diff ),
 				);
 				$time_strings = array(
-					$levels => $time_strings[ $levels ],
+					$levels => $time_strings[$levels],
 				);
 			}
 
@@ -3274,13 +3274,13 @@ 
 		}
 
 		foreach ( $time_strings as $k => $v ) {
-			if ( ! empty( $diff[ $k ] ) ) {
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . ( $diff[ $k ] > 1 ? $v[1] : $v[0] );
-			} elseif ( isset( $diff[ $k ] ) && count( $time_strings ) === 1 ) {
+			if ( ! empty( $diff[$k] ) ) {
+				$time_strings[$k] = $diff[$k] . ' ' . ( $diff[$k] > 1 ? $v[1] : $v[0] );
+			} elseif ( isset( $diff[$k] ) && count( $time_strings ) === 1 ) {
 				// Account for 0.
-				$time_strings[ $k ] = $diff[ $k ] . ' ' . $v[1];
+				$time_strings[$k] = $diff[$k] . ' ' . $v[1];
 			} else {
-				unset( $time_strings[ $k ] );
+				unset( $time_strings[$k] );
 			}
 		}
 
@@ -3304,8 +3304,8 @@ 
 			'd' => 'days',
 		);
 
-		if ( isset( $return[ $unit ] ) ) {
-			return $diff[ $return[ $unit ] ];
+		if ( isset( $return[$unit] ) ) {
+			return $diff[$return[$unit]];
 		}
 
 		$total = $diff['days'] * self::convert_time( 'd', $unit );
@@ -3313,11 +3313,11 @@ 
 		$times = array( 'h', 'i', 's' );
 
 		foreach ( $times as $time ) {
-			if ( ! isset( $diff[ $time ] ) ) {
+			if ( ! isset( $diff[$time] ) ) {
 				continue;
 			}
 
-			$total += $diff[ $time ] * self::convert_time( $time, $unit );
+			$total += $diff[$time] * self::convert_time( $time, $unit );
 		}
 
 		return floor( $total );
@@ -3342,7 +3342,7 @@ 
 			'y' => DAY_IN_SECONDS * 365.25,
 		);
 
-		return $convert[ $from ] / $convert[ $to ];
+		return $convert[$from] / $convert[$to];
 	}
 
 	/**
@@ -3355,7 +3355,7 @@ 
 	private static function get_unit( $unit ) {
 		$units = self::get_time_strings();
 
-		if ( isset( $units[ $unit ] ) || is_numeric( $unit ) ) {
+		if ( isset( $units[$unit] ) || is_numeric( $unit ) ) {
 			return $unit;
 		}
 
@@ -3481,17 +3481,17 @@ 
 
 					case 1:
 						$l2 = $name;
-						self::add_value_to_array( $name, $l2, $this_val, $vars[ $l1 ] );
+						self::add_value_to_array( $name, $l2, $this_val, $vars[$l1] );
 						break;
 
 					case 2:
 						$l3 = $name;
-						self::add_value_to_array( $name, $l3, $this_val, $vars[ $l1 ][ $l2 ] );
+						self::add_value_to_array( $name, $l3, $this_val, $vars[$l1][$l2] );
 						break;
 
 					case 3:
 						$l4 = $name;
-						self::add_value_to_array( $name, $l4, $this_val, $vars[ $l1 ][ $l2 ][ $l3 ] );
+						self::add_value_to_array( $name, $l4, $this_val, $vars[$l1][$l2][$l3] );
 				}
 
 				unset( $this_val, $n );
@@ -3515,8 +3515,8 @@ 
 		// phpcs:ignore Universal.Operators.StrictComparisons
 		if ( $name == '' ) {
 			$vars[] = $val;
-		} elseif ( ! isset( $vars[ $l1 ] ) ) {
-			$vars[ $l1 ] = $val;
+		} elseif ( ! isset( $vars[$l1] ) ) {
+			$vars[$l1] = $val;
 		}
 	}
 
@@ -3540,7 +3540,7 @@ 
 			'new_tab'       => __( 'This option will open the link in a new browser tab. Please note that some popup blockers may prevent this from happening, in which case the link will be displayed.', 'formidable' ),
 		);
 
-		if ( ! isset( $tooltips[ $name ] ) ) {
+		if ( ! isset( $tooltips[$name] ) ) {
 			return;
 		}
 
@@ -3550,7 +3550,7 @@ 
 			echo ' class="frm_help"';
 		}
 
-		echo ' title="' . esc_attr( $tooltips[ $name ] );
+		echo ' title="' . esc_attr( $tooltips[$name] );
 
 		if ( 'open' !== $class ) {
 			echo '"';
@@ -3622,13 +3622,13 @@ 
 	 * @return void
 	 */
 	private static function prepare_action_slashes( $val, $key, &$post_content ) {
-		if ( ! isset( $post_content[ $key ] ) || is_numeric( $val ) ) {
+		if ( ! isset( $post_content[$key] ) || is_numeric( $val ) ) {
 			return;
 		}
 
 		if ( is_array( $val ) ) {
 			foreach ( $val as $k1 => $v1 ) {
-				self::prepare_action_slashes( $v1, $k1, $post_content[ $key ] );
+				self::prepare_action_slashes( $v1, $k1, $post_content[$key] );
 				unset( $k1, $v1 );
 			}
 		} else {
@@ -3636,7 +3636,7 @@ 
 			$val = stripslashes( $val );
 
 			// Add backslashes before double quotes and forward slashes only
-			$post_content[ $key ] = addcslashes( $val, '"\\/' );
+			$post_content[$key] = addcslashes( $val, '"\\/' );
 		}
 	}
 
@@ -3765,14 +3765,14 @@ 
 
 			$key = $input['name'];
 
-			if ( isset( $formatted[ $key ] ) ) {
-				if ( is_array( $formatted[ $key ] ) ) {
-					$formatted[ $key ][] = $input['value'];
+			if ( isset( $formatted[$key] ) ) {
+				if ( is_array( $formatted[$key] ) ) {
+					$formatted[$key][] = $input['value'];
 				} else {
-					$formatted[ $key ] = array( $formatted[ $key ], $input['value'] );
+					$formatted[$key] = array( $formatted[$key], $input['value'] );
 				}
 			} else {
-				$formatted[ $key ] = $input['value'];
+				$formatted[$key] = $input['value'];
 			}
 		}
 
@@ -4503,8 +4503,8 @@ 
 		}
 
 		foreach ( $keys as $key ) {
-			if ( isset( $values[ $key ] ) ) {
-				$values[ $key ] = self::kses( $values[ $key ], 'all' );
+			if ( isset( $values[$key] ) ) {
+				$values[$key] = self::kses( $values[$key], 'all' );
 			}
 		}
 
@@ -4571,7 +4571,7 @@ 
 				'role',
 				'style',
 			);
-			$safe      = in_array( $key, $safe_keys, true );
+			$safe = in_array( $key, $safe_keys, true );
 		}//end if
 
 		/**
@@ -4724,7 +4724,7 @@ 
 			return 0;
 		}
 
-		return strlen( $parts[ count( $parts ) - 1 ] );
+		return strlen( $parts[count( $parts ) - 1] );
 	}
 
 	/**
@@ -4744,7 +4744,7 @@ 
 
 		add_filter(
 			'option_gmt_offset',
-			function ( $offset ) {
+			function( $offset ) {
 				if ( ! is_string( $offset ) || is_numeric( $offset ) ) {
 					// Leave a valid value alone.
 					return $offset;
@@ -4841,7 +4841,7 @@ 
 			return;
 		}
 
-		$ajax_callback = function () use ( $option ) {
+		$ajax_callback = function() use ( $option ) {
 			self::dismiss_warning_message( $option );
 		};
 
@@ -4851,7 +4851,7 @@ 
 
 		add_filter(
 			'frm_message_list',
-			function ( $show_messages ) use ( $message, $option ) {
+			function( $show_messages ) use ( $message, $option ) {
 				if ( get_option( $option, false ) ) {
 					return $show_messages;
 				}

classes/helpers/FrmEntriesHelper.php

Spacing +29 added lines, -29 removed lines

@@ -153,10 +153,10 @@ 
 			$repeating = ! empty( $args['repeating'] );
 
 			if ( $repeating ) {
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				if ( isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 					$value_is_posted = true;
 				}
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			} elseif ( isset( $_POST['item_meta'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$value_is_posted = true;
 			}
 		}
@@ -200,14 +200,14 @@ 
 		preg_match_all( "/\[(default-message|default_message)\b(.*?)(?:(\/))?\]/s", $message, $shortcodes, PREG_PATTERN_ORDER );
 
 		foreach ( $shortcodes[0] as $short_key => $tag ) {
-			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][ $short_key ] );
+			$add_atts = FrmShortcodeHelper::get_shortcode_attribute_array( $shortcodes[2][$short_key] );
 
 			$this_atts = ! empty( $add_atts ) ? array_merge( $atts, $add_atts ) : $atts;
 
 			$default = FrmEntriesController::show_entry_shortcode( $this_atts );
 
 			// Add the default message.
-			$message = str_replace( $shortcodes[0][ $short_key ], $default, $message );
+			$message = str_replace( $shortcodes[0][$short_key], $default, $message );
 		}
 
 		return $message;
@@ -221,7 +221,7 @@ 
 	 * @return string
 	 */
 	public static function prepare_display_value( $entry, $field, $atts ) {
-		$field_value = $entry->metas[ $field->id ] ?? false;
+		$field_value = $entry->metas[$field->id] ?? false;
 
 		if ( FrmAppHelper::pro_is_installed() ) {
 			$empty = empty( $field_value );
@@ -252,7 +252,7 @@ 
 			$child_entries = FrmEntry::getAll( array( 'it.parent_item_id' => $entry->id ), '', '', true );
 		} else {
 			// Get all values for this field.
-			$child_values = $entry->metas[ $atts['embedded_field_id'] ] ?? false;
+			$child_values = $entry->metas[$atts['embedded_field_id']] ?? false;
 
 			if ( $child_values ) {
 				$child_entries = FrmEntry::getAll( array( 'it.id' => (array) $child_values ) );
@@ -385,7 +385,7 @@ 
 		}
 
 		if ( empty( $args['parent_field_id'] ) ) {
-			$_POST['item_meta'][ $field->id ] = $value;
+			$_POST['item_meta'][$field->id] = $value;
 		} else {
 			self::set_parent_field_posted_value( $field, $value, $args );
 		}
@@ -403,17 +403,17 @@ 
 	 * @return void
 	 */
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $_POST['item_meta'][$args['parent_field_id']] ) && is_array( $_POST['item_meta'][$args['parent_field_id']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( ! isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) || ! is_array( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 		} else {
 			// All of the section was probably removed.
-			$_POST['item_meta'][ $args['parent_field_id'] ]                         = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$_POST['item_meta'][$args['parent_field_id']]                         = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 		}
 
-		$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] = $value; // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		$_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field->id] = $value; // phpcs:ignore WordPress.Security.NonceVerification.Missing
 	}
 
 	/**
@@ -460,9 +460,9 @@ 
 	private static function get_posted_meta( $field_id, $args ) {
 		if ( empty( $args['parent_field_id'] ) ) {
 			// Sanitizing is done next.
-			$value = isset( $_POST['item_meta'][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $field_id ] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = isset( $_POST['item_meta'][$field_id] ) ? wp_unslash( $_POST['item_meta'][$field_id] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 		} else {
-			$value = isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) ? wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field_id ] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$value = isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) ? wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']][$field_id] ) : ''; // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 		}
 		return $value;
 	}
@@ -496,14 +496,14 @@ 
 		self::set_other_repeating_vals( $field, $value, $args );
 
 		// Check if there are any posted "Other" values.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 
 			// Save original value.
 			$args['temp_value'] = $value;
 			$args['other']      = true;
 
 			// Sanitizing is done next.
-			$other_vals = wp_unslash( $_POST['item_meta']['other'][ $field->id ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$other_vals = wp_unslash( $_POST['item_meta']['other'][$field->id] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
 
 			// Set the validation value now
@@ -528,12 +528,12 @@ 
 		}
 
 		// Check if there are any other posted "other" values for this field.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// Save original value
 			$args['temp_value'] = $value;
 			$args['other']      = true;
 
-			$other_vals = wp_unslash( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
+			$other_vals = wp_unslash( $_POST['item_meta'][$args['parent_field_id']][$args['key_pointer']]['other'][$field->id] ); // phpcs:ignore WordPress.Security.ValidatedSanitizedInput.InputNotSanitized, WordPress.Security.NonceVerification.Missing
 			FrmAppHelper::sanitize_value( 'sanitize_text_field', $other_vals );
 
 			// Set the validation value now.
@@ -562,7 +562,7 @@ 
 		if ( is_array( $value ) && $field->type === 'checkbox' ) {
 			// Combine "Other" values with checked values. "Other" values will override checked box values.
 			foreach ( $other_vals as $k => $v ) {
-				if ( isset( $value[ $k ] ) && trim( $v ) === '' ) {
+				if ( isset( $value[$k] ) && trim( $v ) === '' ) {
 					// If the other box is checked, but doesn't have a value.
 					$value = '';
 					break;
@@ -580,26 +580,26 @@ 
 			// Multi-select dropdown.
 			if ( is_array( $value ) ) {
 				// phpcs:ignore WordPress.PHP.StrictInArray.MissingTrueStrict
-				$o_key = array_search( $field->options[ $other_key ], $value );
+				$o_key = array_search( $field->options[$other_key], $value );
 
 				if ( $o_key !== false ) {
 					// Modify the original value so other key will be preserved.
-					$value[ $other_key ] = $value[ $o_key ];
+					$value[$other_key] = $value[$o_key];
 
 					// By default, the array keys will be numeric for multi-select dropdowns.
 					// If going backwards and forwards between pages, the array key will match the other key.
 					if ( $o_key !== $other_key ) {
-						unset( $value[ $o_key ] );
+						unset( $value[$o_key] );
 					}
 
 					$args['temp_value']  = $value;
-					$value[ $other_key ] = reset( $other_vals );
+					$value[$other_key] = reset( $other_vals );
 
-					if ( FrmAppHelper::is_empty_value( $value[ $other_key ] ) ) {
-						unset( $value[ $other_key ] );
+					if ( FrmAppHelper::is_empty_value( $value[$other_key] ) ) {
+						unset( $value[$other_key] );
 					}
 				}
-			} elseif ( $field->options[ $other_key ] == $value ) { // phpcs:ignore Universal.Operators.StrictComparisons
+			} elseif ( $field->options[$other_key] == $value ) { // phpcs:ignore Universal.Operators.StrictComparisons
 				$value = $other_vals;
 			}//end if
 		}//end if
@@ -858,7 +858,7 @@ 
 	 * @return void
 	 */
 	public static function maybe_render_captcha_score( $entry_id ) {
-		$query                 = array(
+		$query = array(
 			'item_id'  => (int) $entry_id,
 			'field_id' => 0,
 		);
@@ -913,7 +913,7 @@ 
 	public static function get_entry_status_label( $status ) {
 		$statuses = self::get_entry_statuses();
 
-		return $statuses[ self::get_entry_status( $status ) ];
+		return $statuses[self::get_entry_status( $status )];
 	}
 
 	/**

Braces +16 added lines, -8 removed lines

@@ -149,14 +149,17 @@ 
 	public static function value_is_posted( $field, $args ) {
 		$value_is_posted = false;
 
-		if ( $_POST ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( $_POST ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			$repeating = ! empty( $args['repeating'] );
 
 			if ( $repeating ) {
-				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+				if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ][ $field->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 					$value_is_posted = true;
 				}
-			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+			} elseif ( isset( $_POST['item_meta'][ $field->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$value_is_posted = true;
 			}
 		}
@@ -403,8 +406,10 @@ 
 	 * @return void
 	 */
 	private static function set_parent_field_posted_value( $field, $value, $args ) {
-		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
-			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( isset( $_POST['item_meta'][ $args['parent_field_id'] ] ) && is_array( $_POST['item_meta'][ $args['parent_field_id'] ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
+			if ( ! isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) || ! is_array( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 				$_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ] = array(); // phpcs:ignore WordPress.Security.NonceVerification.Missing
 			}
 		} else {
@@ -496,7 +501,8 @@ 
 		self::set_other_repeating_vals( $field, $value, $args );
 
 		// Check if there are any posted "Other" values.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta']['other'][ $field->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 
 			// Save original value.
 			$args['temp_value'] = $value;
@@ -528,7 +534,8 @@ 
 		}
 
 		// Check if there are any other posted "other" values for this field.
-		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) { // phpcs:ignore WordPress.Security.NonceVerification.Missing
+		if ( FrmField::is_option_true( $field, 'other' ) && isset( $_POST['item_meta'][ $args['parent_field_id'] ][ $args['key_pointer'] ]['other'][ $field->id ] ) ) {
+// phpcs:ignore WordPress.Security.NonceVerification.Missing
 			// Save original value
 			$args['temp_value'] = $value;
 			$args['other']      = true;
@@ -599,7 +606,8 @@ 
 						unset( $value[ $other_key ] );
 					}
 				}
-			} elseif ( $field->options[ $other_key ] == $value ) { // phpcs:ignore Universal.Operators.StrictComparisons
+			} elseif ( $field->options[ $other_key ] == $value ) {
+// phpcs:ignore Universal.Operators.StrictComparisons
 				$value = $other_vals;
 			}//end if
 		}//end if