Completed
Push — master ( 46650c...1b0636 )
by Stephanie
03:46
created
classes/models/FrmEntryValidate.php 1 patch
Spacing   +45 added lines, -45 removed lines patch added patch discarded remove patch
@@ -7,20 +7,20 @@  discard block
 block discarded – undo
7 7
         FrmEntry::sanitize_entry_post( $values );
8 8
         $errors = array();
9 9
 
10
-        if ( ! isset($values['form_id']) || ! isset($values['item_meta']) ) {
10
+        if ( ! isset( $values['form_id'] ) || ! isset( $values['item_meta'] ) ) {
11 11
             $errors['form'] = __( 'There was a problem with your submission. Please try again.', 'formidable' );
12 12
             return $errors;
13 13
         }
14 14
 
15
-		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values[ 'frm_submit_entry_' . $values['form_id'] ] ) || ! wp_verify_nonce( $values[ 'frm_submit_entry_' . $values['form_id'] ], 'frm_submit_entry_nonce' ) ) ) {
15
+		if ( FrmAppHelper::is_admin() && is_user_logged_in() && ( ! isset( $values['frm_submit_entry_' . $values['form_id']] ) || ! wp_verify_nonce( $values['frm_submit_entry_' . $values['form_id']], 'frm_submit_entry_nonce' ) ) ) {
16 16
             $errors['form'] = __( 'You do not have permission to do that', 'formidable' );
17 17
         }
18 18
 
19
-        if ( ! isset($values['item_key']) || $values['item_key'] == '' ) {
20
-            $_POST['item_key'] = $values['item_key'] = FrmAppHelper::get_unique_key('', $wpdb->prefix .'frm_items', 'item_key');
19
+        if ( ! isset( $values['item_key'] ) || $values['item_key'] == '' ) {
20
+            $_POST['item_key'] = $values['item_key'] = FrmAppHelper::get_unique_key( '', $wpdb->prefix . 'frm_items', 'item_key' );
21 21
         }
22 22
 
23
-        $where = apply_filters('frm_posted_field_ids', array( 'fi.form_id' => $values['form_id'] ) );
23
+        $where = apply_filters( 'frm_posted_field_ids', array( 'fi.form_id' => $values['form_id'] ) );
24 24
 		// Don't get subfields
25 25
 		$where['fr.parent_form_id'] = array( null, 0 );
26 26
 		// Don't get excluded fields (like file upload fields in the ajax validation)
@@ -28,20 +28,20 @@  discard block
 block discarded – undo
28 28
 			$where['fi.type not'] = $exclude;
29 29
 		}
30 30
 
31
-        $posted_fields = FrmField::getAll($where, 'field_order');
31
+        $posted_fields = FrmField::getAll( $where, 'field_order' );
32 32
 
33 33
         // Pass exclude value to validate_field function so it can be used for repeating sections
34 34
         $args = array( 'exclude' => $exclude );
35 35
 
36 36
         foreach ( $posted_fields as $posted_field ) {
37
-            self::validate_field($posted_field, $errors, $values, $args);
38
-            unset($posted_field);
37
+            self::validate_field( $posted_field, $errors, $values, $args );
38
+            unset( $posted_field );
39 39
         }
40 40
 
41 41
         // check for spam
42 42
         self::spam_check( $exclude, $values, $errors );
43 43
 
44
-        $errors = apply_filters( 'frm_validate_entry', $errors, $values, compact('exclude') );
44
+        $errors = apply_filters( 'frm_validate_entry', $errors, $values, compact( 'exclude' ) );
45 45
 
46 46
         return $errors;
47 47
     }
@@ -55,8 +55,8 @@  discard block
 block discarded – undo
55 55
         );
56 56
         $args = wp_parse_args( $args, $defaults );
57 57
 
58
-        if ( empty($args['parent_field_id']) ) {
59
-			$value = isset( $values['item_meta'][ $args['id'] ] ) ? $values['item_meta'][ $args['id'] ] : '';
58
+        if ( empty( $args['parent_field_id'] ) ) {
59
+			$value = isset( $values['item_meta'][$args['id']] ) ? $values['item_meta'][$args['id']] : '';
60 60
         } else {
61 61
             // value is from a nested form
62 62
             $value = $values;
@@ -65,32 +65,32 @@  discard block
 block discarded – undo
65 65
         // Check for values in "Other" fields
66 66
         FrmEntriesHelper::maybe_set_other_validation( $posted_field, $value, $args );
67 67
 
68
-        if ( isset($posted_field->field_options['default_blank']) && $posted_field->field_options['default_blank'] && $value == $posted_field->default_value ) {
68
+        if ( isset( $posted_field->field_options['default_blank'] ) && $posted_field->field_options['default_blank'] && $value == $posted_field->default_value ) {
69 69
             $value = '';
70 70
         }
71 71
 
72 72
 		// Check for an array with only one value
73 73
 		// Don't reset values in "Other" fields because array keys need to be preserved
74
-		if ( is_array($value) && count( $value ) == 1 && $args['other'] !== true ) {
75
-			$value = reset($value);
74
+		if ( is_array( $value ) && count( $value ) == 1 && $args['other'] !== true ) {
75
+			$value = reset( $value );
76 76
 		}
77 77
 
78 78
         if ( $posted_field->required == '1' && ! is_array( $value ) && trim( $value ) == '' ) {
79
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
79
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $posted_field, 'blank' );
80 80
         } else if ( $posted_field->type == 'text' && ! isset( $_POST['item_name'] ) ) {
81 81
             $_POST['item_name'] = $value;
82 82
         }
83 83
 
84
-        self::validate_url_field($errors, $posted_field, $value, $args);
85
-        self::validate_email_field($errors, $posted_field, $value, $args);
84
+        self::validate_url_field( $errors, $posted_field, $value, $args );
85
+        self::validate_email_field( $errors, $posted_field, $value, $args );
86 86
 		self::validate_number_field( $errors, $posted_field, $value, $args );
87 87
 		self::validate_phone_field( $errors, $posted_field, $value, $args );
88 88
 
89
-        FrmEntriesHelper::set_posted_value($posted_field, $value, $args);
89
+        FrmEntriesHelper::set_posted_value( $posted_field, $value, $args );
90 90
 
91
-        self::validate_recaptcha($errors, $posted_field, $args);
91
+        self::validate_recaptcha( $errors, $posted_field, $args );
92 92
 
93
-        $errors = apply_filters('frm_validate_field_entry', $errors, $posted_field, $value, $args);
93
+        $errors = apply_filters( 'frm_validate_field_entry', $errors, $posted_field, $value, $args );
94 94
     }
95 95
 
96 96
 	public static function validate_url_field( &$errors, $field, &$value, $args ) {
@@ -98,16 +98,16 @@  discard block
 block discarded – undo
98 98
             return;
99 99
         }
100 100
 
101
-        if ( trim($value) == 'http://' ) {
101
+        if ( trim( $value ) == 'http://' ) {
102 102
             $value = '';
103 103
         } else {
104 104
             $value = esc_url_raw( $value );
105
-            $value = preg_match('/^(https?|ftps?|mailto|news|feed|telnet):/is', $value) ? $value : 'http://'. $value;
105
+            $value = preg_match( '/^(https?|ftps?|mailto|news|feed|telnet):/is', $value ) ? $value : 'http://' . $value;
106 106
         }
107 107
 
108 108
         //validate the url format
109
-        if ( ! preg_match('/^http(s)?:\/\/([\da-z\.-]+)\.([\da-z\.-]+)/i', $value) ) {
110
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
109
+        if ( ! preg_match( '/^http(s)?:\/\/([\da-z\.-]+)\.([\da-z\.-]+)/i', $value ) ) {
110
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
111 111
         }
112 112
     }
113 113
 
@@ -117,8 +117,8 @@  discard block
 block discarded – undo
117 117
         }
118 118
 
119 119
         //validate the email format
120
-        if ( ! is_email($value) ) {
121
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
120
+        if ( ! is_email( $value ) ) {
121
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
122 122
         }
123 123
     }
124 124
 
@@ -128,8 +128,8 @@  discard block
 block discarded – undo
128 128
 			return;
129 129
 		}
130 130
 
131
-		if ( ! is_numeric( $value) ) {
132
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
131
+		if ( ! is_numeric( $value ) ) {
132
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
133 133
 		}
134 134
 
135 135
 		// validate number settings
@@ -139,9 +139,9 @@  discard block
 block discarded – undo
139 139
 			if ( $frm_settings->use_html && isset( $field->field_options['minnum'] ) && isset( $field->field_options['maxnum'] ) ) {
140 140
 				//minnum maxnum
141 141
 				if ( (float) $value < $field->field_options['minnum'] ) {
142
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a higher number', 'formidable' );
142
+					$errors['field' . $args['id']] = __( 'Please select a higher number', 'formidable' );
143 143
 				} else if ( (float) $value > $field->field_options['maxnum'] ) {
144
-					$errors[ 'field' . $args['id'] ] = __( 'Please select a lower number', 'formidable' );
144
+					$errors['field' . $args['id']] = __( 'Please select a lower number', 'formidable' );
145 145
 				}
146 146
 			}
147 147
 		}
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 		$pattern = self::phone_format( $field );
156 156
 
157 157
 		if ( ! preg_match( $pattern, $value ) ) {
158
-			$errors[ 'field' . $args['id'] ] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
158
+			$errors['field' . $args['id']] = FrmFieldsHelper::get_error_msg( $field, 'invalid' );
159 159
 		}
160 160
 	}
161 161
 
@@ -207,11 +207,11 @@  discard block
 block discarded – undo
207 207
 			return;
208 208
 		}
209 209
 
210
-        if ( ! isset($_POST['g-recaptcha-response']) ) {
210
+        if ( ! isset( $_POST['g-recaptcha-response'] ) ) {
211 211
             // If captcha is missing, check if it was already verified
212 212
 			if ( ! isset( $_POST['recaptcha_checked'] ) || ! wp_verify_nonce( $_POST['recaptcha_checked'], 'frm_ajax' ) ) {
213 213
                 // There was no captcha submitted
214
-				$errors[ 'field' . $args['id'] ] = __( 'The captcha is missing from this form', 'formidable' );
214
+				$errors['field' . $args['id']] = __( 'The captcha is missing from this form', 'formidable' );
215 215
             }
216 216
             return;
217 217
         }
@@ -224,11 +224,11 @@  discard block
 block discarded – undo
224 224
 			),
225 225
 		);
226 226
         $resp = wp_remote_post( 'https://www.google.com/recaptcha/api/siteverify', $arg_array );
227
-        $response = json_decode(wp_remote_retrieve_body( $resp ), true);
227
+        $response = json_decode( wp_remote_retrieve_body( $resp ), true );
228 228
 
229 229
         if ( isset( $response['success'] ) && ! $response['success'] ) {
230 230
             // What happens when the CAPTCHA was entered incorrectly
231
-			$errors[ 'field' . $args['id'] ] = ( ! isset( $field->field_options['invalid'] ) || $field->field_options['invalid'] == '' ) ? $frm_settings->re_msg : $field->field_options['invalid'];
231
+			$errors['field' . $args['id']] = ( ! isset( $field->field_options['invalid'] ) || $field->field_options['invalid'] == '' ) ? $frm_settings->re_msg : $field->field_options['invalid'];
232 232
         }
233 233
     }
234 234
 
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 
258 258
 	private static function is_akismet_spam( $values ) {
259 259
 		global $wpcom_api_key;
260
-		return ( is_callable('Akismet::http_post') && ( get_option('wordpress_api_key') || $wpcom_api_key ) && self::akismet( $values ) );
260
+		return ( is_callable( 'Akismet::http_post' ) && ( get_option( 'wordpress_api_key' ) || $wpcom_api_key ) && self::akismet( $values ) );
261 261
 	}
262 262
 
263 263
 	private static function is_akismet_enabled_for_user( $form_id ) {
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 	}
267 267
 
268 268
     public static function blacklist_check( $values ) {
269
-        if ( ! apply_filters('frm_check_blacklist', true, $values) ) {
269
+        if ( ! apply_filters( 'frm_check_blacklist', true, $values ) ) {
270 270
             return false;
271 271
         }
272 272
 
@@ -276,9 +276,9 @@  discard block
 block discarded – undo
276 276
     		return false;
277 277
     	}
278 278
 
279
-    	$content = FrmEntriesHelper::entry_array_to_string($values);
279
+    	$content = FrmEntriesHelper::entry_array_to_string( $values );
280 280
 
281
-		if ( empty($content) ) {
281
+		if ( empty( $content ) ) {
282 282
 		    return false;
283 283
 		}
284 284
 
@@ -287,11 +287,11 @@  discard block
 block discarded – undo
287 287
     	foreach ( (array) $words as $word ) {
288 288
     		$word = trim( $word );
289 289
 
290
-    		if ( empty($word) ) {
290
+    		if ( empty( $word ) ) {
291 291
     			continue;
292 292
     		}
293 293
 
294
-    		if ( preg_match('#' . preg_quote( $word, '#' ) . '#', $content) ) {
294
+    		if ( preg_match( '#' . preg_quote( $word, '#' ) . '#', $content ) ) {
295 295
     			return true;
296 296
     		}
297 297
     	}
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
 			unset( $key, $data );
321 321
 		}
322 322
 
323
-        $response = Akismet::http_post($query_string, 'comment-check');
323
+        $response = Akismet::http_post( $query_string, 'comment-check' );
324 324
 
325 325
 		return ( is_array( $response ) && $response[1] == 'true' );
326 326
     }
@@ -343,12 +343,12 @@  discard block
 block discarded – undo
343 343
 
344 344
         foreach ( $_SERVER as $key => $value ) {
345 345
 			if ( ! in_array( $key, array( 'HTTP_COOKIE', 'HTTP_COOKIE2', 'PHP_AUTH_PW' ) ) && is_string( $value ) ) {
346
-				$datas[ $key ] = wp_strip_all_tags( $value );
346
+				$datas[$key] = wp_strip_all_tags( $value );
347 347
             } else {
348
-				$datas[ $key ] = '';
348
+				$datas[$key] = '';
349 349
             }
350 350
 
351
-            unset($key, $value);
351
+            unset( $key, $value );
352 352
         }
353 353
     }
354 354
 }
Please login to merge, or discard this patch.