Stinger-Soft / EntitySearchBundle

Tests/bootstrap.php

Indentation +3 added lines, -3 removed lines

@@ -9,12 +9,12 @@
 define('TESTS_TEMP_DIR', __DIR__.'/temp');
 define('VENDOR_PATH', realpath(__DIR__.'/../vendor'));
 if (!class_exists('PHPUnit_Framework_TestCase') ||
-    version_compare(PHPUnit_Runner_Version::id(), '3.5') < 0
+	version_compare(PHPUnit_Runner_Version::id(), '3.5') < 0
 ) {
-    die('PHPUnit framework is required, at least 3.5 version');
+	die('PHPUnit framework is required, at least 3.5 version');
 }
 if (!class_exists('PHPUnit_Framework_MockObject_MockBuilder')) {
-    die('PHPUnit MockObject plugin is required, at least 1.0.8 version');
+	die('PHPUnit MockObject plugin is required, at least 1.0.8 version');
 }
 /** @var $loader ClassLoader */
 $loader = require __DIR__.'/../vendor/autoload.php';

StingerSoftEntitySearchBundle.php

Doc Comments +3 added lines

@@ -17,6 +17,9 @@
  */
 class StingerSoftEntitySearchBundle extends Bundle {
 
+	/**
+	 * @param string $env
+	 */
 	public static function getRequiredBundles($env) {
 		$bundles = array();
 		$bundles['StingerSoftEntitySearchBundle'] = '\StingerSoft\EntitySearchBundle\StingerSoftEntitySearchBundle';

Model/Result/FacetSetAdapter.php

Spacing +3 added lines, -3 removed lines

@@ -30,10 +30,10 @@ 
 	}
 
 	public function addFacetValue($key, $value, $increaseCounterBy = 1) {
-		if(!isset($this->facets[$key])){
+		if (!isset($this->facets[$key])) {
 			$this->facets[$key] = array();
 		}
-		if(!isset($this->facets[$key][$value])){
+		if (!isset($this->facets[$key][$value])) {
 			$this->facets[$key][$value] = 0;
 		}
 		$this->facets[$key][$value] = $this->facets[$key][$value] + $increaseCounterBy;
@@ -46,7 +46,7 @@ 
 	 * @see \StingerSoft\EntitySearchBundle\Model\Result\FacetSet::getFacet()
 	 */
 	public function getFacet($key) {
-		if(isset($this->facets[$key])) {
+		if (isset($this->facets[$key])) {
 			return $this->facets[$key];
 		} else {
 			return;

Services/DummySearchService.php

Spacing +10 added lines, -10 removed lines

@@ -29,7 +29,7 @@ 
 		$id = $document->getEntityClass();
 		$id .= '#';
 		$entityId = $document->getEntityId();
-		if(is_scalar($entityId)) {
+		if (is_scalar($entityId)) {
 			$id .= $entityId;
 		} else {
 			$id .= md5(serialize($entityId));
@@ -75,15 +75,15 @@ 
 	 */
 	public function autocomplete($search, $maxResults = 10) {
 		$words = array();
-		foreach($this->index as $doc) {
-			foreach($doc->getFields() as $content) {
-				if(is_string($content)) {
+		foreach ($this->index as $doc) {
+			foreach ($doc->getFields() as $content) {
+				if (is_string($content)) {
 					$words = array_merge($words, explode(' ', $content));
 				}
 			}
 		}
 		
-		return array_filter($words, function ($word) use ($search) {
+		return array_filter($words, function($word) use ($search) {
 			return stripos($word, $search) === 0;
 		});
 	}
@@ -101,10 +101,10 @@ 
 		$facets = new FacetSetAdapter();
 		
 		$hits = array();
-		foreach($this->index as $key => $doc) {
-			foreach($doc->getFields() as $content) {
-				if(is_string($content) && stripos($content, $term) !== false) {
-					if(!isset($hits[$key])) {
+		foreach ($this->index as $key => $doc) {
+			foreach ($doc->getFields() as $content) {
+				if (is_string($content) && stripos($content, $term) !== false) {
+					if (!isset($hits[$key])) {
 						$hits[$key] = 0;
 					}
 					$hits[$key] = $hits[$key] + 1;
@@ -113,7 +113,7 @@ 
 		}
 		arsort($hits);
 		$results = array();
-		foreach(array_keys($hits) as $docId) {
+		foreach (array_keys($hits) as $docId) {
 			$doc = $this->index[$docId];
 			$facets->addFacetValue(FacetSet::FACET_ENTITY_TYPE, $doc->getEntityClass());
 			$facets->addFacetValue(FacetSet::FACET_AUTHOR, $doc->getFieldValue(Document::FIELD_AUTHOR));

Form/FacetChoiceLoader.php

Spacing +4 added lines, -4 removed lines

@@ -39,9 +39,9 @@ 
 	public function loadValuesForChoices(array $choices, $value = null) {
 		// is called on form creat with $choices containing the preset of the bound entity
 		$values = array();
-		foreach($choices as $key => $choice) {
+		foreach ($choices as $key => $choice) {
 			// we use a DataTransformer, thus only plain values arrive as choices which can be used directly as value
-			if(is_callable($value)) {
+			if (is_callable($value)) {
 				$values[$key] = (string)call_user_func($value, $choice, $key);
 			} else {
 				$values[$key] = $choice;
@@ -85,9 +85,9 @@ 
 	public function loadChoicesForValues(array $values, $value = null) {
 		// is called on form submit after loadValuesForChoices of form create and loadChoiceList of form view create
 		$choices = array();
-		foreach($values as $key => $val) {
+		foreach ($values as $key => $val) {
 			// we use a DataTransformer, thus only plain values arrive as choices which can be used directly as value
-			if(is_callable($value)) {
+			if (is_callable($value)) {
 				$choices[$key] = (string)call_user_func($value, $val, $key);
 			} else {
 				$choices[$key] = $val;

Tests/Form/QueryTypeTest.php

Spacing +1 added lines, -1 removed lines

@@ -116,7 +116,7 @@
 		$view = $form->createView();
 		$children = $view->children;
 		
-		foreach(array_keys($formData) as $key) {
+		foreach (array_keys($formData) as $key) {
 			$this->assertArrayHasKey($key, $children);
 		}
 		

Doc Comments +3 added lines

@@ -140,6 +140,9 @@
 // 		$this->assertCount(2, $typeForm->vars['choices']);
 	}
 	
+	/**
+	 * @return ValidatorInterface
+	 */
 	protected function mockValidator() {
 		$validator = $this->getMockBuilder(ValidatorInterface::class)->setMethods(array('validate', 'getErrors'))->getMockForAbstractClass();
 		$validator->method('validate')->willReturn(array());

Model/Query.php

Doc Comments +1 added lines, -1 removed lines

@@ -104,7 +104,7 @@
 	 *
 	 * @param string $name
 	 *        	Name of the property to set
-	 * @param mixed $value
+	 * @param string[] $value
 	 *        	The value of the property
 	 */
 	public function __set($name, $value) {

Spacing +5 added lines, -5 removed lines

@@ -90,10 +90,10 @@ 
 	 * @return \Pec\Bundle\MtuDvpBundle\Entity\TestRiskValue
 	 */
 	public function __get($name) {
-		if(strrpos($name, 'facet_', -strlen($name)) !== false) {
+		if (strrpos($name, 'facet_', -strlen($name)) !== false) {
 			$facetname = substr($name, 6);
 			
-			if(isset($this->facets[$facetname])) {
+			if (isset($this->facets[$facetname])) {
 				return $this->facets[$facetname];
 			}
 			return array();
@@ -108,10 +108,10 @@ 
 	 *        	The value of the property
 	 */
 	public function __set($name, $value) {
-		if(strrpos($name, 'facet_', -strlen($name)) !== false) {
+		if (strrpos($name, 'facet_', -strlen($name)) !== false) {
 			$facetname = substr($name, 6);
 			
-			if(!isset($this->facets[$facetname])) {
+			if (!isset($this->facets[$facetname])) {
 				$this->facets[$facetname] = array();
 			}
 			$this->facets[$facetname] = $value;
@@ -125,7 +125,7 @@ 
 	 * @return boolean
 	 */
 	public function __isset($name) {
-		if(strrpos($name, 'facet_', -strlen($name)) !== false) {
+		if (strrpos($name, 'facet_', -strlen($name)) !== false) {
 			return true;
 		}
 		

Tests/Model/Result/FacetSetAdapterTest.php

Spacing +3 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
 
 class FacetSetAdapterTest extends \PHPUnit_Framework_TestCase {
 
-	public function testAddFacetValue(){
+	public function testAddFacetValue() {
 		$facets = new FacetSetAdapter(array());
 		$this->assertCount(0, $facets);
 		$facets->addFacetValue(Document::FIELD_AUTHOR, 'Oliver Kotte');
@@ -26,13 +26,13 @@ 
 		$this->assertCount(1, $facets);
 		$this->assertCount(2, $facets->getFacet(Document::FIELD_AUTHOR));
 		
-		foreach($facets as $facetKey => $facetValues){
+		foreach ($facets as $facetKey => $facetValues) {
 			$this->assertEquals(Document::FIELD_AUTHOR, $facetKey);
 			$this->assertCount(2, $facetValues);
 		}
 	}
 	
-	public function testGetFacet(){
+	public function testGetFacet() {
 		$facets = new FacetSetAdapter(array());
 		$this->assertCount(0, $facets);
 		$this->assertNull($facets->getFacet('NotExisting'));

Services/DoctrineListener.php

Spacing +6 added lines, -6 removed lines

@@ -73,12 +73,12 @@ 
 	 * @param LifecycleEventArgs $args        	
 	 */
 	public function postPersist(LifecycleEventArgs $args) {
-		if(!$this->enableIndexing) return;
+		if (!$this->enableIndexing) return;
 		$this->updateEntity($args->getObject(), $args->getObjectManager());
 	}
 
 	public function postFlush(PostFlushEventArgs $eventArgs) {
-		if($this->needsFlush) {
+		if ($this->needsFlush) {
 			$this->needsFlush = false;
 			$eventArgs->getEntityManager()->flush();
 		}
@@ -90,7 +90,7 @@ 
 	 * @param LifecycleEventArgs $args        	
 	 */
 	public function preRemove(LifecycleEventArgs $args) {
-		if(!$this->enableIndexing) return;
+		if (!$this->enableIndexing) return;
 		$this->removeEntity($args->getObject(), $args->getObjectManager());
 	}
 
@@ -100,7 +100,7 @@ 
 	 * @param LifecycleEventArgs $args        	
 	 */
 	public function postUpdate(LifecycleEventArgs $args) {
-		if(!$this->enableIndexing) return;
+		if (!$this->enableIndexing) return;
 		$this->updateEntity($args->getObject(), $args->getObjectManager());
 	}
 
@@ -127,7 +127,7 @@ 
 	 */
 	protected function updateEntity($entity, ObjectManager $manager) {
 		$document = $this->getEntityToDocumentMapper()->createDocument($manager, $entity);
-		if($document !== false) {
+		if ($document !== false) {
 			$this->getSearchService($manager)->saveDocument($document);
 		}
 	}
@@ -138,7 +138,7 @@ 
 	 */
 	protected function removeEntity($entity, ObjectManager $manager) {
 		$document = $this->getEntityToDocumentMapper()->createDocument($manager, $entity);
-		if($document !== false) {
+		if ($document !== false) {
 			$this->getSearchService($manager)->removeDocument($document);
 		}
 	}

Braces +9 added lines, -3 removed lines

@@ -73,7 +73,9 @@ 
 	 * @param LifecycleEventArgs $args        	
 	 */
 	public function postPersist(LifecycleEventArgs $args) {
-		if(!$this->enableIndexing) return;
+		if(!$this->enableIndexing) {
+			return;
+		}
 		$this->updateEntity($args->getObject(), $args->getObjectManager());
 	}
 
@@ -90,7 +92,9 @@ 
 	 * @param LifecycleEventArgs $args        	
 	 */
 	public function preRemove(LifecycleEventArgs $args) {
-		if(!$this->enableIndexing) return;
+		if(!$this->enableIndexing) {
+			return;
+		}
 		$this->removeEntity($args->getObject(), $args->getObjectManager());
 	}
 
@@ -100,7 +104,9 @@ 
 	 * @param LifecycleEventArgs $args        	
 	 */
 	public function postUpdate(LifecycleEventArgs $args) {
-		if(!$this->enableIndexing) return;
+		if(!$this->enableIndexing) {
+			return;
+		}
 		$this->updateEntity($args->getObject(), $args->getObjectManager());
 	}