App\Controllers\Admin\Post::createNewPost()

Complexity

Conditions	6
Paths	6

Size

Total Lines	53
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function createNewPost()
    {
        //Security checks
        $this->onlyAdmin();
        if (!$this->request->isPost()) {
            $this->alertBox->setAlert('Only post messages allowed', 'error');
            $this->response->redirect('admin');
        }
        $posts = $this->container->getRequest()->getDataFull();
        $userSessionid = $this->container->getSession()->get("user_id");

        //TODO
        //Slug, check if duplicate
        //Tags, check if duplicate before creating new tag
        //Tags, must have created the post and got the id before associating the tags
        //grab author from session

        $title = $posts["newPostTitle"];
        $postImage = $posts["newPostImage"]; //TODO Sanatize the input ? Or will PDO be enough ?
        $postSlug = $posts["newPostSlug"]; //TODO Check if unique
        $article = $posts["newPostTextArea"];
        $idCategory = $posts["categorySelector"];
        $published = $posts["isPublished"];
        $onFrontpage = $posts["isOnFrontPage"];
        $idUser = $userSessionid;

        $slugModel = new SlugModel($this->container);
        $tagModel = new TagsModel($this->container);
        $postModel = new PostModel($this->container);

        //security and error checks
        if (!$slugModel->isUnique($postSlug, "posts", "posts_slug")) {
            die("SLUG not unique");

Using exit here is not recommended.

        }
        
        $postId = $postModel->newPost($title, $postImage, $idCategory, $article, $idUser, $published, $onFrontpage, $postSlug);

It seems like $idUser can also be of type null; however, parameter $idUser of App\Models\PostModel::newPost() does only seem to accept integer, maybe add an additional type check?

        echo "<p>new post ID : " . $postId . "</p>";

        if(isset($posts["tags"])){
            foreach ($posts["tags"] as $tag) {
                if(isset($tag["id"])){
                    $tagModel->addTagToPost($postId, $tag["id"]);
                    continue;
                }
                $tagModel->addNewTagToPost($postId, $tag["name"]);
            }
        }


        echo "<pre>";
        var_dump($posts);

var_dump($posts) looks like debug code. Are you sure you do not want to remove it?

        die();

Using exit here is not recommended.

}