App\Controllers\Admin\Post

Complexity

Total Complexity

9

Size/Duplication

Total Lines	93
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	new()	0	9	1
A	list()	0	3	1
A	modify()	0	3	1
B	createNewPost()	0	53	6

<?php

namespace App\Controllers\Admin;

use App\Models\CategoryModel;
use App\Models\PostModel;
use App\Models\SlugModel;
use App\Models\TagsModel;
use Core\AdminController;

class Post extends AdminController
{

    /**
     * page for new post
     */
    public function new()
    {
        $this->onlyAdmin();
        //TODO have we receved a $_POST, if yes then probably an error on the create new post
        $categoryModel = new CategoryModel($this->container);
        $tagModel = new TagsModel($this->container);
        $this->data['categories'] = $categoryModel->getCategories();
        $this->data['tags'] = $tagModel->getTags();
        $this->renderView('Admin/NewPost');
    }

    /**
     * Lists all the posts
     */
    public function list()
    {
        $this->onlyAdmin();

    }

    /**
     * Shows the post to modify and update
     * @param $idPost
     */
    public function modify($idPost)

The parameter $idPost is not used and could be removed.

    {
        $this->onlyAdmin();

    }

    /**
     * Create a new post
     * @throws \ErrorException
     */
    public function createNewPost()
    {
        //Security checks
        $this->onlyAdmin();
        if (!$this->request->isPost()) {
            $this->alertBox->setAlert('Only post messages allowed', 'error');
            $this->response->redirect('admin');
        }
        $posts = $this->container->getRequest()->getDataFull();
        $userSessionid = $this->container->getSession()->get("user_id");

        //TODO
        //Slug, check if duplicate
        //Tags, check if duplicate before creating new tag
        //Tags, must have created the post and got the id before associating the tags
        //grab author from session

        $title = $posts["newPostTitle"];
        $postImage = $posts["newPostImage"]; //TODO Sanatize the input ? Or will PDO be enough ?
        $postSlug = $posts["newPostSlug"]; //TODO Check if unique
        $article = $posts["newPostTextArea"];
        $idCategory = $posts["categorySelector"];
        $published = $posts["isPublished"];
        $onFrontpage = $posts["isOnFrontPage"];
        $idUser = $userSessionid;

        $slugModel = new SlugModel($this->container);
        $tagModel = new TagsModel($this->container);
        $postModel = new PostModel($this->container);

        //security and error checks
        if (!$slugModel->isUnique($postSlug, "posts", "posts_slug")) {
            die("SLUG not unique");

Using exit here is not recommended.

        }
        
        $postId = $postModel->newPost($title, $postImage, $idCategory, $article, $idUser, $published, $onFrontpage, $postSlug);

It seems like $idUser can also be of type null; however, parameter $idUser of App\Models\PostModel::newPost() does only seem to accept integer, maybe add an additional type check?

        echo "<p>new post ID : " . $postId . "</p>";

        if(isset($posts["tags"])){
            foreach ($posts["tags"] as $tag) {
                if(isset($tag["id"])){
                    $tagModel->addTagToPost($postId, $tag["id"]);
                    continue;
                }
                $tagModel->addNewTagToPost($postId, $tag["name"]);
            }
        }


        echo "<pre>";
        var_dump($posts);

var_dump($posts) looks like debug code. Are you sure you do not want to remove it?

        die();

Using exit here is not recommended.

        //TODO send a return $_POST with all data to the new post page if errors (also need to check if new page recives post, then add the data back into the forms

        //TODO else redirect to the modify page on OK ? good usability or stay on the new page with blank ?
    }
}