postModification::__construct() - Code Metrics - Inspection of "Adding Ajax post modification + refactoring pagina..." - Starbugstone/blogoc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — Showing-Posts ( a72031...c030ab )

by Stone

created 2018-10-05 07:36 UTC

postModification::__construct() A

↳ Parent: postModification

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace App\Controllers\Ajax;

use App\Models\PostModel;
use Core\AjaxController;
use Core\Container;

class postModification extends AjaxController{


    private $postModule;

    public function __construct(Container $container)
    {
        parent::__construct($container);
        $this->postModule = new PostModel($this->container);
    }

    public function modifyPublished()
    {
        $this->onlyAdmin();
        if (!$this->container->getRequest()->isPost()) {
            throw new \Core\JsonException('Call is not post');
        }
        $state = (bool)($this->request->getData("state") === 'true');
        $postId = (int)$this->request->getData("postId");

        $result["success"] = $this->postModule->setPublished(!$state, $postId);

        $result["state"] = !$state;
        $result["postId"] = $postId;
        echo json_encode($result);
    }

    public function modifyOnFrontPage()
    {
        $this->onlyAdmin();
        if (!$this->container->getRequest()->isPost()) {
            throw new \Core\JsonException('Call is not post');
        }
        $state = ($this->request->getData("state") === 'true');
        $postId = (int)$this->request->getData("postId");

        $result["success"] = $this->postModule->setOnFrontPage(!$state, $postId);

        $result["state"] = !$state;
        $result["postId"] = $postId;
        echo json_encode($result);
    }
}

1			<?php
2
3			namespace App\Controllers\Ajax;
4
5			use App\Models\PostModel;
6			use Core\AjaxController;
7			use Core\Container;
8
9			class postModification extends AjaxController{
10
11
12			private $postModule;
13
14			public function __construct(Container $container)
15			{
16			parent::__construct($container);
17			$this->postModule = new PostModel($this->container);
18			}
19
20			public function modifyPublished()
21			{
22			$this->onlyAdmin();
23			if (!$this->container->getRequest()->isPost()) {
24			throw new \Core\JsonException('Call is not post');
25			}
26			$state = (bool)($this->request->getData("state") === 'true');
27			$postId = (int)$this->request->getData("postId");
28
29			$result["success"] = $this->postModule->setPublished(!$state, $postId);
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-10-05 07:39 UTC by Report Bug Copy Issue Report `$result` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$result = array();` before regardless. Loading history...
30			$result["state"] = !$state;
31			$result["postId"] = $postId;
32			echo json_encode($result);
33			}
34
35			public function modifyOnFrontPage()
36			{
37			$this->onlyAdmin();
38			if (!$this->container->getRequest()->isPost()) {
39			throw new \Core\JsonException('Call is not post');
40			}
41			$state = ($this->request->getData("state") === 'true');
42			$postId = (int)$this->request->getData("postId");
43
44			$result["success"] = $this->postModule->setOnFrontPage(!$state, $postId);
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-10-05 07:39 UTC by Report Bug Copy Issue Report `$result` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$result = array();` before regardless. Loading history...
45			$result["state"] = !$state;
46			$result["postId"] = $postId;
47			echo json_encode($result);
48			}
49			}

Starbugstone / blogoc

Push — Showing-Posts ( a72031...c030ab )

postModification::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like