App\Controllers\Ajax\postModification

Complexity

Total Complexity

5

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	modifyOnFrontPage()	0	13	2
A	modifyPublished()	0	13	2

<?php

namespace App\Controllers\Ajax;

use App\Models\PostModel;
use Core\AjaxController;
use Core\Container;

class postModification extends AjaxController{


    private $postModule;

    public function __construct(Container $container)
    {
        parent::__construct($container);
        $this->postModule = new PostModel($this->container);
    }

    public function modifyPublished()
    {
        $this->onlyAdmin();
        if (!$this->container->getRequest()->isPost()) {
            throw new \Core\JsonException('Call is not post');
        }
        $state = (bool)($this->request->getData("state") === 'true');
        $postId = (int)$this->request->getData("postId");

        $result["success"] = $this->postModule->setPublished(!$state, $postId);

$result was never initialized. Although not strictly required by PHP, it is generally a good practice to add $result = array(); before regardless.

        $result["state"] = !$state;
        $result["postId"] = $postId;
        echo json_encode($result);
    }

    public function modifyOnFrontPage()
    {
        $this->onlyAdmin();
        if (!$this->container->getRequest()->isPost()) {
            throw new \Core\JsonException('Call is not post');
        }
        $state = ($this->request->getData("state") === 'true');
        $postId = (int)$this->request->getData("postId");

        $result["success"] = $this->postModule->setOnFrontPage(!$state, $postId);

$result was never initialized. Although not strictly required by PHP, it is generally a good practice to add $result = array(); before regardless.

        $result["state"] = !$state;
        $result["postId"] = $postId;
        echo json_encode($result);
    }
}