Stanvk / Magister

src/Magister/Models/Enrollment/Enrollment.php

Doc Comments +1 added lines, -1 removed lines

@@ -44,7 +44,7 @@
     /**
      * Define a relationship.
      *
-     * @return mixed
+     * @return \Magister\Services\Database\Elegant\Relations\HasMany
      */
     public function counsellors()
     {

src/Magister/Services/Auth/Guard.php

Doc Comments +2 added lines, -2 removed lines

@@ -153,7 +153,7 @@ 
     /**
      * Determine if the user matches the credentials.
      *
-     * @param mixed $user
+     * @param \Magister\Services\Database\Elegant\Model|null $user
      *
      * @return bool
      */
@@ -286,7 +286,7 @@ 
     /**
      * Return the currently cached user.
      *
-     * @return mixed|null
+     * @return UserContract
      */
     public function getUser()
     {

Spacing +6 added lines, -6 removed lines

@@ -65,7 +65,7 @@ 
      */
     public function check()
     {
-        return !is_null($this->user());
+        return ! is_null($this->user());
     }
 
     /**
@@ -75,7 +75,7 @@ 
      */
     public function guest()
     {
-        return !$this->check();
+        return ! $this->check();
     }
 
     /**
@@ -92,7 +92,7 @@ 
         // If we have already retrieved the user for the current request we can just
         // return it back immediately. We do not want to pull the user data every
         // request into the method because that would tremendously slow an app.
-        if (!is_null($this->user)) {
+        if ( ! is_null($this->user)) {
             return $this->user;
         }
 
@@ -100,7 +100,7 @@ 
 
         $user = null;
 
-        if (!is_null($id)) {
+        if ( ! is_null($id)) {
             $user = $this->provider->retrieveByToken();
         }
 
@@ -159,7 +159,7 @@ 
      */
     protected function hasValidCredentials($user)
     {
-        return !is_null($user);
+        return ! is_null($user);
     }
 
     /**
@@ -314,7 +314,7 @@ 
      */
     public function getCookieJar()
     {
-        if (!isset($this->cookie)) {
+        if ( ! isset($this->cookie)) {
             throw new \RuntimeException('Cookie jar has not been set.');
         }
 

src/Magister/Services/Container/Container.php

Doc Comments +3 added lines, -3 removed lines

@@ -36,7 +36,7 @@ 
      * Register a service as a singleton.
      *
      * @param string $abstract
-     * @param mixed  $concrete
+     * @param Closure  $concrete
      *
      * @return void
      */
@@ -209,7 +209,7 @@ 
      *
      * @param string $abstract
      *
-     * @return bool
+     * @return boolean|null
      */
     public function __isset($abstract)
     {
@@ -258,7 +258,7 @@ 
      *
      * @param string $abstract
      *
-     * @return bool
+     * @return boolean|null
      */
     public function offsetExists($abstract)
     {

Spacing +7 added lines, -7 removed lines

@@ -56,7 +56,7 @@ 
      */
     public function make($abstract)
     {
-        if (!$this->bound($abstract)) {
+        if ( ! $this->bound($abstract)) {
             throw new InvalidArgumentException(sprintf('Identifier "%s" is not defined.', $abstract));
         }
 
@@ -99,7 +99,7 @@ 
      */
     public static function share(Closure $callable)
     {
-        return function ($c) use ($callable) {
+        return function($c) use ($callable) {
             static $object;
 
             if (null === $object) {
@@ -119,7 +119,7 @@ 
      */
     public static function protect(Closure $callable)
     {
-        return function ($c) use ($callable) {
+        return function($c) use ($callable) {
             return $callable;
         };
     }
@@ -135,7 +135,7 @@ 
      */
     public function raw($abstract)
     {
-        if (!array_key_exists($abstract, $this->bindings)) {
+        if ( ! array_key_exists($abstract, $this->bindings)) {
             throw new InvalidArgumentException(sprintf('Identifier "%s" is not defined.', $abstract));
         }
 
@@ -154,17 +154,17 @@ 
      */
     public function extend($abstract, Closure $callable)
     {
-        if (!array_key_exists($abstract, $this->bindings)) {
+        if ( ! array_key_exists($abstract, $this->bindings)) {
             throw new InvalidArgumentException(sprintf('Identifier "%s" is not defined.', $abstract));
         }
 
         $factory = $this->bindings[$abstract];
 
-        if (!($factory instanceof Closure)) {
+        if ( ! ($factory instanceof Closure)) {
             throw new InvalidArgumentException(sprintf('Identifier "%s" does not contain an object definition.', $abstract));
         }
 
-        return $this->bindings[$abstract] = function ($c) use ($callable, $factory) {
+        return $this->bindings[$abstract] = function($c) use ($callable, $factory) {
             return $callable($factory($c), $c);
         };
     }

src/Magister/Services/Database/Elegant/Builder.php

Doc Comments +5 added lines, -5 removed lines

@@ -38,7 +38,7 @@ 
      *
      * @param mixed $id
      *
-     * @return \Magister\Services\Database\Elegant\Model|\Magister\Services\Support\Collection|null
+     * @return Model
      */
     public function find($id)
     {
@@ -58,7 +58,7 @@ 
     /**
      * Execute the query as a select statement.
      *
-     * @return \Magister\Services\Support\Collection|static[]
+     * @return \Magister\Services\Support\Collection
      */
     public function get()
     {
@@ -89,7 +89,7 @@ 
      * @param string $column
      * @param string $key
      *
-     * @return array
+     * @return \Magister\Services\Support\Collection
      */
     public function lists($column, $key = null)
     {
@@ -113,7 +113,7 @@ 
     /**
      * Get the underlying query builder instance.
      *
-     * @return \Magister\Services\Database\Query\Builder|static
+     * @return QueryBuilder
      */
     public function getQuery()
     {
@@ -166,7 +166,7 @@ 
      * @param string $method
      * @param array  $parameters
      *
-     * @return mixed
+     * @return Builder
      */
     public function __call($method, $parameters)
     {

src/Magister/Services/Database/Elegant/Model.php

Doc Comments +2 added lines, -2 removed lines

@@ -105,7 +105,7 @@ 
      *
      * @param mixed $id
      *
-     * @return \Magister\Services\Support\Collection|static|null
+     * @return Model
      */
     public static function find($id)
     {
@@ -563,7 +563,7 @@ 
      *
      * @throws \RuntimeException
      *
-     * @return void
+     * @return string
      */
     public function getUrl()
     {

Spacing +3 added lines, -3 removed lines

@@ -211,7 +211,7 @@ 
     {
         $instance = (new static())->setConnection($connection);
 
-        $items = array_map(function ($item) use ($instance) {
+        $items = array_map(function($item) use ($instance) {
             return $instance->newFromBuilder($item);
         }, $items);
 
@@ -331,7 +331,7 @@ 
         $value = $this->getAttributeFromArray($key);
 
         if (in_array($key, $this->getDates())) {
-            if (!is_null($value)) {
+            if ( ! is_null($value)) {
                 return $this->asDateTime($value);
             }
         }
@@ -388,7 +388,7 @@ 
     {
         $relations = $this->$method();
 
-        if (!$relations instanceof Relation) {
+        if ( ! $relations instanceof Relation) {
             throw new LogicException('Relationship method must return an object of type '.'Magister\Services\Database\Elegant\Relations\Relation');
         }
 

src/Magister/Services/Database/Query/Builder.php

Doc Comments +2 added lines, -2 removed lines

@@ -72,7 +72,7 @@ 
      * @param string $column
      * @param string $key
      *
-     * @return array
+     * @return Collection
      */
     public function lists($column, $key = null)
     {
@@ -200,7 +200,7 @@ 
      *
      * @throws \BadMethodCallException
      *
-     * @return mixed
+     * @return Builder
      */
     public function __call($method, $parameters)
     {

Spacing +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
     {
         $select = is_null($key) ? [$column] : [$column, $key];
 
-        return array_map(function ($column) {
+        return array_map(function($column) {
             $dot = strpos($column, '.');
 
             return $dot === false ? $column : substr($column, $dot + 1);

src/Magister/Services/Events/Dispatcher.php

Doc Comments +1 added lines, -1 removed lines

@@ -155,7 +155,7 @@
     /**
      * Create a class based listener using the IoC container.
      *
-     * @param mixed $listener
+     * @param string $listener
      *
      * @return \Closure
      */

Spacing +4 added lines, -4 removed lines

@@ -79,7 +79,7 @@ 
     {
         $responses = [];
 
-        if (!is_array($payload)) {
+        if ( ! is_array($payload)) {
             $payload = [$payload];
         }
 
@@ -88,7 +88,7 @@ 
         foreach ($this->getListeners($event) as $listener) {
             $response = call_user_func_array($listener, $payload);
 
-            if (!is_null($response) && $halt) {
+            if ( ! is_null($response) && $halt) {
                 return $response;
             }
 
@@ -111,7 +111,7 @@ 
      */
     public function getListeners($eventName)
     {
-        if (!isset($this->sorted[$eventName])) {
+        if ( ! isset($this->sorted[$eventName])) {
             $this->sortListeners($eventName);
         }
 
@@ -163,7 +163,7 @@ 
     {
         $container = $this->container;
 
-        return function () use ($listener, $container) {
+        return function() use ($listener, $container) {
             $segments = explode('@', $listener);
 
             $method = count($segments) == 2 ? $segments[1] : 'handle';

src/Magister/Services/Support/Collection.php

Doc Comments +1 added lines, -1 removed lines

@@ -202,7 +202,7 @@
     /**
      * Remove an item from the collection by key.
      *
-     * @param mixed $key
+     * @param string $key
      *
      * @return void
      */

Spacing +8 added lines, -8 removed lines

@@ -64,13 +64,13 @@ 
     public function contains($key, $value = null)
     {
         if (func_num_args() == 2) {
-            return $this->contains(function ($k, $item) use ($key, $value) {
+            return $this->contains(function($k, $item) use ($key, $value) {
                 return data_get($item, $key) == $value;
             });
         }
 
         if ($this->useAsCallable($key)) {
-            return !is_null($this->first($key));
+            return ! is_null($this->first($key));
         }
 
         return in_array($key, $this->items);
@@ -129,7 +129,7 @@ 
      */
     public function where($key, $value, $strict = true)
     {
-        return $this->filter(function ($item) use ($key, $value, $strict) {
+        return $this->filter(function($item) use ($key, $value, $strict) {
             return $strict ? data_get($item, $key) === $value : data_get($item, $key) == $value;
         });
     }
@@ -157,7 +157,7 @@ 
      */
     public function find($key, $default = null)
     {
-        return array_first($this->items, function ($itemKey, $model) use ($key) {
+        return array_first($this->items, function($itemKey, $model) use ($key) {
             return $itemKey == $key;
         }, $default);
     }
@@ -245,7 +245,7 @@ 
         foreach ($this->items as $key => $value) {
             $groupKey = $groupBy($value, $key);
 
-            if (!array_key_exists($groupKey, $results)) {
+            if ( ! array_key_exists($groupKey, $results)) {
                 $results[$groupKey] = new static();
             }
 
@@ -337,7 +337,7 @@ 
      */
     protected function useAsCallable($value)
     {
-        return !is_string($value) && is_callable($value);
+        return ! is_string($value) && is_callable($value);
     }
 
     /**
@@ -651,7 +651,7 @@ 
             return $value;
         }
 
-        return function ($item) use ($value) {
+        return function($item) use ($value) {
             return data_get($item, $value);
         };
     }
@@ -683,7 +683,7 @@ 
      */
     public function toArray()
     {
-        return array_map(function ($value) {
+        return array_map(function($value) {
             return $value instanceof Arrayable ? $value->toArray() : $value;
         }, $this->items);
     }

src/Magister/Services/Support/helpers.php

Doc Comments +4 added lines, -3 removed lines

@@ -241,7 +241,7 @@ 
      * Determine if a given string starts with a given substring.
      *
      * @param string       $haystack
-     * @param string|array $needles
+     * @param string $needles
      *
      * @return bool
      */
@@ -296,7 +296,7 @@ 
     /**
      * Get the class "basename" of the given object / class.
      *
-     * @param string|object $class
+     * @param Magister\Services\Database\Elegant\Model $class
      *
      * @return string
      */
@@ -394,8 +394,9 @@ 
     /**
      * Return the translation for the foreign.
      * 
-     * @param  string $key
      * 
+     * @param string $foreign
+     * @param string $model
      * @return string
      */
     function transMagisterModel($foreign, $model)

Spacing +28 added lines, -28 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (!function_exists('with')) {
+if ( ! function_exists('with')) {
     /**
      * Return the given object. Useful for chaining.
      *
@@ -14,7 +14,7 @@ 
     }
 }
 
-if (!function_exists('array_set')) {
+if ( ! function_exists('array_set')) {
     /**
      * Set an array item to a given value using dot notation.
      *
@@ -35,7 +35,7 @@ 
         while (count($keys) > 1) {
             $key = array_shift($keys);
 
-            if (!isset($array[$key]) || !is_array($array[$key])) {
+            if ( ! isset($array[$key]) || ! is_array($array[$key])) {
                 $array[$key] = [];
             }
             $array = &$array[$key];
@@ -46,7 +46,7 @@ 
     }
 }
 
-if (!function_exists('array_get')) {
+if ( ! function_exists('array_get')) {
     /**
      * Get an item from an array using dot notation.
      *
@@ -67,7 +67,7 @@ 
         }
 
         foreach (explode('.', $key) as $segment) {
-            if (!is_array($array) || !array_key_exists($segment, $array)) {
+            if ( ! is_array($array) || ! array_key_exists($segment, $array)) {
                 return $default;
             }
             $array = $array[$segment];
@@ -77,7 +77,7 @@ 
     }
 }
 
-if (!function_exists('array_has')) {
+if ( ! function_exists('array_has')) {
     /**
      * Check if an item exists in an array using "dot" notation.
      *
@@ -97,7 +97,7 @@ 
         }
 
         foreach (explode('.', $key) as $segment) {
-            if (!is_array($array) || !array_key_exists($segment, $array)) {
+            if ( ! is_array($array) || ! array_key_exists($segment, $array)) {
                 return false;
             }
             $array = $array[$segment];
@@ -107,7 +107,7 @@ 
     }
 }
 
-if (!function_exists('array_first')) {
+if ( ! function_exists('array_first')) {
     /**
      * Return the first element in an array passing a given truth test.
      *
@@ -129,7 +129,7 @@ 
     }
 }
 
-if (!function_exists('array_last')) {
+if ( ! function_exists('array_last')) {
     /**
      * Return the last element in an array passing a given truth test.
      *
@@ -145,7 +145,7 @@ 
     }
 }
 
-if (!function_exists('array_flatten')) {
+if ( ! function_exists('array_flatten')) {
     /**
      * Flatten a multi-dimensional array into a single level.
      *
@@ -157,7 +157,7 @@ 
     {
         $return = [];
 
-        array_walk_recursive($array, function ($x) use (&$return) {
+        array_walk_recursive($array, function($x) use (&$return) {
             $return[] = $x;
         });
 
@@ -165,7 +165,7 @@ 
     }
 }
 
-if (!function_exists('array_pluck')) {
+if ( ! function_exists('array_pluck')) {
     /**
      * Pluck an array of values from an array.
      *
@@ -195,7 +195,7 @@ 
     }
 }
 
-if (!function_exists('data_get')) {
+if ( ! function_exists('data_get')) {
     /**
      * Get an item from an array or object using "dot" notation.
      *
@@ -213,17 +213,17 @@ 
 
         foreach (explode('.', $key) as $segment) {
             if (is_array($target)) {
-                if (!array_key_exists($segment, $target)) {
+                if ( ! array_key_exists($segment, $target)) {
                     return $default;
                 }
                 $target = $target[$segment];
             } elseif ($target instanceof ArrayAccess) {
-                if (!isset($target[$segment])) {
+                if ( ! isset($target[$segment])) {
                     return $default;
                 }
                 $target = $target[$segment];
             } elseif (is_object($target)) {
-                if (!isset($target->{$segment})) {
+                if ( ! isset($target->{$segment})) {
                     return $default;
                 }
                 $target = $target->{$segment};
@@ -236,7 +236,7 @@ 
     }
 }
 
-if (!function_exists('starts_with')) {
+if ( ! function_exists('starts_with')) {
     /**
      * Determine if a given string starts with a given substring.
      *
@@ -257,7 +257,7 @@ 
     }
 }
 
-if (!function_exists('snake_case')) {
+if ( ! function_exists('snake_case')) {
     /**
      * Convert a string to snake case.
      *
@@ -268,7 +268,7 @@ 
      */
     function snake_case($value, $delimiter = '_')
     {
-        if (!ctype_lower($value)) {
+        if ( ! ctype_lower($value)) {
             $value = strtolower(preg_replace('/(.)(?=[A-Z])/', '$1'.$delimiter, $value));
         }
 
@@ -276,7 +276,7 @@ 
     }
 }
 
-if (!function_exists('camel_case')) {
+if ( ! function_exists('camel_case')) {
     /**
      * Convert a value to camel case.
      *
@@ -292,7 +292,7 @@ 
     }
 }
 
-if (!function_exists('class_basename')) {
+if ( ! function_exists('class_basename')) {
     /**
      * Get the class "basename" of the given object / class.
      *
@@ -308,7 +308,7 @@ 
     }
 }
 
-if (!function_exists('str_random')) {
+if ( ! function_exists('str_random')) {
     /**
      * Generate a more truly "random" alpha-numeric string.
      *
@@ -334,7 +334,7 @@ 
     }
 }
 
-if (!function_exists('get_random_bytes')) {
+if ( ! function_exists('get_random_bytes')) {
     /**
      * Generate a more truly "random" bytes.
      *
@@ -362,7 +362,7 @@ 
     }
 }
 
-if (!function_exists('process')) {
+if ( ! function_exists('process')) {
     /**
      * Process the selected results.
      *
@@ -372,7 +372,7 @@ 
      */
     function process($results)
     {
-        if (!isset($results) || isset($results['Fouttype'])) {
+        if ( ! isset($results) || isset($results['Fouttype'])) {
             return [];
         }
 
@@ -381,7 +381,7 @@ 
         }
 
         foreach ($results as $result) {
-            if (!is_array($result)) {
+            if ( ! is_array($result)) {
                 return [$results];
             }
         }
@@ -390,7 +390,7 @@ 
     }
 }
 
-if (!function_exists('translate')) {
+if ( ! function_exists('translate')) {
     /**
      * Return the translation for the foreign.
      * 
@@ -402,7 +402,7 @@ 
     {
         $translator = \App::make('translator');
         
-        if (!$translator->from($model)->hasTranslation($foreign)) {
+        if ( ! $translator->from($model)->hasTranslation($foreign)) {
             return $foreign;
         }