VotingAbilityAwareAssembly::canVoteOn() - Code Metrics - SpareParts/Overseer - Measure and Improve Code Quality continuously with Scrutinizer

VotingAbilityAwareAssembly::canVoteOn() B
last analyzed 2019-09-17 12:26 UTC

↳ Parent: VotingAbilityAwareAssembly

Complexity

Conditions	7
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	7.0957

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	7
cts	8
cp	0.875
rs	8.8333
c	0
b	0
f	0
cc	7
nc	4
nop	3
crap	7.0957

<?php
namespace SpareParts\Overseer\Assembly;


use SpareParts\Overseer\Context\IVotingContext;
use SpareParts\Overseer\StrategyEnum;
use SpareParts\Overseer\Voter\IVoter;

class VotingAbilityAwareAssembly extends VotingAssembly implements IVotingAbilityAwareAssembly
{

    /**
     * @var string
     */
    protected $subjectClassName;

    /**
     * @var string
     */
    protected $contextClassName;

    /**
     * @var string[]
     */
    protected $actionList;


    /**
     * @param \SpareParts\Overseer\StrategyEnum $strategy
     * @param IVoter[] $voters
     * @param string|string[] $actions
     * @param string $contextClassName
     * @param string $subjectClassName
     */
    public function __construct(
        StrategyEnum $strategy,
        array $voters,
        $actions = null,
        $subjectClassName = null,
        $contextClassName = null
    ) {
        parent::__construct($strategy, $voters);

        $this->actionList = (array) $actions;
        $this->subjectClassName = $subjectClassName;
        $this->contextClassName = $contextClassName;
    }


    /**
     * @param string $actionName
     * @param object $subject
     * @param \SpareParts\Overseer\Context\IVotingContext $context
     * @return bool
     */
    public function canVoteOn($actionName, $subject, IVotingContext $context)
    {
        if ($this->subjectClassName && !($subject instanceof $this->subjectClassName)) {
            return false;
        }

        if ($this->contextClassName && !($context instanceof $this->contextClassName)) {
            return false;
        }

        if ($this->actionList && !in_array($actionName, $this->actionList)) {

            return false;
        }
        return true;
    }

}


1		<?php
2		namespace SpareParts\Overseer\Assembly;
3
4
5		use SpareParts\Overseer\Context\IVotingContext;
6		use SpareParts\Overseer\StrategyEnum;
7		use SpareParts\Overseer\Voter\IVoter;
8
9		class VotingAbilityAwareAssembly extends VotingAssembly implements IVotingAbilityAwareAssembly
10		{
11
12		/**
13		* @var string
14		*/
15		protected $subjectClassName;
16
17		/**
18		* @var string
19		*/
20		protected $contextClassName;
21
22		/**
23		* @var string[]
24		*/
25		protected $actionList;
26
27
28		/**
29		* @param \SpareParts\Overseer\StrategyEnum $strategy
30		* @param IVoter[] $voters
31		* @param string\|string[] $actions
32		* @param string $contextClassName
33		* @param string $subjectClassName
34		*/
35	8	public function __construct(
36		StrategyEnum $strategy,
37		array $voters,
38		$actions = null,
39		$subjectClassName = null,
40		$contextClassName = null
41		) {
42	8	parent::__construct($strategy, $voters);
43
44	8	$this->actionList = (array) $actions;
45	8	$this->subjectClassName = $subjectClassName;
46	8	$this->contextClassName = $contextClassName;
47	8	}
48
49
50		/**
51		* @param string $actionName
52		* @param object $subject
53		* @param \SpareParts\Overseer\Context\IVotingContext $context
54		* @return bool
55		*/
56	8	public function canVoteOn($actionName, $subject, IVotingContext $context)
57		{
58	8	if ($this->subjectClassName && !($subject instanceof $this->subjectClassName)) {
59		return false;
60		}
61
62	8	if ($this->contextClassName && !($context instanceof $this->contextClassName)) {
63	2	return false;
64		}
65
66	6	if ($this->actionList && !in_array($actionName, $this->actionList)) {
		0 ignored issues – show Bug Best Practice introduced 2017-01-07 22:57 UTC by Report Bug Copy Issue Report The expression `$this->actionList` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
67	2	return false;
68		}
69	5	return true;
70		}
71
72		}
73

SpareParts / Overseer

VotingAbilityAwareAssembly::canVoteOn() B last analyzed 2019-09-17 12:26 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

VotingAbilityAwareAssembly::canVoteOn() B
last analyzed 2019-09-17 12:26 UTC