SpareParts\Overseer\Assembly\VotingAbilityAwareAssembly

Complexity

Total Complexity

8

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

92.86%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	1
B	canVoteOn()	0	15	7

<?php
namespace SpareParts\Overseer\Assembly;


use SpareParts\Overseer\Context\IVotingContext;
use SpareParts\Overseer\StrategyEnum;
use SpareParts\Overseer\Voter\IVoter;

class VotingAbilityAwareAssembly extends VotingAssembly implements IVotingAbilityAwareAssembly
{

    /**
     * @var string
     */
    protected $subjectClassName;

    /**
     * @var string
     */
    protected $contextClassName;

    /**
     * @var string[]
     */
    protected $actionList;


    /**
     * @param \SpareParts\Overseer\StrategyEnum $strategy
     * @param IVoter[] $voters
     * @param string|string[] $actions
     * @param string $contextClassName
     * @param string $subjectClassName
     */
    public function __construct(
        StrategyEnum $strategy,
        array $voters,
        $actions = null,
        $subjectClassName = null,
        $contextClassName = null
    ) {
        parent::__construct($strategy, $voters);

        $this->actionList = (array) $actions;
        $this->subjectClassName = $subjectClassName;
        $this->contextClassName = $contextClassName;
    }


    /**
     * @param string $actionName
     * @param object $subject
     * @param \SpareParts\Overseer\Context\IVotingContext $context
     * @return bool
     */
    public function canVoteOn($actionName, $subject, IVotingContext $context)
    {
        if ($this->subjectClassName && !($subject instanceof $this->subjectClassName)) {
            return false;
        }

        if ($this->contextClassName && !($context instanceof $this->contextClassName)) {
            return false;
        }

        if ($this->actionList && !in_array($actionName, $this->actionList)) {

The expression $this->actionList of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return false;
        }
        return true;
    }

}