Linter::packagesAreSorted() - Code Metrics - Inspection of "Sort packages linter" - Soullivaneuh/composer-lint - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Sullivan

created 2016-05-28 22:07 UTC

Linter::packagesAreSorted() A

↳ Parent: Linter

Complexity

Conditions	2
Paths	1

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	2
eloc	8
nc	1
nop	1

<?php

namespace SLLH\ComposerLint;

use Composer\Json\JsonFile;

/**
 * @author Sullivan Senechal <[email protected]>
 */
final class Linter
{
    /**
     * @var array
     */
    private $manifest;

    /**
     * @param string $file composer.json file path
     *
     * @return string[]
     */
    public function validate($file)
    {
        $errors = array();
        $json = new JsonFile($file);
        $this->manifest = $json->read();


        if (isset($this->manifest['config']['sort-packages']) && $this->manifest['config']['sort-packages']) {
            foreach (array('require', 'require-dev', 'conflict', 'replace', 'provide', 'suggest') as $linksSection) {
                if (array_key_exists($linksSection, $this->manifest) && !$this->packagesAreSorted($this->manifest[$linksSection])) {
                    array_push($errors, 'Links under '.$linksSection.' section are not sorted correctly.');
                }
            }
        }

        return $errors;
    }

    private function packagesAreSorted(array $packages)
    {
        $names = array_keys($packages);
        $sortedNames = $names;
        usort($sortedNames, function ($name1, $name2) {
            if ('php' === $name2) {
                return 1;
            }
            // TODO: ext-*

            return strcmp($name1, $name2);
        });

        return $sortedNames === $names;
    }
}


1			<?php
2
3			namespace SLLH\ComposerLint;
4
5			use Composer\Json\JsonFile;
6
7			/**
8			* @author Sullivan Senechal <[email protected]>
9			*/
10			final class Linter
11			{
12			/**
13			* @var array
14			*/
15			private $manifest;
16
17			/**
18			* @param string $file composer.json file path
19			*
20			* @return string[]
21			*/
22			public function validate($file)
23			{
24			$errors = array();
25			$json = new JsonFile($file);
26			$this->manifest = $json->read();
			0 ignored issues – show Documentation Bug introduced 2016-05-28 22:09 UTC by Report Bug Copy Issue Report It seems like `$json->read()` of type `*` is incompatible with the declared type `array` of property `$manifest`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
27
28			if (isset($this->manifest['config']['sort-packages']) && $this->manifest['config']['sort-packages']) {
29			foreach (array('require', 'require-dev', 'conflict', 'replace', 'provide', 'suggest') as $linksSection) {
30			if (array_key_exists($linksSection, $this->manifest) && !$this->packagesAreSorted($this->manifest[$linksSection])) {
31			array_push($errors, 'Links under '.$linksSection.' section are not sorted correctly.');
32			}
33			}
34			}
35
36			return $errors;
37			}
38
39			private function packagesAreSorted(array $packages)
40			{
41			$names = array_keys($packages);
42			$sortedNames = $names;
43			usort($sortedNames, function ($name1, $name2) {
44			if ('php' === $name2) {
45			return 1;
46			}
47			// TODO: ext-*
48
49			return strcmp($name1, $name2);
50			});
51
52			return $sortedNames === $names;
53			}
54			}
55

Soullivaneuh / composer-lint

Pull Request — master (#2)

Linter::packagesAreSorted() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like