SLLH\ComposerLint\Linter

Complexity

Total Complexity

8

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	validate()	0	16	6
A	packagesAreSorted()	0	15	2

<?php

namespace SLLH\ComposerLint;

use Composer\Json\JsonFile;

/**
 * @author Sullivan Senechal <soullivaneuh@gmail.com>
 */
final class Linter
{
    /**
     * @var array
     */
    private $manifest;

    /**
     * @param string $file composer.json file path
     *
     * @return string[]
     */
    public function validate($file)
    {
        $errors = array();
        $json = new JsonFile($file);
        $this->manifest = $json->read();

It seems like $json->read() of type * is incompatible with the declared type array of property $manifest.

        if (isset($this->manifest['config']['sort-packages']) && $this->manifest['config']['sort-packages']) {
            foreach (array('require', 'require-dev', 'conflict', 'replace', 'provide', 'suggest') as $linksSection) {
                if (array_key_exists($linksSection, $this->manifest) && !$this->packagesAreSorted($this->manifest[$linksSection])) {
                    array_push($errors, 'Links under '.$linksSection.' section are not sorted correctly.');
                }
            }
        }

        return $errors;
    }

    private function packagesAreSorted(array $packages)
    {
        $names = array_keys($packages);
        $sortedNames = $names;
        usort($sortedNames, function ($name1, $name2) {
            if ('php' === $name2) {
                return 1;
            }
            // TODO: ext-*

            return strcmp($name1, $name2);
        });

        return $sortedNames === $names;
    }
}