Completed
Pull Request — master (#51)
by Brian
18:41 queued 08:32
created
src/SocialiteWasCalled.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
         $provider = $this->buildProvider($socialite, $providerName, $providerClass, $oauth1Server);
36 36
         $socialite->extend(
37 37
             $providerName,
38
-            function () use ($provider) {
38
+            function() use ($provider) {
39 39
                 return $provider;
40 40
             }
41 41
         );
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -56,11 +56,11 @@  discard block
 block discarded – undo
56 56
 
57 57
     /**
58 58
      * @param SocialiteManager $socialite
59
-     * @param                  $providerName
59
+     * @param                  string $providerName
60 60
      * @param string           $providerClass
61 61
      * @param null|string      $oauth1Server
62 62
      *
63
-     * @return \Laravel\Socialite\One\AbstractProvider|\Laravel\Socialite\Two\AbstractProvider
63
+     * @return string
64 64
      */
65 65
     protected function buildProvider(SocialiteManager $socialite, $providerName, $providerClass, $oauth1Server)
66 66
     {
@@ -80,7 +80,6 @@  discard block
 block discarded – undo
80 80
      *
81 81
      * @param string $providerClass must extend Laravel\Socialite\One\AbstractProvider
82 82
      * @param string $oauth1Server  must extend League\OAuth1\Client\Server\Server
83
-     * @param array  $config
84 83
      *
85 84
      * @return \Laravel\Socialite\One\AbstractProvider
86 85
      */
@@ -107,7 +106,6 @@  discard block
 block discarded – undo
107 106
      *
108 107
      * @param SocialiteManager $socialite
109 108
      * @param string           $providerClass must extend Laravel\Socialite\Two\AbstractProvider
110
-     * @param array            $config
111 109
      *
112 110
      * @return \Laravel\Socialite\Two\AbstractProvider
113 111
      */
@@ -129,7 +127,7 @@  discard block
 block discarded – undo
129 127
      * @param string $providerName
130 128
      *
131 129
      * @throws MissingConfigException
132
-     * @return array
130
+     * @return Contracts\ConfigInterface
133 131
      *
134 132
      */
135 133
     protected function getConfig($providerClass, $providerName)
@@ -183,6 +181,9 @@  discard block
 block discarded – undo
183 181
         }
184 182
     }
185 183
 
184
+    /**
185
+     * @param string|null $providerClass
186
+     */
186 187
     private function classExists($providerClass)
187 188
     {
188 189
         if (!class_exists($providerClass)) {
Please login to merge, or discard this patch.
src/Helpers/ConfigRetriever.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@  discard block
 block discarded – undo
38 38
             $this->getFromEnv("KEY"),
39 39
             $this->getFromEnv("SECRET"),
40 40
             $this->getFromEnv("REDIRECT_URI"),
41
-            $this->getConfigItems($additionalConfigKeys, function ($key) {
41
+            $this->getConfigItems($additionalConfigKeys, function($key) {
42 42
                 return $this->getFromEnv($key);
43 43
             }));
44 44
     }
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
             $this->getFromServices('client_id'),
59 59
             $this->getFromServices('client_secret'),
60 60
             $this->getFromServices('redirect'),
61
-            $this->getConfigItems($additionalConfigKeys, function ($key) {
61
+            $this->getConfigItems($additionalConfigKeys, function($key) {
62 62
                 return $this->getFromServices($key);
63 63
             }));
64 64
     }
Please login to merge, or discard this patch.
src/ServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
     {
24 24
         parent::register();
25 25
 
26
-        $this->app->singleton(ConfigRetrieverInterface::class, function () {
26
+        $this->app->singleton(ConfigRetrieverInterface::class, function() {
27 27
             return new ConfigRetriever();
28 28
         });
29 29
     }
Please login to merge, or discard this patch.